Ecosyste.ms: OpenCollective
An open API service for software projects hosted on Open Collective.
doorkeeper
Doorkeeper is an OAuth2 provider built for Ruby, Rails and Grape
Collective -
Host: opensource -
https://opencollective.com/doorkeeper-gem
- Code: https://github.com/doorkeeper-gem/doorkeeper
Fix the error message for force_pkce
github.com/doorkeeper-gem/doorkeeper - lurz opened this pull request 3 days ago
github.com/doorkeeper-gem/doorkeeper - lurz opened this pull request 3 days ago
Fix refresh tokens with dynamic scopes
github.com/doorkeeper-gem/doorkeeper - stanhu opened this pull request 17 days ago
github.com/doorkeeper-gem/doorkeeper - stanhu opened this pull request 17 days ago
Bump the range of supported Ruby and Rails versions
github.com/doorkeeper-gem/doorkeeper - naitoh opened this pull request 22 days ago
github.com/doorkeeper-gem/doorkeeper - naitoh opened this pull request 22 days ago
delete `TestFixtures.fixture_path=` DEPRECATION WARNING (for support Rails 7.2)
github.com/doorkeeper-gem/doorkeeper - naitoh opened this pull request about 1 month ago
github.com/doorkeeper-gem/doorkeeper - naitoh opened this pull request about 1 month ago
Add funding_uri to gemspec
github.com/doorkeeper-gem/doorkeeper - andrew opened this pull request about 1 month ago
github.com/doorkeeper-gem/doorkeeper - andrew opened this pull request about 1 month ago
Introducing Doorkeeper Guru on Gurubase.io
github.com/doorkeeper-gem/doorkeeper - kursataktas opened this pull request about 1 month ago
github.com/doorkeeper-gem/doorkeeper - kursataktas opened this pull request about 1 month ago
Update rails requirement from >= 6.0, < 7.3 to >= 6.0, < 8.1
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request about 1 month ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request about 1 month ago
Fix unknown pkce method error when configured
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this pull request about 2 months ago
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this pull request about 2 months ago
The error message for invalid pkce method is not affected by pkce_code_challenge_methods configuration
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue about 2 months ago
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue about 2 months ago
Update sqlite3 requirement from ~> 1.4 to ~> 2.2
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request about 2 months ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request about 2 months ago
Allow for expired refresh tokens to be revoked
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this pull request about 2 months ago
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this pull request about 2 months ago
Refresh tokens that are paired with expired access tokens cannot be revoked
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue about 2 months ago
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue about 2 months ago
Fix broken tests for older Rails versions
github.com/doorkeeper-gem/doorkeeper - stanhu opened this pull request about 2 months ago
github.com/doorkeeper-gem/doorkeeper - stanhu opened this pull request about 2 months ago
load the session if the session is not preloaded already
github.com/doorkeeper-gem/doorkeeper - laomatt opened this pull request 2 months ago
github.com/doorkeeper-gem/doorkeeper - laomatt opened this pull request 2 months ago
Dependabot ruby experience
github.com/doorkeeper-gem/doorkeeper - Myahr208 opened this issue 2 months ago
github.com/doorkeeper-gem/doorkeeper - Myahr208 opened this issue 2 months ago
Add support for dynamic scopes
github.com/doorkeeper-gem/doorkeeper - stanhu opened this pull request 2 months ago
github.com/doorkeeper-gem/doorkeeper - stanhu opened this pull request 2 months ago
skip_forgery_protection always
github.com/doorkeeper-gem/doorkeeper - chris-iotum opened this pull request 2 months ago
github.com/doorkeeper-gem/doorkeeper - chris-iotum opened this pull request 2 months ago
Feat: Implement oauth authorization server metadata
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this pull request 3 months ago
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this pull request 3 months ago
Improve developer experience
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this pull request 3 months ago
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this pull request 3 months ago
Add pkce_code_challenge_methods option
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this pull request 3 months ago
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this pull request 3 months ago
Update sqlite3 requirement from ~> 1.4 to ~> 2.1
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 3 months ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 3 months ago
Fix Gemfile & Dockerfile to get passing tests
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this pull request 3 months ago
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this pull request 3 months ago
Refresh token not issued when multiple scopes are requested
github.com/doorkeeper-gem/doorkeeper - dstuckey-uoe opened this issue 3 months ago
github.com/doorkeeper-gem/doorkeeper - dstuckey-uoe opened this issue 3 months ago
There is no way to refresh an access token without revoking the previous access token
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue 3 months ago
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue 3 months ago
Update rspec-rails requirement from ~> 6.0 to ~> 7.0
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 4 months ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 4 months ago
Update sqlite3 requirement from ~> 1.4 to ~> 2.0
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 4 months ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 4 months ago
Allow to set null secret value for Applications if it's public
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 4 months ago
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 4 months ago
Refactor token introspection
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 4 months ago
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 4 months ago
Update rails requirement from >= 6.0, < 7.2 to >= 6.0, < 7.3
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 4 months ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 4 months ago
Doorkeeper shouldn't generate a secret for public clients
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
Add Ruby 3.3 to GitHub Actions testing matrix
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this pull request 5 months ago
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this pull request 5 months ago
Fix outdated ruby version in Dockerfile
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this pull request 5 months ago
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this pull request 5 months ago
Issues getting tests running
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
Support for RFC 9207 - OAuth 2.0 Authorization Server Issuer Identification
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
Refresh Tokens as-implemented are susceptible to Refresh Token Reuse Attacks
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
Doorkeeper's redirect_uri validation is not implemented according to specification
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
Option to specify supported PKCE code_challenge_methods supported
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
github.com/doorkeeper-gem/doorkeeper - ThisIsMissEm opened this issue 5 months ago
When introspection is disabled we return 200 for authorized clients via basic auth but 401 for authorized clients via bearer auth
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue 5 months ago
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue 5 months ago
Fix token introspection invalid request reason
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this pull request 5 months ago
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this pull request 5 months ago
Fix Doorkeeper::AccessToken.find_or_create_for with empty scopes
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 5 months ago
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 5 months ago
Access tokens should be revoked when multiple attempts are made to exchange the same authorization code
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue 5 months ago
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue 5 months ago
Add Pragma: no-cache to token response
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this pull request 6 months ago
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this pull request 6 months ago
Doorkeeper appears to be missing a way to validate client configuration before redirecting to the authentication page
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue 6 months ago
github.com/doorkeeper-gem/doorkeeper - ransombriggs opened this issue 6 months ago
Add GitHub Discussions to the project
github.com/doorkeeper-gem/doorkeeper - kmayer opened this issue 7 months ago
github.com/doorkeeper-gem/doorkeeper - kmayer opened this issue 7 months ago
AuthorizedApplications returns the date that the _application_ was created, not the date that the _authorization_ was created
github.com/doorkeeper-gem/doorkeeper - kmayer opened this issue 7 months ago
github.com/doorkeeper-gem/doorkeeper - kmayer opened this issue 7 months ago
Do not instantiate ActiveRecord model early
github.com/doorkeeper-gem/doorkeeper - tachyons opened this pull request 7 months ago
github.com/doorkeeper-gem/doorkeeper - tachyons opened this pull request 7 months ago
Create tencent.yml
github.com/doorkeeper-gem/doorkeeper - zarkius opened this pull request 8 months ago
github.com/doorkeeper-gem/doorkeeper - zarkius opened this pull request 8 months ago
DRY out AuthorizationsController#render_success
github.com/doorkeeper-gem/doorkeeper - kmayer opened this pull request 8 months ago
github.com/doorkeeper-gem/doorkeeper - kmayer opened this pull request 8 months ago
Add force_pkce option
github.com/doorkeeper-gem/doorkeeper - mattmanning opened this pull request 8 months ago
github.com/doorkeeper-gem/doorkeeper - mattmanning opened this pull request 8 months ago
Update sqlite3 requirement from ~> 1.4 to ~> 2.0
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 8 months ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 8 months ago
Doorkeeper is loading ActiveRecord too early
github.com/doorkeeper-gem/doorkeeper - ngan opened this issue 9 months ago
github.com/doorkeeper-gem/doorkeeper - ngan opened this issue 9 months ago
Fix bugs for error response in the form_post and error view
github.com/doorkeeper-gem/doorkeeper - lurz opened this pull request 9 months ago
github.com/doorkeeper-gem/doorkeeper - lurz opened this pull request 9 months ago
Make redirect_uri optional for Authorization request
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 9 months ago
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 9 months ago
Token revocation error when token contains null byte.
github.com/doorkeeper-gem/doorkeeper - rczern opened this issue 9 months ago
github.com/doorkeeper-gem/doorkeeper - rczern opened this issue 9 months ago
`Doorkeeper::AccessToken.find_or_create_for` with empty scopes raises NoMethodError
github.com/doorkeeper-gem/doorkeeper - pdany1116 opened this issue 9 months ago
github.com/doorkeeper-gem/doorkeeper - pdany1116 opened this issue 9 months ago
Test with Rails 7.1
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 10 months ago
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 10 months ago
Allow a TokenResponse body to be customized
github.com/doorkeeper-gem/doorkeeper - kmayer opened this pull request 10 months ago
github.com/doorkeeper-gem/doorkeeper - kmayer opened this pull request 10 months ago
Add missing method to token response
github.com/doorkeeper-gem/doorkeeper - fredplante opened this pull request 10 months ago
github.com/doorkeeper-gem/doorkeeper - fredplante opened this pull request 10 months ago
Removing active_record_options was a breaking change
github.com/doorkeeper-gem/doorkeeper - AzRu opened this issue 10 months ago
github.com/doorkeeper-gem/doorkeeper - AzRu opened this issue 10 months ago
Fix grammar in initializer template
github.com/doorkeeper-gem/doorkeeper - nikkypx opened this pull request 10 months ago
github.com/doorkeeper-gem/doorkeeper - nikkypx opened this pull request 10 months ago
Different access grants return the same access token with `reuse_access_token` enabled
github.com/doorkeeper-gem/doorkeeper - pyromaniac opened this issue 10 months ago
github.com/doorkeeper-gem/doorkeeper - pyromaniac opened this issue 10 months ago
Recommend explicit expires_in in initializer
github.com/doorkeeper-gem/doorkeeper - Paultdx opened this pull request 10 months ago
github.com/doorkeeper-gem/doorkeeper - Paultdx opened this pull request 10 months ago
Make new errors backward compatible
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 10 months ago
github.com/doorkeeper-gem/doorkeeper - nbulaj opened this pull request 10 months ago
Consider expires_in when clear expired tokens with StaleRecordsCleaner
github.com/doorkeeper-gem/doorkeeper - Paultdx opened this pull request 11 months ago
github.com/doorkeeper-gem/doorkeeper - Paultdx opened this pull request 11 months ago
Remove duplicate information from README
github.com/doorkeeper-gem/doorkeeper - piyush5050 opened this pull request 11 months ago
github.com/doorkeeper-gem/doorkeeper - piyush5050 opened this pull request 11 months ago
Cleanup job removes not expired tokens
github.com/doorkeeper-gem/doorkeeper - jensljungblad opened this issue 11 months ago
github.com/doorkeeper-gem/doorkeeper - jensljungblad opened this issue 11 months ago
Update generator_spec requirement from ~> 0.9.3 to ~> 0.10.0
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 11 months ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request 11 months ago
Refreshing a token sending scopes separated by `+` does not work
github.com/doorkeeper-gem/doorkeeper - danilokleber opened this issue 11 months ago
github.com/doorkeeper-gem/doorkeeper - danilokleber opened this issue 11 months ago
Regression with Errors in 5.6.8
github.com/doorkeeper-gem/doorkeeper - henrikbjorn opened this issue 11 months ago
github.com/doorkeeper-gem/doorkeeper - henrikbjorn opened this issue 11 months ago
How do I know if an application has been authorized by a resource owner?
github.com/doorkeeper-gem/doorkeeper - danieldocki opened this issue 12 months ago
github.com/doorkeeper-gem/doorkeeper - danieldocki opened this issue 12 months ago
OpenId Connect - No e-mail information in the SSO response
github.com/doorkeeper-gem/doorkeeper - habin201291 opened this issue 12 months ago
github.com/doorkeeper-gem/doorkeeper - habin201291 opened this issue 12 months ago
Doorkeeper::Errors::InvalidRedirectUri Raised When No Redirect URI Set
github.com/doorkeeper-gem/doorkeeper - brent-cybrid opened this issue about 1 year ago
github.com/doorkeeper-gem/doorkeeper - brent-cybrid opened this issue about 1 year ago
NoMethodError: undefined method `name_for_response' since v5.6.8
github.com/doorkeeper-gem/doorkeeper - nov opened this issue about 1 year ago
github.com/doorkeeper-gem/doorkeeper - nov opened this issue about 1 year ago
Fix handle_auth_errors :raise NotImplementedError
github.com/doorkeeper-gem/doorkeeper - camero2734 opened this pull request about 1 year ago
github.com/doorkeeper-gem/doorkeeper - camero2734 opened this pull request about 1 year ago
NotImplementedError error response must define #exception_class after upgrading to 5.6.7 from 5.6.6
github.com/doorkeeper-gem/doorkeeper - brent-cybrid opened this issue about 1 year ago
github.com/doorkeeper-gem/doorkeeper - brent-cybrid opened this issue about 1 year ago
Always requiring `redirect_uri` is not compliant to RFC 6749
github.com/doorkeeper-gem/doorkeeper - westnordost opened this issue about 1 year ago
github.com/doorkeeper-gem/doorkeeper - westnordost opened this issue about 1 year ago
Fix URIHelper.valid_for_authorization? breaking for non url URIs
github.com/doorkeeper-gem/doorkeeper - Zeko369 opened this pull request about 1 year ago
github.com/doorkeeper-gem/doorkeeper - Zeko369 opened this pull request about 1 year ago
Improve AuthorizationsController error response handling
github.com/doorkeeper-gem/doorkeeper - camero2734 opened this pull request about 1 year ago
github.com/doorkeeper-gem/doorkeeper - camero2734 opened this pull request about 1 year ago
Better support for credential rotation
github.com/doorkeeper-gem/doorkeeper - sgallag-insta opened this issue about 1 year ago
github.com/doorkeeper-gem/doorkeeper - sgallag-insta opened this issue about 1 year ago
Enhancement: expose `current_resource_owner` to views
github.com/doorkeeper-gem/doorkeeper - vlad-pisanov opened this issue about 1 year ago
github.com/doorkeeper-gem/doorkeeper - vlad-pisanov opened this issue about 1 year ago
Honor custom_access_token_attributes in client credentials grant flow
github.com/doorkeeper-gem/doorkeeper - mlr opened this pull request about 1 year ago
github.com/doorkeeper-gem/doorkeeper - mlr opened this pull request about 1 year ago
Update rails requirement from >= 6.0, < 7.1 to >= 6.0, < 7.2
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request about 1 year ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request about 1 year ago
It is not possible to revoke refresh token bound to the expired access token
github.com/doorkeeper-gem/doorkeeper - syakovyn opened this issue over 1 year ago
github.com/doorkeeper-gem/doorkeeper - syakovyn opened this issue over 1 year ago
Do not recommend setting access_token_expires_in to nil
github.com/doorkeeper-gem/doorkeeper - benissimo opened this issue over 1 year ago
github.com/doorkeeper-gem/doorkeeper - benissimo opened this issue over 1 year ago
Bump actions/checkout from 3 to 4
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request over 1 year ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request over 1 year ago
Provide an option to skip orm hooks
github.com/doorkeeper-gem/doorkeeper - cwjenkins opened this pull request over 1 year ago
github.com/doorkeeper-gem/doorkeeper - cwjenkins opened this pull request over 1 year ago
Pass client instead of grant.application to find_or_create_access_token
github.com/doorkeeper-gem/doorkeeper - giovannelli opened this pull request over 1 year ago
github.com/doorkeeper-gem/doorkeeper - giovannelli opened this pull request over 1 year ago
Issue with defining application_class in Doorkeeper config causing NoMethodError
github.com/doorkeeper-gem/doorkeeper - giovannelli opened this issue over 1 year ago
github.com/doorkeeper-gem/doorkeeper - giovannelli opened this issue over 1 year ago
MAJOR ISSUE - matching_token_for not considering custom attributes
github.com/doorkeeper-gem/doorkeeper - PhilippeChab opened this issue over 1 year ago
github.com/doorkeeper-gem/doorkeeper - PhilippeChab opened this issue over 1 year ago
App is not generating the Oauth2 token using doorkeeper gem
github.com/doorkeeper-gem/doorkeeper - bhardwajrahul919 opened this issue over 1 year ago
github.com/doorkeeper-gem/doorkeeper - bhardwajrahul919 opened this issue over 1 year ago
reuse_access_token config should be used when refreshing a token
github.com/doorkeeper-gem/doorkeeper - PhilippeChab opened this issue over 1 year ago
github.com/doorkeeper-gem/doorkeeper - PhilippeChab opened this issue over 1 year ago
Use validates_with rather than validates to validate URI
github.com/doorkeeper-gem/doorkeeper - ravron opened this pull request over 1 year ago
github.com/doorkeeper-gem/doorkeeper - ravron opened this pull request over 1 year ago
Bump lots0logs/gh-action-get-changed-files from 2.1.4 to 2.2.2
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request over 1 year ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request over 1 year ago
Stop auto-creation of AccessGrant when a matching token is found if custom access token attributes are used
github.com/doorkeeper-gem/doorkeeper - JeremyC-za opened this pull request over 1 year ago
github.com/doorkeeper-gem/doorkeeper - JeremyC-za opened this pull request over 1 year ago
Bump lots0logs/gh-action-get-changed-files from 2.1.4 to 2.2.0
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request over 1 year ago
github.com/doorkeeper-gem/doorkeeper - dependabot[bot] opened this pull request over 1 year ago
Typo Be --> By
github.com/doorkeeper-gem/doorkeeper - olimart opened this pull request over 1 year ago
github.com/doorkeeper-gem/doorkeeper - olimart opened this pull request over 1 year ago
Support OAuth DPoP
github.com/doorkeeper-gem/doorkeeper - hickford opened this issue over 1 year ago
github.com/doorkeeper-gem/doorkeeper - hickford opened this issue over 1 year ago
Option to enforce that clients use PKCE
github.com/doorkeeper-gem/doorkeeper - hickford opened this issue over 1 year ago
github.com/doorkeeper-gem/doorkeeper - hickford opened this issue over 1 year ago
`rails generate doorkeeper:install` fails with `uninitialized constant ActiveRecord` for a non-ActiveRecord project
github.com/doorkeeper-gem/doorkeeper - zedtux opened this issue over 1 year ago
github.com/doorkeeper-gem/doorkeeper - zedtux opened this issue over 1 year ago
Add custom attributes support to token generator
github.com/doorkeeper-gem/doorkeeper - raphaelcosta opened this pull request over 1 year ago
github.com/doorkeeper-gem/doorkeeper - raphaelcosta opened this pull request over 1 year ago