github.com/cert-manager/approver-policy commits

use testenv instead of env

Signed-off-by: Tim Ramlot <[email protected]>

d85980fc2e64efdd4c9201da958189b3e22f4451 authored about 1 year ago by Tim Ramlot <[email protected]>

don't use ROOTDIR variable in tests

Signed-off-by: Tim Ramlot <[email protected]>

a57aba60aca5db7cc65a73a6a18e990c2dcc8539 authored about 1 year ago by Tim Ramlot <[email protected]>

Merge pull request #308 from inteon/fix_copyright

Add missing copyright

b17e306ba7e6fc94a7c5b2dd300cecc0de98e7a8 authored about 1 year ago by jetstack-bot <[email protected]>

add missing copyright

Signed-off-by: Tim Ramlot <[email protected]>

2d3ddd3117cacf47f2ead6b1f874bc5d64a62ce4 authored about 1 year ago by Tim Ramlot <[email protected]>

Merge pull request #256 from erikgb/cel-support-design

CEL expressions approver design

21127a5745939dd189f3ca34ab4e408fc9e3ce8d authored about 1 year ago by jetstack-bot <[email protected]>

CEL expressions approver design

Signed-off-by: Erik Godding Boye <[email protected]>
Co-authored-by: Josh Soref <2119212+jsoref@u...

b2352079525b62d3f32b64d4baff9bee9ddd88c0 authored about 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #277 from erikgb/cel-validations

feat: add allowed CEL validation rules

e0ef9677519a9f09c6aca2c0da04e8c649cd5e17 authored about 1 year ago by jetstack-bot <[email protected]>

feat: CEL validation rules

Signed-off-by: Erik Godding Boye <[email protected]>

6e3982b0cdac2a662b5ccd843088f34af743ad47 authored about 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #305 from erikgb/fix-dynamic-cert-runnable

fix: dynamic cert runnable must NOT be leader election aware

8ae7bb85c1a374a44bf0cde5e85c7048d2a991cb authored about 1 year ago by jetstack-bot <[email protected]>

fix: dynamic cert runnable must NOT be leader election aware

Signed-off-by: Erik Godding Boye <[email protected]>

00ef58dbf155ee69efa8305b25c5c0d8cdb5b534 authored about 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #304 from cert-manager/dependabot/go_modules/all-027c04c118

build(deps): bump the all group with 2 updates

353810d6999014d6dc90ac82ebb30ab35e8c1deb authored about 1 year ago by jetstack-bot <[email protected]>

build(deps): bump the all group with 2 updates

Bumps the all group with 2 updates: [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) ...

4d10f1dd8218f5fe5f6e1b22255d36e64efcfa07 authored about 1 year ago by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Merge pull request #303 from erikgb/fix-request-status-patch

fix: should not change existing condition of type

e27a18aab08034fbecda900a989148209a6f6406 authored about 1 year ago by jetstack-bot <[email protected]>

Merge pull request #299 from cert-manager/dependabot/go_modules/all-308de5d6b1

Bump the all group with 2 updates

dda8379647828cf97a07230f9f90771cc3ebbe4f authored about 1 year ago by jetstack-bot <[email protected]>

copy function from issuer-lib

Signed-off-by: Erik Godding Boye <[email protected]>

502cbb79a17eedaa8718d6a87372467fc9202e6a authored about 1 year ago by Erik Godding Boye <[email protected]>

use utility function from issuer-lib

Signed-off-by: Erik Godding Boye <[email protected]>

89ca7e155bd5ee59b928eab29a28735136c79484 authored about 1 year ago by Erik Godding Boye <[email protected]>

exit early if request is approved or denied

Signed-off-by: Erik Godding Boye <[email protected]>

aa24ad2476f555946aad77b78fd0d9bee0fe8ce0 authored about 1 year ago by Erik Godding Boye <[email protected]>

fix: should not change existing condition of type

Signed-off-by: Erik Godding Boye <[email protected]>

bb75196b1e98dcb078eb70888795c95529cfdde6 authored about 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #302 from erikgb/fix-error-message-typos

fix: typos in error message wrapping

c8f950602e17a0a6fc0d0ef78dd61db20b387d59 authored about 1 year ago by jetstack-bot <[email protected]>

fix: typos in error message wrapping

Signed-off-by: Erik Godding Boye <[email protected]>

8308a6cd02561c6caacdec7c4c21281ed2bd9489 authored about 1 year ago by Erik Godding Boye <[email protected]>

Bump the all group with 2 updates

Bumps the all group with 2 updates: [github.com/spf13/cobra](https://github.com/spf13/cobra) and...

76edad0e7098ee1d0c272317897fa8355a05ed10 authored about 1 year ago by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Merge pull request #298 from inteon/simplify_webhook_tls

Use cert-manager's servertls.CertificateSource and simplify webhook code

0e10303d7ea298d7a0f45a0a6ecb6f8999c64e22 authored about 1 year ago by jetstack-bot <[email protected]>

use cert-manager's servertls.CertificateSource and simplify webhook code

Signed-off-by: Tim Ramlot <[email protected]>

17adcecacb0d0e066e1918b6a6e56c8b8fbec979 authored about 1 year ago by Tim Ramlot <[email protected]>

Merge pull request #296 from cert-manager/dependabot/go_modules/all-34a82aba19

Bump the all group with 3 updates

fb1b306670a30421c648cd65801b90b3d05ced38 authored about 1 year ago by jetstack-bot <[email protected]>

Bump the all group with 3 updates

Bumps the all group with 3 updates: [github.com/cert-manager/cert-manager](https://github.com/ce...

023f21962840967050af2f3209839b9464e302aa authored about 1 year ago by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Merge pull request #294 from erikgb/add-erikgb-to-reviewers

Add erikgb to project reviewers

4471fc574117d02eac5a3b1f3c7f5e74c20d9705 authored about 1 year ago by jetstack-bot <[email protected]>

Add erikgb to project reviewers

Signed-off-by: Erik Godding Boye <[email protected]>

39be391f60ea2d6acad12d2c8d09e21ae356f280 authored about 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #293 from maelvls/fix-metrics

Advanced Metrics: Add the "denied_count" metric to account for the Denied=True condition

b53ff50aaac3a07f06fdb17e5eaaf1427b0231b0 authored about 1 year ago by jetstack-bot <[email protected]>

metrics: add the "denied_count" to account for the Denied=True condition

I mistakenly thought Approved=False would be reported when an approver
denies a CR. I hadn't pro...

09dab420b973732ae0cb83ae311801ae99f15e4a authored about 1 year ago by Maël Valais <[email protected]>

Merge pull request #289 from maelvls/metrics

Metrics: add the `approved_count` and `unmatched_count` metrics

47f564fe1e41ea03fcd4f565f927a96c13f2f20f authored about 1 year ago by jetstack-bot <[email protected]>

metrics: remove "name" from the "unmatched_count" metric

In the standup this morning, we discussed the problem with the label
"name": it may end up being...

e2386efd6e344ca50197811bb5689adf70e2f90b authored about 1 year ago by Maël Valais <[email protected]>

metrics: use "unmatched" instead of "orphan"

Signed-off-by: Maël Valais <[email protected]>

1c0a99307ae71b03c422004572cc5ff7c81a7483 authored about 1 year ago by Maël Valais <[email protected]>

metrics: add tests

Signed-off-by: Maël Valais <[email protected]>

2d0df120e591c5328a417de0a02f83fa464385c7 authored about 1 year ago by Maël Valais <[email protected]>

metrics: getReason was too complex, change to "getApprovedStatus"

Signed-off-by: Maël Valais <[email protected]>

5ec6d82d16f5a9e0f2c895210a2c7e3b869275b0 authored about 1 year ago by Maël Valais <[email protected]>

metrics: add the "approved" and "orphan" metrics

Signed-off-by: Maël Valais <[email protected]>

1c9e5e13d8fcb8c62a6565e234516c087de92652 authored about 1 year ago by Maël Valais <[email protected]>

metrics: use cmmeta.Condition instead of "string"

Signed-off-by: Maël Valais <[email protected]>

4bf1aafd9f01c44bf0a4d65ff912b6746090118b authored about 1 year ago by Maël Valais <[email protected]>

Merge pull request #292 from cert-manager/dependabot/go_modules/all-c12498a31b

Bump the all group with 1 update

cb72560d0ad6588855c93f913a3019e4783d2e8f authored about 1 year ago by jetstack-bot <[email protected]>

Bump the all group with 1 update

Bumps the all group with 1 update: [github.com/onsi/gomega](https://github.com/onsi/gomega).

- ...

c3faf25007095b5255f7ac3b24e274b5bdcb214c authored about 1 year ago by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Merge pull request #291 from erikgb/bump-k8s-deps

chore(deps): bump K8s dependencies to latest releases

0c7df7177355e195b2165ba2e830f8fa7cbee512 authored about 1 year ago by jetstack-bot <[email protected]>

chore(deps): bump K8s dependencies to latest releases

Signed-off-by: Erik Godding Boye <[email protected]>

6b5bf8a92a1e6453b2ab1fa456a0519ea018d52d authored about 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #290 from erikgb/error-list

refactor: support for multiple errors on same field

52b91afb1ca32e73ab08e0fe8fb1d2f90d3eb8ed authored about 1 year ago by jetstack-bot <[email protected]>

refactor: support for multiple errors on same field

Signed-off-by: Erik Godding Boye <[email protected]>

63b90966358011ceae5a101ed1fefd3fda55e400 authored about 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #280 from erikgb/refine-api-docs

docs: refine CertificateRequestPolicy API docs

1bc3fe54334108fcf057d04abf63012cd67d1a4d authored about 1 year ago by jetstack-bot <[email protected]>

docs: refine CertificateRequestPolicy API docs

Co-authored-by: Tim Ramlot <[email protected]>
Co-authored-by: Josh Soref...

93067e7c98a330c45e46cf64955ab904c2073abe authored about 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #283 from cert-manager/dependabot/go_modules/hack/tools/golang.org/x/net-0.17.0

Bump golang.org/x/net from 0.10.0 to 0.17.0 in /hack/tools

03fcf4fd39dd72038f5f52bf1c2f0099d5614d04 authored about 1 year ago by jetstack-bot <[email protected]>

Bump golang.org/x/net from 0.10.0 to 0.17.0 in /hack/tools

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.10.0 to 0.17.0.
- [Commits](https...

03d45164af77df637b705eb46541b19766d90c73 authored about 1 year ago by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Merge pull request #284 from cert-manager/dependabot/go_modules/golang.org/x/net-0.17.0

Bump golang.org/x/net from 0.15.0 to 0.17.0

844e1ac4ab0a2b9fe20c5272646b56900942b2e1 authored about 1 year ago by jetstack-bot <[email protected]>

Merge pull request #286 from erikgb/fix-mark-generated

chore: rename ' .gitattributes' to .gitattributes

e9d255e1f1b118fd59e12e28d55e0ce049d87afb authored about 1 year ago by jetstack-bot <[email protected]>

chore: rename ' .gitattributes' to .gitattributes

Signed-off-by: Erik Godding Boye <[email protected]>

e7dfa2d31d7c705cedd85f5384f6ce4a8e0ad39e authored about 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #285 from erikgb/mark-generated

chore: add .gitattributes to mark generated files

03157a690c01f4ca52738df2d884657552dbf6b3 authored about 1 year ago by jetstack-bot <[email protected]>

chore: add .gitattributes to mark generated files

Signed-off-by: Erik Godding Boye <[email protected]>

e73f5b34efc7cfbbe827a0fef77049ce8747173b authored about 1 year ago by Erik Godding Boye <[email protected]>

Bump golang.org/x/net from 0.15.0 to 0.17.0

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.17.0.
- [Commits](https...

9696c500198b5f332ed7c1ed3b6d36c8236033dd authored about 1 year ago by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Merge pull request #282 from cert-manager/dependabot/go_modules/all-514de3b65d

Bump the all group with 3 updates

81d4334838d958ca2e2fe0b1d9e0e0090b0ed8f6 authored about 1 year ago by jetstack-bot <[email protected]>

Merge pull request #281 from erikgb/crd-processing

feat: add TODO for validation of fields with set semantics

31eeb1f5081a3a722c57fcf4d14a43007d9a5083 authored about 1 year ago by jetstack-bot <[email protected]>

feat: add TODO for validation of fields with set semantics

Signed-off-by: Erik Godding Boye <[email protected]>

35ab0cfb3b84f5a631268752e862cd8975711676 authored over 1 year ago by Erik Godding Boye <[email protected]>

Bump the all group with 3 updates

Bumps the all group with 3 updates: [github.com/cert-manager/cert-manager](https://github.com/ce...

2b96cdf2bc606898ea481219b3198c978c414fe9 authored over 1 year ago by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat: add validation for fields with set semantics

Signed-off-by: Erik Godding Boye <[email protected]>

e16efdb67a4c58089537d297725716ef8859994d authored over 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #279 from SgtCoDFish/typo

Fix typo pared -> paired

f08a07cd63bcfa27dba03e531a13df1ba243299c authored over 1 year ago by jetstack-bot <[email protected]>

fix typo pared -> paired

Signed-off-by: Ashley Davis <[email protected]>

c5bbe77ec47dc3bc9a12f2595691ac61c8685336 authored over 1 year ago by Ashley Davis <[email protected]>

Merge pull request #272 from erikgb/refactor-evaluate

Refactor Evaluate preparing for CEL

71dbe2cc4cedce1399c67334b2c129e5dd66adfb authored over 1 year ago by jetstack-bot <[email protected]>

Refactor Evaluate preparing for CEL

Signed-off-by: Erik Godding Boye <[email protected]>

55f2f2cb079b326978632aa8a62a345cd632db87 authored over 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #264 from inteon/helm_image_options

HELM: add options for configuring image

9ecb1beacafdf7dcb6d62ceba9dd3b35820f78e2 authored over 1 year ago by Ashley Davis <[email protected]>

Merge pull request #269 from cert-manager/dependabot/github_actions/all-24b8ca4839

Bump the all group with 5 updates

fda7f86d761d34f04f780f6777f54cf753060010 authored over 1 year ago by Tim Ramlot <[email protected]>

Merge pull request #270 from cert-manager/dependabot/go_modules/all-f0fd31dbaa

Bump the all group with 4 updates

829432c7af20a66aa81b1fe9050f7471da6adde1 authored over 1 year ago by Tim Ramlot <[email protected]>

Bump the all group with 4 updates

Bumps the all group with 4 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/api...

e42918d4a2227c2279192153a7d65859125c94ea authored over 1 year ago by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump the all group with 5 updates

Bumps the all group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [actions/chec...

b64af5ad981bb79d2f1b4dabb603f0cad7b6f7f0 authored over 1 year ago by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Merge pull request #265 from inteon/depbot_grouping

Enable grouping for dependabot

dc4bbdc5741c9d43f78bfb14f9511d1c7bd06f19 authored over 1 year ago by jetstack-bot <[email protected]>

Merge pull request #266 from erikgb/cm-1-13

Upgrade to cert-manager 1.13.0

c96f43d3a3c42ccea43d89990d46ba275438f0bf authored over 1 year ago by jetstack-bot <[email protected]>

Upgrade to cert-manager 1.13.0

Signed-off-by: Erik Godding Boye <[email protected]>

5793c46ce350cdb174d8f9b35196f496471e39cc authored over 1 year ago by Erik Godding Boye <[email protected]>

enable grouping for dependabot

Signed-off-by: Tim Ramlot <[email protected]>

51967e3a580ffeed588dfe176081f0da43f33f7c authored over 1 year ago by Tim Ramlot <[email protected]>

HELM: add options for configuring image

Signed-off-by: Tim Ramlot <[email protected]>

66377c7eaad33b2b8125a1b14166296d367458bc authored over 1 year ago by Tim Ramlot <[email protected]>

Merge pull request #263 from erikgb/fix-cr-log

Fix uninitialized controller-runtime logger

50dca1c178056f2b514581a7303e1749408b68f5 authored over 1 year ago by jetstack-bot <[email protected]>

Fix uninitialized controller-runtime logger

Signed-off-by: Erik Godding Boye <[email protected]>

8466d2f7d9de7975751b7c48405a65e0c85962d3 authored over 1 year ago by Erik Godding Boye <[email protected]>

Merge pull request #259 from cert-manager/remove_command_from_deployment

Remove the command field from the yaml deployment

3a51e3caaea5cc2de2758df6a86fb51dc683bba3 authored over 1 year ago by jetstack-bot <[email protected]>

remove the command field from the yaml deployment, this makes it easier to swap the image with an image with another entrypoint (eg. because you are running approver-policy with additional plugins)

Signed-off-by: Tim Ramlot <[email protected]>

b54ea4ebd6933a434a566ec7f3078e95e8a256b4 authored over 1 year ago by Tim Ramlot <[email protected]>

Merge pull request #244 from irbekrm/bump_test_deps

Bumps test tool dependencies

ce8aeca1c9fe8e18c8f236c3c3b2b2e918934655 authored over 1 year ago by jetstack-bot <[email protected]>

Bumps test tool dependencies

Signed-off-by: irbekrm <[email protected]>

f33914ca85fed3be1d97ad5cf35915d701ba97e8 authored over 1 year ago by irbekrm <[email protected]>

Merge pull request #237 from irbekrm/fix_not_allowed

Bugfix: catch CRP not allowed cornercase

bcbb1d8a93912001a4645eccf98106f0f2a89762 authored over 1 year ago by jetstack-bot <[email protected]>

Use stdlib error in validator

To allow using errors that aren't apimachinery field errors

Signed-off-by: irbekrm <irbekrm@gma...

5042bc78cf88a11d5417dd37daa7e2c389d89805 authored over 1 year ago by Tim Ramlot <[email protected]>

Do not allow a CRP that was not allowed by a plugin

Even if the plugin did not provide error detail

Signed-off-by: irbekrm <[email protected]>

aeccc08cd2a46ed7911ef32a478a7322a72da160 authored over 1 year ago by irbekrm <[email protected]>

Merge pull request #243 from cert-manager/dependabot/go_modules/github.com/cert-manager/cert-manager-1.12.1

Bump github.com/cert-manager/cert-manager from 1.12.0 to 1.12.1

2a69373708959cc41d5ff5f176a1fce77b458095 authored over 1 year ago by jetstack-bot <[email protected]>

Merge pull request #235 from irbekrm/webhook_warnings

Admission webhook warnings

b40e6f6b7ed78ef4d2ddcab2e52b62150bb72065 authored over 1 year ago by jetstack-bot <[email protected]>

Bump github.com/cert-manager/cert-manager from 1.12.0 to 1.12.1

Bumps [github.com/cert-manager/cert-manager](https://github.com/cert-manager/cert-manager) from ...

6d0a3b5407f093faf439ea2d2195292f349418f4 authored over 1 year ago by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

approver plugins can optionally return warnings in policy validation response

To be displayed as Kubernetes admission warnings

Signed-off-by: irbekrm <[email protected]>

f9346cfdd17cf908e40f1d835b9c70331661c6f5 authored over 1 year ago by irbekrm <[email protected]>

Merge pull request #233 from irbekrm/bump_deps

Update dependencies, make changes to work with latest c/r

97d4546da3cfe3fb21aab3841be4c51e225745f9 authored over 1 year ago by jetstack-bot <[email protected]>

Code review feedback

Signed-off-by: irbekrm <[email protected]>

9bf645b2fda8506ea1478f8e188acfe98596c770 authored over 1 year ago by irbekrm <[email protected]>

Use latest cert-manager and c/r

Signed-off-by: irbekrm <[email protected]>

9e91ecc538145b2b8e5d6e9a26bfcac459b6db4f authored over 1 year ago by irbekrm <[email protected]>

c/r changes: use the new validating webhook path from c/r

This is now hardcoded in c/r

Signed-off-by: irbekrm <[email protected]>

8662898603f2dff579ab97bcf6d32b58d16d6c45 authored over 1 year ago by irbekrm <[email protected]>

c/r changes: use the new webhook setup method

The way we used to set up webhook by relying on c/r injecting decoder no longer works

Signed-of...

285557c6791c2442c71aab8c0b94410558076397 authored over 1 year ago by irbekrm <[email protected]>

c/r changes: update event source setup and event handlers

As these were changed in latest c/r

Signed-off-by: irbekrm <[email protected]>

a309fe6fe5c2e2518d7d43a45aa782f3ed2e074f authored over 1 year ago by irbekrm <[email protected]>

Bump base image

Signed-off-by: irbekrm <[email protected]>

a8646887fa509ce82c02dc22686bdf8d3bfbc6f8 authored over 1 year ago by irbekrm <[email protected]>

Go 1.20

Latest Kubernetes libraries use some stdlib code that was added in Go 1.20

Signed-off-by: irbek...

efacbb86676fd795299432a52f48371b0283ad20 authored over 1 year ago by irbekrm <[email protected]>

kustomize v4 -> v5

This change is needed because latest k8s.io/cli-runtime dep pulls in a version of kustomize api ...

9f04646fbb120974c99ede748d3b5de891103868 authored over 1 year ago by irbekrm <[email protected]>

Update go module deps

Signed-off-by: irbekrm <[email protected]>

db0036b0dfb25fd341f210fce6fed6f6f81e2259 authored over 1 year ago by irbekrm <[email protected]>

Bump kube libraries and other deps

Signed-off-by: irbekrm <[email protected]>

7bf89b77f1fa07b87cc36ef5a25247ea0633e0eb authored over 1 year ago by irbekrm <[email protected]>

Merge pull request #223 from wallrj/go-mod-upgrade

Go mod upgrade

268cd2fdba78d616a67a97c07d6ecb211f3da346 authored over 1 year ago by jetstack-bot <[email protected]>

go mod tidy

Signed-off-by: Richard Wall <[email protected]>

995acc020389536481ceb03d0ec344779e7bdec7 authored over 1 year ago by Richard Wall <[email protected]>

Manually bump the patch versions of some other dependencies

Signed-off-by: Richard Wall <[email protected]>

c6d22c693f91ef24eebdaa96526fb5c74ef5bc2d authored over 1 year ago by Richard Wall <[email protected]>

go-mod-upgrade

Signed-off-by: Richard Wall <[email protected]>

c6af4e50dd0669ba54955d139b64a931dff4c663 authored over 1 year ago by Richard Wall <[email protected]>

Merge pull request #215 from cert-manager/upgrade_dependencies

Upgrade dependencies

6a5b02111ab5ddd301549b2f71c8c73fa09989d2 authored almost 2 years ago by jetstack-bot <[email protected]>

Ecosyste.ms: OpenCollective

github.com/cert-manager/approver-policy