github.com/maikebing/putty commits | Ecosyste.ms: OpenCollective

Harvey Kwok observes that EnumPrinters() can sometimes fail to fill

in its output parameters. Hence, we initialise them before calling
it.

[originally from svn r7729]

9acc508c4ee32577c2626ec9088d551472e9456c authored over 17 years ago

Don't try SSH-1 RSA authentication unless the server has advertised support

for it. It's possible that this obsoletes BUG_CHOKES_ON_RSA. Certainly
the one SSH-1.5-Cisco-1....

1854dcd3881a23d85f8e39eaff53821823f2b942 authored over 17 years ago

In SSH-1, don't attempt password authentication unless the server has

announced support for it. Instead exit with a fatal error (since password
auth is our last resor...

1e8a5e47960cdb77a1627493d519a1cdf8c5fb3e authored over 17 years ago

Avoid "unused variable" warning when NO_IPV6 defined.

[originally from svn r7710]

2323cb947e2923f2d15137b17697b36985f849c9 authored over 17 years ago

Suggest another ttymode we could usefully set automatically.

[originally from svn r7709]

54321544d465196d52f9a3c3b4f6aae15ff61127 authored over 17 years ago

ssh->mainchan can be NULL; try not to segfault in that situation.

[originally from svn r7705]

4b178be3e9608120fe68a62999b8c678ef860e97 authored over 17 years ago

Correctly terminate nc target hostname when copying it.

While we're here, use memcpy rather than strncpy when we've already worked
out how much we're goi...

be8818b4bcf3a802850c99ee68731a9a8663c94b authored over 17 years ago

Use "int" rather than "unsigned" as the argument to ssh2_set_window, not

because it can ever be negative, but because we'll be comparing it with
another int. This way, C...

ac041a3d66c8105645267af4f017c55a8a4ef48f authored over 17 years ago

May as well reference an RFC rather than an Internet Draft where we can.

[originally from svn r7682]

dd10ff58648cb323d4449077b7b5e8c44fb652dd authored over 17 years ago

Small window-handling tweaks. Set the default big window to 0x7fffffff bytes,

and tweak ssh2_set_window() so it can cope with that. Also arrange to send
a private channel mes...

16cbd4f26095627796e2774e0ca43648f9c4c692 authored over 17 years ago

Remember to clear ssh_simple when initialising config.

[originally from svn r7674]

486771ec4a2e40278fb210cc36e133e976ef4609 authored over 17 years ago

In the file-transfer applications, which only ever use the main

channel, arrange to set the SSH-2 window size to something very
large. This prevents the connect...

a3ea90c0e8a113ec8ec28942a650d3aae99f44ff authored over 17 years ago

"CR implies LF" patch, based on one from Paul Coldrey.

[originally from svn r7669]

8659f5145ff8e72091943739a681b5031283551b authored over 17 years ago

Tweak window handling so that we send a window adjust if the window is half

used up, rather than over half. That this increases the throughput of PSCP
by 50% indicates just...

3dc0f8507d6752702e118822d5b34a5d922b2362 authored over 17 years ago

When omitting session data from logs, don't omit the length of the session

data string. This isn't strictly necessary, but it makes the logs easier to
use.

[originally fr...

7cda30ac1a7f9e2a6770f6c76824b806e4b6c5bd authored over 17 years ago

Tweak to window handling: Keep the local window in a signed integer, and

arrange to handle usefully the case where the server sends us more data
than it's allowed to. Th...

f48e3eb16b8abb9cf2f0f51e8fdbf0207f7ca35d authored over 17 years ago

Don't throw away data that we receive before we're ready for it. Just save

it up for later. This should prevent hangs when talking to particularly
enthusiastic servers.

T...

6d2c196708355f65d1764adc4fa1c04b0422356c authored over 17 years ago

Note lack of proxy auto-detection.

[originally from svn r7648]

ac6b5c8bd5e0e422d73b9994debadd7c9a7160dc authored over 17 years ago

Split pkt_ctx into a separate enumeration for each of kex and userauth

instead of a bitfield for both. This doesn't gain much here, but it should
make it easier to mak...

77da96c62f67871bfde01f48558b0e22882056f4 authored over 17 years ago

Arrange that log_packet() isn't called for raw data logging if logctx is null.

This allows us to send data in ssh_init(), albeit at the expense of its not
being properly logged...

c1459927df4cb40a2d2a45d63afdddc27a0f6edc authored over 17 years ago

Separate out the code for creating and sending SSH version strings so that in

the SSH-2-only case, we can send it as soon as we connect rather than waiting
for the server's on...

22cde3ee5b1938cf368e24955395c955bdd9daea authored over 17 years ago

Update an outdated comment.

[originally from svn r7642]

3ac841ff6fc3f2964c7c63d0be740019d9cb22a2 authored over 17 years ago

Implement Marcin Bulandra's suggestion of only automatically updating the

port number in the GUI when the connection type is changed if the current
port number is the stan...

db7cc1cba6dbd229db63d8ab1b2b86125c5d5933 authored over 17 years ago

Remove port number validation from Windows PuTTY -- it could cause unnecessary

trouble with serial connections, and a port number of zero gets caught later
anyway.

[originally...

6c14388c1d76c996318438d270afc91c76a076ce authored over 17 years ago

Rationalise access to, and content of, backends[] array.

Should be no significant change in behaviour.
(Well, entering usernames containing commas on Plin...

46c00b0f381f48a9992e43e014e104015952e9da authored over 17 years ago

Fix a couple of signedness compiler warnings, presumably due to me

using a different version of gcc from before.

[originally from svn r7627]

90e7bf4228fa74fda1c65cb2597c9d964329f702 authored over 17 years ago

Tong Ho points out a missing ssh_pkt_ensure().

[originally from svn r7626]

fd26b64c74af3dec75fd0a15059afd2e2ed9a275 authored over 17 years ago

Index "MAC" a bit more thoroughly.

[originally from svn r7610]

c2bb01fa9348c364c5e875a147c46db7f4b94a8a authored over 17 years ago

Explicitly spell out that "incorrect MAC" type errors can be caused by

data corruption in the network.

[originally from svn r7609]

3a79eff8e2dcc7a7855e535e29e1ce3512087e18 authored over 17 years ago

Retire the e-gold link. Nobody's used it in years; I honestly don't

know how I'd go about retrieving money from them any more because my
last exchange transaction we...

aeee77998ee67ead931e6ddc5257bc0c6c84cbb2 authored over 17 years ago

These days, you _can_ save a host name in Default Settings.

[originally from svn r7566]

7eaa5e1c44d03efba2d07a58dde13877557f9444 authored over 17 years ago

Make bounds of automatic array constant.

[originally from svn r7503]

3814ef0725dfef8d6b7e3bb74d62ddcf72ab16fc authored almost 18 years ago

Since r7496, Pageant needs sshsh256 to build (although it doesn't need

SHA-256 to actually do its job).

[originally from svn r7500]
[r7496 == dad558a1e59c059b7f3436a48...

f2f717bb47a041c476b99192d355eddbac2bb5db authored almost 18 years ago

Reindent the section that was marked `XXX The lines below should be

reindented before this is committed'. Unfortunately not before it
was committed, but you can't ha...

723d834a13fd1b89beafe55254e776ef82640b53 authored almost 18 years ago

Add support for RFC 4432 RSA key exchange, the patch for which has been

lying around in my home directory for _years_.

[originally from svn r7496]

dad558a1e59c059b7f3436a4865b5e4e17c59539 authored almost 18 years ago

Create installations directories before installing into them, like GNU

packages do.

Problem reported by Manfred Pausch.

[originally from svn r7494]

9f7f5157fe921dadc837f65a38a2f50e416ecb7f authored almost 18 years ago

Update version numbers for 0.60 release.

[originally from svn r7488]

3f9d53aa9e58be5a6764862f0c15c1c4979ac19f authored almost 18 years ago

Avoid creating the Session/hostport control set in mid-session.

[originally from svn r7477]

ec1e37fb55c65c4a81023837115cdfa145c8bbc9 authored almost 18 years ago

Capitalisation error.

[originally from svn r7476]

ce6349bd89e4876e4bf531f12bc8d4789946f2ca authored almost 18 years ago

When we get an error writing to a local file, stop the download rather than

pretending we just got -1 bytes. Not actually tested, but it looks pretty
obvious.
Bug reported ...

7df108f2fd0d8311a312bb9feee3cfe0c8fe79c5 authored almost 18 years ago

When the comments say `if we're in restart mode', the code in

question should actually be conditional on restart mode!

[originally from svn r7438]

0a3c07d15e8888ec0fc13c755a753d215b35ebd1 authored almost 18 years ago

In the wake of r7415, let's have some better error reporting.

Instead of passing -1 to its gotdata and sentdata callbacks on
error, winhandl.c will now pass th...

5f410ef051252d9961065c5441051c2395cc84eb authored almost 18 years ago

Windows apparently sends ERROR_BROKEN_PIPE when a pipe we're reading

from is closed normally from the writing end. This is ludicrous; if
that situation isn't a natura...

702a92ceb848394f722292cd4a54c414d4e0be67 authored almost 18 years ago

Patch from John Sullivan: process double-clicks in the session list

box on button-up rather than button-down. The effect of this is that
if a saved session is alread...

7e4eb1f4042323d42e9b7753714a6bf1becd9b5e authored almost 18 years ago

Fix a stupid one-character typo that was breaking 256-colour support on GTK.

[originally from svn r7403]

d1df3e226a7385f948196d62edf119ee82028100 authored almost 18 years ago

get_random_data() can return NULL (for instance, if we can't open /dev/random

on Unix), yet cmdgen failed to deal with this. Spotted by Darren Tucker.

[originally from svn r7...

36db0d6f72e81c449317e66624c7cebf651ccb3c authored almost 18 years ago

Process -t/-T later than -m, so that they can override -m's default behaviour

of no pty.

[originally from svn r7348]

2b0d1b02243e2d7f2b64ee1c69a39df5555a75ba authored almost 18 years ago

Prepend \\.\ to configured serial line string, to allow easy access to ports

above COM9.

[originally from svn r7345]
[this svn revision also touched putty-wishlist]

a3ff37885dfe3705230f4349d770c7d83a212af0 authored almost 18 years ago

Attempt to scrub -pw's argument in argv[], to make it less obvious.

[originally from svn r7323]

01612d38e4bb0b5d4bd8d9c2edc7e6ca819426aa authored almost 18 years ago

Delay evaluating the "-pw" option, so we can criticise the user's choice of

backend, bailing out if anything other than SSH is in use.

[originally from svn r7322]

917b32dd8b3be37a70d282865a197ae7db691f19 authored almost 18 years ago

Since r7265, a user could not launch a PuTTY session to a specific host by

simply specifying a hostname on the command line -- this would bring up the
config dialog. Use a ...

befd797f97078d7e5486fce9c715f12c3be0825b authored almost 18 years ago

"-noagent" and friends should be marked SAVEABLE, to ensure they're not

clobbered by "-load".

[originally from svn r7320]

fe1909e0e21a4f6e619eb93c883cdc28d4dbf6ad authored almost 18 years ago

Gareth pointed out yesterday that the Unix terminal front end treats

BELL_DISABLED as BELL_DEFAULT. How embarrassing.

[originally from svn r7316]

b897c90dd3f0be2f951ddd78741bc8ee5f0d9f01 authored almost 18 years ago

This reordering of the Unix Makefiles (requested by Michael Shigorin) allows

use of -Wl,--as-needed.

[originally from svn r7299]

0f013108c31d7f4ea09582dfe9ff06ccfd6a4516 authored almost 18 years ago

In controls where a list of entries is manipulated by Add/Remove buttons

(SSH tunnels, TTY modes, and environment variables), when the Remove button is
pressed, populate ...

0407960951fa2bb3b9c1a3976201f2176c36c23e authored almost 18 years ago

Allow dlg_listbox_index() to be called on multi-selection list boxes.

[originally from svn r7297]

31382c02df2a1c888822ed52afa3d9408c2721ab authored almost 18 years ago

Bring the OS X front end up to date with recent changes to the main

code base.

[originally from svn r7296]

4d51d0d38017084e56ac8b0e6b264923306993b7 authored almost 18 years ago

Ctrl-Break now sends a Break signal (previously it was equivalent to Ctrl-C).

[originally from svn r7295]
[this svn revision also touched putty-wishlist]

c5374da822d48a28eb28adb18320d420044976b5 authored almost 18 years ago

Use preprocessor trickery to make the signal translation mechanism a little

less hideous. The output of the preprocessor should be basically unchanged.

[originally from sv...

3ffd1fbe38f2bece92498334bd0949dd1b28ebfe authored almost 18 years ago

ssh2_set_window checks whether the channel is being closed, so there's no

need to check that before calling it.

[originally from svn r7293]

f69a0cf005dab818839bdcbbe0c8a6cdeead7023 authored almost 18 years ago

Unbreak "Duplicate session" on Windows, in a similar way to r7291.

[originally from svn r7292]
[r7291 == 062b5ab3e412435b9c452b371b51beeaa026608e]

8230ce9fa0c204ad9d0a27f2d3ecd524e9380018 authored almost 18 years ago

r7265 broke the legacy `putty @sessionname' construction, which I

wouldn't care about except for the fact that it's still used to
implement the Saved Sessions menu...

062b5ab3e412435b9c452b371b51beeaa026608e authored almost 18 years ago

LICENCE in the installer should have CP/M line endings.

[originally from svn r7290]

f634340275cf9a002cf64f04dfc73ee6da1df077 authored almost 18 years ago

It turns out that HH_INITIALIZE and HH_UNINITIALIZE are optional, and are for

putting HTML Help into "single-threaded" mode. Furthermore, this requires
extra work from the app...

3d78bf9b261b4bfd30ae00d5ba43744c4144c934 authored almost 18 years ago

Note that htmlhelp.h from HTML Help Workshop works perfectly well with Cygwin.

[originally from svn r7273]

c8ac23705d7c2707238ed8b9094c5b74c70432f5 authored almost 18 years ago

Typo.

[originally from svn r7271]

f947275c64f73a8ea84fe5dc535b1c10446633f7 authored almost 18 years ago

Since we're now able to cope with Default Settings describing a

launchable session without getting confused by it, we can relax the
restriction on storing a host...

856ed4ae73576ef5725f1ea4999f40907ab13589 authored almost 18 years ago

Avoid launching a session from the Default Settings, even if they do

represent a launchable session, unless the user can be construed to
have really meant it. This me...

5d76e00dac9220e8798e4d0f17a4069a58ae1667 authored almost 18 years ago

I've changed my mind about the PuTTY build script. It now delivers

the release directory into a _subdirectory_ of the main build.out,
and delivers the link maps and...

c4893477bdc563fd24cfeb406ff1925467670673 authored almost 18 years ago

The big payoff from bob (from my POV at least): the PuTTY release

procedure is now a huge amount less painful.

[originally from svn r7249]

c61c0644e4e37d848ecf9035221b5d336baa066c authored almost 18 years ago

`installer.ico' doesn't fit into 8.3, so gets truncated to INSTALLE.ICO in

the Windows source Zips. Rename to `puttyins.ico'.

[originally from svn r7241]

762f341d56597700589b2d99bbafab350d7cd921 authored almost 18 years ago

When emitting SSH_MSG_IGNORE to protect against known-IV attacks on CBC,

remember to put an empty string in it rather than sending a completely
empty packet. This should...

91694cb3a28a10e105430bf03ef0a37d4701637b authored almost 18 years ago

Ahem; other half of r7232...

[originally from svn r7233]
[r7232 == 6ee6a4d37926062f5b610de4cef2a6ce4fe63345]

9c35141162c047546e5bb400b97c53cdd23a7dca authored almost 18 years ago

When calling TIOCSCTTY, it helps to pass it an fd that's still open,

instead of one we closed two lines earlier. I apparently broke this
in r7107.

[originally from s...

6ee6a4d37926062f5b610de4cef2a6ce4fe63345 authored almost 18 years ago

Avoid passing modified SVN revision numbers (of the form 1234M) to

parts of the versioning code which might not like them.

As a result of this checkin, bob builds ...

a5d45db0c9fe7684951901f88307f32dcd19829d authored almost 18 years ago

Fiddle further with .htaccess: add some $s on the ends of the

regexps to stop them matching the wrong files.

[originally from svn r7229]

0865939a56235aa682ce50fbe909f9a3550431ec authored almost 18 years ago

HTTP redirects for the variably-named signatures as well as their

base files. (The signatures aren't actually _generated_ by bob, of
course, but the redirects are ...

54dd6440ba778c6feb3469727957fa319c5b6feb authored almost 18 years ago

Script to generate signatures on the various PuTTY build outputs.

Saves me having to remember all the fiddly gpg arguments every time.
Should be usable for both re...

1c2c6f6c475c64e1e56beda2a86d51ad908fdac7 authored almost 18 years ago

Fixes for snapshot building using bob. All of releases, snapshots

and custom svn builds should now have appropriately named Unix
source archives and installer bina...

a45f89cdd4a587e6ad3e2e0d2e5ca4fb558f1125 authored almost 18 years ago

Be slightly more forgiving about the nature of SVN_REV; bob will be

reliable at defining it, and it's useful to be able to pass `1234M'-
type revisions in for testin...

0a4bb7e711e1715d60111ec0bd2e12f5ecfcb7ee authored almost 18 years ago

Fix errors in $(Makeargs) which only occur when building development

snapshots.

[originally from svn r7220]

9951498e63629357ff6f59ebae4f9f5264767bba authored almost 18 years ago

PuTTY builds should save the map files.

[originally from svn r7212]

64b4984354ccef36fda068ca17748aa082b282dd authored about 18 years ago

Version management updates for the new bob build script. There's now

a fourth class of PuTTY version tags in addition to release,
snapshot and unidentified: we now ha...

ab795ba00889e6f1c9dc57b053d14ddf6bbc5fee authored about 18 years ago

Document \\.\COM10 faff on Windows.

References:
<http://msdn2.microsoft.com/en-us/library/aa363858.aspx> (CreateFile() docs)
descri...

c183555bd5185498fae083881f892b0428456ecd authored about 18 years ago

Build script for PuTTY using bob.

[originally from svn r7205]

29ba6a6b873ae75dcf4b00e3a879fe17739cf8cf authored about 18 years ago

Swap order of `Columns' and `Rows' in the config dialog, to make it

consistent with sizetip.c (and more nebulous conventions).

[originally from svn r7196]

0f366c32bb221e508de9f9c7214414ccd5111436 authored about 18 years ago

Colin Watson has fixed the disgusting icons on GTK1. His patch

appears to merely fix the background colour (arranging for it to
have transparency rather than be...

b5df0a7732024a838adf79dbebb6f7dae62f0799 authored about 18 years ago

In the cases where Setup asks to restart the computer, explain exactly why this

is deemed necessary.

[originally from svn r7179]

7d6dae5e584bb5d84356ee3d7ea2db18733e0283 authored about 18 years ago

Better not forget to make sure GTK1 doesn't break.

[originally from svn r7174]

12e019bafc75cb441e965c63e15dfceeaf71ca1e authored about 18 years ago

Move the TODO items from the top of gtkdlg.c into the main TODO file.

[originally from svn r7173]

1d829f97cc49ad94c25b11f356302add9eba6be0 authored about 18 years ago

Changed my mind about r7164. Instead of checking for zero flags

inside one single uxsel front end, better to do it centrally and
avoid passing zero flags on to t...

0ed390d44a6243edf7847c2b50ff1f59a025f07b authored about 18 years ago

Switch round the order of CFLAGS and XFLAGS, so that the latter

comes last on the compiler command line. This makes it easier to
override the normal compile opti...

f042451e3ca6e501f4cc1dbf22fd241418a84054 authored about 18 years ago

If I'd tested under Minefield before releasing, r7168 would have

been committed before the release. Therefore, stick it on the
checklist for next time.

[original...

aa67efd0fab280dff74dac684313f17844838e59 authored about 18 years ago

Kai Jourdan spotted a rather embarrassing double-free, and Minefield

confirms that it's a real problem.

[originally from svn r7168]

b3a5cdc5fbab8884755690286211fa6b3425d9d3 authored about 18 years ago

Er, whoops. Remove two lines from a previous attempt at r7165, which

broke the build. Ahem.

[originally from svn r7166]
[r7165 == 6d81ee9cc0e62cddf339b5e4030d5edeca1...

13ad541cb5c7f54a5eb8b781dcea1f48c9f05896 authored about 18 years ago

Collapse tree view branches deeper than level 2, bringing the GTK2

tree code into line with the GTK1.

[originally from svn r7165]

6d81ee9cc0e62cddf339b5e4030d5edeca192047 authored about 18 years ago

Stop calling gdk_input_add() with a zero flags word. If we don't

want to know about any input events on a socket, it's simpler not to
call gdk_input_add() on it a...

65f9735b95cc8bbf5e7e23f165c01fd3cddf9ec5 authored about 18 years ago

Another TODO item. (There's always one.)

[originally from svn r7163]

5d3306f98d986ec42cae0c22b0dd82626e63ecb9 authored about 18 years ago

Begin tracking a TODO list for this branch.

[originally from svn r7162]

c5953f16807ece1ce88af1f4182c561cbca6049c authored about 18 years ago

A nasty GTK signal cascade was causing any edit box whose contents

was modified on session load to be blanked. More details in the
comment in dlg_editbox_set().

[o...

ac7870a63530a4d548bb786bbca529d47a73178c authored about 18 years ago