github.com/maikebing/putty commits | Ecosyste.ms: OpenCollective

Hiroshi Oota points out that PuTTY's agent forwarding sockets can get

confused if they receive a request followed by immediate EOF, since we
currently send outgoing EO...

14539a77197feb8d9e0f56433545fcd828b8aa3a authored over 12 years ago

Factor out some common code for constructing SSH2_CHANNEL_OPEN.

[originally from svn r9649]

33c58dd91b8350bd47b363786a3f39587cf8ead6 authored over 12 years ago

struct winadj is unused now. G/c it.

[originally from svn r9648]

de6d59b500ca7907be0018ffab06b9cd856cf927 authored over 12 years ago

All of the initial CHANNEL_REQUESTs are conditional on (ssh->mainchan &&

!ssh->ncmode), so bundle them up in a big block conditional on this rather
than checking it five ...

98e562b7f6b0e0e0e5c71d4acb636d964a0b5b3a authored over 12 years ago

do_ssh2_authconn() now installs the standard handlers for CHANNEL_SUCCESS

and CHANNEL_FAILURE as soon as it's opened a channel, so there's no need
for it to set them again...

54da9ee07a3334b2fb32995f0af4408e6e9edec8 authored over 12 years ago

Memory leak fixes reported by Balazs Domjan.

[originally from svn r9645]

8acd57afb51e2facb1c3db7783800f45fda9fda0 authored over 12 years ago

Rename the various ssh2_maybe_setup_* functions to ssh2_setup_*, and

move the primary conditions out of them into their callers. Fixes a
crash in 'plink -N', since th...

b631c1e18e2abb89e8fb8fdf02140f399a1a99c9 authored over 12 years ago

In openssh_read(), we shouldn't ever return SSH2_WRONG_PASSPHRASE for

an unencrypted key. (The other import function, sshcom_read(), already
got this right.) Thanks to...

dbc8ea8e353c06edb3287c02fa4901d1e026a836 authored over 12 years ago

Avoid leaking file handles in load_openssh_key(), as reported by David

Wedderwille.

[originally from svn r9642]

e2a48fe9b11975ebab421bdf222edea4ea239965 authored over 12 years ago

Fix a controlling-terminal bug reported by Anthony Heading: Cygwin

doesn't have TIOCSCTTY, so my attempt to set the ctty of the child
process isn't doing anything, ...

ddfca43402791924161b9a2cb7405e32dba5916e authored over 12 years ago

Partially revert r9636. It is true that we can directly return the

result of memcmp, but untrue that we can do so _unconditionally_: if
memcmp returns zero, we stil...

03ebc74b9f284e9334f58646f00784ebfe5fc308 authored over 12 years ago

Clang, like LCC, objects to using '<' and '>' on function pointers.

I'm not entirely sure that using memcmp() is any more defined by the C
standard, but at least Cl...

538090ede444b111039904cf918f095dc858e875 authored over 12 years ago

Change return type of do_ssh2_transport() to void.

Nothing pays attention to it any more, anyway.

[originally from svn r9635]

e27ce2017e860c93369414d4f9c1ed12c54360f6 authored over 12 years ago

Make bombout() less of a macro and more of a function.

This gives GCC slightly fewer opportunities to gratuitously inflate
its output.

[originally fro...

3cc03d85e7c96fd1c1e05617566968a4091b6e97 authored over 12 years ago

Fix a memory leak in parse_ttymodes() (found by Memcheck/Valgrind).

[originally from svn r9633]

df83634e21d9442210ed244c9b4ff1a0c3fbd983 authored over 12 years ago

Slightly simplify crFinishFree{,V}.

They're only likely to be useful for freeing a coroutine state
structure, in which case there's ...

475507e9786af7850b42b18eec2eb8b59856651b authored over 12 years ago

Don't close SSH-2 channels with outstanding channel requests on local error.

In sshfwd_unclean_close(), get ssh2_check_close() to handle sending
SSH_MSG_CHANNEL_CLOSE. That...

0768c8557d9c4c6297e7bd7a5a114accd51ce546 authored over 12 years ago

It's not legal to free a coroutine's state structure before invoking

crFinish or crFinishV, since they will attempt to write to the
coroutine state variable contained...

3fa95b2a7fa8082ad0109959d601c9e664ecdf84 authored over 12 years ago

Fix markup error introduced in r9626.

[originally from svn r9627]
[r9626 == 92fc25c6cd04788cd409021979106f98ac032f30]

85c95e30e4cb29c3bfef8004af7a06f00cc6ecf9 authored over 12 years ago

Remove documentation for "Out of space for port forwardings" error.

It no longer exists in the code, and should have been obsoleted by
r9214 at the latest.

[origin...

92fc25c6cd04788cd409021979106f98ac032f30 authored over 12 years ago

Improve window-size handling in Unix Plink.

Unconditionally override the configured terminal size with the one
from stdin if it's available....

3fad1f402b6a3919be6b62241583636e5f85c84f authored over 12 years ago

Better handling of outstanding CHANNEL_REQUESTS on channel destruction.

Part the first: make sure that all structures describing channel
requests are freed when the SSH...

3d466aec90909db75eef8b6aaeedcd56eb925a2a authored over 12 years ago

Factor out common code to construct CHANNEL_REQUESTS.

This reduces code size a little and also makes it harder to
accidentally request a reply without...

4e623f5b23ec549a3da21f9d819c8ee31fd31417 authored over 12 years ago

Simplify handling of responses to channel requests.

The various setup routines can only receive CHANNEL_SUCCESS or
CHANNEL_FAILURE, so there's no ne...

ab6d966f91ce694bbb66e73f50b6e869672f9e05 authored over 12 years ago

Add some kind of window tracking to logparse.pl.

[originally from svn r9618]

1c4eac5fa31170c89e0d2601b6b2f13077a9d83c authored over 12 years ago

Fix matching of channel and global requests with replies in logparse.pl.

In each case, want_reply was being treated as true even when it wasn't,
because it got decoded i...

8387897d9051354b7ddde4e06a95286865c7ea34 authored over 12 years ago

Handle all replies to CHANNEL_REQUESTs through the per-channel queue.

Each of the minor start-of-session requests is now dealt with by its own
little co-routine, whi...

30e43ba2a33c4f107da25d3a2d6b081ffd978d43 authored over 12 years ago

Generalise SSH_MSG_CHANNEL_{SUCCESS,FAILURE} handling.

Now each channel has a queue of arbitrary handlers for those messages,
with anything that sends...

57945a753fcbe3dd55286775ef2a2236fd419187 authored over 12 years ago

Fix a bug in the PSFTP command parser which would cause it to

hallucinate an extra empty argument word at the end of a line if the
line ended in more than one ...

5ebf74d103034960dd8f1c4ad0cc15254317dce0 authored over 12 years ago

Enhance logparse.pl so that it detects channels running SFTP and

decodes the SFTP message layer in addition to the underlying SSH.
Requests and responses are matc...

f796f2d2d38830b9ed25f00eba761a10ec527f32 authored over 12 years ago

Fix recently-introduced memory leak in ssh2_msg_unexpected().

[originally from svn r9611]

f071feb9a646ecb51e3d6db543119b88cafda832 authored over 12 years ago

De-duplicate code in KEXINIT generation.

There's no need to have identical code generating server-to-client and
client-to-server versions...

e148dd97e3ab3417ef1ad424351d4af70a6cdd19 authored over 12 years ago

Reworking of packet delivery to coroutines in SSH-2.

Before, NULL in the dispatch table meant "send to the appropriate one of
do_ssh2_transport() an...

8e0ab8be5938c930c744e2cd624a4c7e88e5f64c authored over 12 years ago

Fix an erroneous "case" fallthrough in ssh1_msg_channel_close, which was

causing assertion failures when closing X11 channels in SSH-1. Also fix
another pasto.

[origin...

4e5012aeda11177b8cc53a8d49e051747a3efcf7 authored over 12 years ago

Tweak to SSH coroutine code: put line number in the coroutine state

structure, which is consistent with Simon's canonical version of the
macros.

[originally from sv...

e570820c746a921e15a2e7c8e4b410e0deebd9b8 authored over 12 years ago

Use a single sftp_senddata() to send each SFTP packet, rather than

using one for the length field and one for the rest of the packet
contents. Since sftp_senddata()...

1ac65ff01703a06eb78a0a74b658ce30b0f5b08b authored over 12 years ago

Rework bufchain code to allow for variable-sized granules.

bufchain_add() now allocates at most one new granule. Granules still
have a minimum size, so sm...

b599e77ada8399459b14c710ed1db1e48456c868 authored over 12 years ago

Reduce the number of round-trips involved in opening an SSH-2 session

by sending most of the initial SSH_MSG_CHANNEL_REQUEST messages before
waiting for any replies. ...

37ea0f45414fe01250de8485ed9f4c390057861c authored over 12 years ago

Add a missing \define I accidentally assumed was there in r9592.

[originally from svn r9593]
[r9592 == 71f0c7546dfa8930277c895b88f57585fd8ef854]

8ae3278d0c88875696ede0416240db34d6dc7bef authored over 12 years ago

Add a bug-compatibility flag to disable the

[email protected] request. Not currently enabled
automatically, but should be us...

71f0c7546dfa8930277c895b88f57585fd8ef854 authored over 12 years ago

Fix an embarrassing mistake in config box handling which was causing

changes to any SSH bug config option to be lost when the config box
switched to a different panel...

0b8753a4b93447fda7af63f5af3526f35bfcc206 authored over 12 years ago

Move the declaration of smemclr() out of putty.h into misc.h, because

one of its uses (in sshaes.c) wasn't picking up the former. Thanks to
Ubuntu's gcc for spotting t...

b0bb426aa7ade2204b1d5b7f3f3570ebf7501c56 authored over 12 years ago

Remove an unused variable.

[originally from svn r9589]

afa871e3cfc82eb6b92b02fd1dad094c5d1949f2 authored over 12 years ago

Introduce a new utility function smemclr(), which memsets things to

zero but does it in such a way that over-clever compilers hopefully
won't helpfully optimise the ...

aa5bae89163f96453ee84541c1e96c650b3bc8f8 authored over 12 years ago

Remove a bashism in mksrcarc.sh, without which bob builds fail on

Ubuntu (whose /bin/sh is not bash).

[originally from svn r9585]

acf8a5385d22db78435555a19ce0288b468cfd98 authored over 12 years ago

Add '-Wall -Werror' to the compile options in the autotools makefile,

having just noticed that Makefile.gtk had it and this one doesn't. (Of
course, this being autocon...

3d3052f680f533daa5a6134342d9a76753afa237 authored over 12 years ago

Rework the new type-check in sresize so that it doesn't cause a

compile warning ('left-hand operand of comma expression has no
effect'), which of course becomes ...

f40d49b70455bb549fc6746f273873a771039fcb authored over 12 years ago

Remove term_key, which was intended to handle function keys in a cross-

platform manner, but which nothing ever called. It thus served only to
trap up the unwary. The ...

1993b90edf96e2d1c80b3c7a1682701757b3bf06 authored over 12 years ago

If pterm's execvp fails when given the whole argument list after -e,

and the argument list contains only one string, try again by passing
that single string to "$SHEL...

75239b955ba7cb4843aa7a7e9d2befc4c3f27a27 authored over 12 years ago

Turns out that the compose-keys fix in r9567 did in fact break one

piece of keyboard handling: if Num Lock is on, numeric keypad keys are
eaten by the IM, so we mus...

a3f74661c8da1b8ac2eb34b0e73fb70172a85b48 authored over 12 years ago

Stop including <gtk/gtkcontainer.h> directly, since a user points out

that it'll be absent in GTK 3.

[originally from svn r9571]

d0ac277f78dea1a359d03b3619ace462c8600fca authored over 12 years ago

John Hartnup reports that Apache SSHD's SFTP server responds to

FXP_READDIR on an empty directory by returning a zero-length list of
filenames, instead of the mo...

a580c22c2419a9236466ca8ee80bc97bc9da41eb authored over 12 years ago

Add the missing code to treat data coming from the input method as

keypresses for purposes of hiding the mouse pointer and resetting the
scrollback.

[originally fr...

72640ff6152f460620431848ddf616eecf0e39cf authored over 12 years ago

Support for dead keys and compose sequences on Unix, by instantiating

a GtkIMMulticontext and having that filter most keypresses. I think
I've got this right so that i...

7fc8db15b262ba644b1c7f8e9b89cc5a86f104f2 authored over 12 years ago

Introduce a third setting for the 'bold as colour' mode, which lets

you both brighten the colour _and_ bold the font at the same time.
(Fixes 'bold-font-colour' and ...

bc6e0952ef1c27c577318ee3c0883c7823c7005b authored over 12 years ago

Add missing check for failure to agree a host key algorithm.

[originally from svn r9557]

a46aac386b20e6474d45f701a96d7afc8cfdafec authored over 12 years ago

Missing #include.

[originally from svn r9551]

799f7f563d505357cf904b5b8e28dcbc79194063 authored over 12 years ago

Fix a bug in cygtermd, spotted by Casey Zacek, in which we

unconditionally set the telnet state to SEENCR regardless of whether
we have actually seen a CR, ...

615455a913d5d28c1368406474ae4bb06697bf44 authored over 12 years ago

Enhance my 'sresize' macro so that it type-checks the pointer you pass

_in_ to it, as well as the one it returns. Why have I never thought of
doing that before?!

[orig...

c10a8dee07fc10cbe9295e1a088b15b6e357f774 authored over 12 years ago

Fix bug in the new CLOCK_MONOTONIC implementation. I was treating the

nanoseconds field as a microseconds field, with hilarious consequences.

[originally from svn r9535]

29184e3702f7b9131d78f4732e4deae5d1c918bc authored over 12 years ago

Use clock_gettime(CLOCK_MONOTONIC) as the Unix getticks(), if it's

available.

[originally from svn r9529]

0395e52bb8db4b77e792ea1c46b2c0024c67986b authored over 12 years ago

Patch from Robert de Bath to substantially simplify timing.c.

The previous platform-dependent ifdefs, switching between a system
which tried to cope with spur...

aba05b7180b39ee51d72b1da867303c002188f2c authored over 12 years ago

Fix from Robert de Bath which reorders the Windows initialisation

sequence: since init_fonts sets up ucsdata based on the available
Windows fonts, we should call i...

d095b3c35c8b8a597dbff99dd34ff19bfa3986fe authored over 12 years ago

Bug fix from Robert de Bath: since lpDx_maybe is always supposed to

equal either lpDx or NULL, we mustn't forget to update it when we
realloc lpDx.

[originally from...

16a02bb9fc3f6e5ac89822d6a773cb00369a38c5 authored over 12 years ago

When we are asked to unthrottle an SSH connection (by the front end

calling back->unthrottle), we should immediately call
ssh_process_queued_incoming_data to handle ...

b73527e641fa09ff57ffd4d20ec4e4045039b890 authored over 12 years ago

Fix trivial Perl goof in logparse.pl which caused

SSH2_MSG_CHANNEL_FAILURE to be reported as replying to
ARRAY(0xrubbish) instead of to a message n...

03cc84d3f3ec122b0787bf6e97d2e715f979f432 authored over 12 years ago

Fix an inverted comparison in rlogin.c which must surely have broken

logins completely, with or without a supplied username. Ahem.

[originally from svn r9471]

4318e3227fbb3a28125b1c30175c4869b97654f3 authored almost 13 years ago

Call sshfwd_unclean_close() in the event of a local socket error on a

forwarded X connection. (I somehow forgot to do this in r9364, despite
making the identical chang...

76a27757e6bbc57eed01315c8346b6ec7848fe84 authored almost 13 years ago

Patch from Robert de Bath to ifdef out the Windows-specific hack for

the offset horizontal line characters in the VT100 line-drawing set
(o,p,r,s), so that no trace o...

3225f3743eed10fd84fe6d5adaf30b16618a890a authored almost 13 years ago

Bug fix from Robert de Bath: if wc_to_mb returns a length of zero, it

will not even initialise sbstring[0], so we shouldn't even look at it
let alone depend on it to t...

b81b04f9b2fec6d6e7bd71431d0c597ab7f2bab6 authored almost 13 years ago

Bug fix from Robert de Bath: if the utf8_override setting is changed

in mid-session, it affects translation and hence display, so it should
be listed among the settin...

bb1d656dd4dac5594bf13717dac1e2512b311935 authored almost 13 years ago

Conditionalise the calls to premsg and postmsg in uxcons.c's

logevent(), which temporarily turn off the raw mode we've put stderr
into, so that they don't get...

f030975da7bb38c196caa936ccf8c33ec8437654 authored almost 13 years ago

Fix a Perl warning about useless use of a constant in void context.

[originally from svn r9458]

5c743effc0934ed841e68cdec60f96f3337889c1 authored almost 13 years ago

New utility script to parse an SSH packet dump and write out an

interpretation with some analysis done on it. The script will do its
own tracking of the set of o...

76cdb3f523809d854c406a42a4f961a4cb8cc6d0 authored almost 13 years ago

Add code in dlg_filesel_set and dlg_fontsel_set which makes them

duplicate the strings they pass to gtk_entry_set_text. I was already
doing that in dlg_editbox_se...

047dc326b4a86804ad0b7549068cf8a540096165 authored almost 13 years ago

Fallout from the big revamp in r9214: colour handling was going a bit

wonky because I'd used the subkey for the red component in four places
where I should have used t...

63cb9c835663881e2c473753b7e54d2ceb2b7d47 authored almost 13 years ago

Fix another type mismatch introduced by r9409.

[originally from svn r9427]
[r9409 == 053d2ba6d1c35c3d3c77bbc48bfd31fd8628ed35]

947fa8f0aee7b9f54eee499d81f6d27af721ab1a authored almost 13 years ago

Fix a type mismatch in minibidi.c - r9409 changed the 'wc' fields in

bidi_char from wchar_t to unsigned int, but omitted to similarly
adjust the parameter to doMirror...

78dc12eec73e58c123b506bc1e3059c0b73d1220 authored almost 13 years ago

Initialise some variables to NULL, to placate optimisers.

[originally from svn r9425]

9ecfbee08f914001b1dc91937957be6021974e63 authored almost 13 years ago

Remove comment about 1024/1023 RSA key lengths that's no longer true as of

r9421.

[originally from svn r9422]
[r9421 == 9604c2b367a2379b37fd1d299cd831193eed43c5]

24f0a6f13b90bd495a8174d06f40813fd8852d78 authored almost 13 years ago

Generate keys more carefully, so that when the user asks for an n-bit

key they always get an n-bit number instead of n-1. The latter was
perfectly harmless but kept co...

9604c2b367a2379b37fd1d299cd831193eed43c5 authored almost 13 years ago

Long overdue rewrapping of the primes[] array for legibility. I think

the previous ghastly formatting arose when I ran the whole source base
through GNU indent...

[or...

e59f1ac827da4f690918fbcae41d173f4c4a8d85 authored almost 13 years ago

Update default key length in PuTTYgen to 2048.

[originally from svn r9414]

948203f2c7cd5f0ebe6f995aea79ce65ed93e4ee authored almost 13 years ago

Update to 2007-05-26 version of upstream wcwidth.c.

[originally from svn r9413]

46bd2b07212e48f4e861e1934d6712fc0c07b330 authored almost 13 years ago

Patch from Matsui Nag to implement xterm's "bracketed paste mode", in

which text pasted into the terminal is preceded and followed by
special function-key-like escape ...

21b04f5e00e21b4ffbb790d23c26e25b7f977ba2 authored almost 13 years ago

Patch from Yoshida Masato to fill in the missing pieces of Windows

UTF-16 support. High Unicode characters in the terminal are now
converted back into surrogates du...

053d2ba6d1c35c3d3c77bbc48bfd31fd8628ed35 authored almost 13 years ago

WM_SIZE/SIZE_MAXIMIZED can show up even during an interactive resize,

so we should ensure we treat it the same way as other WM_SIZEs that
show up during that time: set...

e350ca2b4e80bfea2fe4915d512000bcb353333b authored almost 13 years ago

New FAQ: "When I put PuTTY in C:\WINDOWS\SYSTEM32 on my 64-bit Windows system,

`Duplicate Session' doesn't work." (Explanation courtesy Owen.)

[originally from svn r9391]

f9a6c2e4a58c58ee03b86ac3f8ef8f37e0214645 authored almost 13 years ago

It's a new year.

[originally from svn r9390]
[this svn revision also touched putty-website]

0e6f6ff4eb47c9f88166baa7d41b926b26c7f4b2 authored almost 13 years ago

If we're called on to uncleanly close an SSH channel for which we've

already sent SSH2_MSG_CHANNEL_CLOSE, we should not skip the _whole_ of
sshfwd_unclean_close(), on...

7c61b3c73342a59f1b219eff1cebef9440d16524 authored almost 13 years ago

Patch from Colin Watson to use g_ascii_strcasecmp in place of the

deprecated g_strcasecmp (since all the strings being compared are
parts of XLFDs and won't be in ...

736c5f86ebbb6cbabd21f2ebfd407fc8d32d4013 authored about 13 years ago

Checklist update following the 0.62 release. I managed to send out the

announcement email without a subject line, so I'm reorganising the
announcement entry in the chec...

a80ba74239e2bccd54af309829c3b8c3339bd846 authored about 13 years ago

Bump version number on trunk prior to tagging 0.62 on the branch.

[originally from svn r9365]

c968d9fe8ea9a0fabc02ff7a384550ff350e819d authored about 13 years ago

Introduce a function sshfwd_unclean_close(), supplied by ssh.c to

subsidiary network modules like portfwd.c. To be called when the
subsidiary module experiences a ...

49927f6c4dc619865ade72fabd0f659726bc0908 authored about 13 years ago

Arrange to call net_pending_errors on Unix, which we've never actually

remembered to do before! Also some related fixes, such as that after
we do so we should immediate...

f892af999e245675aae2b037ffb4bb873a1d0392 authored about 13 years ago

When we receive CHANNEL_CLOSE on an SSH-2 channel and haven't sent EOF

on it yet, we should send EOF on _that channel_, not the main session
channel! Oops.

[originally...

8aa218e8942bcfd4ef1bc3cea393616283f18389 authored about 13 years ago

Whitespace fix while I was passing.

[originally from svn r9361]

69a01afe48365b8898a9b48cea0d9f9729d32347 authored about 13 years ago

Make sure we never send window adjustments (or winadjes) on channels

for which we've already sent CHANNEL_CLOSE. It would be embarrassing
if the remote end had also s...

8e9868bda0b6cb75e681e31a4e42e6279176fc2a authored about 13 years ago

Block SIGPIPE in Unix plink. In a port-forwarding run we may have lots

of local sockets and pipes all open at once, and if one of them is
uncleanly closed from the remo...

66ea8dc1b94401dfa60abdb26918026f3230baaa authored about 13 years ago

Add a missing free_prompts() call in the keyboard-interactive code.

[originally from svn r9357]

bb542eaeff5f7964f74c5893b7d3bec8656f0589 authored about 13 years ago