Ecosyste.ms: OpenCollective

An open API service for software projects hosted on Open Collective.

github.com/maikebing/putty

PuTTY is a free implementation of Telnet and SSH for Windows and Unix platforms, along with an xterm terminal emulator. It is written and maintained primarily by Simon Tatham.
https://github.com/maikebing/putty

Initialise 'psa' to NULL on every code path in the Pageant client

code, fixing a potential segfault when compiling with -DNO_SECURITY.

[originally from svn r9954]

da052d88f8122c7299595ca51ffd03ce42bc9411 authored over 11 years ago
If the SSH server sends us CHANNEL_CLOSE for a channel on which we're

sitting on a pile of buffered data waiting for WINDOW_ADJUSTs, we
should throw away that buffered...

eaea69ef53c73356bf647cf6661ef3647a58c580 authored over 11 years ago
Add '.so' to the list of file extensions cleared up by 'make clean' in

Makefile.cyg, since if you're building against Winelib it will
generate one of those alongside ea...

4f457ff7f217ec3c5f4d2bc249101c43f94a8b4d authored over 11 years ago
Completely remove the 'frozen_readable' mechanism from uxnet.c. It

parallels a similar mechanism in winnet.c and came over by copy and
paste, but is pointless in th...

7426b8f2158f7c2495faa3704a3c34a9be32901c authored over 11 years ago
Fix error checking in uxstore.c: add a missing check, and fix a

mis-cut-and-pasted one.

[originally from svn r9950]

77791de4e179af27adc5557a76605827e8ac19ab authored over 11 years ago
When I turned fcntls into noncloexecs in r9940, I missed one.

[originally from svn r9949]
[r9940 == b4268722196a3d93183252584b86cbb719187a38]

f1d6fa47125cf625bfebdeca2b7d3c0022acd01c authored over 11 years ago
Two more memory leak fixes, on error paths I didn't spot in r9919.

[originally from svn r9948]
[r9919 == ea301bdd9b892a5e70692f82f5c0b98bd585e775]

08d46fca517e292ae1671c4daa994af99d8c0a1d authored over 11 years ago
Fix a null-dereference introduced by another mis-fix in r9919.

[originally from svn r9946]
[r9919 == ea301bdd9b892a5e70692f82f5c0b98bd585e775]

1073d229ae99b8348abe92439084257da5b6fa7e authored over 11 years ago
Fix leak of 'fname' introduced by the rewrite of write_random_seed in

r9933.

[originally from svn r9945]
[r9933 == 2854ae1f33fe16124830b0cc3ac3ca843cd8ce9d]

adf8b3222fc1f54565891d1a9114d393e23a9870 authored over 11 years ago
Another two mis-fixes from r9919: when we sfree(line) on exit from the

ssh.com and OpenSSH key import loops, we should also null it out so
that the cleanup path doesn't...

01ead8590b5459393e6a87b5f591bce6fb8de8d3 authored over 11 years ago
Redo a mis-fix of a memory leak in r9919: I added sfree(data)

immediately after conf_deserialise in the Duplicate Session receiver,
whereas I should have put i...

3af26af19e94264dc575f4e68b6442092a2638bf authored over 11 years ago
Switch to translating keystrokes using ToUnicodeEx rather than

ToAsciiEx, where possible.

This enables support for keys which generate Unicode characters that
...

c46fc37ebc108bae1dbaa68ecb333140d683355e authored over 11 years ago
Been meaning to get round to this for a while: use CryptGenRandom to

gather extra entropy at Windows PuTTY startup time. (It's only used as
one of the inputs to PuTTY...

8902fef44575ffd958abbe4791d3400f782f41c2 authored over 11 years ago
Centralise calls to fcntl into functions that carefully check the

error returns.

[originally from svn r9940]

b4268722196a3d93183252584b86cbb719187a38 authored over 11 years ago
Add an error check to every setsockopt call in uxnet.c.

[originally from svn r9939]

96f3589e16d2aa5a80567fb2e4aba15e8aa37e57 authored over 11 years ago
Add some conditionally-compilable diagnostics to the RNG. I got

briefly worried that it might not be doing what I thought it was
doing, but examining these diagn...

8966f7c1eac34b6d732aa54b32d67819eb6bdce2 authored over 11 years ago
Better error reporting when failing to save a session.

[originally from svn r9937]

407fd7b9ab2cb92d365569f7a62b10311874606b authored over 11 years ago
Add some missing calls to cleanup_exit.

[originally from svn r9936]

13bac5ed69ce4cd603a21c940f82370ef8b0a44d authored over 11 years ago
Run the random pool setup and teardown functions with random_active

nonzero rather than zero.

[originally from svn r9935]

311761e245b9c7fbe0b800eebada1a94fa88b863 authored over 11 years ago
Report errors in store_host_key too.

[originally from svn r9934]

b4adf61bc70edc1f4c1d14bf5981be1246e105c5 authored over 11 years ago
Add proper error reports in write_random_seed, via the new 'nonfatal'

error reporting function.

[originally from svn r9933]

2854ae1f33fe16124830b0cc3ac3ca843cd8ce9d authored over 11 years ago
Add a nonfatal() function everywhere, to be used for reporting things

that the user really ought to know but that are not actually fatal to
continued operation of PuTT...

acf38797ebbcc9c86974f4ada47160ab7d5e5c12 authored over 11 years ago
Add a missing error check in pterm's child-process setup. Shouldn't

really fail, but might as well be careful.

[originally from svn r9931]

1d21346d4c4fe0610c68c2a2424429978798207d authored over 11 years ago
It suddenly strikes me as probably a good idea to enforce that anyone

calling random_byte has previously called random_ref.

(I'm not aware of any current code getting...

33f485c1c3a0942192763f085292aa57d9c3de87 authored over 11 years ago
Fix a build failure: r9924 thoughtlessly put an assert before some

declarations, and gcc didn't complain but VC did.

[originally from svn r9928]
[r9924 == 1dabc578...

e8f661c2e40424c2b92c4157b3971e1c657388e8 authored over 11 years ago
In the various channel request mini-coroutines, replace

crWaitUntilV(pktin) with plain crReturnV, because those coroutines can
be called back either with...

0d7f2fdabc386f8ae2a679f325b1c9f79fb11e69 authored over 11 years ago
Remove a redundant while-loop condition when reading RFC822-style

header text from a PuTTY key file.

(It's silly to have both while (len > 0) at the top of the lo...

16d62f6d94a449d04120ae35eb42796fe5b8bc57 authored over 11 years ago
Remove a pointless assignment in setup_config_box.

[originally from svn r9925]

3692a585f72a2899b979fcd24f4c6d95363df41c authored over 11 years ago
Remove a return path from sshcom_write() which was both unreachable

(it would trigger if !type==RSA and !type==DSA, but one of those must
have been true to get there...

1dabc578a9419783836b4808a9afc265ab2e718c authored over 11 years ago
Use the new ctrl_alloc_with_free to clean up a long-standing FIXME in

the session saving code, in which the contents of the edit box giving
the current saved session n...

7554dd5a9c39f035a0a71a6e2ccb10e64f80d313 authored over 11 years ago
Add an extended version of ctrl_alloc which permits you to provide a

custom free function, in case you need to ctrl_alloc a structure which
then has additional dynami...

ff09d5379bd9f6fdb43c55be1ca5244247691f22 authored over 11 years ago
Move the calculation of the exchange hash to above the various

warnings about insecure crypto components. The latter may crReturn
(though not in any current imp...

2f6d6a839de9b9ac1aaaf9e2c00b9bfd3123f3bf authored over 11 years ago
Add a missing null pointer check in wc_unescape, to bring it in line

with the usage comment saying you're allowed to pass NULL to find out
only the return value. No c...

74cf14e4ebc2c3190e35095ad2d11336c4b4bc2c authored over 11 years ago
Fix another giant batch of resource leaks. (Mostly memory, but there's

one missing fclose too.)

[originally from svn r9919]

ea301bdd9b892a5e70692f82f5c0b98bd585e775 authored over 11 years ago
Tighten up a lot of casts from unsigned to int which are read by one

of the GET_32BIT macros and then used as length fields. Missing bounds
checks against zero have b...

896bb7c74d06200d92f846d666224e3f9c80b634 authored over 11 years ago
Fix an always-false if statement which was causing the window border

not to be redrawn when the user reconfigured the background colour.

[originally from svn r9917]

1662a2f6cf015ff05de76d01e7a80e0e4a5756d0 authored over 11 years ago
Add an assortment of missing frees, and one missing file close. Mostly

on error paths, although the one in PSFTP's wildcard_iterate will come
up in normal usage.

[orig...

cc4f38df148c84183efce644cd48f822233b962a authored over 11 years ago
xfer_{up,down}load_gotpkt free their input sftp_packet as a side

effect of handling it, but they do not free it if it isn't a packet
they recognise as part of the...

c925526e3fbf580a4df3e796fc78e22bbe33651d authored over 11 years ago
Fix a collection of calls to tell_user so that they don't add their

own newline before the one tell_user puts on the end anyway. Also,
while I'm here, make up my min...

d9ccf044be5618fd1ded0c69e86212e2038ec6b9 authored over 11 years ago
Fix a couple of code paths on which, if fxp_readdir returned an error,

we would return without first closing the directory handle we had used
as an argument.

[original...

f78c9165a1e417b6d2304ee36b219ccd09751a1c authored over 11 years ago
It's not actually legal by the C standard to call qsort with a null

array pointer, _even_ if you're asking it to sort zero elements so
that in principle it should ne...

779466f0b0089b7d7b35d7acd39498d57d62a539 authored over 11 years ago
Fixes for the tree234 unit test: break its dependencies on half of the

rest of PuTTY, and fix a couple of format string type mismatches
pointed out by gcc.

[originally...

84fed5c62014bd3825b46ee3acdf4ff559eda1d2 authored over 11 years ago
Add missing checks in update_for_intended_size() in the font selector

code, which would have coped badly if ever asked to select the first
font in the list at a size s...

3d69dd2071839c73d1eb76aead16639b9f5bce1e authored over 11 years ago
Fix a pty-freeing error which caused a segfault if you attempted to

use Restart Session in a post-not-close-on-exit pterm.

[originally from svn r9909]

5a04ae342012c649c4ba6529a0f832aa2534456b authored over 11 years ago
Add some missing null checks for inst->ldisc, which were causing

segfaults if a PuTTY or pterm did not close on exit and then you
either typed something via input...

1f3901a3a263c22197820ac1f1b9558430a602f5 authored over 11 years ago
Remove another pointless null check, this time of inst->back in the

function which has just dereferenced it to get the exit code.

[originally from svn r9907]

916cd3f0cd99d0fafc594fb21dfadc2512aa6700 authored over 11 years ago
Remove redundant null checks for arguments to sftp_{get,put}_file

which are (a) never NULL anyway, and (b) have already been
dereferenced by the time we make those...

8201e7d22dda2ed3985760a1bbef0abdaec36f53 authored over 11 years ago
Fix a mishandling of error returns from makekey() in the SSH-1 private

key loader.

[originally from svn r9905]

85300e0b15d6245f02bfe177289cde1a9babaeb9 authored over 11 years ago
Add another missing bounds check in the SSH-1 private key loader.

[originally from svn r9904]

1dbdd2c43ff7c72f560cac113e7dfe114636767f authored over 11 years ago
Get rid of the fixed-size 'hostname' buffer in every port-forwarded

connection, and replace it with sensible dynamically allocated
storage. While I'm at it, get rid ...

bc2076185e94b4429a3120b4203253e1b492eca7 authored over 11 years ago
Add an assortment of extra safety checks.

[originally from svn r9896]

8b6a8b617f0720d8c17cc2a505ca1371286ada58 authored over 11 years ago
Move the SSH-1 servkey and hostkey variables into the coroutine state,

since there is a theoretical code path (via the crReturn loop after
asking an interactive questio...

ac8baf4cac6b51e5940f1d030277e5e135e465c9 authored over 11 years ago
Clean up handling of the return value from sftp_find_request. In many

places we simply enforce by assertion that it will match the request
we sent out a moment ago: in...

2c586ee2cd6e3ad3c39002e44e6cf73a3b702614 authored over 11 years ago
A collection of small bug fixes from Chris West, apparently spotted by

Coverity: assorted language-use goofs like freeing the wrong thing or
forgetting to initialise a ...

bbc9709b48515954f2f3eb631d1a6bea960bda18 authored over 11 years ago
Fallback for manual setup of GTK 1, if autoconf is run on a system

where the GTK1 detection function AM_PATH_GTK hasn't been provided by
/usr/share/aclocal/gtk.m4 o...

c5876a8ba2655c08125add29b907adb127c44a04 authored over 11 years ago
Update docs for change to UTF-8 by default, and emphasise UTF-8 more generally.

[originally from svn r9846]

a7611316c503e930d4489b79d646fd1bb4232f19 authored over 11 years ago
It's probably well past time for this: change PuTTY's default

character set configuration to UTF-8, on both Windows and Unix, and
reorganise the dropdown lists...

15f1bc7cdb1e7c651a1c729aa9474f5844c8a284 authored over 11 years ago
Fix a bug in which terminal output received from the session could be

buffered in terminal.c indefinitely and only released when further
output turned up.

Arose becau...

4c8c5e26b962255f4fd30d74cde91c63fe62823e authored almost 12 years ago
Remove the half-hearted attempt to make the utmp helper process drop

privileges just before dying of a fatal signal. I'm not sure what I
intended it for in the first ...

a9eb51b7d42c6733b07e4cbaebc0112073e63b4a authored almost 12 years ago
Don't forget to check the return values of setuid and friends.

[originally from svn r9764]

74bc2635ad8bd813fabb08ea9fb6a510a45c3a85 authored almost 12 years ago
Give a better error message if a PuTTY private key file has a version

number we don't understand. It's nicer to report 'format too new' than
'not a PuTTY key file'.

[...

40ce043a97c71374d2118ed636a36b16a148d411 authored almost 12 years ago
Add support for HMAC-SHA-256 as an SSH-2 MAC algorithm ("hmac-sha2-256")

as specified in RFC 6668. This is not so much because I think it's
necessary, but because scryp...

8f3cc4a9bff7a6dbce8c175e0061d2300677b131 authored almost 12 years ago
Take advantage of PUT_32BIT_MSB_FIRST when constructing sequence numbers

to MAC.

[originally from svn r9758]

3045a9ac8c3202b7917cdfebc349cedb5f763e2c authored almost 12 years ago
Patch from Egmont Koblinger to implement two extended variants of

xterm mouse tracking, both supported by the current up-to-date xterm
(288). They take the form of...

329087e2da70e114026371f7d3d831d7722a38cc authored about 12 years ago
Adjust comments around split_into_argv() to clarify that it's not

*Windows's* command-line splitting rules we're mimicking here; it's
VC7's, and they're not the sa...

2ebdd3799d7806d8b569d1591efb2a94b588dec7 authored about 12 years ago
Reorganise setup_fonts_ucs so that in case of error it does nothing

and returns its error message as a string, instead of actually
printing it on standard error and ...

896f9f22562b7f32946c7d3310655ec4d52b0a5e authored about 12 years ago
Move the -I options for all our source subdirectories out of AM_CFLAGS

and into AM_CPPFLAGS. This is more conceptually sensible according to
my reading of the automake ...

ac115f9082d36ede34c18485741932ef8182ecbc authored about 12 years ago
Update the suggested compile command in sshbn.c's test rig.

[originally from svn r9732]

3c443bd2a54bfef8a9333bb093d0302ff9042ee3 authored about 12 years ago
Fix two gcc warnings about confused printf format strings in the

bignum code's test harness. Thanks to Sup Yut Sum for fixing this in
TortoisePlink and Sven Stric...

f2bbeca400edae9429f274cc47ee434816bb7306 authored about 12 years ago
Ronald Landheer-Cieslak points out that the various back ends which

treat all socket closures as clean exits (because the protocol doesn't
provide for transferring a...

38b668648aa0f832600f964d7030879d37d9a302 authored about 12 years ago
Switch round a bogus if statement I've just noticed. Both the write to

pty_utmp_helper_pipe _and_ the close of it if we're not going to write
should be conditionalised ...

9a7dd918da75fc0d80aa17c447b2728ba8d1173f authored about 12 years ago
Use O_NOCTTY (if available) when opening /dev/ptmx, just in case any

OS doesn't automatically assume it.

(It would seem faintly weird to me - surely opening the mast...

25c45bf0438ff596b588ccbd9a508b89f7fb9760 authored about 12 years ago
Patch from Brad Smith to use posix_openpt() instead of

open("/dev/ptmx"), where the former is available. Improves
portability, since at least one OS (Op...

7c22b1d755314257d3bc9d383982c1b35b342973 authored about 12 years ago
Add a bounds check in the word-by-word selection code to prevent

attempting to call lineptr() with a y-coordinate off the bottom of the
screen and triggering the ...

dbcd633985899cac96ecf605716dcacfdfe24237 authored about 12 years ago
Patch from Hideki Eiraku to make PuTTY call GetScrollInfo, so it can

use 32-bit scrollbar position data instead of being limited to the
16-bit version that comes in s...

c3df7b9b1562ab804453bf3f3e3d3db93699c26c authored about 12 years ago
Fix another error-reporting bug, in which sk_newlistener would fail to

capture the error code if listen() returned an error, and instead pass
0 (saved from the previous...

3e22c99c9a3c28e042f2dc3a50fadf95e7c277e7 authored about 12 years ago
When manually initialising a 'struct RSAKey' due to loading an SSH1

public key but not the private half, NULL out all the CRT-optimisation
fields as well as the priv...

06b51312c1ec70e9120c41f7b09f560ebacc6e35 authored about 12 years ago
Add a fallback case to winsock_error_string() which makes it call

FormatMessage to get the OS's text for any error not in our own
translation table. Should elimina...

69113b16b1131928dbe4fdf03eff338c99e54c20 authored about 12 years ago
Windows's sk_address_is_local() was returning the wrong answers for

IPv6 addresses, because I'd mistakenly cast an ai_addr to the low-
level 'struct in6_addr' instea...

251876b5947a5246d76c59f7616e815062f1fea2 authored over 12 years ago
When a proxy negotiation function is called with PROXY_CHANGE_NEW, it

should not call plug functions, because it's being called from within
new_connection(), and the s...

7c8841d881c9b034fa5e8ab97382bfb7da0b7e2a authored over 12 years ago
If you configure Unix PuTTY to use a proxy, tell it to even proxy

localhost connections, and also enable X forwarding in such a way that
it will attempt to connect...

58870f60e473b787feff96c069df344e1745facc authored over 12 years ago
Add timestamps to the 'SSH raw data' logging mode.

[originally from svn r9687]

36b8d450f0fa33b3f4a1d2cda9a4854ca2ab4eb6 authored over 12 years ago
A user points out that we should free the 'hProcess' and 'hThread'

handles returned in the PROCESS_INFORMATION structure after we call
CreateProcess.

[originally f...

8e56c52eaaa78b322eec301ea007c093a75cb7dd authored over 12 years ago
Sumudu Fernando points out that in the big r9214 destabilisation I

mistakenly rearranged the logic in an if statement in window.c, with
the effect that scroll-wheel...

74902c696667bd8a49fb3417d18776de9f0cc1a1 authored over 12 years ago
Clip the 'lines' parameter to scroll() at the size of the scroll

window. scroll() iterates that many times, so this prevents a tedious
wait if you give a very lar...

b2b54bc47004b9473be9b41166cf04cbdbf447b5 authored over 12 years ago
Windows PSFTP has two places that call run_timers and I'd only updated

one of them. Correct that.

[originally from svn r9676]

c048389315170840ce2991f2349d87bab6dbe5f8 authored over 12 years ago
Fix indentation mess in my timing overhaul.

[originally from svn r9675]

897029153f403314325749fa359546cb34912394 authored over 12 years ago
Fix a stupid sign bug in run_timers() that broke Windows Plink (and

should really have broken everything else too).

[originally from svn r9674]

a3aca31b55de6208640bd8e81e1b29d9cbdc0b05 authored over 12 years ago
Make --help and --version work consistently across all tools.

Well, at least across all command-line tools on both Windows and Unix,
and the GTK apps on Unix ...

5db48dcddb0556e2b5930ba8fd4a4247f67b01d4 authored over 12 years ago
Better document the various environments with which Makefile.cyg works.

[originally from svn r9670]

65290ced76509ef8cbc65ea4dbc1525268f5040b authored over 12 years ago
Add a new COMPAT option for environments lacking SecureZeroMemory(),

rather than explicitly checking for Winelib. It seems that w32api is
lacking it as well.

[origi...

580103fca215e76e62de4537f30cb7085660c306 authored over 12 years ago
Allow remote-to-local forwardings to use IPv6.

RFC 4245 section 7.1 specifies the meaning of the "address to bind"
parameter in a "tcpip-forwar...

bc8f2193f69eba9b0cfb597eef9c9362167c6787 authored over 12 years ago
Two related changes to timing code:

First, make absolute times unsigned. This means that it's safe to
depend on their overflow beh...

d5836982e23d8a6176114e1073469950c4eaae37 authored over 12 years ago
Quell a (correct) GCC warning in the NO_HTMLHELP case.

[originally from svn r9666]

41ad182710a8b8bde5bb27114631a25dae37c6cf authored over 12 years ago
Should have been part of r9663: do use the platform-independent version

of smemclr when compiling with Winelib.

[originally from svn r9665]
[r9663 == 3b27c3e32b8fe560c5...

942aca34d1b545904795b29d36cd1b07d81f848f authored over 12 years ago
Tweak comment in Recipe that had become separated from its code.

[originally from svn r9664]

d63ce7d30a54959ec697992ed6653e5390cffbba authored over 12 years ago
Don't try to use SecureZeroMemory under Winelib, since it isn't available

there (yet).

[originally from svn r9663]

3b27c3e32b8fe560c5b2bb35781038715abf29c2 authored over 12 years ago
Define SECURITY_WIN32 for Winelib/Cygwin builds as well as for VC.

This should perhaps go into winmisc.c: it's caused problems for
other people too:

<http://stack...

e7324f7934c8fa87ba6471a0d3b62d8a55f54358 authored over 12 years ago
In the cygwin Makefile, use "-o" on the windres command line to specify

the output file. This appears to be supported by windres, and is
required by wrc (the Winelib re...

5415b8293067e02ea743321dbefdcbed72a114cc authored over 12 years ago
Most of the code for "nc" mode duplicated that for opening a session or

a fowarded port. Arrange that this code is shared instead. The main
visible change is a slight ...

8c1d1be95669a623c4e8f9e3100f80bc299635b5 authored over 12 years ago