github.com/thangchung/clean-code-dotnet issues

Fix typo in ShowDeveloperList in the DRY section

huynhdieutuong opened this pull request 2 months ago

Dictionary<string, string> indexer return type is single string in RE…

IAFahim opened this pull request 9 months ago

Translate this repository into Persian

sara1989mohammadi opened this pull request over 1 year ago

Searchable Names Part1 in Good code section incorrect variable is used

IsaacMorris1980 opened this issue over 1 year ago

Fixed typo in single responsiblity principle.

janzenbupa opened this pull request over 1 year ago

Add FIRST to Testing Section

oliveira-alexdias opened this pull request over 1 year ago

Added link of ASP.NET Core Developer Roadmap

syedmouaazfarrukh opened this pull request almost 2 years ago

Fixed #96: LSP Rectangles must be array

azubrytski-dev opened this pull request about 2 years ago

Simplify Fibonacci example

azubrytski-dev opened this pull request about 2 years ago

Fixed typo: pubic -> public

a-fitzgerald opened this pull request over 2 years ago

README.md

jarede-dev opened this pull request over 2 years ago

Adjustments to the examples "Use getters and setters" ("Objects and Data Structures")

jarosal opened this pull request over 2 years ago

fixed a typo in getters and setters segment

jarosal opened this pull request over 2 years ago

Typo in section "Functions" paragraph "Functions should only be one level of abstraction"

AdmiralReality opened this issue over 2 years ago

What is the meaning of 'using domain name'?

eliumoraes opened this issue over 2 years ago

ShowList funtion in DRY section does not return a list

mdgr3301 opened this issue over 2 years ago

fix typo "is an worker"

mdgr3301 opened this pull request over 2 years ago

Add ids to <details> elements, in order to share URLs to specific rules

yor-so opened this issue almost 3 years ago

Update README.md

BL1NDX3N0N opened this pull request almost 3 years ago

Update README.MD

BL1NDX3N0N opened this pull request almost 3 years ago

Fix example of DRY

SirFX opened this pull request almost 3 years ago

Fix example LSP

SirFX opened this pull request almost 3 years ago

fix：update README.md

MickeyShiue opened this pull request almost 3 years ago

Update README.md

Kamaew opened this pull request about 3 years ago

reduce if statement

mtss92 opened this pull request over 3 years ago

fix a misspelling.

omid-ahmadpour opened this pull request over 3 years ago

Fixed typo in DRY source example

kellerfabian opened this pull request over 3 years ago

Changing parameter for RenderLargeRectangles

theilgaz opened this pull request over 3 years ago

Changing parameter for RenderLargeRectangles

theilgaz opened this pull request over 3 years ago

Update README.md

acsteitz opened this pull request over 3 years ago

Add some of the sections from https://csharpcodingguidelines.com/

studentutu opened this issue almost 4 years ago

Please, add vs project with cs examples in this repo

VitaliyPavlyukov opened this issue about 4 years ago

SOLID. Liskov Substitution Principle (LSP). Example incorrect.

VitaliyPavlyukov opened this issue about 4 years ago

Update README.md

svsubith opened this pull request about 4 years ago

Objects and Data Structures. Make objects have private/protected members

VitaliyPavlyukov opened this issue about 4 years ago

Avoid conditionals

VitaliyPavlyukov opened this issue about 4 years ago

Add new type definition suggestion

mehmetcantas opened this pull request about 4 years ago

CleanCodeDotnet

TIcha-Toey opened this issue about 4 years ago

Update README.md - Fix type in searchable names (part 1)

lacc opened this pull request about 4 years ago

OCP: HttpRequester Inheritance from AdapterBase does not make sense

Mostafa-Armandi opened this issue about 4 years ago

Update README.md

mohammed-ezzedine opened this pull request about 4 years ago

Typo: publc to public

tobiola opened this pull request over 4 years ago

Fix variable name in an example

marcinjahn opened this pull request over 4 years ago

Change "Not Good" Text To "Bad"

sagarkumarofficial1 opened this pull request over 4 years ago

adjust README, add IAsyncEnumerable and C# version mention for a problem

EvgeniyZ opened this pull request over 4 years ago

Missing IAsyncEnumerable mention in Common Async Problems

EvgeniyZ opened this issue over 4 years ago

Typo in getter/setter section

latobibor opened this issue almost 5 years ago

telegram bot

emremp opened this issue almost 5 years ago

Add New Section To Functions - Prefer Exceptions to Returning Error Codes

ofirbarak opened this issue almost 5 years ago

fix compiler errors in the "Use getters and setters" example

JimmyCushnie opened this pull request almost 5 years ago

Corrected missuse of a variable in the DRY exemple part of SOLID

XalbatEcheverria opened this pull request almost 5 years ago

Fix Liskov Subsutution bad example

filipbekic01 opened this pull request almost 5 years ago

Fix Liskov Substitution example

filipbekic01 opened this pull request about 5 years ago

Fixed typo

boop5 opened this pull request about 5 years ago

Use searchable names (part 2)

boop5 opened this issue about 5 years ago

Added a link to another clean code resource

jwigert opened this pull request about 5 years ago

Update Function Naming

ducqhl opened this pull request about 5 years ago

add chinese simplified version

hippieZhou opened this pull request about 5 years ago

correct syntax errors in LSP section

liushuping opened this pull request about 5 years ago

Correct syntax error in section Make objects have private/protected m…

liushuping opened this pull request about 5 years ago

corrected line 109 typo "parameters"

Chitova263 opened this pull request over 5 years ago

Merge pull request #66 from cezarypiatek/patch-1

cezarypiatek opened this pull request over 5 years ago

"Avoid side effects" Example is not right

raulmarindev opened this issue over 5 years ago

fix typo in "Function arguments 2 or fewer ideally"

BlowaXD opened this pull request over 5 years ago

Newfeature2

quynguyenhcm opened this pull request over 5 years ago

Thuy changed

chauthuy89 opened this pull request over 5 years ago

included Primitive Obssession pattern example

phduarte opened this pull request over 5 years ago

There is a syntax error in the "Avoid conditionals" Section

esofar opened this issue over 5 years ago

Code sample return type correction, and apply readonly property.

citizenR opened this pull request over 5 years ago

Primitive Obsession

phduarte opened this issue over 5 years ago

Some confusion regarding the code example in "Don't write to global functions"

user3301 opened this issue over 5 years ago

Update README.md

marcustung opened this pull request over 5 years ago

Remove Java and C++ code. Adding the best practice section for Async/Await.

toanvo288 opened this pull request almost 6 years ago

Add Famous Laws Of Software Development

thangchung opened this issue almost 6 years ago

Fix DIP code example

filipbekic01 opened this pull request almost 6 years ago

Fix function type

filipbekic01 opened this pull request almost 6 years ago

Fix test coverage link in README.md

ryanstreur opened this pull request almost 6 years ago

Fix Grammar in "Don't use flags as function parameters" Section

Justbeingjustin opened this pull request almost 6 years ago

Fix Grammar in "Don't use flags as function parameters" Section

Justbeingjustin opened this issue almost 6 years ago

Fix UserAuth constructor

filipbekic01 opened this pull request almost 6 years ago

Fix grammar use camelcase notation

Justbeingjustin opened this pull request almost 6 years ago

Fix Grammar in "Use Camelcase Notation" Section

Justbeingjustin opened this issue almost 6 years ago

Fix Grammar In "Avoid Disinformation name" Section

Justbeingjustin opened this pull request almost 6 years ago

Fix Grammar in "Avoid Disinformation name" Section

Justbeingjustin opened this issue almost 6 years ago

Fix Grammar In "Avoid using a bad name" Section

Justbeingjustin opened this pull request almost 6 years ago

Fix Grammar In "Avoid using a bad name" Section

Justbeingjustin opened this issue almost 6 years ago

Features/32 comment

avitsidis opened this pull request almost 6 years ago

implement #35

avitsidis opened this pull request almost 6 years ago

Added Forgotten GetName method to "Make objects have private/protected members"

MoienTajik opened this pull request almost 6 years ago

Example error in [Dependency Inversion Principle (DIP)]/[Good] section

dust63 opened this issue almost 6 years ago

Added 2 new error handling item

suadev opened this pull request almost 6 years ago

Sort error handling

Justbeingjustin opened this pull request almost 6 years ago

Add New Throw Entry to Error Handling Section

Justbeingjustin opened this issue almost 6 years ago

fix typos in code samples

avitsidis opened this pull request almost 6 years ago

The _tokenizer and _lexer properties in BetterJSAlternative class must change with own class types.

hasanaliagar opened this issue almost 6 years ago

Only comment things that have business logic complexity section sample is not correct

avitsidis opened this issue almost 6 years ago

Use consistent capitalization should reference Microsoft conventions

avitsidis opened this issue almost 6 years ago

Error handling section content is not related to error/exception

avitsidis opened this issue almost 6 years ago

Add a Testing structure proposal in testing section

avitsidis opened this issue almost 6 years ago

The under code in 'Avoid magic string' title must change to const

hasanaliagar opened this issue almost 6 years ago

Ecosyste.ms: OpenCollective

github.com/thangchung/clean-code-dotnet