github.com/joomla/coding-standards commits | Ecosyste.ms: OpenCollective

Overwrite custom ControlStructures sniffs and add tests; fix ruleset

823aaea850ddbb57e99b81812df401bd642c9722 authored over 9 years ago

custom sniff for MemberVarSpacingSniff

6efa9f72ebf75b17320cf076f4ab455047a36087 authored over 9 years ago

first round of changes - InstantiateNewClasses

7fd0c9a37b8187ad5c647cc34829a40e00cbefe0 authored over 9 years ago

structure change

721b4fefa429597db87986ef91070d2e7d39a6e6 authored over 9 years ago

Merge pull request #1 from photodude/phpcs-2

Phpcs 2

8a6d52d6ba8ff9889f11fd03af4e70ab7cae1c30 authored over 9 years ago

Add Squiz.Commenting.VariableComment

5bf196569226ec6affc9029ad5ab8e25dc33b5d8 authored over 9 years ago

Add error exclusion for Squiz.WhiteSpace.MemberVarSpacing

0cfe24b749d3f9f49a1adf8beb6a66a95611d36e authored over 9 years ago

Exclude some errors from block comments

Block comments (aka multi-line comments) require an "EmptyLineBefore" and no EmptyLineAfter. The...

a3022d055c2b4bfbdc73384acc4e937046ed4591 authored over 9 years ago

Allow newlines instead of spaces for operators

7eba23c329538dd0399cd3a977bbf8c1a9e6b199 authored over 9 years ago

Allow newlines instead of spaces for concat

Allow newlines instead of spaces for multi-line Concatenation

a9494832082d9f3e1e0adc1ce38b354474fd6f52 authored over 9 years ago

Add Squiz.PHP.CommentedOutCode

b88a5d743d648365b5bc7de43cdab655153df9ea authored over 9 years ago

Merge pull request #116 from brianteeman/patch-1

Corrected comment

5e1c67ffe32f580d34d0f62181e35d4000ecb0d8 authored over 9 years ago

Corrected comment

Small correction to the comment so that it actually matches the rule it is describing and is rea...

c0f34875c9bfd7888b88fa4802546ea219722145 authored over 9 years ago

Merge pull request #110 from photodude/patch-3

Correct File DocBlock Headers list

448b8a1033e8e4727488b81740df4536f297437d authored over 9 years ago

Add Squiz.PHP.GlobalKeyword, Generic.Strings.UnnecessaryStringConcat

- "Do not use global variables. Use static class properties or constants instead of globals."
-...

d3351afa153412c9d4145733043391eb149bd9d8 authored over 9 years ago

B/C fix for php 5.3 arrays

PHP 5.3 doesn't allow the short array syntax `[]`, only in php 5.4+ can we replace `array()` wit...

0f9e1ca5ce7e0131ef46ab5a98c6f42d9650ea09 authored over 9 years ago

Add Squiz.Commenting.BlockComment

This sniff should handle and enforce the multi-line comments
```
/*
* A multiline comment
...

5631261a14bd7d11e547a6554049d598be4c4dcc authored over 9 years ago

Add TODO notice for adding fixer

TODO - Add a fixer method for removing `()` from new class instantiations that lack parameters
...

b35627055ae7246819b182c1b507eba1c2c0ad65 authored over 9 years ago

Merge pull request #4 from mbabker/fixes

fcdbcfa9388918b32162222f7c9b45d257ca3f08 authored over 9 years ago

Get the sniffs up to standard

87a9c5ccaa15eabb718e110dcd3e228c141dfc6f authored over 9 years ago

Have our ClassCommentSniff extend PEAR's, only override register and array

a89dbeca42b0377d89d308d6c677852a6cb28126 authored over 9 years ago

Apply our code standard

53eb7e60ea7b925a94e4e513b2115e55196c9ad7 authored over 9 years ago

Adjust ValidFunctionNameSniff to remove leading underscore requirement.

4497dbb3ab14e3bc0ca10ea5c5353cfb210b97cf authored over 9 years ago

Extend Squiz.NamingConventions.ValidVariableName to remove underscore private var check

dec81a1d78aad5a35a861cc547eb3f1683b13b1d authored over 9 years ago

Go back to having FunctionCommentSniff extend PEAR, comment overrides, class tags need @ symbol

a1af467be71b06e38632c3203b8c1e8a85720b96 authored over 9 years ago

Add Squiz.NamingConventions.ValidVariableName

175ba3b7ce540797ff24dca450a03def1c5c5217 authored over 9 years ago

Replace with Squiz.NamingConventions.ValidVariableName in ruleset

62e139e90db41268a2de6777e1f3a64d817638bf authored over 9 years ago

Rebuild from PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php

Differs in the protected $magicMethods = array() where we use camelCase
Should be reviewed to ...

5d1672799da0813774e4d5a25f6fb71ae33e0bc3 authored over 9 years ago

Add Squiz.WhiteSpace.ControlStructureSpacing

18fec75bfb3e76713cc4b068676e9276c10f4a9b authored over 9 years ago

Replace with Squiz.WhiteSpace.ControlStructureSpacing in ruleset

c0cba3270487bed1bcd6f5060710a8bc280a7cbd authored over 9 years ago

Add Squiz.Scope.StaticThisUsage

7625ffb9afb35ab32af7e74bfddc8670f2788a6c authored over 9 years ago

Replaced by Squiz.Scope.StaticThisUsage in ruleset

63544dd671d47bac0cdfd5f34823bc4f09ea9c90 authored over 9 years ago

Replaced by Generic.PHP.LowerCaseConstant in ruleset

41617f398c982877e9dea05b8dd55ad564fd3f5f authored over 9 years ago

Replaced by PSR2.ControlStructures.ElseIfDeclaration

- Adjusted in the ruleset
```
<rule ref="PSR2.ControlStructures.ElseIfDeclaration.NotAllowed">...

79096dc4ad51acc41a2aba2b29575180f4a463c1 authored over 9 years ago

Rebuild from source PEAR/Sniffs/Commenting/FunctionCommentSniff

4ec176c6dd3682cd37adc14e0826ea0a81bdf496 authored over 9 years ago

Rebuild from source PEAR/Sniffs/Commenting/ClassCommentSniff

b50595de81c0b9f164452aec0337a2ddc6e1bff4 authored over 9 years ago

Replaced by PEAR.Functions.FunctionDeclaration in the ruleset

6c231eaf9746b22d13a9506a7d2f6f75968878cc authored over 9 years ago

Adjust some ordering and add rule

- Use alphabetical ordering for easier reviewing of which standards are being used
- Add rule P...

47ebc580ecf1bfb87a3fe9873628959e365d05cf authored over 9 years ago

Merge pull request #3 from mbabker/ClassTagFix

Class tags read incorrectly

8cea122ced334d4a893583e0400c98122f54479f authored over 9 years ago

Class tags read incorrectly

0bcce0a80d143c78bf4772bb3146fe4a9c071b60 authored over 9 years ago

Merge pull request #2 from mbabker/methodParamAlignment

Method param alignment & indent errors

3f3551c55b17f29c670cd9875658b61d5f066d27 authored over 9 years ago

Whoops, wrong file

5c4281a557c29a4520ce21048695c6e3f1a2dd2d authored over 9 years ago

I just realized you can override these with the properties tags...

b14028ebd263399f9e4601d4fcf722e6c89cf234 authored over 9 years ago

Merge remote-tracking branch 'photodude/phpcs-2' into methodParamAlignment

1d0300d4225aaf389283983282b2324420adaf30 authored over 9 years ago

Extend PEAR sniffs to adjust spacing requirements

a80975b026bbacedb7425962f781a8caa335d07e authored over 9 years ago

Get method parameter alignment checks back up to speed

cdf57812b2698dc5b3520aa901a84357ff4bf017 authored over 9 years ago

Merge pull request #1 from mbabker/phpcs2-fixes

Misc. fixes

6dc15e5709fd51e131f76234b35f5b3172669ac8 authored over 9 years ago

Merge remote-tracking branch 'photodude/phpcs-2' into phpcs2-fixes

e620d0d29db643e814bd41423a16658111156941 authored over 9 years ago

Fixes after running on Issue Tracker

ddd6bf1f613652ec1abecb727b78f1604bd4c2a6 authored over 9 years ago

`sniff` is not part of the rule name

21068086260fe28d57d6553d6e45a1573bea493d authored over 9 years ago

The file tag isn't required anymore

5fa312bc30d6efaa991985ca437a4883d2f9948c authored over 9 years ago

Correct rule name

85edfb0597f550014f72082d816d375bc56c7abd authored over 9 years ago

Merge pull request #112 from zero-24/layout_files

Layout files section

a0cd52fd1b16f7ce231664cd447c8fc4f7fa86c9 authored over 9 years ago

Update php.md

a28bcc56646a7d6a9eb63112dc703232b7fe7eeb authored over 9 years ago

Update php.md

b26f6dd36ed3f30b8fb7b16a8ce2ce1d09500f6b authored over 9 years ago

Update php.md

c1f40f5de0d03aa7225abcc630c2b1379dfc0c31 authored over 9 years ago

Fix english thanks @brianteeman

6128d89cc9d9452d211da814501dcbf5aef7820f authored over 9 years ago

Improved with suggestions by @bakual

c65cd238e67c1f17d54e0ae81e960fc1b3549b55 authored over 9 years ago

Merge pull request #111 from zero-24/mirror_fixes

2 very mirror fixes

f06a129855e8a09c7a3edf16d1645bc5710f9098 authored over 9 years ago

layout files section

be483603316e82beee0b9e5d965ee0172792b829 authored over 9 years ago

some mirror fixes

6942983223dc2ab9799de806640952fbc4734eec authored over 9 years ago

Remove in favor of using PEAR.Functions.FunctionCallSignature in the ruleset

c2c65bbf720b4a118229bb9a3aaf761fe384a802 authored over 9 years ago

Use PEAR.Functions.FunctionCallSignature in ruleset rather than custom sniff

14737364ccbf435bd9f4acb6982068e8b56886cc authored over 9 years ago

Exclude message MultiLineCondition.NewlineBeforeOpenBrace

07ed3041551190491919a4bd3f749387f70d9494 authored over 9 years ago

Use PEAR.ControlStructures.MultiLineCondition in ruleset rather than custom sniff

ba6441b8a8389fece3743b06c95660a9ab6b2e80 authored over 9 years ago

Remove in favor of using PEAR.ControlStructures.MultiLineCondition in the ruleset

19ddbfb0b942662b329e3e2476dfd304d54a1760 authored over 9 years ago

Use Generic.ControlStructures.InlineControlStructure rather than custom sniff

ec794b2b505f46a2d0b1c81a1354f43d88fdb868 authored over 9 years ago

Remove in favor of using Generic.ControlStructures.InlineControlStructure in Ruleset

4575ec8224bc98645cb60f58e164b314e154211c authored over 9 years ago

Update from source with modifications

Source PEAR/Sniffs/ControlStructures/ControlSignatureSniff

365335a77dc54cde72c0ec39d7b2d5414c0f5d97 authored over 9 years ago

Use Squiz.Scope.MethodScopeSniff rather than custom sniff

- Change Error message in rule set to `No scope modifier specified for function "%s`

76872c1cf31a64f8751ed825493e7fc0a8f76a15 authored over 9 years ago

Remove in favor of using Squiz.Scope.MethodScopeSniff in the ruleset

- Change Error message in rule set to `No scope modifier specified for function "%s`

2c3e3d39936d69cd7aca849b7669f88d1804b963 authored over 9 years ago

Remove in favor of using Squiz.Scope.MemberVarScope in the ruleset

e7fb506653ae6f9b900f081676a5dbb012eee624 authored over 9 years ago

Use Squiz.Scope.MemberVarScope rather than custom sniff

ac56eb5bde667b5cdc8c8df8257e86de62ce4451 authored over 9 years ago

Remove in favor of using Generic.Formatting.SpaceAfterCast in the ruleset

ea9276629bd749f1b4b5d951f3a995891dc681fa authored over 9 years ago

Use Generic.Formatting.SpaceAfterCast rather than custom sniff

8604b84e89bea8b87ce5cd7a82dcc1c58caaf146 authored over 9 years ago

Use Squiz.Strings.ConcatenationSpacing rather than custom sniff

- Set Squiz.Strings.ConcatenationSpacing spacing value to 1
- Replaces Joomla.Whitespace.Concat...

40988d484f11ed1d0ef94f43afb57fb4192c4388 authored over 9 years ago

Remove in favor of using Squiz.Strings.ConcatenationSpacing in the ruleset

43c820e9621c9f2f8a613cbb320865e4baadb3de authored over 9 years ago

Update to use standards rather than custom sniffs

There are existing standards that achieve the same results as the customs sniffs, there is no po...

4a00a4966977096205e32af406b18a32f56610b8 authored over 9 years ago

Remove in favor of using Squiz.WhiteSpace.OperatorSpacing in the ruleset

de071e1b4f884cf2cd63743e1b534a4edec7b62c authored over 9 years ago

Remove in favor of using PEAR.WhiteSpace.ObjectOperatorIndent in the ruleset

37615572522643aaa71d69789352de1f8eeb5c65 authored over 9 years ago

Remove in favor of using Squiz.WhiteSpace.CastSpacing in the ruleset

85240315eb5d691b19ea3ec778e1a949f1f6b476 authored over 9 years ago

Remove in favor of using Generic.WhiteSpace.DisallowSpaceIndent in the ruleset

95ceab8ad6e24788b31472b3276ef0d05bfe6aee authored over 9 years ago

Remove in favor of using Squiz.WhiteSpace.MemberVarSpacing in the ruleset

2347cc4b38f61d20afa21a2b477834a2c03bc542 authored over 9 years ago

Remove in favor of using Squiz.WhiteSpace.SemicolonSpacing in the ruleset

0cbf8df9bb8584f00a0f77c63043a29e690b2e03 authored over 9 years ago

Remove in favor of using Squiz.WhiteSpace.SuperfluousWhitespace in ruleset.xml

90699e344ab85f2ed03e4d8cad1e8b37d3f4705f authored over 9 years ago

Rebuild from source with modifications

- Based on PEAR/Sniffs/Commenting/InlineCommentSniff

37c572c11af7aff6a29ca30a20e1322784842a63 authored over 9 years ago

Rebuild from source PEAR/Sniffs/Commenting/FileCommentSniff with modifications

6cb1120b2dbd9aa66cb81362f9b2ad90a1be7c9e authored over 9 years ago

Add missing elseif sniffs to ruleset

471f9f2c02a265a1002675d07bfe9854018ed9ab authored over 9 years ago

Correct File DocBlock Headers list

- follow the definitions structure listed in https://github.com/joomla/coding-standards/blob/mas...

de7bd56fdc5a0640e568c3600a32230a0594d0ba authored over 9 years ago

Merge pull request #108 from photodude/patch-3

typo correction

6ec0be2e6cd396daa906fe513e6813fbddfeb875 authored almost 10 years ago

typo correction

if not is...

85ea3fe4cf71fe437e453b186b83fc71b16190ea authored almost 10 years ago

Merge pull request #106 from photodude/patch-3

Better documentation of differences from core standards

521dbb2268aa2fbb42e1d900fb397cd3dbfea551 authored almost 10 years ago

Merge pull request #107 from zero-24/patch-1

fix wrong syntax for JRoute::_();

a3af281fa38950e094e64e39f4ebd4f9d75f316e authored almost 10 years ago

fix wrong syntax for JRoute::_();

2e989522b8bfb1a1038adda1013f149f2089710b authored almost 10 years ago

Various updates

- Try to include some better documentation of differences from core standards to help with curre...

5aa57824567a6cf6300df0602893d14cc8fbfff3 authored almost 10 years ago

Missing space at item 1 add headers

971e93cb0d737bcd5b7fe7dd2069c48501696d5a authored almost 10 years ago

Typo fix and Scheme reference

8f7a0137b06756f77fd32bea15e0338b84e0684a authored almost 10 years ago

Expanded IDE instructions for PHPStorm

10be72033e3bdafad199ef8fd9be3e7725dc62ca authored almost 10 years ago

Merge pull request #100 from photodude/patch-2

PHPCS 2.x is stable but Joomla Sniffers is not yet compatible

d78aa2fb39a454fd6a80e021b87b573768f7bac9 authored almost 10 years ago

Merge pull request #99 from photodude/patch-1

Reorder to better match the Squiz/ruleset.xml order

0cf117a6357c80165dff52e5cb50858224480f63 authored almost 10 years ago