github.com/joomla/coding-standards commits | Ecosyste.ms: OpenCollective

[CS] Expected 1 space before/after "/"

172392aa1e02ad0c664ca3868c3e1f666f563e51 authored about 8 years ago

The adjustment in on "spaces" not expected

48422aa2dd1020e28acf078885a5738c7ad9bbb1 authored about 8 years ago

try fixing the space check

c03939795377f4ae1d02c8f37f99a219e1f2ade0 authored about 8 years ago

error is now on line 6

f8b0f2f97dfc132f32743ffde40ea12e95af3535 authored about 8 years ago

add back expected error

026b424497e9752be5d7de03f511c090d1a33a5b authored about 8 years ago

fix tags

The tag in position 1 should be the @package tag (Joomla.Commenting.FileComment.PackageTagOrder)...

b7e190170097e9770bd1ded59f75cccb4b72d116 authored about 8 years ago

Update FileCommentUnitTest.inc

5c37f197cb9de5ed2416e19b9f561bd20dcd52a2 authored about 8 years ago

Try reverting changes to fix sniff

d741d62cd5b559ed1702839a890a1dd9fab9b55c authored about 8 years ago

Merge pull request #144 from photodude/patch-2

[PHPCS2] Fix some spelling and grammar in the readme

2dd462662509732638178c4a4ef7ee42f8d18311 authored about 8 years ago

Capitalize PHP

fa3c223a13ff3f5d2cd03c5ca633d81f3ea52671 authored about 8 years ago

Update README.md

7271ac6c9459df801bf1c79da1fae2c716d3f2a7 authored about 8 years ago

Fix some spelling and grammar

8e7f29ae45b1898c767f981d764f5b069d5af662 authored about 8 years ago

Merge branch 'master' of github.com:joomla/coding-standards

475337cefb4940db76602525716ab758c2c08e2c authored about 8 years ago

Expanded CSS selector info (Fix #91)

6b224404fa6cc6d058e78267b3b813019a1f44b6 authored about 8 years ago

Merge pull request #105 from photodude/patch-2

Expanded IDE instructions for PHPStorm

e372ab50ed488f825d8a3b8611d14e1c88a883a8 authored about 8 years ago

Merge branch 'master' into patch-2

b2b95a44ced5e399e5b47ad4f28c168b0e30e9dd authored about 8 years ago

Merge pull request #142 from photodude/patch-4

Apply fixes to PHPCS 1.5.x InstantiateNewClasses Sniff

d4ca8c3efb36e1712ffc5a6be07472d2d08863ae authored about 8 years ago

Merge pull request #109 from photodude/phpcs-2

Update for PHPCS 2.x series

5e5d8e6c0d3a6f740a24ed03360ea203d8f320eb authored about 8 years ago

Apply fixes to InstantiateNewClasses Sniff

73fd2a6f4e4bbca6bdf05b64942906aed20e2d87 authored about 8 years ago

Merge pull request #140 from brianteeman/master

Stage 1 - copying markdown docs from gh-pages branch

abb398c4dab39e34fee316e2e169bb49bbb31585 authored about 8 years ago

remove index.html

38c04ae5161d78de17d56343f8d4152a671aa21f authored about 8 years ago

remove css and js assets

53daec4b057e0dbf9c8b36d95ef59696b4dccd59 authored about 8 years ago

Move documents from gh-pages branch

25b79cd0e3769775aa5a824e8f05f89b41684fa9 authored about 8 years ago

Merge remote-tracking branch 'origin/gh-pages'

4db9e06f02dcdcc9b6584b9465de93b70df57837 authored about 8 years ago

allowing shortArraySyntax in method parameters

87079ea108a13832dc86492d5c47b20e156d7637 authored about 8 years ago

Fix nameSpaced search

$namespaced is the token ID (an INT), so we need to check the type using $tokens[$namespaced]['c...

b5059f405de39db0890be12c85c9cfa946c32cb6 authored over 8 years ago

Improve namespaced search

Improved Check for a namespace token, notes if certain other tokens are found so we can move on....

16827b092325162e9416d691355190f0fdfc5f50 authored over 8 years ago

We don't use package tags in namespaced code

Ignore the @package tag requirement for namespaced code, require it otherwise.

d3e2f8dfbafb8fd17400beaa332f74b4c37c6416 authored over 8 years ago

Merge pull request #139 from zero-24/patch-1

Fix the path for phpstrorm thanks @yvesh

acb96f777e5e4bb5b14e7aa2b406b99524522268 authored over 8 years ago

Thanks @yves

e1930781ee84582c45f5add94db856ee03dda49d authored over 8 years ago

MultiLineCondition.CloseBracketNewLine is not correct

PEAR.ControlStructures.MultiLineCondition.CloseBracketNewLine should not be enforced

remove
...

3483533cfd4850970cc38c7472375183cd17f200 authored over 8 years ago

Apply Code Style to changes

eb379b011d13869ea2371f8be9525d2f0af67467 authored over 8 years ago

Move NewlineAfterOpenBrace into ControlStructuresBrackets

Try to keep brace specific checks in the ControlStructuresBrackets sniff

bb00b22e563c093a9958024e4c2d6281247306d9 authored over 8 years ago

Try a different aproach to fix control structure unit tests

4469ae710b6b16f823bc27a883cd3586c0a28788 authored over 8 years ago

Recheck unit tests for fix to ControlStructuresBrackets

21e81407f74bb833d035fd3b69fcb8df78e7b906 authored over 8 years ago

Bump minimum phpCS to 2.7.x

Add PHP 7.1 to tests as allowed failure
seperate PHPCS and PHPUnit tests
continue work fixing co...

c9298efafd974f12da8f1b5712db85552f9d46b1 authored over 8 years ago

Fix control structure unit test

fixed file wasn't fixed

3dd8efef05323122daf928b261b0d675e3384352 authored over 8 years ago

Fix Indenting of multiline if brackets

5cdd6a5a9daef9d89f29945b76ee02a48eb3a151 authored over 8 years ago

Merge pull request #138 from photodude/patch-4

Add note about type casting Integer field values

117f18e88005e828a3904c3f75a4797745584c07 authored over 8 years ago

Apply CodeStyle fixes to sniffs

b954687d7c14e0009de67f4f301fce29979eab64 authored over 8 years ago

Fix new instantiation instances of classes encapsulated in a variable

Add unit tests for new instantiation instances of classes encapsulated
in a variable
The followi...

16d3ab4700021eed78e41bf3ddb5fdeb44f40b95 authored over 8 years ago

Add note about type casting Integer field values

Integer field values should also be type cast to `(int)`.

af49359b8d967690c49ec982e423dea0984188ad authored over 8 years ago

Fix Typo causing parse error

Missing `$` in front of variable name.

9fa39ece65054dc0322bac1c4f9474e1d2a2827c authored over 8 years ago

MultiLineCondition.CloseBracketNewLine is correct

Closing parenthesis of a multi-line function call must be on a line by itself
so remove `<exclu...

235b582ab2ea8ea8a07db5757b8624c60caf944f authored over 8 years ago

add conditionally controlled support for Short Array Syntax

Provides a method to allow Short Array Syntax for select projects that don't support php 5.3
Th...

8b4fc88b697502f7697abbea7f5dcceed3cd5b78 authored over 8 years ago

add exclusion ScopeNotCamelCaps

1ef15923bec6f85924cd4080cdbdf1e6168ab46f authored over 8 years ago

add two more comon exclusions

```xml
<exclude name="Joomla.NamingConventions.ValidFunctionName.FunctionNoCapital"/>
<exclude...

60e3d7bb22ca46893e994619faf028a502cd227e authored over 8 years ago

only use -s for diagnostics

27ac38e3ea706f0832984cd3622bee90545d6b55 authored over 8 years ago

add some additional hard-code command line values

0af3426d32392f3222893c2400aded883e2e8945 authored over 8 years ago

try tabs again

0ca6147e9ac045d0c3d8c340a9aea25a2a369344 authored over 8 years ago

Update ControlStructuresBracketsUnitTest.inc.fixed

try spaces again

4f7d0f86d92a25bd535e3e29a6736700ab5160d4 authored over 8 years ago

Update ControlStructuresBracketsUnitTest.inc.fixed

try with spaces rather than tabs, the spaces to tabs are mostly corrected via other sniffs

32cdf25c6d3c657ac0d567b4559c6c5a1ada2ada authored over 8 years ago

code style fix: Line indented incorrectly

6bf1520d1a40bc853277688e83e4c414b84e88ad authored over 8 years ago

code style fixes

14b8b1d346eb563eea23bab3fc3d6ee9d4a6d113 authored over 8 years ago

We have to convert the space value to a tab value here

This should fix the sniff processing to give the correct space counts for the tabs.

5ee709e3dc6d49752d2718edfb5ee5e6c6789e13 authored over 8 years ago

add back --extensions=php

4aef8e402a81ff6ccdf196b31e21bc23e2c240ac authored over 8 years ago

revert to previous indenting

attempt fixing the unit test issue

ce830beea806644591c93a84bbd9a2c3ef038b2c authored over 8 years ago

used Generic.WhiteSpace.ScopeIndent

Generic.WhiteSpace.ScopeIndent is the correct sniff as in the PEAR standard, you don't indent CA...

5c8751b4fd902ec02a6620260d5c31df50785d94 authored over 8 years ago

add PEAR.WhiteSpace.ScopeIndent

correct the file indentings

911e4ae41f2597423fbde5c774410480a7a29b00 authored over 8 years ago

code sniffer 2.6.0+ is required

356677e09ea7932282b2c7369a05a15cd7df2aa5 authored over 8 years ago

remove unnecessary conditional

e0bec1c37b352936f9fb6be02aec29bbba397633 authored over 8 years ago

code style fix

Comment must start with a capital letter; found "c"
Please consider an empty line before the if...

55ace766bfa345a4759f210987d3ec3a49f7bfab authored over 8 years ago

correct spaces for tab fix

0f80f886e5fed4c1fce693b949d5efbb1ea5d04c authored over 8 years ago

try correcting the tab vs space value again

41af70a21a8ff0ce714a5ca84008bac5566ec605 authored over 8 years ago

temp test without --extensions=php

a064abdb9808e6d6458a3df0849c1c0b8f588dd2 authored over 8 years ago

code style fix

8530445b785542484aadd66d94fd43c4c642b01e authored over 8 years ago

code style fix

66d710aa57a00d9ac169e3162625bea85d4517f4 authored over 8 years ago

only fixer is tab based

b6f6da48a2e2c63c57e88203dd1b4c369c7cda51 authored over 8 years ago

need to check if there is no whitespace be

f93f0250809c60c529327d09ec34d00059fbf3e8 authored over 8 years ago

missed a needed control structure

7e5d38bbaf38a9ac1c68e840103e8b45c616897e authored over 8 years ago

test a different version of the fixer

fd323bcbcb5d7e74fddff886a8a9a9fe58f275a7 authored over 8 years ago

adjust fixer for T_ECHO

25dec17d25a47227decf071be13cab0ca7ddb07c authored over 8 years ago

Attempt to report/fix echo($a); error

1308589e03bcaf55164eccf06b2264b2b7ffb6c2 authored over 8 years ago

correct error lines

fb5e6efa90bd28d3ee2af9e6fd7dc2aa43ce6b82 authored over 8 years ago

echo $a; or echo ($a); is allowed

f08a386083cc75187aeda8186e5ec4d1b8bb6891 authored over 8 years ago

add echo $a;

echo $a; or echo ($a); is allowed

558bce5bb4c01b986e0ec517fea9488b86400b68 authored over 8 years ago

Fixer is tab based but the sniff was space based

correct the expected to be indent of tab=1

bca40e7a53ea28c2dbca76ad6b1154f9be9353d4 authored over 8 years ago

Modified messages require properties to be redeclaired

These are space based sniffs and need `<property name="indent" value="4"/>` i.e 4 spaces = 1 tab

d9312610a20f8d40f27cb0dcbb1492732916ed45 authored over 8 years ago

This is a space based sniff.

We get false positives if this is not `$indent = 4` meaning 4 spaces = 1 tab

06cf889e887cc390f5f4f55239ef901a01582694 authored over 8 years ago

fix tabs vs spaces issue

Most of the sniffs written for PHP_CodeSniffer do not support the usage of tabs for indentation ...

25b73752778cec682e91baa88f38aed289977eb5 authored over 8 years ago

Note ruleset exception for MethodUnderscore

b722b2676bc86676e1f64770f72dd93b3aad3cbb authored over 8 years ago

Note ruleset exception for MemberNotCamelCaps

7a9e57188f1ced577fc8193e4cf5d8f25238a853 authored over 8 years ago

Merge pull request #136 from photodude/patch-4

Fix "Class" typo

c903e6a5ca807e66fb1c16b2d492dfb30bcb17a3 authored over 8 years ago

Outline Selectively Applying Rules and ruleset exceptions

8591a50dbe6710ee9ab87fd377f376bb6689a1b9 authored over 8 years ago

Fix "Class" typo

A formatting change, Add an extra return before ## to improve readability and help visually spec...

74c475b438eb095ccfd0275d95671c7cf63319a5 authored almost 9 years ago

Merge pull request #135 from photodude/patch-4

Remove unnecessary duplication & add try/catch...

5650091f977f86556ddd92f7a0fd13cd7ab99ab2 authored almost 9 years ago

Array assignments maybe aligned with spaces

49933a2624d954cc46763d4c05dafa180e38e8cf authored almost 9 years ago

Merge pull request #86 from SniperSister/bugfix-instantiateclass

empty arrays are a valid parameter too

13d9a5287432f54a0f2db79b9cb1e08ebcce2976 authored almost 9 years ago

Remove unnecessary duplication & add try/catch...

- Reference the chapter on DocBlocks rather than duplicating content.
- Add a try-catch example...

fd846b4dd6c0abc48adbcc9baaa21428d8a34122 authored almost 9 years ago

Merge pull request #133 from photodude/patch-4

Add @throws requirement to methods DocBlock

269b50ec4ec2b609ec276947f5bfd4d59faaae71 authored almost 9 years ago

Correct @throws order

b7cfde2b129c6a022ddc53520d147adb9893dc28 authored almost 9 years ago

Remove T_ECHO

`echo` should be allowed to be used with or without parenthesis

11734f669423e3d8d832c0510e26056d3a02a3e3 authored almost 9 years ago

Merge pull request #134 from photodude/patch-5

Remove T_ECHO fixes #130

8e0f801ba7bcb70c55c4b3e66efc2cdbe414f6bd authored almost 9 years ago

Remove T_ECHO

`echo` should be allowed to be used with or without parenthesis

e3f9986f1b2aaa48ac4d64e0e15da25d3a6678f5 authored almost 9 years ago

Add back missing DisallowShortArraySyntax

Generic.Arrays.DisallowShortArraySyntax should be included until php5.3 support is ended.
Cons...

0e47a8a5173f50f92c789cdc10b20a27b2676e59 authored almost 9 years ago

Add @throws requirement to methods DocBlock

PSR-5 proposal indicates that the @throws tag is "RECOMMENDED" for every occurrence of an except...

2203d809f80c5b5ab597435bce84bbe1e6483e90 authored almost 9 years ago

Message should be tabs count not spaces count

fixer is correctly applying tabs and not spaces so just the message is wrong.

00391f631ab4319b348931108674cf0c26803b33 authored almost 9 years ago

Exclude PEAR BraceOnNewLine

PEAR.Functions.FunctionDeclaration.BraceOnNewLine returns a result opposite of the desired resul...

15b69fcf9309a86dd49187d3e7be9880fa8cb587 authored almost 9 years ago

Merge pull request #131 from genr8r/gh-pages

override .close span class from bootstrap

f2ee1b38091683d5fc7d508ebcbc33db3d9831d9 authored almost 9 years ago

override .close span class from bootstrap

The closing tags on all the code samples at https://joomla.github.io/coding-standards/?coding-st...

b30ec5a5f324066acd3b7a207a7ec2863a2f506e authored almost 9 years ago