github.com/SDWebImage/SDWebImage commits | Ecosyste.ms: OpenCollective

Merge pull request #2068 from bpoplauschi/improve_unit_tests

Fixed our tests and improved the code coverage

83e2c35f8e12866fcfbb7b0aecbad5f0bc946bd7 authored over 7 years ago

Merge pull request #2048 from dreampiggy/fix_cancelBlock_multi_thread_issue

Fix #1941 by placing a lock to avoid multi-thread issue for SDWebImageCombinedOperation cancelBlock

b12ef07e5eb4bc00ec25248a2fc1192b06ecdc61 authored over 7 years ago

Accidentally deleted a comma from an array declaration

f55635de1a1a79b9086fc42adafcdd8b7a737948 authored over 7 years ago

Finally fixed the tests from `SDImageCacheTests` so we can re-enable `test40InsertionOfImageData`

- the problems: some tests were just poorly written, using async calls but not properly setting ...

ed411dcba990dca7fad2e2e9d744fdd5c0163218 authored over 7 years ago

Switched all the tests from using https://s3.amazonaws.com/fast-image-cache/demo-images/* images which are big and sometimes fail to arrive in 5 seconds (before the test can timeout) to smaller images, basically using http://via.placeholder.com/ like http://via.placeholder.com/50x50.jpg or http://via.placeholder.com/200x200.png

This should speed up the tests a bit and also avoid some of the random failures due to timeout

86151183f6e5b442e196c724b3ef145b703ae981 authored over 7 years ago

Refactored the `SDWebImageDecoderTests` a bit. Per DRY, created `verifyCoder:withLocalImageURL:isAnimatedImage:` method that will take a imageURL and a coder and will check decoding and encoding back and forth, sizes and so. Reusing this method for the static WebP image, for the animated WebP image and for the GIF.

90c90a06bc59578f970033b885cc2c26d873961f authored over 7 years ago

Improved the code coverage of our unit tests (given that we disabled test40InsertionOfImageData).

Also updated the Tests Podfile so we don't get a warning (xcodeproj was renamed to project)

f57c21d52a49d1b3d3610e1b077ac742493adcb8 authored over 7 years ago

Merge branch 'master' into 5.x

9d80374064a631bbda5b37f89140af975bae1bbc authored over 7 years ago

Merge pull request #2067 from dreampiggy/feature_gif_encoding_macOS

Add the animated GIF encoding support for SDWebImageGIFCoder on macOS(use NSImage's API)

30275b4415503e9c135dff3801693f1390e18f88 authored over 7 years ago

Merge pull request #2066 from dreampiggy/fix_progressive_webp_height_issue

Provide a way to fix libwebp’s bug during WebP progressive decoding f…

5804934a698ff6ecee941d586d918f3e60aa7d2b authored over 7 years ago

Just disabled this test test40InsertionOfImageData - keeps failing for unknown reasons (strangely sometimes the data doesn't get written to disk)

05828742e8c852111f7e5866d4aa53c9931b8385 authored over 7 years ago

Provide a way to fix libwebp’s bug during WebP progressive decoding for x86 architecture (macOS and iPhone simulator). It kept the previous decoded partial bitmap and will cause current image looks strange.

23a174d859b977eb778de6d81a01d4d1baf59a1f authored over 7 years ago

Add the animated GIF encoding support for SDWebImageGIFCoder on macOS(use NSImage’s API)

2860b78a38df424924a607268068e4de1f07a6e7 authored over 7 years ago

Explicitly set `diskCacheReadingOptions` to its default value 0

748c7d46b69574b45381e7c17679ab42f5d70772 authored over 7 years ago

Merge pull request #2057 from dreampiggy/feature_disk_cache_reading_options

Allow user to provide reading options such as mapped file to improve performance in SDImageCache...

e1a76d76bd58057c9b9021cfb4baea3b3c69a6dc authored over 7 years ago

Fix the build due to #2064 changes - had to make sure pod lib lint works on macOS as well

4ea5423064da59819d0f052272d94d92cd76786d authored over 7 years ago

Attempt to fix the build - the Tests target link to SDWebImage.framework (iOS), so cleaning the schemes that have built that. The problem now with Xcode 9 is that those targets already contain the libwebp and FLAnimatedImage files, Xcode will not rebuild the framework from the proper sources and then we will have duplicate symbols with the libwebp and FLAnimatedImage files that are also compiled by CocoaPods separately.

f3524d33e5694a46995dd07e0be0feef02c7302a authored over 7 years ago

Merge pull request #1898 from walkline/master into 5.x

Handle storeImageDataToDisk error.

324563c7d2a865fbbf3a372670cc8fbefe13d03e authored over 7 years ago

Merge pull request #2064 from dreampiggy/feature_gif_category_support_animate_again

Give back our GIF category animation support since we now use plugin coders

81c71087062213edad4107a0768de00d9372dbeb authored over 7 years ago

Comment updates

a32ab28acb4318c5acb2830384b228fe8ea4ea4e authored over 7 years ago

My IDE loves extra spaces 🙈

879ea189a4bfb5aad4354c1a9a98e20a59f5b2fe authored over 7 years ago

Fixes fail condition in storeImageDataToDisk. Removes extra spaces.

1644d71e7f4bc478e3c21069c2d52dc207bb9651 authored over 7 years ago

Give back our GIF category animation support since we now use plugin coders. This will not affect FLAnimatedImageView which just create the first frame.

1. Change default coders to [IOCoder, WebPCoder]
2. Add back our previous GIF decoding code, wit...

17386829c13cdb327e098b37b73b1ebd8ea7149c authored over 7 years ago

Updated diagrams per latest master change

d12484a7620eeed77f7b281345b2c3e1bf7fdf55 authored over 7 years ago

Let's try building with Xcode 9

bd8d01aa30dcaa1e52ac672e61aa235d018e0a69 authored over 7 years ago

Merge pull request #1991 from dreampiggy/feature_refactor_decoding_with_plugin

Feature: refactor decoding code and provide decoding plugin

5c33c10617d8c02e3d892a406cd900639a610b40 authored over 7 years ago

Fixed cached image filename generated with invalid path extensions

69fe97926603f3aff568aa9157916c434722810e authored over 7 years ago

Feature: refactor decoding code and provide decoding plugin

- open the decoding/encoding procedures to the users
- switch from hardcoded decoding/encoding t...

a0879fc049453c9028e2e1a9755cd9028aecf5f5 authored over 7 years ago

Allow user to provide reading options such as mapped file to improve performance in SDImageCache disk cache

e1603e1800c9a6cb0d3ae0ea7d9775d74cee1275 authored over 7 years ago

Removing not needed functions in SDImageCache. Using DI with initializer.

b51e0ca6891ac91172f2c15b4940602c658b2920 authored over 7 years ago

Merge branch 'master' of github.com:rs/SDWebImage

5fbbf7398638cba87fd712f39e0d07b9e8dd8cd6 authored over 7 years ago

Bumped version to 4.1.2 and added to changelog

c1df782869955cc505a9304637599c606ba04477 authored over 7 years ago

Merge pull request #2051 from dreampiggy/fix_progressive_totalsize_protect

Change finished check from equal to equal or greater than to protect …

322070e2c4c6a2d2fa31a760c266557febce6358 authored over 7 years ago

Merge pull request #2050 from dreampiggy/performance_webp

Static WebP decoding a little enhancement. Do not need create WebP it…

25837a32e40f14e004f6e5bf659d6f0a708d31db authored over 7 years ago

Change finished check from equal to equal or greater than to protect accident condition

9fef316dfa1f31fd96dc8a4e402f1e5f91756f9d authored over 7 years ago

Static WebP decoding a little enhancement. Do not need create WebP iterator for static images.

756e59a995901d4130ce093af5d8487d706782fe authored over 7 years ago

Merge pull request #2049 from dreampiggy/fix_operation_not_call_done

Fix SDWebImageDownloaderOperation not call done when use SDWebImageDownloaderIgnoreCachedResponse

e59d34fdb7515534808c9c98e3d400d5a3f22fb6 authored over 7 years ago

Fix web format check not use immutable image data

4991cb303870180b7955a87ae3fc7256bdb09622 authored over 7 years ago

Fix SDWebImageDownloaderIgnoreCachedResponse early return without call done method

624aa1e2587a10d180219e126933b3f72ce5d925 authored over 7 years ago

Bumped version to 4.1.1 + updated changelog

93a386ed0f118d118d720d7f1283c8ba1d0de83f authored over 7 years ago

Xcode 9 recommended settings applied

ff0690547d268b346e7216cf6d48347bcb0cc2f6 authored over 7 years ago

Merge pull request #1983 from dreampiggy/fix_webp_import_issue

Fix SDWebImage v4 can not import libwebp framework's header files.

4258154c2dd5a9c734985fae118351a0ae5a9166 authored over 7 years ago

Merge pull request #2032 from dreampiggy/adopt_refresh_cache_behavior

Adopt the previous version behavior about SDWebImageDownloaderIgnoreC…

50e26dc5f72cc31e6e9e179c43d7b741a4de8555 authored over 7 years ago

Fix #1941 by placing a lock to avoid multi-thread issue for SDWebImageCombinedOperation cancelBlock

3bb12e8956353e2a13b977463993ca9e5b66bb86 authored over 7 years ago

Fix SDWebImage v4 can not import libwebp framework's header files.

Fix FLAnimatedImageView mixed local and global import

44e80816f0e9b8b6390b3c9bbf4d4f67eb0d26e3 authored over 7 years ago

Adopt the previous version behavior about SDWebImageDownloaderIgnoreCachedResponse and SDWebImageRefreshCached without hack code

7491510f7ec77009fd315bc673d21e9447243ceb authored over 7 years ago

Merge pull request #2040 from dreampiggy/Fix_progressive_download_gray_background

Use CGImageSourceCreateIncremental to perform progressive decoding in…

52993c7150c7b8af8be803567e56a8452a790420 authored over 7 years ago

Remove unused Image IO header

91aef6442c8591db6c60b6e40cb81084f16980ab authored over 7 years ago

Merge pull request #2043 from dreampiggy/set_uibutton_placeholder_if_url_is_nil

Set UIButton's placeholer-image even if the url is nil

05fea33dac8f7904235a82ed5cd7cc17bf114291 authored over 7 years ago

Set UIButton's placeholer-image even if the url is nil

3ab924b01670824bd9fd298612e04b2ebbac7264 authored over 7 years ago

Merge pull request #1985 from dreampiggy/performance_webp_decoding_optimize

Performance enhancement related to single WebP and animated WebP decoding...

250e1fc87f44a39b835ebccb84febe59afb53d4b authored over 7 years ago

Use CGImageSourceCreateIncremental to perform progressive decoding instead of decode partial data each time from the beginning to improve performance and remove that gray background

facdc9925b0ad72eea83d3a18ddac3c914396184 authored over 7 years ago

Performance enhancement related to single WebP image and animated WebP decoding

1. Change the code to not decode WebP images created in SD because it has been decoded
2. Add @a...

df099ced20a48231ff1e843c764d390f01f79a27 authored over 7 years ago

Merge pull request #2011 from dreampiggy/Fix_downloadOperation_imagedata_crash

Fix SDWebImageDownloadOperation imageData multi-thread issue.

cd1158055a75ae499e32c66682ffaa8b6cb15570 authored over 7 years ago

Merge pull request #2035 from dreampiggy/fix_macos_demo_deployment_target

Update macOS Demo deployment target to 10.10 to support build on Xcode 9

d36a664ef8ae354ac03986355393e006a7388ae2 authored over 7 years ago

Update macOS Demo deployment target to 10.10 to support build on Xcode 9

a33d8dd7e03ffce69d73c21ec816e4ec538f8fd3 authored over 7 years ago

Merge pull request #2031 from dreampiggy/add_refresh_cache_test

Add a test for SDWebImageRefreshCached

266b9be6a79f8956ffc152a7a1f14977139f4666 authored over 7 years ago

Add a test for SDWebImageRefreshCached

74566aeb98e9f0e49b3ef0c61e8f0cb63e9f878e authored over 7 years ago

Update ManualInstallation.md (#2030)

Fix `Other Linker Flags` images

207677a6a49915f61d8bf761eee645a1986bf75a authored over 7 years ago

Merge pull request #2027 from dreampiggy/fix_test_prototype_warning

Fix clang strict prototype warning in test

f5570320edeadbe602b6d8fd278296ea9bba651d authored over 7 years ago

Merge pull request #1994 from bpoplauschi/fix_request_cache_policy

Fix request cache policy

446c33f14ffd9daf7c9f87219d7b728141998668 authored over 7 years ago

Fix clang strict prototype warning in test

05dfa6c588649b97aa0cc9cb98b0d984706a4092 authored over 7 years ago

Merge branch 'master' of github.com:rs/SDWebImage

# Conflicts:
# Tests/SDWebImage Tests.xcodeproj/project.pbxproj

b9c17dcdd0d101134a41874040d4c8da2fd40946 authored over 7 years ago

Change access the imageData in NSURLSession delegate queue to solve non thread-safe issue. Also, ensure imageData in completion block is immutable to avoid accident modification from the other queue

9021e5b0024ff510a4a008b1e4e1a15a21215582 authored over 7 years ago

Merge pull request #2002 from iwill/master

Fix issue #2001, add sd_currentBackgroundImageURL and sd_backgroundIm…

e4ab5ebce2450c3ef9094ea93b8170fd130743be authored over 7 years ago

Fix issue #2001

de897ae33a79f72fad12a75f22fb43ab8db580c6 authored over 7 years ago

Fix issue #2001, add sd_currentBackgroundImageURL and sd_backgroundImageURLForState: for UIButton

80dace4a4a46d579efe79b0230987cccfba43ecc authored over 7 years ago

Merge pull request #1995 from DwayneCoussement/strict-prototype

CLANG_WARN_STRICT_PROTOTYPES: Yes please!

94cdb773d74967f7ba2feecf0d151012bd965fde authored over 7 years ago

CLANG_WARN_STRICT_PROTOTYPES: Yes please!

4d99ca6c86493003e44d4ecb5c69f31eb9303655 authored over 7 years ago

Revert "Update for cache policy calculation: I think that if SDWebImageDownloaderIgnoreCachedResponse is there, we need NSURLRequestReloadIgnoringLocalCacheData so we always reload."

This reverts commit ae75b747b039ff3650e9883fd291017133218aaa.

79124e1bab17d0ecee411501ffa0266a8e020b3b authored over 7 years ago

Update for cache policy calculation: I think that if SDWebImageDownloaderIgnoreCachedResponse is there, we need NSURLRequestReloadIgnoringLocalCacheData so we always reload.

ae75b747b039ff3650e9883fd291017133218aaa authored over 7 years ago

The docs say the progressBlock is called on a background queue, so when doing UI, we need to dispatch on the main queue

* @param progressBlock A block called while image is downloading
* @note the progress block is e...

7b79c29a8cd03c3bb50a1a86a2f3b0113bee023e authored over 7 years ago

Fixed #1993 Load image with option `SDWebImageRefreshCached` get error

#1737 introduced an issue that is using NSURLRequestReturnCacheDataDontLoad for our cached images...

ecdd0128ab3ef2e7f44d59efe6079172f4922504 authored over 7 years ago

Attempt to fix #1883 by using a weakSelf reference to remove from callbackBlocks (on the barrierQueue)

2f892f968fe03e82f468adf9df20fd6b06254aea authored over 7 years ago

Merge pull request #1984 from dreampiggy/fix_unreachable_code

Fix unreachable code build warning on macOS

4cfb2e4b9f9ad1e8dc3facf5f0225ddf7fd2951d authored over 7 years ago

Fix unreachable code warning

Fix unreachable code warning because of the return and break expression in #if SD_MAC

65548e36509d897f819fd03c8da6d9f34f5341e0 authored over 7 years ago

Merge pull request #1980 from skyline75489/feature/sdtestcase

Move common test logic to SDTestCase

6e70dbc5ad57aee4ce8476264e4b8cc049af9033 authored over 7 years ago

Move common test logic to SDTestCase

d11597a796ec293310743edad6aa8e3d9900e51f authored over 7 years ago

Merge pull request #1977 from skyline75489/fix/use-foundation-export

Use FOUNDATION_EXPORT over extern

cd84881ff8dea1ca201d4571665755ac1ec0d7a9 authored over 7 years ago

Merge pull request #1978 from dreampiggy/fix_CFRelease_crash

Fix CFRelease on NULL if CGImageSourceRef create failed

ff3b4ac9fdaaa801c7fdeb2e8241476ecddddddd authored over 7 years ago

Merge pull request #1976 from dreampiggy/fix_CGBitmapContextCreate_memory_leak

Fix CGBitmapContextCreate bitmap memory leak issue

a4a5e018c45cedd73c9373b16fbab04e39f12ff7 authored over 7 years ago

Fix CFRelease on NULL if CGImageSourceRef create failed

Fix CFRelease on NULL if CGImageSourceRef create failed, this may happen on progressive download...

c7a444f4a7f1f03c99feda48b81ada08027a00ef authored over 7 years ago

Use FOUNDATION_EXPORT over extern

0f387c669449505323c9e2fccfb0d880aa8de235 authored over 7 years ago

Fix CGBitmapContextCreate bitmap memory leak issue

Pass NULL to CGBitmapContextCreate whenever the data param is not used later to reduce memory le...

5e367af7b53b95bf084ded361dfe431c66572150 authored over 7 years ago

Updated Readme.md added dreampiggy to the team

49772b3bc97e86bcca9f4d2f067db5fba30f5591 authored over 7 years ago

Bumped libwebp submodule reference to version 0.6.0

1f4f371a7af4a32c7f4ba1a5bada0e1bed980644 authored over 7 years ago

Bumped version to 4.1.0, updated changeling

2d9c81295fb990dfe7c3d0b5f56cf9ad06c77144 authored over 7 years ago

Merge pull request #1952 from dreampiggy/master

#1951: Fix animated WebP decoding issue, including canvas size, the support for dispose method a...

f6cca301d5807dc1776e1f43e7e1d450cd79c577 authored over 7 years ago

Merge pull request #1452 from sean9keenan/fixedOutOfOrderImages

Fixed issue where animated image arrays could be populated out of order

b0cf9d6c576bf299782b8ad21ccc3851e635eea4 authored over 7 years ago

Merge pull request #1975 from dreampiggy/mac_animate_gif

support animated GIF on macOS

3d7b6c1bf6fbd7efb9ef8873abdd0d5e14588c60 authored over 7 years ago

Fixed #1776 Umbrella header warning for the FLAnimatedImage (while using Carthage) - replaces #1781

d9f7cf417b636e79d29b87dcd881566a5fd6707c authored over 7 years ago

Removed unreliable check from Downloader tests - sometimes there is more than 1 download in the queue which makes the tests fail

637c41813965f969f22c818baf74a18ff1eeaa0b authored over 7 years ago

Merge branch 'master' of https://github.com/rs/SDWebImage

# Conflicts:
# SDWebImage/SDWebImageCompat.m

886b857e8a9f85d45074fdf8e414ea34ec51bb6f authored over 7 years ago

Improve Animated WebP decoder robustness and fix warning

Only decode the first frame on macOS
Fix CGBitmapContextCreate failed issue
Duration set to 100m...

bd7886388807b38de213a5ce204104ca4ed64649 authored over 7 years ago

support animated GIF on macOS

use NSImage built-in method to maintain GIF on macOS
update README

fecf4d28fdd65ad326756f5aa1d9c5bac1af5ce4 authored over 7 years ago

Merge pull request #1971 from kekeYezi/master

Small change - coding style

3c64b81ac10f75a610b95ed919d2fa139fce3ae5 authored over 7 years ago

Small change

Small change

a4751a652f6dc47419651c560f8e724fc87ab91d authored over 7 years ago

Merge pull request #1891 from Westacular/1870_Change_NSURLSessionConfiguration

Add ability to change NSURLSessionConfiguration used by SDWebImageDownloader

4da40ac8536c0b4497ee28dd079151e0923f140f authored over 7 years ago

Merge pull request #1797 from skyline75489/quick-fix-for-swift3

Fix #1764 Swift naming collision

8ac72a2bdb16282feebb5b8143eccf140c15d2e1 authored over 7 years ago

Merge pull request #1940 from joshuafeldman/master

#1807 - #1821 - Fixing incorrectly retained pointer to self which app…

dbb2dcd2b5506c823487ed7964f04b6b5e013745 authored over 7 years ago