Ecosyste.ms: OpenCollective

An open API service for software projects hosted on Open Collective.

github.com/dahliaOS/zircon-rpi

Zircon for the Raspberry Pi4
https://github.com/dahliaOS/zircon-rpi

[virtualization] disable guest_integration_tests in ASan

The tests consistently fail in ASan on a NUC.

Bug: 50820
Change-Id: I3934185d302cec35c9d322277d...

c6f9bcabdbfbd03a997f8e22d0f874a49fd8d570 authored almost 5 years ago
[cobalt] Make FuchsiaSystemClock thread safe.

A pointer to an instance of FuchsiaSystemClock is passed in
to the CobaltConfig that is passed t...

01ce1a0b3ed1b09161cb9a55a424b51e8dec65e6 authored almost 5 years ago
[usb] Remove log noise in GetDescriptor

GetDescriptor keeps printing errors for unsupported descriptor types.
This patch removes the noi...

133d2ab560076d246f6018eaff54e619950f2f7f authored almost 5 years ago
[camera][imx227] Remove setting mode in StopStreaming, just deinit

This squelches i2c errors when attempting to write to the sensor when
it may have already been p...

f13903abd5d52877ba6f474050f811aa8af93093 authored almost 5 years ago
[kernel][x86] PV: Implement paravirtual EOI optimization

Local APICs traditionally require a CPU to mark an
interrupt as done via an EOI (end of interrup...

7a35d10b5cfc648c94be55ae99f48853ce0730f5 authored almost 5 years ago
[docs] describe new topology in early boot components

The topology described in "everything between power on and your
component" was dated, so update ...

19805e03a3975d1c07cc72c8e0a15295de80e4a4 authored almost 5 years ago
[serve-remote] tunnel ports 8443 & 80 to workstation

Change-Id: I10e1cebd8ebd25afd032ec06c00adc0d72c53771
Reviewed-on: https://fuchsia-review.googles...

598e5c2a8df53fb078d6c34173bcfba525245be1 authored almost 5 years ago
[gndoc] Update GN build arguments documentation

Change-Id: I271ec4215716e41dc563a30f73576d7f39fe21da
Reviewed-on: https://fuchsia-review.googles...

b84210bfb5db27f320e7d2b3574b723933ece17a authored almost 5 years ago
[devices][block]: Ftl Proxy Test Flake.

There was a race condition introduced by creating a ramdevice.
Since it would fail if ramctl wou...

7e6b8a762c5871eb9403073f152a2cf0ecb56089 authored almost 5 years ago
[traceutil] add trigger (alert:action mapping)

This CL adds the ability to invoke the trigger feature already
available in the 'trace' target u...

0d080fac7a05d536a66a1c32a56e039311890c3e authored almost 5 years ago
[brcmfmac] Remove 'mac' field in brcmf_pub

The 'mac' field in brcmf_pub is unused and need to be removed.

Bug: 50812
Test: All existing te...

266339c3622436599671778908b270d02f1acc5c authored almost 5 years ago
[audio_core][mixer] Shave 10% off SincFilter creation

Out of curiousity, I ran Martin's new benchmarks from fxr/382938 with
FX_VLOGS(SPEW) statements ...

2c82e3ccfbf19c1f36c1feda9229713dedc24b27 authored almost 5 years ago
[fidlc] Fix table reserved field max out of line calculation

Max out of line calculation for vector body should include reserved
fields that preceed non rese...

d81e63279ea1656575f55092dead8c4b61b648a5 authored almost 5 years ago
[testparser] Support more test frameworks

Bug: 50501
Change-Id: I447c211a1bf5c19b77060d0f7b1e556a54ce6a82
Reviewed-on: https://fuchsia-rev...

d6085040f75a1e82134d29428876225163553f3d authored almost 5 years ago
[weave] Clear waiters before invoking HandleSelectResult

Clear waiters before invoking HandleSelectResult, as
HandleSelectResult might close fds and clea...

50919e8ee3f19d099305958c1f7fcca94eb46261 authored almost 5 years ago
[weavestack] Add pairing code to fabric state

The generic implementation provides a convenience function that
populates a variety of the field...

58d5d71f10e949663f154cf02a33c7681ecaaaaf authored almost 5 years ago
[camera][imx227] Replace magic number

Change-Id: Ic5b39bdba678f1dc7573990bbfa14ff51a853633
Reviewed-on: https://fuchsia-review.googles...

4e5058e09cc14025219d04bcf6d51cdc5760e153 authored almost 5 years ago
[omaha-client] Change startup timing to always check at 60 sec.

Change the startup case timing to always check for an update at 60
seconds after starting the cl...

b678ac1d5dd661d34115b32051fab6e353f89742 authored almost 5 years ago
[gtest_runner] Add huge tests.

Change-Id: I267f09938d2ac03914d79d12089599928521416f
Reviewed-on: https://fuchsia-review.googles...

9e3d5e8f4a6275a8fcdc90a4f2f5c9ba77ab9ba6 authored almost 5 years ago
[build][testing] Only define host_test_data when is_host

It only makes sense in that toolchain context, and forces people to be
explicit about the host_t...

21adb4ad00d6597326ccdc65c1e7326d5bea0d05 authored almost 5 years ago
[build][testing] Clarify test_spec's path parameter

This is actually required for host, as it is passed to ninja as a target
and ninja will choke on...

c145db56722e7341f03e673f029fd2db1f668899 authored almost 5 years ago
[bt][l2cap] Check size of command reject payload

Check size of command reject payload before parsing.

Create InvalidCIDPayload struct for Comman...

342a6fe56dc30e8a9a992b13ca31c3bfe954e93a authored almost 5 years ago
[build][dart] Enforce existence of *_test.dart files in dart_test

At least one *_test.dart must be passed to dart_test under |sources|.
While this was true in pri...

6657dc253c7458d3a187f2c06fafd68428954320 authored almost 5 years ago
[build] Remove unecessary cruft from BUILD.gn files

Change-Id: I1acb71ac8e06fddb7c7382ebd323a5ca2835f82f
Reviewed-on: https://fuchsia-review.googles...

129f409ecda5d17b1dfa5585e5496895b1833128 authored almost 5 years ago
[docs] Adding missing README.md files

In preparation for enforcing links to directories include a README.md
file, cleaning up existing...

4090fc70389119eb4952afd67d1336867274a3ad authored almost 5 years ago
[camera] Remove log spam at app exit

This change removes logging errors based on the result of loop.Run()

Test: logging change only
...

389ffde602d9ecc25057607f63834f17f6a144cd authored almost 5 years ago
[docs] Document Intel serial-over-LAN

Intel NUC with vPro supports serial-over-LAN, but it needs to be
enabled which wasn't documented...

3abf23b229f2be6e0eb4e9b393ce589b7ebaa73a authored almost 5 years ago
[archivist] Don't fail on send if receiver is closed

The new API might abort the archivist future while the handling of
an event is going on on a sep...

9ba6e52da88aa807c5c2899b4a65b22bdb625eb3 authored almost 5 years ago
[fidlcat] use printer everywhere

This is a refactoring to be more consistent and versatile.

The printer is now independent of th...

aff1ae0e04681c68758bc2bcec4ef155f3a66000 authored almost 5 years ago
[fidl][gidl][benchmarks] Infrastructure to generate FIDL+GIDL for

benchmarks

Since we need to generate FIDL as well as GIDL, I created a generator
that lets you r...

ebce4583f502327c24828cd14e45241583c41f36 authored almost 5 years ago
[docs] Adding source reference and numbering pre-reqs

Change-Id: I2ca9e05b2eca2625fe095e38cadd1e221def56c0
Reviewed-on: https://fuchsia-review.googles...

5fa86dfde9aee9198378ef900e3f7a6d5f577cc8 authored almost 5 years ago
[camera][controller] Implement MutlipleStartStream tests correctly

Test: fx test controller-test

Change-Id: Ia55c5bee4e2b98dfdaf29a1b6059562a1e78bd2c
Reviewed-on:...

fb1565f56fcb60562f7b812e627c610f396ae1bc authored almost 5 years ago
[run_test_component] Solve stdout interleaving problem.

Give different sockets to launched component so that run-test-component
can buffer component's s...

a8e47adcccddbae786de9357f9abbcfa280c3e30 authored almost 5 years ago
[http_client] Lower log verbosity to 0

verbosity 1 should not be enabled for all builds.

Fixed: 50476
Change-Id: I74c3fb4b073033800743...

1fab2b2e727f0388d36f791618c881b010246665 authored almost 5 years ago
[devices] Update uses of printf to LOGF/LOGD

Update uses of printf to LOGF/LOGD in order to standardise on a single
form of logging.

Bug: 49...

22cbb9321d93bbd4d669652e0d200c60378689e7 authored almost 5 years ago
[bt][le-central] Add support for reliable writes

* This change introduces a flag, "-r" for WriteLongChr allowing a client
to send a Reliable Long...

81e3e88ecf8c7c06297b0e5b7a6040e5ffd83d04 authored almost 5 years ago
Revert "[paver] Re-enable GPT partition tests"

This reverts commit 3c5549252fc7608c4adad1191ae8477bafed60a5.

Reason for revert: Still flaking
...

777a74a105d19065e254eb467a79b7767e8a3e66 authored almost 5 years ago
Revert "[ui-input][shortcut] Quick fix for Meta-only shortcut"

This reverts commit 8e62911c937638b9bfda9a4c22e068906f514fe1.

Reason for revert: While this cha...

f9c30889bb74c8ea1c9783a4d835a043bc84b861 authored almost 5 years ago
[lsc] Standardize g{test,mock} includes

Change-Id: I4f08cae2c615e563d4708b8caad793cb94081b9f
Reviewed-on: https://fuchsia-review.googles...

8e5b638fd8750bbb3b3eb3bb21a43d9f14c81395 authored almost 5 years ago
[tools] add the bssl tool to //bundles:tools

Change-Id: Iabff8b2f13807753330ef9dc7b64365c7e3632ce
Reviewed-on: https://fuchsia-review.googles...

0148d220ba7c045155e64f5deda0dc0fedfda502 authored almost 5 years ago
[intl] The C++ lookup interface.

An interface for looking up localized message versions.

Bug: 50725

Change-Id: I9dddef6247c9846...

7a13dfdca8e66cbe1575bf6073fb28b299a30f59 authored almost 5 years ago
[debug] SCE #1: Extend ExceptionRecord

This change
(1) extends ExceptionRecord by a boolean field indicating whether the
associated exc...

69e62f848c403b9de4b13cd2f65ce63c991f1c69 authored almost 5 years ago
[development-bridge] Remove references to gtest adapter.

Change-Id: Iacfd51429523aaf18c5be44109bc89d8e7cd2758
Reviewed-on: https://fuchsia-review.googles...

efb2b3429e6c7ba2fc399526d59de5cfe014c6f6 authored almost 5 years ago
[archivist_tests] Fix tests.

Now archivist is logging into it's own LogSink, so fix integration test
to use tags so that we d...

1edc0ca40198fa66d98b0df803239fcb6f630603 authored almost 5 years ago
[fidl][docs] Fix HLCPP doc changes

Re-add a large chunk of the HLCPP tutorial that went missing
after the structuring, and fix some...

af188b6dcaffb93d25e649e1e00ca08b70951f91 authored almost 5 years ago
[docs][guides] Add a note to recommend the version of Git to be >2.24

to the Get the Fuchsia source guide.

BUG: b/154945759
Change-Id: Ia96be6b4d12fb8fcff42bd643cbc1e...

fc4d89e16ce43629ee83c79ff42d924ca7054e9c authored almost 5 years ago
[magma] Add new allowed driver symbols

These are needed for new versions of the mali driver.

Change-Id: If3ebe0eaf1910bdc2359c71ce54ee...

d4fcc2472faff21f581d19def2b2c785d1c1ffd7 authored almost 5 years ago
[serial][server] Allow consecutive connections

This will allow consecutive host-target interaction tests to connect to
FUCHSIA_SERIAL_SOCKET.

...

24bcacd8719c372d96b947132f1711f613992933 authored almost 5 years ago
[docs][guides] Remove outdated links from the Contribute changes doc.

Change-Id: Ia06a46afdfbe196934478e689109e07d01939707
Reviewed-on: https://fuchsia-review.googles...

798864f99f6094bc118f9536f9851f9a798d8aee authored almost 5 years ago
[device-enumeration] Make it clear the qemu case is for arm64

Change-Id: Ifa3148991b77325e3d0fffd65cd0ac10685608f1
Reviewed-on: https://fuchsia-review.googles...

cac6eb718be2c2133145b53d839bb5d42558acd3 authored almost 5 years ago
[ffx] Adding a thread-safe cache for the Config

This will prevent the config reloading everytime there's a query for a
config key.

Change-Id: I...

f86f28a5d08cd220f8a5c8026692466ff2d5f511 authored almost 5 years ago
[test_runners] Add doc for rust test runner.

Change-Id: Ia8c73b290d75a45840ccbad5f87523bdee6a5b3d
Reviewed-on: https://fuchsia-review.googles...

1b736bbd9fe98385edd2630e7610aef92f7a7519 authored almost 5 years ago
[runtests] Parse test cases from stdout

Bug: 50501
Change-Id: I71a9aa9f331bf22311decacb197301e75dfce5d7
Reviewed-on: https://fuchsia-rev...

31b1acf4ebde400b9725a3e7a7c27a628d9fc646 authored almost 5 years ago
[benchmarks] Remove dangling references to topaz/tests/benchmarks/

That directory has been removed, including
topaz_input_latency_benchmarks.

Bug: 23091
Change-Id...

254578e082a841c7e81d715bd7fbf8fe1759f57d authored almost 5 years ago
[gtest_runner] Add integration tests.

Fixed: 45854
Change-Id: I2eb89d4b36567aea8fbaf227f61b057e94a8dc3f
Reviewed-on: https://fuchsia-r...

0236684ccfa38608a6bff61eaabe952cfdbe4819 authored almost 5 years ago
[appmgr] Add feedback to build-info allowlist

Bug: 50308
Change-Id: Ifab7b87ddd176290f805f5c86f2ca5b180816abb
Reviewed-on: https://fuchsia-rev...

4599cac2b0e2b53d7d4e6d2d67b7940704e55324 authored almost 5 years ago
[bt][gatt] Check ExtendedProperty before performing ReliableWrite

* This CL adds a check for the ExtendedProperty bit of the Properties
associated with a characte...

15c8d282aab6eeaff3763fba72c59add0b63778e authored almost 5 years ago
[lsc] Replace googletest:gtest_main with fxl/test

fxl/test:gtest_main is a superset of googletest:gtest_main which adds
support for Fuchsia-specif...

ecf0f92a840792d6f837d513cd1efb43d663f597 authored almost 5 years ago
[pkg-resolver] Test update_tuf_client metric on error

Change-Id: I7ee353c6c0bf21d274b5a5f218cdf51296058bb0
Reviewed-on: https://fuchsia-review.googles...

851eac8de897a73489f07faadce9450b74ac8aaa authored almost 5 years ago
[fx ssh] enable the use of ssh-agents

The prior motivation for this exclusion has been lifted, and there
are now some use cases that m...

e0907229f83e3220c1f4ff130fa35517bd14cab8 authored almost 5 years ago
[modular] Allow comments in Modular config JSON

This enables ModularConfigReader to parse and ignore /* */ and //
comments in the (non-standard)...

8de32fd145f5fb329273cee69d63c2774cf5c1db authored almost 5 years ago
[images] support firmware_prebuilts

Adds support for the firmware_prebuilts variable, which allows adding a
set of firmware images t...

b9005ce4a4a11c1c6e76f64f8c1aebd13e78bf60 authored almost 5 years ago
[escher] Define lifetime of DescriptorSetAllocators

This CL moves caching policy for DescriptorSetAllocators into
DescriptorSetAllocatorCache class....

5290940a6582ead7798bfc7e9271d62fac996c4e authored almost 5 years ago
[audio] Move clock domain to the StreamConfig protocol

Test: fx run-test audio_core_unittests
Change-Id: I7896dd4bedd702611a358ac26211fc73d780849b
Revi...

d208bee01d74c1d5c0dc8815d89456bde9f8a843 authored almost 5 years ago
[fidlgen] Add install_host_tools targets for fidlgens

This CL adds install_host_tools("host") targets to each fidlgen backend
in tools/fidl, and inclu...

9cdf87589c2be71034a8dd9afa9bb35aaae1e5c2 authored almost 5 years ago
[docs] remove outdated mod integration testing doc

Removes old Flutter/Dart integration testing doc that referenced mods, removed
Modular functiona...

be1238fd82ed1d99ae1168ad62d2e8674094dfe6 authored almost 5 years ago
[a11y] Modifies a11y focus manager to change highlights on focus change.

This CL ensures that the a11y focus manager manipulates highlights to
reflect changes in a11y fo...

beba33ceaebccd01a16ebe76165a80e7ef4447cc authored almost 5 years ago
[fidlc] Recoverable parsing at member boundary

This CL builds on the functionality added in fxrev.dev/378714 to add
recoverable parsing between...

a26d85da889554293c2240b0870afcefbc5f79e9 authored almost 5 years ago
[a11y] Next / previous action scrolls nodes to make them visible.

Change-Id: Icc233b3f391911eeee1ee6684897ab5a394429fd
Reviewed-on: https://fuchsia-review.googles...

a46cb9be7c28956ccf87bbbddac7d7e1aad1c4da authored almost 5 years ago
[sshutil] Add test for running a command

This adds a test to make sure that running a command against an ssh
server actually works. It wr...

76c6bc89a4a89e9ba348c15e798f8fcdd11ebe4d authored almost 5 years ago
[testsharder] Enable fuzzy multiplier matching

Test multipliers currently have to reference the "name" field of some
test from tests.json. With...

3e6c325bb335f4255b8dd8a6aecaf900d5f89b1d authored almost 5 years ago
[docs][prebuilt_packages] Update documentation.

This updates the documentation describing how to public a new
prebuilt package to CIPD.

- Clari...

57ea6b40073c24cb98f9dd2d7bb5e21171f7d574 authored almost 5 years ago
[sdk] fix fuchsia.hardware.ram.metrics

We recently made 'zx' not magic in fidl and
this library landed shortly after.

This is not actu...

1fe76d29b15b2e9938a9fe56bfe107cce5377a5f authored almost 5 years ago
[camera] Add Lifecycle protocol to camera-gym.

This change adds support for the Lifecycle protocol to camera-gym,
allowing it to cleanly shut d...

a469ed41d83a0ef5158daf10dbb82ee65bc1a308 authored almost 5 years ago
[storage] Add Zero method to storage::BlockBuffer.

This is needed for following changes. Where the buffer is backed by a
VMO we can use a specialis...

f2d3899257fb98ca4c1e0553e62cf99906051cfb authored almost 5 years ago
[gndoc] Update GN build arguments documentation

Change-Id: I24f15f58662d56f19acb2be9c83f077c26940e8f
Reviewed-on: https://fuchsia-review.googles...

15a32b4197c8a28ee0f5f196c21e6fe331499f81 authored almost 5 years ago
[storage] Add a buffer abstraction that works for both host and target.

Introduce a ResizeableArrayBuffer type (for host use) and a
ResizeableVmoBuffer type (for target...

2dc4dd26740abf6bc2ccda4afd6c514f3955cef0 authored almost 5 years ago
[pkg-resolver] Log errors with anyhow

Fixed: 50570
Change-Id: Ifa908005192c9be5cb9d4a3332825a9d89ccd43d
Reviewed-on: https://fuchsia-r...

d490a75df90a3a3b786e7599c1951ee05f9c1f27 authored almost 5 years ago
[x86][platform-bus] Convert acpi_device_t into a C++ style type (DDKDevice).

Change-Id: I1f921147a78c829e44859914d68fcd19b95c7468
Reviewed-on: https://fuchsia-review.googles...

a569142080c50b66c140c44018d5f20917a026fe authored almost 5 years ago
[kernel][x86] Rename pvclock to pv_clock

Also rename pv_clock.{h,cc} to pv.{h,cc} so we can put all
para-virtualised code into the same p...

b2bbaa678d4f94be6c23af1fe5c22f77ebd20c2e authored almost 5 years ago
[kernel][x86] Add more hypervisor feature flags

Add feature flags for pv-eoi and pv-ipi, and add convenience functions
for all pv features.

Cha...

c9de59c5758f0768d8b77c1c754a404d13bcfe3c authored almost 5 years ago
[diagnostics] Restructure log format

Change-Id: I3b3d6ffac9d2566200d2d8b8e9ac2273b8dcc6e1
Reviewed-on: https://fuchsia-review.googles...

51fcae3980e627fd43a0eafec3ac810b9794663c authored almost 5 years ago
[devices] Log console shell terminated to debuglog

When the console shell terminates, log it to the debuglog so that it's
clear to the user of the ...

c2895e48012403b9e79d737bbdd1aaef532ebad8 authored almost 5 years ago
[bt][hci] Avoid assuming kernel message batching behaviour in tests.

The current test "HCI_CommandChannelTest.EventHandlerResults" implicitly
assumes a particular be...

7badeb1a8fd7e00021a1ecd891ce92fd82d4956c authored almost 5 years ago
[swd-e2e-tests] Add ability to pave slot A zircon and vbmeta

Also adds tests for the paver package. The tests check that the correct
arguments are passed to ...

d56d4e93da4513da3efb91283c753637a07d07c7 authored almost 5 years ago
[carnelian] Remove redundant GN targets

The removed targets are redundant and implicitly included by the
`vk_find_target` target.

Chang...

d8a93d3ac386c8ae6d91cbd04a9873ac00f1bea2 authored almost 5 years ago
[carnelian] Add SRGB formats to spinel render backend

Provides gamma correct rendering when these formats are
available.

The motioncopy shader was up...

935e13a6c7c1f667901c33fa9f999f0145ac0f8d authored almost 5 years ago
[carnelian] Fix spn_styling_group_range_hi typo.

Call spn_styling_group_range_hi instead of spn_styling_group_range_lo
twice. Also handle the zer...

9e2310017361e6c6fd7286d51ab32d22e0604da3 authored almost 5 years ago
[carnelian] Fix vulkan validation layer support

Include validation layers for examples that support Spinel
backend.

Test: fx run gamma-rs -s
Ch...

54d70c2e3e0624408c73452b11ab3efe49fa4f38 authored almost 5 years ago
[fidl][measure-tape] Use mini-CFG representation

Preparing measure tape to be generalized to support multiple
backends.

* Separating the logic c...

3fbd021706035a965ab0af6cd5f570caabf25659 authored almost 5 years ago
[fidl][measure-tape] Support for vectors

Adding support for vectors.

Test: fx test measure-tape-tests
Bug: 49480
Change-Id: Iacd35dc586e...

b3b5a6cbfdc4b508c385057e3127c0805d5da1fa authored almost 5 years ago
[gndoc] Update GN build arguments documentation

Change-Id: I24ab6eee57409836b6afce4df21936e0b2d528d2
Reviewed-on: https://fuchsia-review.googles...

3c0077961771ba5566adb6c2d5889f54c58cd291 authored almost 5 years ago
[tools][debug][elflib] Handle PE-COFF PDB GUIDs as build IDs

This makes elflib a bit of a misnomer, since it reads both ELF
and PE-COFF now. It's really bui...

90e0dde78b6c60ac657471e84287bf643245db9e authored almost 5 years ago
[sdk] Add fuchsia.hardware.ram.metrics FIDL

This interface is for reporting memory bandwith
and utilization.

See the bug for more informati...

3f27177e328847fccfa17c8e8d320f85e2f3657c authored almost 5 years ago
[runtests] Avoid infinite loop

When an empty VMO is published, we would continue the loop, but
since we only popped the element...

bcc5a70af27d8fb0cd45898ff67ec2f72a5239a6 authored almost 5 years ago
[wlan] Added set mac API from brcmfmac to wlancfg

An optional parameter is added in CreateIface function in the code stack
from brcmfmac driver to...

b20b2ad917b862eef36c62d6559e33c3e46194a0 authored almost 5 years ago
[debugger] Add location support for clear/enable/disable

Introducing a new syntax for clear/enable/disable which takes an
optional location so that the b...

2a38607d57c460f9a2d76d304a8c8d45aba2779f authored almost 5 years ago
[gndoc] Update GN build arguments documentation

Change-Id: I13a3fdc80450a7b4a368f4d668323acf60a17a1d
Reviewed-on: https://fuchsia-review.googles...

c9a34899f30dba2bf27959e11d50ff696abd4210 authored almost 5 years ago
[devices] Remove DDK_LOG_DEBUG* macros

Now that we've migrated over to syslog, these macros are no longer
useful.

Bug: 49457
Change-Id...

7182e622a952ebee31643d2643ac554d40229980 authored almost 5 years ago
[devices] Replace DDK macros that use ZX_LOG_LOCAL

Replace these macros with DDK_LOG_SERIAL, that is used to indicate that
we should log to debuglo...

46f50c0849fa827601a90236ec1c62808b7a6317 authored almost 5 years ago