* Remove an unnecessary type conversion
* Make golint happier about consistent receiver names
* ...

Change-Id: I9d77655026f16a41a77bd0036d693a40cdd6d52f
Reviewed-on: https://go-review.googlesource...

Now that issue #12438 is resolved, this TODO can be completed.
Create a logf helper, which is si...

When If-Range does not match and the requested resource is
available, server should return a "20...

Updates http2 to x/net/http2 git rev 1c05540f687 for:

http2: fix format argument warnings in ...

Setting the Content-Type header explicitly allows browsers to know what
the type of the content ...

We can make it panic with a more explicit and readable error message
during Go 1.10, but documen...

In CL https://golang.org/cl/4893043 (6 years ago), a new package named
"url" was created (it is ...

Fixes #21077

Change-Id: Ic61d7313907f58ff4027fd2eee1ddb8c1656304d
Reviewed-on: https://go-revie...

Updates #18997

Change-Id: Ib1961a4c26b42f99b98b255beb7e2a74b632e0c1
Reviewed-on: https://go-rev...

The Server struct has exported fields, which allows users to manually
create a Server object wit...

Updates http2 to x/net/http2 git rev d4223d6710a for:

http2: refund connection flow control...

Fixes #20810

Change-Id: I09365b2db50c41aa3383dd730859b6f2cdb78e63
Reviewed-on: https://go-revie...

mutex profile requires explicit calls to
runtime.SetMutexProfileFraction to enable/disable
profi...

Add a test and fix for the request body being closed twice.

Fixes #19186

Change-Id: I1e35ad4ae...

We used to do it sometimes as an optimization, but the optimization is
flawed: in all non-contri...

The existing implementation sequentially closes connection in the loop
and until the previous cl...

Updates #20759.

Change-Id: Ic61dcb6d101ad1491dca535aebb6ee8ee740d013
Reviewed-on: https://go-re...

Fixes #20383

Change-Id: I11234393c3beb669f87976a4f0b424bec7372b82
Reviewed-on: https://go-revie...

Updates http2 to x/net/http2 git rev 3d7ac2a5d for:

http2: fix Server race
https://gola...

Updates http2 to x/net/http2 git rev 973f3f3 for:

http2: make Transport treat http.NoBody li...

Change-Id: I8aa070f8093e80ba19f0546d7447caf847a2b388
Reviewed-on: https://go-review.googlesource...

Fixes #20618

Change-Id: I90712bd76d9d47f29221bc298c69737ebee25c12
Reviewed-on: https://go-revie...

Update x/net/http2 to git rev 6b17b9baf5 for:

http2: stop rejecting outgoing paths beginning...

I accidentally set the wrong pattern mask as
* []byte("\x4F\x67\x67\x53\x00") --> "OggS", the by...

The golang.org/x/tools/cmd/bundle tool previously had a bug where it
dropped some comments.

Thi...

The net/http package has long documented that Request.ProtoMajor and
Request.ProtoMinor are igno...

TestServeTLS was added in CL 44074, merged today.
This cleans up the test a little.

Updates #13...

Server.ServeTLS wraps Server.Serve with added TLS support. This is
particularly useful for servi...

The test is passing on a 64bit RFS.

Fixes #18008

Change-Id: Ia4c4f4dde0392c7f6bbe5dbffc97cf848...

Fixes #19850

Change-Id: I8c86e288159408c687c2a85f458ade282adae450
Reviewed-on: https://go-revie...

Fixes #20601

Change-Id: I296d50dc5210a735a2a65d64bfef05d14c93057b
Reviewed-on: https://go-revie...

This is another attempt at the change attempted in
https://golang.org/cl/27117 and rolled back i...

This updates the bundled copy of x/net/http2 to x/net git rev
3470a06c1357df53 for:

http2: fix ...

CL 43779/commit 6a6c792eef55eded7fb3165a330ec2b239b83960
broke the builds at tip, and that CL do...

When writing the 'Connection: close' header based on response Close
attribute we also check if i...

Despite the previously known behavior of Request.WithContext
shallow copying a request, usage of...

Apparently they exist in the wild. See:
https://github.com/golang/go/issues/18215#issuecomment-3...

Avoid directly using the binary of the
gzipped encoded string in the handler.

Follow up of CL 3...

The existing Transport implementation does not detect gzip encoding
when the Content-Encoding he...

This updates the bundled copy of x/net/http2 to x/net git rev a8e8f92cd6 for:

http2: remove...

This will be used to allow http2 servers to register a shutdown function
so that net/http.Server...

Fixes #18438

Change-Id: I9599c1536d5e8bad7662b8ffa19e9b0746e27e60
Reviewed-on: https://go-revie...

The jarKey function handles broken PublicSuffixList implementations but
no test verified it.

Ch...

According to RFC 6255 a cookie value may contain neither spaces " "
nor commas ",". But browsers...

Trailers that are not announced in the Trailer must be passed on to
the downstream client.

Rath...

Ensure that the implicitly created redirect
for
"/route"
after
"/route/"
has been registered...

Updates #18318

Change-Id: Ibd4ebc7708abf87eded8da9661378b5777b8a400
Reviewed-on: https://go-rev...

Updates bundled http2 to x/net/http2 git rev feeb485 for:

http2: add all bad ciphers, use p...

Fixes #20196.

Change-Id: Ib87f6e9e27a38f21f860b7150c818d77be653dd3
Reviewed-on: https://go-revi...

Fixes #7121.

CL 31173 inadvertently fixed this issue in the Go1.8 cycle.
This CL enables the te...

It used to be simple, and then it got complicated for speed (to reduce
allocations, mostly), but...

Fixes #19976

Change-Id: I48486467066784a9dcc24357ec94a1be85265a6f
Reviewed-on: https://go-revie...

The LocalAddrContext should have the network address of the actual
interface.

Fixes #18686

Cha...

This updates the bundled http2 package from git rev
5602c733f70afc6dcec6766be0d5034d4c4f14de of ...

Cleanup CL https://golang.org/cl/41691 broke the plan9 build by removing
a use of a package but ...

Mostly unnecessary *testing.T arguments.

Found with github.com/mvdan/unparam.

Change-Id: Ifb95...

Change-Id: I9cdf6e7da0fb2d5194426eafa61812ea7a85f52f
Reviewed-on: https://go-review.googlesource...

Brad noticed a bullet list was rendered as preformatted text because of
the indentation. One can...

Returns at the end of func bodies where the funcs have no return values
are pointless.

Change-I...

If the bool value isn't used, there is no need to assign to underscore -
there is a shorter form...

Reading a response with a status line like "HTTP/1.0 401 Unauthorized"
(with two spaces after t...

The current interface can't access all environment
variables directly or via cgi.RequestFromMap,...

Updates #18437

Change-Id: Iaa8a35d18eca8be24763dd151ad9e324ecbf7f7b
Reviewed-on: https://go-rev...

In particular, this lead to the code accepting invalid ETags as long as
they finished with a '"'...

Change-Id: I1f1cfb161640eb8756fb1a283892d06b30b7a8fa
Reviewed-on: https://go-review.googlesource...

The aLongTimeAgo time value in net and net/http is used to cancel
in-flight read and writes. It ...

If the user created an httptest.Server directly without using a
constructor it won't have the ne...

If go doesn't have permission to run strace, this test hangs while
waiting for strace to run. In...

This change strips the port in mux.Handler before attempting to
match handlers and adds a test f...

Custom logic from request.go has been removed.

Created by running: “go run gen.go -core” from x...

The DefaultServeMux included in net/http uses a map to store routes,
but iterates all keys for e...

TestOnlyWriteTimeout assumes wrongly that:
- the Accept method of trackLastConnListener is calle...

The old implementation of Jar made the assumption that the host names
in the URLs given to SetCo...

Given an entry in $no_proxy like ":1" we would interpret it as an empty
host name and a port num...

As noted in https://github.com/golang/go/issues/19161#issuecomment-287554171,
CL 37771 (adding u...

Retry the test several times with increasingly long timeouts.

Fixes #19538 (hopefully)

Change-...

Fix last proxy in TestProxyFromEnvironment bleeds into other tests
Change ResetProxyEnv to use t...

Call body close after ioutil.ReadAll is done

Change-Id: Ieceb1965a6a8f2dbc024e983acdfe22df17d07...

It appears that this test is particularly
sensitive to resource starvation.
Returning it to non-...

After merging https://go-review.googlesource.com/c/34639/,
it was pointed out to me that a lot o...

Found by github.com/mvdan/unparam.

Change-Id: I66f5a191cf9c9a11a7c3c4d7ee0a02e2c185f019
Reviewe...

Adds a function for easily accessing the x509.Certificate
of a Server, if there is one. Also add...

If I put a 10 millisecond sleep at testHookWaitResLoop, before the big
select in (*persistConn)....

It fails on Solaris often, but nowhere else.

Not sure why. Add some debugging.

Change-Id: I79f...

See #18508

This commit adds http Client support for socks5 proxies.

Change-Id: Ib015f3819801da...

In an unrelated CL I found a way to increase the likelihood of latent
flaky tests and found this...

This was a t.Parallel test but it was using the global DefaultTransport
via the global Get func....

Updates http2 to x/net/http2 git rev 906cda9 for:

http2: add configurable knobs for the server'...

Change-Id: I0455ffaa51c661803d8013c7961910f920d3c3cc
Reviewed-on: https://go-review.googlesource...

Fixes #19085

Change-Id: Ib11b9a22ea8092aca9e1c9c36b1fb015dd555c4b
Reviewed-on: https://go-revie...

The current implementation does not account for Dir being
initialized with an absolute path on s...

I noticed that Content-Length may appear in http.Response.Header, but the docs
say it should be ...

The current implementation fails to produce an "IsNotExist" error on some
platforms (unix) for c...

As of https://golang.org/cl/21530, rules are updated to state
that Handlers shouldn't modify the...

Updates Profile and Trace handlers to reject requests for durations >=
WriteTimeout.

Modifies g...

Fixes #18838

Change-Id: I44976cadb0dc3c23eacb8cdd58429a572cd8d28a
Reviewed-on: https://go-revie...

The name lookups are unrooted; the test should be unrooted too.
Correctly skips the tests if the...

Adds helper function to auto-skip tests when DNS returns
a successful response for a domain know...

Fixes #18319

Change-Id: If88e60a86828f60d8d93fc291932c19bab19e8dc
Reviewed-on: https://go-revie...