Closes https://github.com/ooni/probe/issues/2183

While there, avoid exposing nil values for o...

We're using a request-specific logger where we also print the ID
of the request. This design he...

This diff makes `measurex` depend on `measurexlite` rather than the other way around.

While t...

Part of https://github.com/ooni/probe/issues/2240

This commit moves the TH structs and definitions to model. We don't want
oohelperd to depend on...

A bunch of packages (including oohelperd) just need the ability to
use MaxMind-like databases. ...

This diff improves oohelperd to measure :443 endpoints with TLS.

Part of https://github.com/o...

This diff introduces the following `oohelperd` enhancements:

1. measure both IP addresses res...

This diff refactors oohelperd to make performing additional measurements easier. We need:

1. ...

While working on https://github.com/ooni/probe/issues/2237, I noticed
there's no enforced timeo...

Part of https://github.com/ooni/probe/issues/2183

See what we documented at https://github.com/ooni/spec/pull/257

Reference issue: https://gith...

Part of https://github.com/ooni/probe/issues/2237

See https://github.com/ooni/probe/issues/2237

In a pure step-by-step model, we don't need to trace HTTP round trips like we did before. We _ma...

See https://github.com/ooni/probe/issues/2231

Co-authored-by: decfox <[email protected]>
Co-...

The T0 field is the moment when we started collecting data, while T
is the moment when we finis...

This pull request started as a draft to enable users to see CNAME answers. It contained several ...

* feat: save CNAME into archival data format

When a DNSResponse contains a non-empty CNAME, w...

* feat(dnsovergetaddrinfo): collect the CNAME

This diff modifies how dnsovergetaddrinfo.go wo...

* feat(netxlite): support extracting the CNAME

Closes https://github.com/ooni/probe/issues/22...

* cleanup: remove UnderlyingNetworkLibrary and TProxy

While there, replace mixture of mocking...

See https://github.com/ooni/probe/issues/2221

Co-authored-by: decfox <[email protected]>
Co-...

* chore: use {go,oohttp,oocrypto} v1.18.5

This diff pins OONI to use go1.18.5 and oohttp and ...

Part of https://github.com/ooni/probe/issues/2211.

See also https://github.com/ooni/probe/iss...

* upgrade to our go.mod enabled of psiphon-tunnel-core such that
we're now using v2.0.24 of the...

See https://github.com/ooni/probe/issues/2219

Closes https://github.com/ooni/probe/issues/2215

This diff contains minor changes to make the build scripts in here
compatible with https://gith...

It turns out the problem described in https://github.com/ooni/probe/issues/2122
only affects da...

Skip options that begin with the `Safe` prefix from appearing in the
serialization of a Measure...

While there, document what we need to document without mentioning too
many details about releas...

See https://github.com/ooni/probe/issues/2218

I made a mistake while adapting code from an experimental branch thus
breaking these two experi...

See https://github.com/ooni/probe/issues/2217

See https://github.com/ooni/probe/issues/2216

See https://github.com/ooni/probe/issues/2159 and https://github.com/ooni/spec/pull/254

* feat: add support for system resolver in measurexlite

* more tests for coverage

* Apply ...

* refactor: remove query-based mapping and introducing resolver wrapper

* refactor dnsping to...

* feat: Introduce context-based tracing to the system resolver

* testing: added tests for con...

Reference issue for this pull request: https://github.com/ooni/probe/issues/2159

This diff re...

Until OONI Run v2 has support for repeating the measurement with a schedule, introduce a command...

This diff adds support for OONIRun v2 links.

Part of https://github.com/ooni/probe/issues/2184.

This diff adds support for running OONIRun v1 links.

Run with `miniooni` using:

```
./min...

This diff refactors the ./internal/cmd/miniooni pkg and moves the code
for running experiments ...

The integration test that was broken was:

```
--- FAIL: TestCreateInvalidExperiment (0.35s)
...

This option has been disabled for a long time and we said in the
codebase we were going to remo...

This diff modifies the engine package to make Experiment and
ExperimentBuilder interfaces rathe...

Bug reported by @DecFox and subsequently observed in several
CI builds. No need to create an is...

This diff refactors how we set options for experiments to accept
in input an any value or a map...

This diff makes the implementation of the engine package more
abstract by changing HTTPClient()...

After this diff has landed, we have addressed all the points
originally published at https://gi...

In https://github.com/ooni/probe-cli/pull/832's initial diff, I
mentioned it would be cool to f...

This diff modifies the implementation of oohelperd in the master branch
to always use throw-awa...

* doc(step-by-step): further improvements on design doc

* Update docs/design/dd-003-step-by-s...

## Checklist

- [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cl...

I am not 100% sure I was able to fix all the cases in which we
need higher permissions than the...

This bug is one of these bugs that definitely help one to stay
humble and focused on improving ...

This diff contains readability improvements for the step-by-step design document.

Co-authored...

This diff changes all github actions and mk to use go1.18.3.

That's what I am using locally.
...

This commit changes the README of `./internal` to make
sure we're referring to the step-by-step...

Thanks @ainghazal for mentioning this useful tool to me!

This pull request publishes the step-by-step design document that I have been discussing with @h...

These factories will soon be useful to finish with
https://github.com/ooni/probe/issues/2135.

This will help with https://github.com/ooni/probe/issues/2135

See https://github.com/ooni/probe/issues/2135

Part of https://github.com/ooni/probe/issues/2135

We can simplify code in a bunch of places using a useful factory.

Part of https://github.com/...

See https://github.com/ooni/probe/issues/2135#issuecomment-1149840579

This diff addresses the following points of https://github.com/ooni/probe/issues/2135:

- [x] ...

The oohelperd implementation did not actually need using netx because
it was just constructing ...

The oohelper does not need to use netx and it's enough to use
netxlite, hence let us apply this...

This diff forward ports 4fb5f7de69b900cfc2bd211f723108a67bda350d to master.

See https://githu...

This diff forward ports 261d1a4cdc88522f6a8f63d6c540f51054566b28 to master
whose original commi...

See https://github.com/ooni/probe/issues/2121#issuecomment-1147424810

This diff refactors netx and netxlite to ensure we're not using
netxlite legacy names inside of...

Before finishing the ongoing refactoring and leaving whatever
is left of netx in tree, I would ...

Now that we have properly refactored the caching resolvers we can
move them into netxlite as op...

For testability, replace most if-based construction logic with
calls to well-tested factories l...

This diff modifies netx to stop using most netxlite resolver internals
but the internal functio...

Part of https://github.com/ooni/probe/issues/2121

1. Use the netxlite.NewHTTPTransport factory for creating a new
HTTP2 (and HTTP1) transport;

...

This diff improves testing and increases coverage inside the
./internal/netxlite and ./internal...

* add gosec step

* fix: disable build on pull request

Co-authored-by: Simone Basso <bassos...

There's no point in doing that. Also, once this change is merged, it becomes easier to cleanup/s...

Part of https://github.com/ooni/probe/issues/2121

This diff modifies netx to use netxlite to build the TLSDialer.

Building the TLSDialer entail...

See https://github.com/ooni/probe/issues/2121

This pull request consists of several small and obvious cleanups in the netx directory.

See h...

By just storing the raw certificate we simplify the internal data
structure we use. In turn, th...

There are two reasons why this is beneficial:

1. github.com/google/go-cmp is more annoying to...

This diff forward ports b606494db8a9293384efaf5c33a88601f6e1e2a6
to the main development branch...

See https://github.com/ooni/probe/issues/2122 for context.

* oocrypto is now using go1.18.3

* oohttp is now using go1.18.3

* probe-assets is now usin...

* refactor: move tracex outside of engine/netx

Consistently with https://github.com/ooni/prob...

The exercise already allowed me to notice issues such as fields not
being properly initialized ...

Tracex contained some fragile code that assembled HTTP measurements
from scattered events, whic...