There was no way to serialize-deserialize QIcon to-from QDataStream,
because the `QDataStream &o...

It conflicts with the one in qtermwidget when in superbuild mode.

Change-Id: I7531ffd4f2d5b2193bb6231c743ff0a074618b99
Reviewed-by: Lars Knoll <[email protected]>
...

Very hand to easily debug icon lookup.
It outputs:
* The name of the found icon. It may be d...

Reference: https://wiki.qt.io/Iterators

By default, it sometimes becomes possible to assign non...

Detected by [-Wextra-semi] and [-Wpedantic].

Port of the stuff from lxqt-build-tools.

* xdgiconloader-maint:
QtGui: eradicate Q_FOREACH loops [already const]
Optimize QIconLoader...

Profiling QIconLoader::findIconHelper() shows that a significant portion of CPU time is being sp...

(or trivially marked const) ... by replacing them
with C++11 range-for loops.

Change-Id: I3cce9...

Xdgiconloader maintenance.
Port of upstream qiconloader stuff.

Change-Id: Idac0b24631187063445ea5acfd078b2479359d52
Reviewed-by: Olivier Goffart (Woboq GmbH) <...

Avoid looking up by key twice in a row in various locations, but instead
using iterators and ind...

Change-Id: I7671b05f2e3c218870dca04f3ed52c231dbe4a9d
Reviewed-by: Marc Mutz <[email protected]>...

QLatin1Literal is just alias of QLatin1String for Qt4 compatibility.
So it's style cleanup patch...

lookup() method now takes QStringRef arg.
Reduce allocations.

Change-Id: I556d01be5c5f268672121...

For CoW types, prefer const methods to avoid needless detach()ing.

Change-Id: I88d08d499e1be72c...

It also adds the --no-undefined linker flag.
This is a port of Hong Jen Yee (PCMan) work on LXQ...

Rationale:
CMAKE_SOURCE_DIR is the directory which contains the top-level
CMakeLists.txt, i....

Use CMake policy NEW CMP0024 behavior.
Reference: https://cmake.org/cmake/help/v3.0/policy/CMP00...

* cmake-maint:
Remove duplicate use of source header files
Use AUTOMOC everywhere
Stop usi...

We don't need it.

Using target_include_directories().

All in one place.

1. Use as much of the Qt QIconLoader implementation as possible (do not
just copy-paste all of t...

We were not copying the XdgIconLoader private installable headers.

On some systems /home is a symlink and $HOME points to the symlink.
This commit allows the xdg-us...

* required-versions:
Updates version requirements in pkg-config (.pc) stuff
Make Qt5Xdg use ...

It also drops the QUIET option. The REQUIRED option will make it be verbose
anyway.
Use a more t...

They are part of the same package. They are meant to be used together.

LC_MESSAGES is the first in the hierarchy. Using LANG can lead to false
positives.

* remove "building with cpack" from CMakeLists.txt - not used anymore

* Added very basic .git...

And adjust structure a little bit while at it.

Adds gtk-update-icon-cache to the optional runtime dependencies.

* backport:
QIconLoader: Use the GTK+ icon caches
QIcon: add a hook in the engine so a non n...

It was always returning true.
Closes lxde/libqtxdg#98.
Closes lxde/lxqt#1081.

It was an implicit dependency as XdgIconLoader always support svg icons.
Let's make it explicit.

Loading icons is quite slow because we need to stat many files in many directories.
That's why g...

Implement it in the QIconLoader

We have to change detach() because some code does:
icon = QIcon...

It doesn't save any space, is not required for ABI compat
(because it's private API), generates ...

There was an attempt to allow static instances of QIcon in
7727a4355876607a1a022ff54e2570dae883f...

Currently all icon resolving is passed thru to the platform icon engine,
even in the case where ...

To avoid source-incompatibilites, wrap in QT_DEPRECATED_SINCE(5, 5)
in public headers.

Change-I...

We still have a bunch of Q_WS_ ifdefs in our code, which are easy to
mistake for Q_OS_ ifdefs wh...

Explicitly initialize all members.

After separating the iconloader engine there were no mean how to
use the qt5xdgiconloader separa...

Test some (not all, yet) of it.

It adds no value (anymore).

One time is enough!

* maint:
XdgDesktopFileCache: Check if a file isValid() only when needed
XdgDesktopFile: Rew...

If the allocation fails don't use the object.
If load() fails we destroy it and return a null po...

That assignment is never read.
When declaring the variable we assign it, although, we also not u...

Although in this case they are not needed, they "confuse" static analyzers.

It adds null pointer protection and reuses code.
Returns nullptr if a file isn't found or isn't ...

XdgDesktopFileCache::getDefaultApp() always returns valid files.

Avoids unnecessary string conversions.

* strings:
Replace the QString % operator by the + operator
No more implicit string conversi...

Without performance penalty.

We now use compile definitions to enforce it.

It can be used by Qt5Xdg and Qt5XdgIconLoader.

Very easy to do, but, hard to spot.

* Puts Qt5Xdg library in it's own directory: qtxdg

All changes are the strictly minimum neede...

We use const references where appropriate. Also made the container constant
when appropriate.

Benchmarking Qt applications indicates there is always a performance
penalty to using a foreach ...

Eat our own dog food.

It implements the desktop-file ID calculator.
Spec:
https://specifications.freedesktop.org/deskt...

XdgDesktopFile: Adds Exec fallback when DBusActivatable fails

We are deliberately violating the standard. The minimum we can do is to
document it properly.

This way '+' will automatically be performed as the QStringBuilder '%'
everywhere.

Just use the CMake BUILD_DEV_UTILS option to control it. Defaults to OFF.

We fallback to use the Exec key when the DBusActivatable fails.
Closes lxde/lxqt#967.

It allows a developer to start an .desktop file from the command line.
Closes #63.

The best time to find bugs is in development.

It makes it more readable.

Eat our own dog food and reuse code.

Although XdgDirs::userDir() already returns the default values when the
the values in the config...

A convenience, but handy, member.

The actualSize() always returned {0,0} if:
- the scalable icon (.svg) was found in directory not...

Based on Qt doc:
'Note: when dealing with remote objects, it is not always possible to
determine...

* There are no GPL2+ parts in the project
* qticonloader is licensed as LGPL with Digia-1.1 exc...

Also generate warning messages about errors.

If the path to the folder is empty we return the default value.
It's what xdg-user-dirs also do.

it is an optional enty of the specification [1]

http://standards.freedesktop.org/desktop-entry-...