github.com/pulsar-edit/watcher commits | Ecosyste.ms: OpenCollective

Loosen the ts_less_than checks to ts_not_equal

a96ec1b589709f8b4bcc5b37f6f3f6b3320593cd authored over 7 years ago by Ash Wilson <[email protected]>

Change in size === modification

8139e005a464ffd3a6593fbee07f7739c56330d8 authored over 7 years ago by Ash Wilson <[email protected]>

Different inode == delete + create

7d861c663b8e6646c6271feac4143aa3c06732f4 authored over 7 years ago by Ash Wilson <[email protected]>

Only report the stat flags we care about

31337b6872c27550482dcb80e6141bb35b05a0f6 authored over 7 years ago by Ash Wilson <[email protected]>

:white_check_mark:

3428ce43e83df6026a22fb3c6e2085828550cba5 authored over 7 years ago by Ash Wilson <[email protected]>

Polling mode cannot (currently) detect rename events

a65b95cd36abdf68324a84f45244d1178773c758 authored over 7 years ago by Ash Wilson <[email protected]>

Drop the default polling interval to 100ms

a0bd5722877d7144bbac6ab613ef3d9ea89e39cd authored over 7 years ago by Ash Wilson <[email protected]>

Delete missing entries from the DirectoryRecord on a scan()

f80832642e50d6deb7f08233d4f724365fec3dd6 authored over 7 years ago by Ash Wilson <[email protected]>

Test events with and without polling

c041a915bac08620f1402c51c319c0948b90e7c9 authored over 7 years ago by Ash Wilson <[email protected]>

Protip: stat stores entry kind in st_mode, not st_flags

4c57a7c4d1785ba6f77841a9cbd7ef515b71799f authored over 7 years ago by Ash Wilson <[email protected]>

Log stat results

5babab671749f2d0fe5bf9a1467d636bb0a6ee54 authored over 7 years ago by Ash Wilson <[email protected]>

Implement private DirectoryRecord constructor

AKA "How the hell is this working on non-Windows platforms"

e1eb265fa5665bc86b68023b3312afc8a744eaec authored over 7 years ago by Ash Wilson <[email protected]>

Use a little trick to initialize the dispatch table

60fc7afb7a6ec468c72661864786280a219029c3 authored over 7 years ago by Ash Wilson <[email protected]>

Finish Thread docs

5e2b7d7ef6d33b997fafb47322e8f9ecafa65aa1 authored over 7 years ago by Ash Wilson <[email protected]>

Document Thread because it's sprawling a bit

571ce77f5d3a0d1229ac039dc761e9b235a687ac authored over 7 years ago by Ash Wilson <[email protected]>

:shirt:

833fbeebef14c9b2c3a83927429a1e0101d68ecf authored over 7 years ago by Ash Wilson <[email protected]>

Mistyped assertions

f626a5c92369c623c4d479c890a4d74076025645 authored over 7 years ago by Ash Wilson <[email protected]>

Report thread states

1367d4d9a34897170ed4a950927684f790c326de authored over 7 years ago by Ash Wilson <[email protected]>

:fire: extra spaces in logging

c77c81586ec372a24ba9581327464905ed5712ec authored over 7 years ago by Ash Wilson <[email protected]>

Test polling thread configuration between states

d66684c8ce8ffe5f4021e3d5f995d904a81c388c authored over 7 years ago by Ash Wilson <[email protected]>

Use shared_ptr to manage AllCallback lifetimes

7b3f8a5d5214a997e4b94cdf9971c43d91dac14c authored over 7 years ago by Ash Wilson <[email protected]>

Ensure the done callback is only called once

3c39b88357c06b09c66a67cdde929be7fcb35a9b authored over 7 years ago by Ash Wilson <[email protected]>

Disable logs on disable :eyes:

56116b674a78da491889cd6d557d9bbc5ba5d2b8 authored over 7 years ago by Ash Wilson <[email protected]>

Store AllCallback's functions in a forward_list instead of a vector

This avoids invalidating function references when the vector is
reallocated.

add97743fa9e818e9544a6e1be20a96af7d40695 authored over 7 years ago by Ash Wilson <[email protected]>

Accept an rvalue in Hub::unwatch

c44946510de252ee29a6852767e9da013081a9f5 authored over 7 years ago by Ash Wilson <[email protected]>

Send messages to the correct thread, not just the worker

0760405448bed70ed1b1d038486a30a634e9d50f authored over 7 years ago by Ash Wilson <[email protected]>

Variable rename

990ed8d133eb1bed9f0e6307b5a6878472beaf9f authored over 7 years ago by Ash Wilson <[email protected]>

Threads can be printed to ostreams

b5fa96a617f5dbe3f68f616b364266e0a89562d1 authored over 7 years ago by Ash Wilson <[email protected]>

Give subclases access to an Errable source

4e88ba229626538800dfa23100f4f6fdd0ae616d authored over 7 years ago by Ash Wilson <[email protected]>

Explicitly propagate a successful Result as Result<>

37a537cde6c8c271a8c2706d7889c20a51748d71 authored over 7 years ago by Ash Wilson <[email protected]>

Add a test for polling configuration

1eb0e080686abec9e13fe2bc1fac4dbe21ba326c authored over 7 years ago by Ash Wilson <[email protected]>

Normalize polling options in JS

76629c40c89a62c1669b90bceef99c5bf1e1be89 authored over 7 years ago by Ash Wilson <[email protected]>

Handle events from both Threads

77a282ce35855f6731241c252871e1c31d5c69d6 authored over 7 years ago by Ash Wilson <[email protected]>

Avoid collision with NULL_COMMAND_ID

b29f74e326b9e7ffb036563d2594bf443bf3c11b authored over 7 years ago by Ash Wilson <[email protected]>

Unify send_xyz_command() methods

d9fed7f5c2fe6b32c8cc807a77325bd6599666fd authored over 7 years ago by Ash Wilson <[email protected]>

Rework the Thread hierarchy to account for threads stopping and starting

8608efa3a1ca41d9e34012f1ad5cb1ad0b6e7b05 authored over 7 years ago by Ash Wilson <[email protected]>

Reserve NULL_COMMAND_ID for "command that does not require an ack"

7ad86ffba0bde8d4acadfe4814d258760aa29342 authored over 7 years ago by Ash Wilson <[email protected]>

Add a "drain" command to tell the Hub to process dead letter messages

c984b6c566a03531522dfd0f30d4df36d2097561 authored over 7 years ago by Ash Wilson <[email protected]>

Static factory methods for Ack messages

e7be0e03d8b2f0a9183a0e1328bbefeb0226966d authored over 7 years ago by Ash Wilson <[email protected]>

:fire: useless "static"

807ec7c45ca63d6794da827fd9f73aaed2d8ea02 authored over 7 years ago by Ash Wilson <[email protected]>

ThreadStarter to defer commands sent to a stopped Thread

2baa4953568f52ffb806c3711802bcee1b06083e authored over 7 years ago by Ash Wilson <[email protected]>

Create missing destructor

86d09272d72e243a68da72202c716cfa63ba4c51 authored over 7 years ago by Ash Wilson <[email protected]>

Retain AllCallbacks until done() is fired

fe9aa7b1e55a8fa83b17cbf8bda83f19de8a090d authored over 7 years ago by Ash Wilson <[email protected]>

If you aren't storing pointers in integers it doesn't count as C++

b101d974e0db47f547cd236c9f0b0930f61c070c authored over 7 years ago by Ash Wilson <[email protected]>

Report the polling thread log file in unit tests

ffbbf3df884027f13b2dc64491335aec590c8951 authored over 7 years ago by Ash Wilson <[email protected]>

Various linker errors

7ce074a1d3e3095b3bdca98c404f4aa9fe54590d authored over 7 years ago by Ash Wilson <[email protected]>

Set the CommandOutcome flag instead of thread state

464a0e0fb85eb70e4fa3406c0c4ed471af275a97 authored over 7 years ago by Ash Wilson <[email protected]>

Join threads that are STOPPING

de9bc71b6ffbb1a55bea4b313af46235fd8a1486 authored over 7 years ago by Ash Wilson <[email protected]>

Update .watch() call sites

07598b9096dac08624530a2a2ac09f0e8aa40068 authored over 7 years ago by Ash Wilson <[email protected]>

Pass an options object to the entry point

dcb4962eb9dc187a531a72981ca578c8a1dde010 authored over 7 years ago by Ash Wilson <[email protected]>

Accept a {poll: [true|false]} argument in watch()

64483ccc6af794b9034df3cdd463643792496429 authored over 7 years ago by Ash Wilson <[email protected]>

Refactor Main into Hub and binding.cpp

79e5f6f9204843874dd999351c7a611489787ae4 authored over 7 years ago by Ash Wilson <[email protected]>

Split options object extraction into its own source file

92c29132ed6b25c7c5f64dd277881f3091df5ca0 authored over 7 years ago by Ash Wilson <[email protected]>

Use an AllCallback to configure both threads

004491a79465809aea238ddbaa7dc2bd293243c5 authored over 7 years ago by Ash Wilson <[email protected]>

Build the new files

ded60c1a32909a1b2c82ab7ad1a1cb5389cf8c03 authored over 7 years ago by Ash Wilson <[email protected]>

Create 0-n callbacks and fire a done callback when all are complete

6229f70b45cbd4706fb4378f6bd3a99e8b4a36f5 authored over 7 years ago by Ash Wilson <[email protected]>

C++ type jujitsu to use std::functions as Nan::Callbacks

26dfb8351a8b331146e4893186d41e70f998a3c3 authored over 7 years ago by Ash Wilson <[email protected]>

Include a PollingThread in the module entry point

48c60941fe26b8d836a38540d17ccb1c09d23307 authored over 7 years ago by Ash Wilson <[email protected]>

A bunch of logging

f68085cef629817e2cfdd0dde44b6c3d9f2f1ce0 authored over 7 years ago by Ash Wilson <[email protected]>

Tweak the information in each operator<<

b57cb93e86477cc9ca648c3c46f0bd4e2e018d91 authored over 7 years ago by Ash Wilson <[email protected]>

operator<< for PollingThread support objects

06c717b9d2874301e5f0fef3dec776d65f87c565 authored over 7 years ago by Ash Wilson <[email protected]>

Mark a DirectoryRecord populated after completing its first ENTRIES loop

b2051e3cc6196ffd127fe46643748a3301d84817 authored over 7 years ago by Ash Wilson <[email protected]>

Emit deletion events for entries that are missing during scan

670dec89816f0cd59100014f4cc5d92b0c79d06c authored over 7 years ago by Ash Wilson <[email protected]>

Move Entry typedef to message.h to be visible from DirectoryRecord

68eac73945c64eca093e88bacaf88959d73605d5 authored over 7 years ago by Ash Wilson <[email protected]>

Compare kinds with kinds_are_different() to account for UNKNOWN

5e3632879752d9d1fb35f888cd18a8864aed9a1f authored over 7 years ago by Ash Wilson <[email protected]>

Remember entry kinds reported by scandir()

829ee65220764e6a5a919c924cbd00bcd9eb2c49 authored over 7 years ago by Ash Wilson <[email protected]>

Cache DirectoryRecord paths throughout the ENTRIES phase

3fb8ca58f90f06c4110a4e8ad63dcff227f8cf8b authored over 7 years ago by Ash Wilson <[email protected]>

Reverse arg order in ChannelMessageBuffer constructor

For consistency with BoundPollingIterator.

58773487e340d20bddaf84bf3eb11faaf1c0e254 authored over 7 years ago by Ash Wilson <[email protected]>

Recursive, throttled filesystem polling

2400f50d9502e053bf2f88c607639539e5b9d3d0 authored over 7 years ago by Ash Wilson <[email protected]>

Cross-platform path joins

0b8c9a7ad23cc19545f5a9d0a20b5e162bd6c00e authored over 7 years ago by Ash Wilson <[email protected]>

Store a MessageBuffer reference in ChannelMessageBuffer

f32ee33badc01bf59018b91c6be3bbd3b4a366eb authored over 7 years ago by Ash Wilson <[email protected]>

Simple PollingThread test

c9c8809db45a516e92341edbb82c6ad06078bfcf authored over 7 years ago by Ash Wilson <[email protected]>

Stub PollingThread

ec744e0b9062edb39c9c52f41d926a2b56548b86 authored over 7 years ago by Ash Wilson <[email protected]>

Adapt different handle_commands() signatures

bd8856d1b733a93710fd35b8ce37af10ecd64a10 authored over 7 years ago by Ash Wilson <[email protected]>

Use inherited functionality in WorkerThread

e1a14f0a6f68f7ef873ba5c47e3215de74b9bbc0 authored over 7 years ago by Ash Wilson <[email protected]>

Collect and report polling thread status

139f9deec6ea223c330fd09c91f35a863bd2970b authored over 7 years ago by Ash Wilson <[email protected]>

Refactor common command handling into Thread

779817ddff0319b83eb8ea189de1d110ffda723e authored over 7 years ago by Ash Wilson <[email protected]>

Merge pull request #40 from atom/aw-macos-message-buffer

Use a ChannelMessageBuffer in the MacOS worker thread

ba9c15e08db6262cbd393cc5cb87f803b86f467c authored over 7 years ago by Ash Wilson <[email protected]>

Use a ChannelMessageBuffer in the MacOS worker thread

b49625c5cb7490840015866e9f9b3ee6359de1b7 authored over 7 years ago by Ash Wilson <[email protected]>

Merge pull request #39 from atom/aw-event-spec

Change the event spec to be consistent with Atom's watchPath events

febb9ae355d68e7ad7a48d18eee3c41c8fe672d0 authored over 7 years ago by Ash Wilson <[email protected]>

Missed an "oldPath" in the tests

13dc6c0f41f6299b6fb536dc2afdc573bfe1734a authored over 7 years ago by Ash Wilson <[email protected]>

Change JS object creation

615d1ec4834d5e70430e56b466e3e9cb8313d6af authored over 7 years ago by Ash Wilson <[email protected]>

Update other FileSystemPayload creation callsites

b81357e622b9101977b9afa43b3f5fb48a6347b0 authored over 7 years ago by Ash Wilson <[email protected]>

Update MessageBuffer convenience methods

8556d0b5708dafe7ff9f10ce023bba0d5068f82a authored over 7 years ago by Ash Wilson <[email protected]>

Missed the move constructor

a196d18faed7be8f42adab52b2bbda6fcf26bbfd authored over 7 years ago by Ash Wilson <[email protected]>

Rename member veriables within FileSystemPayload

1cdb26fd7e7d06d05731d549e8cc29059cdc439b authored over 7 years ago by Ash Wilson <[email protected]>

Unused oldPath fields are '', not undefined

eb637ff86544e1af209b935d2aad253faaf045fa authored over 7 years ago by Ash Wilson <[email protected]>

Translate native events to the expected shape

eebc4d270e152b74773d2445bcbb671eee4565a8 authored over 7 years ago by Ash Wilson <[email protected]>

Update tests first :notes:

4a9b1a01f9d6d1128de3242ea920f42c22df62ae authored over 7 years ago by Ash Wilson <[email protected]>

Update the lockfile

e38a6afb9a5d708f01f7b9b31f7d5edb00a97852 authored over 7 years ago by Ash Wilson <[email protected]>

Merge pull request #38 from atom/aw-separate-specs

Separate specs into multiple files

74c64ac75c0f386e0e1670df6fb9d514351a460d authored over 7 years ago by Ash Wilson <[email protected]>

Oh right Windows can't tell the kind of a deleted entry

2a306346c8e5262b0900a7d2b74ea87bdca81862 authored over 7 years ago by Ash Wilson <[email protected]>

Remove node-gyp hang diagnostics

ef06354e050c138c565175c6c76ab945013d5ef5 authored over 7 years ago by Ash Wilson <[email protected]>

Unwatching tests

2d8464c64086212996712090ac460206ae22304b authored over 7 years ago by Ash Wilson <[email protected]>

"watching" reads better than "watches"

1428f0bff7ea0a5d90f87e90ab0a07850b47f0a3 authored over 7 years ago by Ash Wilson <[email protected]>

Split out event specs

1079597e457c8e420bc7614b98b340632a22023d authored over 7 years ago by Ash Wilson <[email protected]>

Split out directory watch creation tests

7821a0b06d215f3ecf8db396a659e875cd19051e authored over 7 years ago by Ash Wilson <[email protected]>

Split out configuration tests

d02f9b0b90c10a1f14b31a00262631559716b07a authored over 7 years ago by Ash Wilson <[email protected]>

Refactor beforeEach and afterEach helpers into their own file

091d1cd4e76e555f4a6204d1c10c0d0da13d6d44 authored over 7 years ago by Ash Wilson <[email protected]>

Configure timeout in global and package.json

2bb9fec2dff80b67bcea01fb0f2a920b1e4e2f39 authored over 7 years ago by Ash Wilson <[email protected]>