github.com/sudo-project/sudo commits | Ecosyste.ms: OpenCollective

Fix --with-fqdn, the value should be NULL since it is a flag.

a014a2abd49f1540efc4d7b4e2bc2057903a8456 authored about 8 years ago by Todd C. Miller <[email protected]>

Add support for early defaults to the ldap and sssd backends.

16551031f9bd234a879badea84d994d87b758483 authored about 8 years ago by Todd C. Miller <[email protected]>

Repair symlink check in sudo_edit_openat_nofollow() on systems

without O_NOFOLLOW, it must be done relative to dfd. Previously
the lstat() would always fail, p...

cc31c2b2414548fc16f752b16204d3ad845b55c4 authored about 8 years ago by Todd C. Miller <[email protected]>

On systems that lack the O_NOFOLLOW open(2) flag, check in

sudo_edit_open() whether the path to be opened is symlink before
opening it. This is racey but w...

bf82b3f2ba37e3c8d02abb10cdf02727c94d188a authored about 8 years ago by Todd C. Miller <[email protected]>

Update debug_decl for sudo_edit_openat_nofollow()

Remove unused variables when O_NOFOLLOW is not present.

26635751180689744cb90010d0922774e486f119 authored about 8 years ago by Todd C. Miller <[email protected]>

Split set_default_entry() out of set_default() so we can call it

from check_defaults() to validate the defaults value. In visudo,
suppress warnings from update_d...

2c21663b2243359dfd985fbe61937f2fadec2a7f authored about 8 years ago by Todd C. Miller <[email protected]>

Split binding match code out of default_type_matches() into

default_binding_matches(). We can now use default_type_matches()
in check_defaults().

29d842dbaf09b02fa6e276131855949b97924042 authored about 8 years ago by Todd C. Miller <[email protected]>

Pass quiet flag to init_parser() and update_defaults() when doing

first parse of sudoers.

e0ac76647301a21df6047f8ea931e4396dd29469 authored about 8 years ago by Todd C. Miller <[email protected]>

Update defaults in visudo after sudoers has been edited so we pick

up locale changes. The init_defaults() function will now re-init
the sudoers locale.

256ca993b9ada7c067f0bb9915ecfdc36581583b authored about 8 years ago by Todd C. Miller <[email protected]>

Set sudoers locale before calling sudoersparse(). We don't need

to restore the user's locale since warnings are displayed in the
user's locale anyway.

65579b69eb3754d1e2ccb797d72c177d9b8d90bd authored about 8 years ago by Todd C. Miller <[email protected]>

Set the locale to the sudoers locale when parsing and restore the

user's locale afterward. Also set the warn/fatal locale helper
function so warning messages duri...

ef24bd5c3cec42ebf76cf3c5e7e38d54fb77fdc0 authored about 8 years ago by Todd C. Miller <[email protected]>

Add forward decl of union sudo_defs_val to silence a gcc warning.

6ba2769ba821f2deb0c3016f758e60aeee8a091c authored about 8 years ago by Todd C. Miller <[email protected]>

Set the warn/fatal locale helper function in sudoers_policy_init()

so warning messages during sudoers loading are displayed in the
user's own locale.

e257f2c9e32610e53b5d58a242487b1d3c63a0f9 authored about 8 years ago by Todd C. Miller <[email protected]>

Move sudoers locale callback function to locale.c and user it in

visudo and testsudoers.

b5c2ca2fe55b04e9c5bd8eb26a53c2056c73f249 authored about 8 years ago by Todd C. Miller <[email protected]>

In cb_sudoers_locale() actually set the locale in addition to storing

its name. Otherwise, it won't take effect until sudoers lookup time.

30f7ecca10c0f36cea91c58f30d4db2f22a754d9 authored about 8 years ago by Todd C. Miller <[email protected]>

Fix regression that would cause early defaults entries to be

set multiple times.

684161618d0e510ff4001c0a3723a03fe3405cc2 authored about 8 years ago by Todd C. Miller <[email protected]>

sudo 1.8.18

1349bb760b7bfa17baf9dccbb14b56fdea0e98af authored about 8 years ago by Todd C. Miller <[email protected]>

Only set early defaults once, regardless of how many times the

variable is set in sudoers. This avoids running an early callback
more than once. For example, ...

6daf3c5ce12ad4b8c0f3d6daa2ad6987fd2e5c88 authored over 8 years ago by Todd C. Miller <[email protected]>

Make strings const in functions that set defaults as they are

not modified.

5e9173df7a33927f8c6ad93f631bead709c7f6be authored over 8 years ago by Todd C. Miller <[email protected]>

In cb_fqdn() just return if the fqdn flag is set to false.

08e369572efe0743c8c4ff731ba8690098f1a809 authored over 8 years ago by Todd C. Miller <[email protected]>

Implement callbacks for defaults flags (T_FLAG).

7218dbe54201f6eb87972e44470be8880d835532 authored over 8 years ago by Todd C. Miller <[email protected]>

add debug_decl for cb_runas_default and cb_sudoers_locale

d92a396da5aac221fa8bdd9abc8ed3b45cc55181 authored over 8 years ago by Todd C. Miller <[email protected]>

Convert fqdn to a callback and add it to the list of early defaults.

36b18c6e6461ad136b34124b13fe48acc1c1792e authored over 8 years ago by Todd C. Miller <[email protected]>

Change defaults callbacks to take a union sudo_defs_val * instead

of a char *.

9b42640ef50e0bd5c532ce6230c949510679e6fc authored over 8 years ago by Todd C. Miller <[email protected]>

When updating defaults, process certain values fist since they can

influence how other defaults are parsed. Currently, runas_default
and sudoers_locale are process...

6ddc95a47c9668236b37c8722189613b7ddc2d48 authored over 8 years ago by Todd C. Miller <[email protected]>

Fix typo introduced in last commit to fix fill_args() overflow check.

eae8bc9d56542c87a546eb2ee1e536ff643d42eb authored over 8 years ago by Todd C. Miller <[email protected]>

Fix underflow checl in fill_args().

73b0ac4bc13af0072c67a6264725c55983e223ea authored over 8 years ago by Todd C. Miller <[email protected]>

Make sure we account for the trailing NUL when computing arg_size

in fill_args(). Bug #752

88ba54f478f4dd03fa99362ebd66c4c2ffd9cd67 authored over 8 years ago by Todd C. Miller <[email protected]>

Make arg_size and arg_len unsigned since we do bitwise operations

on them.

0f816c44017107d4b1f7d2e29c4587eeb4d82b35 authored over 8 years ago by Todd C. Miller <[email protected]>

Only remove backup files as part of "make uninstall" when INSTALL_BACKUP

is set.

6f5b8cf757958ad013db348649774f21ae62c509 authored over 8 years ago by Todd C. Miller <[email protected]>

Only keep backups of installed files on HP-UX where you cannot

unlink a shared library that is in use.

144e3bb53f21ae17cd231c5fe2b1ee7c335fd0ad authored over 8 years ago by Todd C. Miller <[email protected]>

Ignore a missing or insecure #includedir, it is not a fatal error.

19c80f8aee73d1ffc00091d7fda206f48e429dd9 authored over 8 years ago by Todd C. Miller <[email protected]>

Make sure we always call sudoerserror() on error in read_dir_files(),

otherwise sudo will not treat it as a fatal error.

026b403f27906ef8669098610701dec42132e10a authored over 8 years ago by Todd C. Miller <[email protected]>

Set the sudoers locale before opening the sudoers file.

Previously the sudoers locale was used when evaluating sudoers
but not during the inital parse. ...

7bfe2e7969494cc3ab3e6d00d7fe5568e62a9bb2 authored over 8 years ago by Todd C. Miller <[email protected]>

Add debugging

5a176e8509d2b623b4ea685319a0468965fb5ad2 authored over 8 years ago by Todd C. Miller <[email protected]>

Don't link test programs with the sudoers-specific locale code

if we don't need to.

c56d52ea621d856e23a1474bafa11c15c2ef1952 authored over 8 years ago by Todd C. Miller <[email protected]>

sudoreplay does not need to link with the sudoers-specific locale code.

cbd2cf290bc7630f875f211a94172ae65cc4f9a3 authored over 8 years ago by Todd C. Miller <[email protected]>

new_digest was prototyped as static but not explicitly declared

static.

81e33e1f562ff6a8ab1c7fa921cad3290c705088 authored over 8 years ago by Todd C. Miller <[email protected]>

Some versions of HP-UX 11.11 do not expose struct sockaddr_ext if

_XOPEN_SOURCE_EXTENDED is defined. Only define _XOPEN_SOURCE_EXTENDED
if we can still compile ne...

9cc354aae3b227aa3220b1ee9881b02fd995afb4 authored over 8 years ago by Todd C. Miller <[email protected]>

Some versions of HP-UX make will ignore suffix rules if they are

empty.

9c7680e01664a2c36266a0d54d862c0fee0dca92 authored over 8 years ago by Todd C. Miller <[email protected]>

Don't skip debug printfs in handle_sigchld() just because execve()

returned an error.

66ab525f1e91e3721752c6d81912ec8cdad7647d authored over 8 years ago by Todd C. Miller <[email protected]>

Add definition of nitems for those without it and use it throughout.

f683cbd582df4ed15a4d10fa56218e480be90016 authored over 8 years ago by Todd C. Miller <[email protected]>

Update copyright year.

ff2cd3cf277dce96c94f9778947697d72ef909b5 authored over 8 years ago by Todd C. Miller <[email protected]>

Sudo 1.8.17p1

c4118f66f412d68c3b2d314ac30da64e4597b413 authored over 8 years ago by Todd C. Miller <[email protected]>

Set user groups in exec_setup() if they were not already set by

policy_init_session(). Bug #749

ed9b457eb2c80dd8d94c4efd8e8fb174a2de1b86 authored over 8 years ago by Todd C. Miller <[email protected]>

Point the reader to the sudoers manual for the list of supported

arguments after the plugin path.

f98b481af2e1f8bf2245fb50b308a0ba7bef18d0 authored over 8 years ago by Todd C. Miller <[email protected]>

forgot to update date in last commit

3a85a8892f982cc47cf44ece71a2f7e7d7550905 authored over 8 years ago by Todd C. Miller <[email protected]>

Fix typo; cn=default should be cn=defaults

6c7eb07e0edeb939f37ef940813b0677d0f24043 authored over 8 years ago by Todd C. Miller <[email protected]>

Fold lines at 80 characters for the clean: target

72f18cff9a358850d92e87c385d555015a2aa787 authored over 8 years ago by Todd C. Miller <[email protected]>

Remove mksiglist, siglist.c, mksigname, signame.c as part of "distclean"

5348d32ab611e70e33eac3d4c0b3ec6bbcaf2e1e authored over 8 years ago by Todd C. Miller <[email protected]>

sync with translationproject.org

ea23932af0e8f86df86d651bdeaecd8bceb15904 authored over 8 years ago by Todd C. Miller <[email protected]>

LDAP sudoers doesn't support negated users, groups or netgroups.

d9e14bc659c6a923350dede96e814c3a40fa9cba authored over 8 years ago by Todd C. Miller <[email protected]>

Bug #746

63a242889254fa98704ac03fb6a647c1d7c32e1c authored over 8 years ago by Todd C. Miller <[email protected]>

When matching paths with glob(3), check returned matches against

user_cmnd first if it is fully-qualified. This avoids a lot of
needless stat(2) calls and avoids...

e2de0027dc4eed910312029c7232f6674bd52ff3 authored over 8 years ago by Todd C. Miller <[email protected]>

Add execve failure in pty bug fix.

74c2dc78066c08cd07cb15e66207b57abc74092a authored over 8 years ago by Todd C. Miller <[email protected]>

sync with translationproject.org

ce28b15ecad4105b20faff51fcb3e8df0b17ac5f authored over 8 years ago by Todd C. Miller <[email protected]>

In handle_sigchld() fix the return value when we've already received

an exec error. We don't want to overwrite the error status but we
do need to indicate that the c...

8a86233c16d788173def9e01c904c99aebb9c62b authored over 8 years ago by Todd C. Miller <[email protected]>

Move sudo_debug_execve() call into sudo_execve().

1ec4d9918d5d28f5d36ce37406d76287fcedee19 authored over 8 years ago by Todd C. Miller <[email protected]>

sync with translationproject.org

12ab5b810813fd705a0c2b079cde201928ca54a1 authored over 8 years ago by Todd C. Miller <[email protected]>

update for 1.8.17 final

bd8e3b5fb92482ced9c29c3a61d303003b5db46d authored over 8 years ago by Todd C. Miller <[email protected]>

Fix setting of hard stack limit when stack_hard is not specified

in /etc/security/limits. When 64-bit resource limits are supported
we can use the default value ...

1052a7205fce35455d3b75dbcfda81fdfe7836a7 authored over 8 years ago by Todd C. Miller <[email protected]>

regen

734b43c6b0745987c3fb5da7106ac6aaa3aff70a authored over 8 years ago by Todd C. Miller <[email protected]>

Ignore empty ipa_hostname

3169259821002f22016ac04dec78638301e9e8ae authored over 8 years ago by Todd C. Miller <[email protected]>

Better martching of ipa_hostname in sssd.conf

c6a21bd53d10ad8f5ec33d7cec815b6999ef46af authored over 8 years ago by Todd C. Miller <[email protected]>

Use the value of ipa_hostname from /etc/sssd/sssd.conf if present

instead of the system hostname.

9b027676c081e3769dbe7fb0966c3222ca3a91ab authored over 8 years ago by Todd C. Miller <[email protected]>

When matching host, short-circuit the loop when we get a match.

Only check username as part of the netgroup when netgroup_tuple is
enabled.

ccf88d3bb22fbb9804fd66bd4fb4ab6c168b10f4 authored over 8 years ago by Todd C. Miller <[email protected]>

Avoid using !strcmp()

a71cac91f2448168772d0627231006770e335b46 authored over 8 years ago by Todd C. Miller <[email protected]>

SSSD doesn't handle netgroups, we have to ensure they are correctly filtered

in sudo. The rules may contain mixed sudoUser specification so we have to
check not only for netg...

b6beccf19ef58ba0c246326994437fb26a2c6429 authored over 8 years ago by Todd C. Miller <[email protected]>

Return PAM_CONV_ERR from the conversation function if getpass returns

NULL or the user pressed ^C.

a24f4b8248510a30d7811906227dd0111b1c47fe authored over 8 years ago by Todd C. Miller <[email protected]>

Make base64 decoding table-driven.

7a35bab8c8a08e42ff8f5d3b5befe2cdc67a35b2 authored over 8 years ago by Todd C. Miller <[email protected]>

Back out cfa26b99228f, it was already fixed differently.

Caught by regress checks.

fc517ba9f890e8671e5d4cdda4134c9cffd64d8b authored over 8 years ago by Todd C. Miller <[email protected]>

Allow double-quoted groups and netgroups to be part of a Defaults spec.

From Daniel Kopecek.

6c3c03ea26ed7ef1e426eaa84fcc66b42daea430 authored over 8 years ago by Todd C. Miller <[email protected]>

The sudoers.ldap manual is installed in section 4 or 5, not 1m or 8.

Also fix the section for ldap.conf cross-references.

638acc28cf24f3aab52f282a3e953e1284173109 authored over 8 years ago by Todd C. Miller <[email protected]>

Fix copy pasta, "sudoNotAfter" not "sudoNotBefore".

Add missing word "order" in a sentence describing sudoOrder.

77331392e05d4877b05ae051290df38ac8b5793d authored over 8 years ago by Todd C. Miller <[email protected]>

For sudo -ll (long list) print the SSSD role just like we do

for the LDAP backend. Adapted from sudo-1.8.6p3-sssdrulenames.patch

461a419d046a582d17563318e26b4221a872f5f1 authored over 8 years ago by Todd C. Miller <[email protected]>

Setting timestamp_timeout less than zero only lasts until the

next reboot. Adapted from a RedHat patch.

c6b41b1657c29b138f3719ae5582dfffb5f4bdf8 authored over 8 years ago by Todd C. Miller <[email protected]>

sync with translationproject.org

77179d69ded45006d8d5373025d35421f1348169 authored over 8 years ago by Todd C. Miller <[email protected]>

fputs() is now specified as returning non-negative on success, not

explicitly zero. Fixes a failure on glibc.

53ebf69af3a75d2338307a6c1df2e849bd209d8d authored over 8 years ago by Todd C. Miller <[email protected]>

Don't try to dereference replies[] if it is a NULL pointer.

e93b4aa68135f8b4c3d6ce1e1c4aba5d8c4b6e28 authored over 8 years ago by Todd C. Miller <[email protected]>

sudo_version should be unsigned

db2c732931f8c03f996020f75fa893413f822b9c authored over 8 years ago by Todd C. Miller <[email protected]>

sync with translationproject.org

4d36fbec2ffe39199573671bb0f0abff659a9670 authored over 8 years ago by Todd C. Miller <[email protected]>

Korean translation for sudo and sudoers from translationproject.org.

63dbb74250daf3d704624ab172c39abbc16f487a authored over 8 years ago by Todd C. Miller <[email protected]>

Ignore PAM_SESSION_ERR from pam_open_session() since this can

apparently happen on systems using Solaris-derived PAM. Other
errors from pam_open_session() are...

5e1084c08a653c7103b51099035ed93625b5ac6c authored over 8 years ago by Todd C. Miller <[email protected]>

Don't read from stdin when flushing final buffers in blocking mode.

Reading from the pipe can block too if the other end is not closed.

356e74e1dbd9871287bd0dfb4a99efc02a82ed7d authored over 8 years ago by Todd C. Miller <[email protected]>

Mention visudo -x change.

e3514817df8561a5a93327144fcae0b50b9ecd31 authored over 8 years ago by Todd C. Miller <[email protected]>

There's no need to escape forward slashes in JSON output. While

it is legal to escape a forward slash, it is not required.

58ffab1dfa221123b95862496a550e1564899369 authored over 8 years ago by Todd C. Miller <[email protected]>

Document that in 1.8.12 sudo started being able to check the NIS

domain on Solaris.

ab861b92d267e4f078b6d4d4794c8ac077262a7b authored over 8 years ago by Todd C. Miller <[email protected]>

Better description of the I/O logging pipe issue.

ccece8c01da15b954d6643299886d91a44ab24e2 authored over 8 years ago by Todd C. Miller <[email protected]>

In del_io_events(), avoid reading from the pty master in blocking

mode. We now do two passes, one with SUDO_EVLOOP_NONBLOCK and
another that could block if stdin ...

8f694cc228ee2e7311357d5af6dbde73d5f116c4 authored over 8 years ago by Todd C. Miller <[email protected]>

Improve debug info in sudo_ev_add() and sudo_ev_del()

223b251c19b509b1e36b84d24f910e42564ca037 authored over 8 years ago by Todd C. Miller <[email protected]>

In pty_close(), call del_io_events with the SUDO_EVLOOP_ONCE flag

so the event loop will exit after a single run through. Otherwise,
we may hang at exit on non-BS...

994f86b40fac6773cef9168915b1aad575624629 authored over 8 years ago by Todd C. Miller <[email protected]>

regen

d8cfe6211336f1e8adad967167724e839c63f023 authored over 8 years ago by Todd C. Miller <[email protected]>

Bump I/O buffer size to 64K. We don't use PIPE_BUF or _PC_PIPE_BUF

for this because that corresponds to the value for atomic pipe
writes. The actual pipe buffer is...

38f4ba22499d77ea8aae55f125d07e28d3d6ffa3 authored over 8 years ago by Todd C. Miller <[email protected]>

I/O logging bug fix

fb247aa76a43635c6ef8456e134ec9e6036cbc5b authored over 8 years ago by Todd C. Miller <[email protected]>

Don't use SUDO_EVLOOP_NONBLOCK when flushing buffers at pty close

time, only when the user suspends sudo. Fixes a problem where all
buffers might not get flushed ...

3b6cb9d65ba64a70f39f4be11d1bb3a6a4d82ce8 authored over 8 years ago by Todd C. Miller <[email protected]>

Don't try to fflush(export_fp) or ferror(export_fp) if export_fp

is NULL, which can happen on the error path.

eb4510597bed7344f39bed2c37b02b11df33e7c1 authored over 8 years ago by Todd C. Miller <[email protected]>

O_NOCTTY has no effect when opening /dev/tty as the open can only

succeed if there is already a controlling tty.

a2e541aef8f39eb746e3e5ed605f42a8481ca87f authored over 8 years ago by Todd C. Miller <[email protected]>

Do not need to open /dev/tty with O_NONBLOCK, it doesn't block on

first open like a physical terminal. By definition, if you have a
controlling tty, the first ope...

3b39377246ac7b799590f2270864b4c660e7ee9e authored over 8 years ago by Todd C. Miller <[email protected]>

Use O_NOCTTY when opening a tty.

4e6b6fd0fa508672ef0d7f4ba2aebe31046762a6 authored over 8 years ago by Todd C. Miller <[email protected]>

regen

3161c05a04c12944e7f7408e6681f6fc4e773845 authored over 8 years ago by Todd C. Miller <[email protected]>