github.com/gerbera/gerbera commits | Ecosyste.ms: OpenCollective

std mem conversions

Signed-off-by: Rosen Penev <[email protected]>

537a053aebc14309bcb8ebef648f9396e8e6e984 authored over 3 years ago by Rosen Penev <[email protected]>

Add unit test for SQL statement generators

697ad6d750acf1a9824f255bb78c0b71f2fe4499 authored over 3 years ago by Matthias Straka <[email protected]>

Unified delete methods for simple deletes

fix clang-format

408323b25a5e0fc3ec1f9f738106e3c037796a8b authored over 3 years ago by Matthias Straka <[email protected]>

read autoscan ids as integer

fab189a63e66fe1628eee4c00524655a04501ec0 authored over 3 years ago by Matthias Straka <[email protected]>

Code review fixes

fix

b504abb9a80c459be19811c492e9b5139b34aba7 authored over 3 years ago by Matthias Straka <[email protected]>

std file conversions

Signed-off-by: Rosen Penev <[email protected]>

e27820871a283d179b172146156cfe35e1e23e4e authored over 3 years ago by Rosen Penev <[email protected]>

capture several lambda refs by value

value is the recommended way to do lambdas. Small size decrease.

Signed-off-by: Rosen Penev <ro...

dc1bee485a01807bc86dce79d1fb63506e87d45c authored over 3 years ago by Rosen Penev <[email protected]>

Replace stdio with fmt calls

b7c1490ebf09e3c4a7ae90194ead5b1d648af31a authored over 3 years ago by Matthias Straka <[email protected]>

Simplify AddUpdateTable vectors without shared_ptr

2ff072e18247edc8635ad72dc5769f5291e16adb authored over 3 years ago by Matthias Straka <[email protected]>

Code review fixes

b06e05ded68a0712e56a427ba38a61208e3138eb authored over 3 years ago by Matthias Straka <[email protected]>

replace several substr calls with startswith

These are used in boolean context.

Signed-off-by: Rosen Penev <[email protected]>

33dc273bb67cd36f632828523717f41025894bba authored over 3 years ago by Rosen Penev <[email protected]>

use std::int32_t

Signed-off-by: Rosen Penev <[email protected]>

59f6abdd5107b82390ef382374ca9fa005b10688 authored over 3 years ago by Rosen Penev <[email protected]>

Allow adding metadata from media file tags

Supports configuration of user defined upnp tags.

23fba241ee1b5cc2c2746ca8650e2c2683cf1d58 authored over 3 years ago by Karl Straußberger <[email protected]>

use string_view to remove strlen.

Signed-off-by: Rosen Penev <[email protected]>

3c4e5e50037b8a8548186c60f5f6e087783a83cd authored over 3 years ago by Rosen Penev <[email protected]>

replace strlen with startswith

Simpler.

Signed-off-by: Rosen Penev <[email protected]>

0b379fbee5c1f1ae2372af974776d1380c119ccb authored over 3 years ago by Rosen Penev <[email protected]>

use std::exit

Signed-off-by: Rosen Penev <[email protected]>

d0874fc07377832a0081c07bc56b673150ecf53d authored over 3 years ago by Rosen Penev <[email protected]>

use std::abort

Signed-off-by: Rosen Penev <[email protected]>

5141e76083be4af3c0b9950c48cc09f6a56cc257 authored over 3 years ago by Rosen Penev <[email protected]>

Handle defaults for col_int

std::atoi return 0 event in case of failure.
Logic before was more like isNullOrEmpty

Attempt t...

d3e061d9ece3bbc0205d12c99dc45203002a91d5 authored over 3 years ago by Karl Straußberger <[email protected]>

bring back quote(const char* str)

closes #1891

It is required by, e.g. quote(UPNP_CLASS_CONTAINER), which otherwise expands to qu...

392f9bebb69f66be146e8b29e8b170bef6ad3b79 authored over 3 years ago by Karl Straußberger <[email protected]>

col_int: remove default for null_value

2d0a8edf92a5de843775f447e5f3563a12f97c14 authored over 3 years ago by Karl Straußberger <[email protected]>

Downgrade libspdlog dependency to 1.8.1

98c523de7e276acea232fc0517328e7ec0554108 authored over 3 years ago by Matthias Straka <[email protected]>

Update instructions to match CMake requirements

Sync compile.rst with install script

67c10b98fca0a583e6814cd3182ede69138f97a9 authored over 3 years ago by Matthias Straka <[email protected]>

use std::system

Signed-off-by: Rosen Penev <[email protected]>

d7770de8d24ea8873bb984d445d333beb862ff03 authored over 3 years ago by Rosen Penev <[email protected]>

use std::strlen

Signed-off-by: Rosen Penev <[email protected]>

08f1bb1ac9f51bb049652de33c50b8752ce0dbd4 authored over 3 years ago by Rosen Penev <[email protected]>

change size_t to std

Signed-off-by: Rosen Penev <[email protected]>

14385a5f148ce583dae9f07ea7345d5dcd285f1f authored over 3 years ago by Rosen Penev <[email protected]>

const ref conversion

This can't be converted to an rvalue ref to force moves, so make it a
normal ref.

Signed-off-by...

60f930f3fe3aabe7042d6d44cf8a87b512816755 authored over 3 years ago by Rosen Penev <[email protected]>

more emplace conversions

No need to use operator[] aka try_emplace since this is going into an
empty map.

09129389858bb58c52a3b78606eff5d4f2de926d authored over 3 years ago by Rosen Penev <[email protected]>

taglib: demote warning to debug

Too much log spam.

Signed-off-by: Rosen Penev <[email protected]>

827fbd49d4a6c8acf6ecc8d72f5611a9f431db3d authored over 3 years ago by Rosen Penev <[email protected]>

rvalue conversions

moves are cheaper than copies.

Signed-off-by: Rosen Penev <[email protected]>

732c9d8ae1fe466060765edfbddca3c98efdac86 authored over 3 years ago by Rosen Penev <[email protected]>

move variables down

Found with cppcheck

Signed-off-by: Rosen Penev <[email protected]>

07d241d2132dca64f03b7a4b43fb0460e339ee11 authored over 3 years ago by Rosen Penev <[email protected]>

clang-tidy: remove redundant c_str

Found with readability-redundant-string-cstr

Signed-off-by: Rosen Penev <[email protected]>

e2b9b620d1923915454628a53b33cb41e7b1da59 authored over 3 years ago by Rosen Penev <[email protected]>

simplify it loop slightly

Add a continue to avoid some code duplication.

Signed-off-by: Rosen Penev <[email protected]>

488a0ee3e1e6536a07200c344e27b65d2429e26c authored over 3 years ago by Rosen Penev <[email protected]>

remove dead assignments

There's an immediate return.

Signed-off-by: Rosen Penev <[email protected]>

3fe1bfddd9e032c4ef167dffdbf35a179e787eea authored over 3 years ago by Rosen Penev <[email protected]>

clang-tidy: performance fixes

std::remove expects a reference, not a moved value.

Same with quote().

Signed-off-by: Rosen Pe...

5bbd8c76d857445f35e7b64f446c038fd47d3996 authored over 3 years ago by Rosen Penev <[email protected]>

fix wrong value being assigned

The variable name was changed but this entry was not.

Signed-off-by: Rosen Penev <rosenp@gmail....

457f0f4f32581b15bf6eeac2b5abf166cfa60184 authored over 3 years ago by Rosen Penev <[email protected]>

remove std::insert

The + operator can be used.

Also added some fmt::format conversions.

Signed-off-by: Rosen Pene...

4883dcb194dbad0ceb1d63f89d3fcdf5cf00f41e authored over 3 years ago by Rosen Penev <[email protected]>

replace loop with std::find

Simpler.

Signed-off-by: Rosen Penev <[email protected]>

1c0d276dfc2cea6778140804608adfbf9546aceb authored over 3 years ago by Rosen Penev <[email protected]>

simplify loop

Add a continue; to get rid of some code duplication.

Signed-off-by: Rosen Penev <[email protected]>

7e8fd9fbc2c6ba0e25507f4c05d1e422672248de authored over 3 years ago by Rosen Penev <[email protected]>

Remove seemingly unnecessary and heavily duplicated AND X IS NOT NULL in SQL logic operations

ec981f9c643d51c7fe7120acfeb2baeae461fae4 authored over 3 years ago by Tucker Kern <[email protected]>

Only return matches with distinct IDs when performing count search.

d51f95d372e8876fbca30b946450a0b45f744b1f authored over 3 years ago by Tucker Kern <[email protected]>

Remove "AND _t_._upnp_class_ IS NOT NULL" from expected output of SearchHandler tests

2cd03a3f73b6796cf613a2eaf0fbbc9f5cfc010f authored over 3 years ago by Tucker Kern <[email protected]>

Speed up Cds object updates

9c6f4c359ac874755777a766dcbcdc0a913e10ad authored over 3 years ago by Matthias Straka <[email protected]>

Avoid copying returned vectors

3d618030a526a3f3fb3dc91eb784a08e0fe3e8f7 authored over 3 years ago by Matthias Straka <[email protected]>

deprecate currently unused method

03823269d52f0b78a5a9ac28200f449cf946f107 authored over 3 years ago by Matthias Straka <[email protected]>

Prefer emplace when inserting into a new map item

86fd8e756f8a296091a7a76bbf2a86cf322ab275 authored over 3 years ago by Matthias Straka <[email protected]>

Do not copy AddUpdateTable data when reading

53bca5eb158f94ec6f5764f9665df2fae5d22806 authored over 3 years ago by Matthias Straka <[email protected]>

Ensure Root dir teminates with /

realpath seems to remove it in CI calls

92afece74b1e28cc6caa00a3b0185cf97879e2ee authored over 3 years ago by Karlchen <[email protected]>

Update build scripts to run on Raspbian

ff5ddb141dcb14cb04eabb58eacefccd81013dc6 authored over 3 years ago by Karlchen <[email protected]>

fix some weird memory leak

clang-analyzer reports that memory is leaked here. I have no idea why.

Signed-off-by: Rosen Pen...

eb5aafda7626adc6f7c7101cab048c9b160d8633 authored over 3 years ago by Rosen Penev <[email protected]>

remove last std::list

Removes compiler warnings on ARM regarding changed ABI.

Signed-off-by: Rosen Penev <rosenp@gmai...

92ca9ecd982166b337b8aa77953e178657a0b126 authored over 3 years ago by Rosen Penev <[email protected]>

remove some lambdas

Not really needed.

Signed-off-by: Rosen Penev <[email protected]>

ac30a907b0abccf43ccf4009d3567c0236038fa7 authored over 3 years ago by Rosen Penev <[email protected]>

std::shared_ptr<Executor> value conversions

Also removed the lambda and switched to normal std::remove.

Signed-off-by: Rosen Penev <rosenp@...

8635ebf1d012ce9f4b81ccfd8b8a7f6e505fd097 authored over 3 years ago by Rosen Penev <[email protected]>

add std::move for some maps

The constructor passes std::map by value. Also make the constructor
rvalue to force moves.

Sign...

b6126cc30a6fd61a541cad15ffcc774d03396d3e authored over 3 years ago by Rosen Penev <[email protected]>

use auto for Timer constructors

More readable to have the variable in front.

Signed-off-by: Rosen Penev <[email protected]>

e6af144be85c081b5923cb81d5252a863b4d63ff authored over 3 years ago by Rosen Penev <[email protected]>

rename several shadowed variables

Signed-off-by: Rosen Penev <[email protected]>

56e892f19ff56bdae165cf4ca073343d4c8b7f57 authored over 3 years ago by Rosen Penev <[email protected]>

use auto

Signed-off-by: Rosen Penev <[email protected]>

1cf0a7fb8e635b56741a471c78e37e12921db8a4 authored over 3 years ago by Rosen Penev <[email protected]>

splitUrl: use std::string

Small code reduction.

Signed-off-by: Rosen Penev <[email protected]>

852e0d136e4aea5e3eadfa0ce583175e71c1a33a authored over 3 years ago by Rosen Penev <[email protected]>

remove sort of redundant std::move

If the return type matches the function, copy elision applies. In this
case, since the types don...

918706d6336017f4b82e888ba09801487c5db6f9 authored over 3 years ago by Rosen Penev <[email protected]>

use string::npos

It's more accurate here than numeric limits.

Also fix port type.

Signed-off-by: Rosen Penev <r...

91927ac1cfa0d81a14365cb3694c9a0439ca5d02 authored over 3 years ago by Rosen Penev <[email protected]>

use C++ macro to check for starts_with

This evaluates to true under C++20.

Signed-off-by: Rosen Penev <[email protected]>

664534e7e6e4b00528b31b60874005c55e9d95d4 authored over 3 years ago by Rosen Penev <[email protected]>

remove left and rightTrimStringInPlace

They're both one liners and unused.

This seems to have been copy/paste from StackOverflow.

Sig...

d1050a2a25f5bf55460c6d7ed0cd79e1b1f0df5e authored over 3 years ago by Rosen Penev <[email protected]>

replace several usages of trimString

More efficient to do it in place.

Signed-off-by: Rosen Penev <[email protected]>

3fb40d2167f68dbee6e4cb5033bfda979efad945 authored over 3 years ago by Rosen Penev <[email protected]>

use C++ macro to check for to_underlying

This evaluates to true under C++23.

Signed-off-by: Rosen Penev <[email protected]>

d0a37a3c163b3cebd4be58884853bb2135e57f6c authored over 3 years ago by Rosen Penev <[email protected]>

Add Composer Tag to Metacontent Handler

f379b9f7ab7f98919db768677e876ea75282ec37 authored over 3 years ago by Miguel A. Arroyo <[email protected]>

Apply clang-format

bbb7c67acfc3c9250bc70ea6bbb21058ccd67767 authored over 3 years ago by Tucker Kern <[email protected]>

Eliminate warning about 2nd upnp_class variable hiding another by the same name.

3eebcad261d9c35682528b8d64b9adf48acacaff authored over 3 years ago by Tucker Kern <[email protected]>

Remove unnecessary braces

09cb2be91205711352db49f7464c33e52668a695 authored over 3 years ago by Tucker Kern <[email protected]>

Fix dangling pointer caused by taking c_str() of a temporary.

a1fc7eb4549edf5188f26dff5f967fb0bfb78f1d authored over 3 years ago by Tucker Kern <[email protected]>

Use std::string::npos for stringLimit check as size_t cannot be negative.

4bd22513e1128667e9162729a8bb0e5dea312f1e authored over 3 years ago by Tucker Kern <[email protected]>

Use a lambda to trim strings in renderObject

e0b635ed028fd33dd2bb1b204e750f15f70cab2a authored over 3 years ago by Tucker Kern <[email protected]>

Use auto for c_str() result

7ec1dec56c3a08e04e3864cbd21006e48d9214ae authored over 3 years ago by Tucker Kern <[email protected]>

gitignore: Add buildconfig

Used by GNOME Builder.

Signed-off-by: Rosen Penev <[email protected]>

87249198f21d99f40566d738be18264e979257e5 authored over 3 years ago by Rosen Penev <[email protected]>

use auto with constexpr