github.com/pmd/pmd commits | Ecosyste.ms: OpenCollective

Merge pull request #3577 from SCWells72/pmd-3576

b9f53ef56af9b504faeb01ab2206c91c99f62884 authored over 3 years ago

Merge pull request #3572 from SCWells72/pmd-3566

e67f2a04001a8b53b4c51a6b454a48176d1d77f6 authored over 3 years ago

Merge pull request #3571 from SCWells72/pmd-1089

e1d4a29e94b8e6a50dd31ca8ca307aa6a09ec654 authored over 3 years ago

Incorporated the code review feedback from another PR where applicable.

c919c4d05823df28fbaae0b5c1ce859ef0c62c2e authored over 3 years ago

Changes based on review feedback, specifically:

1) Only try to compile the configured pattern once if provided for both efficiency and noise sup...

dc0e1ee17f1e18123e8fd42ea66ca1fba2e0cd91 authored over 3 years ago

Merge pull request #3565 from lujiefsi:master

[doc] Fix resource leak due to Files.walk #3565

02af527026699b60aa304089ba657895054a471c authored over 3 years ago

Add @lujiefsi as a contributor

95e61c593338b5f2ac512ac0d33acb16a0c1fc8f authored over 3 years ago

[doc] Update release notes (#3565)

ad0233e9abff861a35280f0456dd5184c0907160 authored over 3 years ago

Fix missing import j.u.s.Stream

1cae88061dcdd765ef9f7ad49fa2cf3e68de3b78 authored over 3 years ago

Added a compiled pattern cache for the configured method name patterns. Fixed some checkstyle-reported formatting issues.

64595b801baff2f37fb133d5bfd4b2d9bb829041 authored over 3 years ago

Added information about an observed bug with authorization checks against sub-relations in static SOQL queries. Added a test case that reproduces the bug. Once the bug is fixed, the unit test expectation can be changed to provide both verification and a check against regressions.

873f3527b292aca1f524d9241bdcd1ca45cac4d3 authored over 3 years ago

Minor formatting corrections.

baad5701dc097e1cd8c792b51276da10f7f04baa authored over 3 years ago

Added a test to verify the *TypeParamIndex configuration properties.

b07686ae437b611f38e28a69ec9813055260d6b2 authored over 3 years ago

Minor clean-up from branch-to-branch merge.

2e0ea7161759ef1e7dff0e3e17566a1a157186d5 authored over 3 years ago

Added tests for read/queries. Changed to use set-based multimaps as duplicate entries aren't useful.

57626f44d2e878c9895d85778e366d7debf21dd8 authored over 3 years ago

Added support for undelete (except for ESAPI which doesn't support it anyway) and merge. Updated unit tests for this enhancement to include a combination of DML statements and Database methods.

4e1c17e2971494c05cea9b2f8c4d54debb2aab82 authored over 3 years ago

Issue 3576 - First commit for this work with support for most DML operations but not yet undelete (which doesn't seem to be supported at all yet) or merge, nor does it support read/query operations yet. I'll add those in subsequent commits, but I want to lay the foundation now that it seems to be in good shape.

b843242e47e26d1f33887cf5250705fd8e1b9e4c authored over 3 years ago

Issue 3570 - Added a new configuration property, 'reportInForLoopInitializer', that if set to false (default is true if unspecified) doesn't report an issue for multiple declarations in a for loop initializer.

c20db3388455aa921fc3b93e27ff23e9fdf95fb1 authored over 3 years ago

Issue 3569 - Added a new configuration property, 'reportInTestMethod', that if set to false (default is true if unspecified) doesn't report an issue for empty catch blocks in test methods that are commonly used to verify that an expected exception has been thrown.

d5711f518c09abd10fa22d859a1843925ddb2633 authored over 3 years ago

Issue 3568 - Added a new configuration property, 'reportEmptyVirtualMethod', that if set to false (default is true if unspecified) doesn't report an issue for empty virtual methods that are commonly used in abstract base classes as default no-op implementations when partial override/specialization is typical in derived classes.

ddd310eb63c07f317c9504ecc5c03eeeabbef5c0 authored over 3 years ago

Issue 3568 - Added a new configuration property, 'reportEmptyPrivateNoArgConstructor', that if set to false (default is true if unspecified) doesn't report an issue for empty private no-arg constructors that are commonly used in singleton and utility class implementations according to respective best practices.

ff6c178108129a7574fdb07bb5868e17b9857d20 authored over 3 years ago

Issue 3566 - Added a new configuration property, 'reportMissingDescription', that if set to false (default is true if unspecified) doesn't report an issue if the '@description' tag is missing. This is consistent with the dialect supported by ApexDoc derivatives such as SfApexDoc.

efbe149f21d52c49bd498d5bdeed9fefff71b3a8 authored over 3 years ago

Issue 1089 - Added a new configuration property, 'additionalAssertMethodPattern', that when specified is also evaluated against each invoked method name to determine whether it represents a test assertion. This will provide support for those who use testing facades such as sirono-common's Assert, or who encapsulate common assertions in local utility methods.

230fc4c805367a13afd6ca2c928b2489a175eb1b authored over 3 years ago

[java] JumbledIncrementer: Fix no ForInit in nested loop FN

e4b17d59fac004e482dec5e6d5aecc04fbea979e authored over 3 years ago

Merge branch 'pmd/7.0.x' into pmd7-update-JumbledIncrementer

9d4b918fe2eb893e24531e8f47bb24f35751aa92 authored over 3 years ago

fix resource leak due to Files.walk

3b791b49c7c729f23048cd71e3b02a5a81726074 authored over 3 years ago

[java] MisplacedNullCheck - fix false positives

e153880d3b2a28d9b2ff19a785a8abc0cb980f3e authored over 3 years ago

Merge branch 'pmd/7.0.x' into pmd7-update-MisplacedNullCheck

abd485b83e745df8893ff1263ccfc9acebd8cbf7 authored over 3 years ago

Merge branch 'master' into pmd/7.0.x

f9a012a8de99cee68cbacc55edf1fa9ebb2fd6a7 authored over 3 years ago

Merge pull request #3553 from adangel:pmd7-update-CloneMethodMustBePublic

[java] Update rule CloneMethodMustBePublic #3553

0dd1e39027c101e45cbe304ed2adf0f1837f411e authored over 3 years ago

Merge pull request #3552 from adangel:pmd7-update-CloneMethodReturnTypeMustMatchClassName

[java] Update rule CloneMethodReturnTypeMustMatchClassName #3552

3cfab917e599581779bc24abe530878a3ec74ced authored over 3 years ago

Merge pull request #3548 from adangel:pmd7-update-DoNotCallGarbageCollectionExplicitly

[java] Update rule DoNotCallGarbageCollectionExplicitly #3548

f1617884aa6880e1d0c6c5d59c9ee2b2badf2201 authored over 3 years ago

Merge pull request #3547 from adangel:pmd7-update-DontUseFloatTypeForLoopIndices

[java] Update rule DontUseFloatTypeForLoopIndices #3547

948e3bba74c6e41814754e275281dcc5692a73cb authored over 3 years ago

Merge pull request #3536 from adangel:pmd7-update-NonCaseLabelInSwitchStatement

[java] Update rule NonCaseLabelInSwitchStatement #3536

db8fe733d04a5d4a53a698098fe94ac41a9fcac0 authored over 3 years ago

Merge pull request #3535 from

adangel:pmd7-update-OverrideBothEqualsAndHashcode

[java] Update rule OverrideBothEqualsAndHashco...

1a099d1c4b0161c502c36de806b024f88641ed9c authored over 3 years ago

Merge pull request #3534 from adangel:pmd7-update-ProperCloneImplementation

[java] Update rule ProperCloneImplementation #3534

0dce4f1fc59f130021da6d1548e3bb30f162b393 authored over 3 years ago

Merge pull request #3564

docs: add essobedo as a contributor for code #3564

adaf0313114b15e5fac71ff617baf49e31d26f66 authored over 3 years ago

Merge pull request #3561 from

essobedo:3560/block-lambda-InvalidLogMessageFormat

[java] InvalidLogMessageFormat: False positiv...

5c9581113a35cde043ce4200b9d5d557fd65b45b authored over 3 years ago

[doc] Update release notes (#3560, #3561)

2fc8047edd0dc7d1ca4861eea61032df8d0efad2 authored over 3 years ago

docs: update .all-contributorsrc [skip ci]

8cffb660dccaa2801eb30f5745f8c6b2992697d2 authored over 3 years ago

docs: update docs/pages/pmd/projectdocs/credits.md [skip ci]

3ce8d0eba19e23f59fc8b022cdc9cbc5985856ba authored over 3 years ago

Merge pull request #3562 from adangel:update-danger

Bump danger from 5.16.1 to 8.4.0 #3562

34b13ebbc7ab71b4dcad3ac1321bd70549e77c7a authored over 3 years ago

Bump danger from 5.16.1 to 8.4.0

740968461a2e814188bd9524a6511a928c73cba4 authored over 3 years ago

Revert "[ci] Remove DANGER_GITHUB_API_TOKEN"

This reverts commit 23e5e2d8b478133fec4149d9bd0e7d35c0335640.

We still need a separate token fo...

cbba7ec05c373315de2f1593dd38c909890bb1be authored over 3 years ago

moved libDirectory setting for kotlin to pmd-kotlin pom.xml

bf10da5444fb4ead8eb6f9fc4f71087485bea6a5 authored over 3 years ago

fix checkstyle issues

faeffd4f17868e45cdd7ae9883c1428bb7159f8a authored over 3 years ago

added kotlin Simple parser test

97eeac0daa5d25885f2b9c5c199277c3e9da7012 authored over 3 years ago

added kotlin xpath function 'pmd-kotlin:hasChildren(3)' as test case for custom kotlin xpath functions

a2e9d2b65294068063091bed255c83ff8aef199f authored over 3 years ago

[java] InvalidLogMessageFormat: False positive with message and exception in a block inside a lambda

afab7d7881e34524e849be16b9b0815012cbc507 authored over 3 years ago

Use GITHUB_TOKEN or deploy key

Also use [email protected] as committer email.

4bfb35cb86b046e35084f4b664c377500f4d6b46 authored over 3 years ago

[ci] Remove DANGER_GITHUB_API_TOKEN

23e5e2d8b478133fec4149d9bd0e7d35c0335640 authored over 3 years ago

[doc] Visualforce type resolution

35f3f3f51750ab9aacd0a38e349a778104a2e769 authored over 3 years ago

[doc] Add a warning box in major language contributions

39807f325f28184fa55b593949be9d0c66f4c176 authored over 3 years ago

[java] Update rule ClassCastExceptionWithToArray

74a283e928516173f47ee22d4732095f33c0dc78 authored over 3 years ago

Fix unit tests

89e86391adc32b551075cbed872ef3209f81bec9 authored over 3 years ago

Merge branch 'master' into pmd/7.0.x

4a221d2e12c873d8779a9bf9b67c52fd82d59957 authored over 3 years ago

[apex] Fix errors due to jorje update

ad951bcb851b14d71689426125218947a12534cc authored over 3 years ago

[apex] Update jorje to version 54.0 (Spring '22)

72f17b51c6f3a65e079fb41d1b3f37ff17a10bf2 authored over 3 years ago

[doc] Fix old release notes for 6.37.0 [skip ci]

71a69bec667e05b9d5966defa03ac56d1d2388cd authored over 3 years ago

Merge pull request #3549 from

smyachenkov:addemptystring-anotations-ignore

[java] Ignore AddEmptyString rule in annotations #3549

eb1f30cd660e02bed7079d26b30fb76ca6ed6026 authored over 3 years ago

docs: add smyachenkov as a contributor for code #3554

b8584aa90a2d2656f59aae7cdc8023f902644a80 authored over 3 years ago

[doc] Update release notes (#2364, #3549)

ae877b38632b8cdf774f1deabd2633e56b0fe65a authored over 3 years ago

docs: update .all-contributorsrc [skip ci]

a92970699777815ebb107d42175a2fd30389d220 authored over 3 years ago

docs: update docs/pages/pmd/projectdocs/credits.md [skip ci]

e5c951d8fc93d661792bfcc766f96d36ed8805cd authored over 3 years ago

Merge pull request #3538 from jonathanwiesel:consistent-describe

[apex] New rule EagerlyLoadedDescribeSObjectResult #3538

7e542135c5172f678b13acb01423e97a6ff3cc65 authored over 3 years ago

[doc] Update release notes (#3532, #3538)

eeaa300b7bfb09dbbb023c319c92f2f1b958536b authored over 3 years ago

[java] Update rule CloneMethodMustBePublic

78c61600f75a90d4ca3e2c20523703c625d64fd3 authored over 3 years ago

[java] Update rule CloneMethodReturnTypeMustMatchClassName

bc6c8bd578f2e16e8848238f50d46f545b45a911 authored over 3 years ago

[java] CloseResource: fix NPE with null literal

9b9009f59bb0ee1434e5166642e1c3d3aedb2be5 authored over 3 years ago

added FunctionNameTooShort test in bestpractices category for Kotlin, with unit test cases

4fbf4fb580dd02299981ca0dd81cae245683da24 authored over 3 years ago

upped antlr plugin version, fix AST errors by using separate UnicodeClasses.g4 file, added <libDirectory> to maven antlr plugin to make it work

1a36a7cc555390ad6ef771d391b5d016255740dd authored over 3 years ago

[java] Update rule CloseResource

2d6595d6033ff91f6a3f2851fcdc6a75e88bcad4 authored over 3 years ago

update testcase

becd447a4a225dbfc1f48410107f87d19e67a1dc authored over 3 years ago

Ignore AddEmptyString rule in annotations

83dfeb5533ff030615afb6a6e9e20f74364192fb authored over 3 years ago

Fixing docs and add other describer fetcher

c331fa1a8d18cae20cfc8ef9edf51ae130931223 authored over 3 years ago

[java] Update rule DoNotCallGarbageCollectionExplicitly

c1a347bead9388b12f333ab3f17389528563789d authored over 3 years ago

[java] Update rule DontUseFloatTypeForLoopIndices

45e291a7cbc24dbb43a76cfac7060bbd6d32243d authored over 3 years ago

[java] Update rule JumbledIncrementer

77fbd275500f41bd674caa9590ba3c2fe225f735 authored over 3 years ago

[java] Update rule MisplacedNullCheck

12286b52bbb96ea7d36fe38b8885830d364897f0 authored over 3 years ago

Merge pull request #3533 from adangel:pmd7-update-ReturnEmptyCollectionRatherThanNull

[java] Update rule ReturnEmptyCollectionRatherThanNull #3533

34b41a952c6af9fb5866b15d968490e4afa6889b authored over 3 years ago

Merge pull request #3530 from

adangel:pmd7-update-SingletonClassReturningNewInstance

[java] Update rule SingletonClassReturnin...

727da617c3bf62ad1e643d4d02a5f49bc404f472 authored over 3 years ago

Merge pull request #3525 from adangel:pmd7-update-UnnecessaryBooleanAssertion

[java] Update rule UnnecessaryBooleanAssertion #3525

5643659555ba5873b086a15185850c782285d653 authored over 3 years ago

Merge pull request #3529 from

adangel:pmd7-update-StaticEJBFieldShouldBeFinal

[java] Update rule StaticEJBFieldShouldBeFinal #...

8eb80ea2e58eb06732b8c9745017c76a84a39e36 authored over 3 years ago

Merge pull request #3527 from adangel:pmd7-update-SuspiciousOctalEscape

[java] Update rule SuspiciousOctalEscape #3527

24ab5abb66bd560179b5d4633de54505f6b22fba authored over 3 years ago

Merge branch 'pmd/7.0.x' into pmd7-update-UnnecessaryBooleanAssertion

84f484318a98724db066900a8ee18e2730379a72 authored over 3 years ago

[java] UnnecessaryBooleanAssertion - fix overlapping with ...

... SimplifiableTestAssertion

Fixes #3087

a0da5f35e383f82b737c6f56f207b9d684ae6038 authored over 3 years ago

[java] SuspiciousOctalEscape: Improve rule message

a16cd764f63170106b9ce34fb87d397d65e70821 authored over 3 years ago

Merge pull request #3528 from adangel:pmd7-update-StringBufferInstantiationWithChar

[java] Update rule StringBufferInstantiationWithChar #3528

49f7e5f17ec3ba669b6491a33448d8b7e240a309 authored over 3 years ago

Merge pull request #3526 from adangel:pmd7-update-UnconditionalIfStatement

[java] Update rule UnconditionalIfStatement #3526

d9d2866c2f5397b2c5a43d96e83aa6c93de77aa5 authored over 3 years ago

Merge pull request #3524 from adangel:pmd7-update-UnnecessaryCaseChange

[java] Update rule UnnecessaryCaseChange #3524

12cc2b91aba623580d9ef4bbfc39ec7bdff2d6a7 authored over 3 years ago

Merge pull request #3523 from adangel:pmd7-update-UnnecessaryConversionTemporary

[java] Update rule UnnecessaryConversionTemporary #3523

b286584cd5a3bd71a59c0bd96e64b3af9711d205 authored over 3 years ago

Merge pull request #3522 from adangel:pmd7-update-AvoidAccessibilityAlteration

[java] Update rule AvoidAccessibilityAlteration #3522

fda1501cf4f4eb6550f41f5c435689d78fe2dce2 authored over 3 years ago

Fix stack overflow error

202079eeca9e9f877d0e5fc89bc51df93509602a authored over 3 years ago

[java] HardcodedCryptoKey false negative with variable assignments #3368

701938de1cf19fc02b34b1100fb654c0bb4a19cd authored over 3 years ago

[java] MissingOverride: False negative for enum method #3542

Improves type resolution to support enum constants

a1a358619ce505fc3e222f3c348b72400b3035fd authored over 3 years ago

Add GetDescribeShouldUseSObjectDescribeOptions Apex rule

bd479e4cc44612a58b56dd56a2cada86c11590fc authored over 3 years ago

Merge pull request #3483 from adangel:pmd7-update-UseCorrectExceptionLogging

[java] Update rule UseCorrectExceptionLogging #3483

cb1d840c0fa18f317fd06e472672d2ac5d9cad04 authored over 3 years ago

[java] Update rule MissingStaticMethodInNonInstantiatableClass

d81e1d93339a9a4e9c77538962a97420ae7bc09b authored over 3 years ago

[java] Update rule NonCaseLabelInSwitchStatement

582816893404490bd830d1874bc515814deb0426 authored over 3 years ago

[java] Update rule OverrideBothEqualsAndHashcode

dc3fedd306fca5dc9bc90056f4cffc2d05d98a03 authored over 3 years ago