github.com/shakacode/react_on_rails commits | Ecosyste.ms: OpenCollective

Merge pull request #112 from shakacode/update-linters

Update linters to conform to ShakaCode standards

48e117d2b591e2866769e71708e51c079eb9865e authored about 9 years ago

Update linters to conform to ShakaCode standards

This change is in parallel with the change made for the webpack
tutorial.

See https://github.co...

3573d80ff8d8cbcfd18052217da2672e0124013e authored about 9 years ago

Merge pull request #113 from shakacode/ryanaip-data-tags

Use data attrs when rendering react_components instead of script tags

4f5c51b14e415621ec585cda59bf5437dbe192c1 authored about 9 years ago

Change class matcher to js-react-on-rail-component

* Avoid any chance of conflicts with a user desired class name.
* Set display:none on the div wi...

68246ea0c7bf3d990b701b799864031e4ccf48a9 authored about 9 years ago

Props on server not sanitized

Because that is to prevent XSS when JS is put in HTML.

166e42e7b874e8073f39b58f6cf0e50470f209fe authored about 9 years ago

Use data attrs when rendering react_component's

Client side rendering scripts do not get called when using the forward/back buttons with turboli...

df8d8312dc3823ca72d46415afe9145a79bffd37 authored about 9 years ago

Merge pull request #103 from shakacode/remove-global-variable-for-props

Removed unnecessary global exposed window variable

75180ab5bde6c424ebee8056eda60e0c945a365b authored about 9 years ago

Update style.md

ac41379503cc41161cac5accb2f0af3ab60cfb59 authored about 9 years ago

Added links to Ruby and JS Doc

fd507944ad03a0cd5d16661b39925c88a31367b1 authored about 9 years ago

typo

3b9c877df2209c9b93dc25545a5a943f224fd67b authored about 9 years ago

Add reference to Abramov article

3fdee4a38ccad8c5be47b36298653cc24be6b12a authored about 9 years ago

Update react-and-redux.md

fc4ec2393238f23a682005df8923e2978622dec7 authored about 9 years ago

Update and rename generated_client_code.md to react-and-redux.md

189e00be329ac8e155d627740ff0c9559b6c8c08 authored about 9 years ago

Create README.md

103599bb31746320666440babc208c880c554b74 authored about 9 years ago

add linters and style guide

0ede906b5a28900ded0c81f35b24770b226f2d29 authored about 9 years ago

Removed unnecessary global exposed window variable

Props is passed to component, so no need for the globally exposed props.

This was probably some...

76966dc0667d1da45c0f5e07a3d27bce3e8311b9 authored about 9 years ago

Updated Gemfile.lock

b5cb83eb6540bcb049bdba3fb756fe8e11c592e9 authored about 9 years ago

Bump to 1.0.3

cc3ced383688c5167ca24d43036e486ac2cc1119 authored about 9 years ago

Merge pull request #101 from shakacode/fix-missing-new-line

Fix missing new line at end of Gemfile for generators

213fd8049840387f32bdb626e20fbde29a5acea5 authored about 9 years ago

Fix missing new line at end of Gemfile for generators

184b9d0223ccddf3ca0e0c06c741528de7f9b0c7 authored about 9 years ago

Merge pull request #100 from shakacode/add-puma

Make Heroku Generator Optional

b0eb69edcc9e25a281c032d519542996bebc9fc9 authored about 9 years ago

Add Puma to Heroku Deployment generator and disable generator by default

5ca833786e5f55f7d524eee059a5d31a66cccd2f authored about 9 years ago

Merge pull request #97 from shakacode/mapreal19-fix-generated-linters-task

Fix generated linters task

36b97db046b1c0a7206cac2bf2a5157482930232 authored about 9 years ago

Fix generated linters task

cf4444db8d5e81d83a1dcea65b684b0e93884121 authored about 9 years ago

Updated Gemfile.lock

f5aa771416f0c6a9b4c4e2f2d5fcd01652605954 authored about 9 years ago

Bump to 1.0.2

6d6e0e3f384b57a73853fc6520930d25fb05ccb0 authored about 9 years ago

Merge pull request #93 from shakacode/update-readme

Improve README and link to the v1.0.0 generator results repo

ce48c2f55a020447bbe3994733b907cb929ffee3 authored about 9 years ago

Improve README, link v1.0.0 generator results repo

* Make generators not include 'Client' suffix when there is no server-rendering
* Add heroku_dep...

1f25003af6f6a0c0333aee1aeba4d18cbd57f510 authored about 9 years ago

Merge pull request #88 from shakacode/recognize-application-scss

Improve generator functionality related to `application.scss`

- Generator now allows for user...

9c16d9be95cc524fe2a48cb45198babef9515912 authored about 9 years ago

Make generator create its own application.scss if none exist

4baed7eff4a43ad67c1d8d5f0db589bd41f83d3d authored about 9 years ago

Make generator recognize application.scss in addition to application.css.scss

Fixes #86

We're just forcing any version of application.css or
application.css.scss to be appli...

84723f7ce56a59a7b12414f009fc15c25a7caede authored about 9 years ago

Merge pull request #90 from shakacode/refactor-logger-middleware-generation

Refactor logger middleware generation

cf3ec9b1743c5bd1afff49a5024767f73a628c58 authored about 9 years ago

Switch loggerMiddleware back to using 'result' variable

61e0bb1118cadedfa89340affbdb54aaa77b20e3 authored about 9 years ago

Use JSON.stringify in loggerMiddlware

613f0d95e2882249c8599e8ca97a5f43ad8c0bdc authored about 9 years ago

Merge pull request #87 from shakacode/improve-linter-generators

Improve Linter Generators

f50b5c04f09e69606705c6d849052f2c3f6ef77b authored about 9 years ago

Add --redux class option to base generator

Without this class option, client/package.json will be unable
to access the `options.redux?` met...

1d4227983c1229947aa06899c6c5e5f50397d01b authored about 9 years ago

Fix error in loggerMiddleware

4b65c0543604fe1a74b3fbc9d17483051754e743 authored about 9 years ago

Use a single client/package.json template instead of two different filesfor react and non-react generators

36162124f25d1d1f7a79ffdd5cba70ebfb938a2e authored about 9 years ago

Fix generated code to pass JS linters

b42eb5bafc28041361ca4eef3f5783be7ec7a6d4 authored about 9 years ago

Use better ERB syntax in package.json

d1a18fa28c6707f9fa2fc98891bc4bf63e74e356 authored about 9 years ago

Include comment in Server.js about needing to install dependencies if doing async

7914fd25c4c4ccbfa7eb865f1b1ca42541393ac2 authored about 9 years ago

Split linting into two generators and enable JS linting by default

7ed130c048c2cdecfc03986098bf32100a1e1146 authored about 9 years ago

Implement templating of lib/tasks/linters.rake to handle all scenarios

3d32699240a1738517a1538b83c703fb8107c4c2 authored about 9 years ago

Remove unnecessary comments and improve description in install_generator

592c09643aacb9a27abb7ce9ddd250e791305f6c authored about 9 years ago

Add missing ruby linter files

665edc24c346b359531ad078835a2821bb70f63f authored about 9 years ago

Merge pull request #83 from rupurt/clobber-all-files

Clobber all files in generated directory

36d7773e4d607dcc9fbeb0b77499fe58feadf47d authored about 9 years ago

Clobber all files in generated directory

b8dba1c7c40ec72c03e6b22a25e6891db3ab34df authored about 9 years ago

Merge pull request #82 from shakacode/change-linters-default

Linters are no longer the default.

Because we do not have automated linter tests for the gene...

dfa3295c4c5759344d53bf7177d08e6ca9720fc4 authored about 9 years ago

Linters are not the default

Now you have to specify

--linters or -L

to add linters

383e31d536051c157114abf0ba9af9ab160cb030 authored about 9 years ago

Merge pull request #81 from rstudner/update_eslint_rc

lodash / _ has to be excluded from the minimum 2 rule.

0ba27a8c7cd1efa58cdaae6658bbf828146cc242 authored about 9 years ago

lodash / _ has to be excluded from the minimum 2 rule.

70995a25bee55fa5bcbdad432fb7ae8289e2cd35 authored about 9 years ago

Updated Gemfile.lock

ce6918e8d63521344bb6ee82e4eda169bd4eb11f authored about 9 years ago

Bump to 1.0.1

33b011272c1f62f45296f6b5143fb3eb08469e33 authored about 9 years ago

Merge pull request #80 from rstudner/fix_generator_development_mode

fixes the variable name change

e8240bb204f62c0a47e86ca3ea8af6f3f39f6b99 authored about 9 years ago

fixes the variable name change

8542bfa47d3b72c523f8feb0eef7dbb10e212ccf authored about 9 years ago

Updated Gemfile.lock

802482e9b4de01f0abfeda3ce9fbb7a0c691467f authored about 9 years ago

Bump to 1.0.0

e0135efed4c607ef178af896980a8bdeb6ac16fe authored about 9 years ago

Merge pull request #70 from shakacode/add-generators

Add generators

bacc78a3edaa8cd4763d1398bc68ce4a217ee53e authored about 9 years ago

Add Generators

Adds a Rails generator for installing everything needed to get up and running.
The generator inc...

6772a4f726681879a153414065697ca366a52cad authored about 9 years ago

Merge pull request #75 from rstudner/server-reload-bundle-fix

Server reload bundle fix

1044c8ed5610751cd893836a5d298a7872263553 authored about 9 years ago

Merge pull request #77 from shakacode/log-detailed-message-to-console-if-server-js-file-missing

Detailed message to console if no server js file

08dd095c7e05745be3a62d8d059760984dc3876e authored about 9 years ago

Detailed message to console if no server js file

Added details on how to avoid this message.

9bf4551bae34d0ef4e371a238de0e2f01d1978c0 authored about 9 years ago

remaining two comments.

115430d9ef016b6aa737e264499b9ebc38e42ea8 authored about 9 years ago

variable name change.

f2a314e7818261f4a304163171c21b9ff289394d authored about 9 years ago

break up terinary so lint doesn't scold me.

a33a96b5c755284c05e32b370ad3ef110c85c533 authored about 9 years ago

two line length changes.

332bb5d34f019f67d9913864ecc2108a81eecb4a authored about 9 years ago

move server bundle modification check code to ServerRenderingPool

Conflicts:
lib/generators/react_on_rails/generator_helper.rb

1ee55a271feb6d0639c8975590504627155d7416 authored about 9 years ago

added check for development to reload server bundle ever time it changes. changed links in readme from shell to markdown links. moved linters order

Conflicts:
lib/generators/react_on_rails/linters_generator.rb
lib/generators/react_on_rails/te...

a76408d23df205e3ee19a4c7529188005941a82d authored about 9 years ago

Merge pull request #73 from shakacode/default-rake-task-lints

Make default rake task run docker:lint

455bb4f61d501a6186856cde8d92268c45b6103c authored about 9 years ago

Make default rake task run docker:lint

a8d2166e3568c770ac20bfd8771d8018ca80c663 authored about 9 years ago

Merge pull request #66 from robwise/add-unit-tests-to-helper

Add unit tests to helper

19d125e69aaa05570ef87cebc54ed09544f526e6 authored over 9 years ago

Fix whitespace issue when rendering JavaScript

We were using the `html_safe' method which was, for some reason, adding whitespace. I have switc...

8c04ed24c9974df19e604a860e4c4b42e1500b43 authored over 9 years ago

Added some basic test coverage for the helpers

- Resolves #5

4938990aea6e11d925a8b8acd9a801e6bce58d49 authored over 9 years ago

Fix failing tests

e9543ccecb1ba0a0ec184cd8bcea03d569989ca1 authored over 9 years ago

Merge pull request #67 from shakacode/docker_ci-coveralls-reporting

Docker ci coveralls reporting

7e4fcf1611457de6565e4c12e98af55dbad07e75 authored over 9 years ago

Adjust travis.yml to only use docker for linting

e88dd74d5d4a633cb0fce4d39c8f1cbe649a259e authored over 9 years ago

adjust travi.yml for Xvfb config

fbff374e4b677e7e640179119192ea2b0724164e authored over 9 years ago

Adjuse rake task :dummy_react_013 sh command

09d0582553de9690ec4c55c04ed646813ed2d4b0 authored over 9 years ago

Fixed long line and missing update to Gemfile.lock

Missing update to Gemfile.lock in tests.

57b1c4b4cb7fb423e9d510dc60f06ad5f98dc85c authored over 9 years ago

Merge pull request #65 from shakacode/Update-docker

Update docker for CI, Test, and Linting

d12b50f603c72c35760203d610f18674d08ee3af authored over 9 years ago

Merge pull request #64 from robwise/tune-coveralls

Tune up Coveralls and SimpleCov

f2099bfa5530eab5fa3950e0bb8081f02ebd830e authored over 9 years ago

Tune up Coveralls and SimpleCov

52306dd6e0248d2a74f46e125c0a3cd654db23ef authored over 9 years ago

Edit .coveralls.yml

3f9ba7ab67a30186415d2a839fb4bf79bedc82a1 authored over 9 years ago

Move docker-compose build ci to install section of travis.yml

9fe5a65087eb69b05cb75ba10db610ae564c4e34 authored over 9 years ago

fix linting offenses and exclude application.css from scss-lint

102cf23e139dcdc260e6f326bcae6f78f2af95f0 authored over 9 years ago

add sudo to travis.yml

3bcbb29c41f0174e40aaf5276227c415ae0f0e65 authored over 9 years ago

Setup docker ci, tests, and lint containers

Remove rubocop from gemspec
Add scss_lint, rubocop, and ruby-lint to spec/dummy/Gemfile
Add eval...

ff485d971b117a98202c28fb90bbf5893f8673e7 authored over 9 years ago

Merge pull request #63 from liorbrauer/master

Support for rails 3.2+

b4166a02cd45fa884b3ded1bc0e40508e163ec67 authored over 9 years ago

backward support for rails 3.2+

98c30592702ded2dfe7b84f59ae55b0f9cafa3e8 authored over 9 years ago

Update docker-compose.yml for new image

Delete Dockerfile
Set proper scss directory for scss-lint
Set :scss_lint to lint proper dummy di...

c07d23dada4ebd9782c8af5e2d08b574ba2ed2ac authored over 9 years ago

Merge pull request #61 from robwise/linters-ignore-coverage

Make linters ignore the coverage folder

910f5fbf5601b8e672bbed3d1c17741f535ea96a authored over 9 years ago

Make linters ignore the coverage folder

73707e6f67a60bb2e85087a521395307d1a98ea6 authored over 9 years ago

Fix config syntax parsing error within .jscsrc

2971f9db629e9895ae51102312a6f35e23831a9a authored over 9 years ago

Add coveralls gem install to Dockerfile

820238bd77644f2bfbe1f9f52c1a69bf0bfe28cd authored over 9 years ago

Merge pull request #60 from robwise/fix-coverage

Fix coverage to include dummy app specs

40a9515673753ac2cc91bc8d66eb4cf157e661ac authored over 9 years ago

Fix coverage to include dummy app specs

- switch from Coveralls wear_merged! to SimpleCov in order to specify the correct output 'covera...

4193a3c44bcf0b879e47eb2d6ee869e1846f94f5 authored over 9 years ago

Merge pull request #58 from shakacode/coveralls-merge

Setup coveralls to merge code coverage from :gem, :dummy, :dummy_reac…

cf9680024f51c19e7aca8e287f5fabc9e944976b authored over 9 years ago

Update README.md

d561b272851360efb9028003c2d767e640fbd0fa authored over 9 years ago

Update README.md

a153f83ee040b2f204ae74cf282a97eaaa2c29c4 authored over 9 years ago

Update README.md

9eca09b3f7dbff49837ba2f1a7bfbdadf2c2fdef authored over 9 years ago