Fixes QubesOS/qubes-issues#2872

This will allow to evaluate policy extracted from other system.
And also ease tests.

QubesOS/qu...

This is natural to write space after coma.

This ease Admin API administration, and also adds checking if qrexec
policy + scripts matches ac...

QubesOS/qubes-issues#2256

commit/recover/reset should really be handled in start/stop. Nothing
stops specific pool impleme...

Since VM name is immutable, rename method can be dropped from storage
API.

QubesOS/qubes-issues...

Always define those properties, always include them in volume config.
Also simplify overriding p...

Since VM name in immutable now, drop rename-related methods.

QubesOS/qubes-issues#2868

Don't set <backenddomain> element in libvirt XML when device is provided
by dom0.

Do not fail app.save() just because listing devices failed, for any
reason.

Linux kernel bug cause hypercall fails from HVM userspace (see
referenced issue). As a simple wo...

Since libvirt do provide object for dom0 too, return it here.
It's much easier than special-casi...

Second attempt: this time use full words for scope, read, write,
execute.

QubesOS/qubes-issues#...

Have `default_policy_is_accept` variable of type bool, instead of
`policy`, which is only compar...

Use keyword arguments to pass untrusted arguments to make sure the
function parameter also have ...

The first operation returns a token, which can be passed to the second
one to actually perform c...

The same can be achieved with Create+volume.Clone

QubesOS/qubes-issues#2622

QubesOS/qubes-issues#2256

This is continuation of 0f12870 "storage: use direct object references,
not only identifiers".

...

Add convenient collection wrapper for easier getting selected volume.
Storage pool implementatio...

This is much more logical for *import*_volume function.

QubesOS/qubes-issues#2256

In the end firewall is implemented as .Get and .Set rules, with policy
statically set to 'drop'....

There is a problem with having separate default action ("policy") and
rules because it isn't pos...

Do this for all standard property types - even if other types do
additional validation, do not e...

This operation is going to be removed, so apply a quick fix for tests.

QubesOS/qubes-issues#2622

We've decided to make VM name immutable. This is especially important
for Admin API, where some ...

Do not fail on empty kernel value - which means "use booloader on
root.img".

Fixes 3ddc052 "vm:...

Suggested by @woju

for managing tags

meminfo (written by VM) is expected report KiB, but qmemman internally
use bytes. Convert units....

Check if exit code retrieved from dom0 is really the one expected.

Fix typo in test_065_qrexec_...

Since tests expose qubesd socket, qvm-start-gui should handle starting
GUI daemons (so, GUI sess...

When test expect to wait for remote process, use vm.run_for_stdio.
Additionally, when the call f...

Since run_for_stdio raise an exception for non-zero exit code, it isn't
ignored anymore. So, che...

Flush new policy file to the disk, otherwise it will stay only in write
buffer.

Setter is called also on qubes.xml load, so missing kernel breaks
qubes.xml parsing - for exampl...

When method (as expected) raise an exception, service output would not be
assigned. Extract it f...

In core3 this isn't needed anymore (and unit tests already check if
that's really true).

Do it before shutting down qubesd socket - some things may require it
for VM removal/shutdown.

QubesOS/qubes-issues#2851

Now there is a single function to do this, shared with tests.

Test suite creates some VMs and needs to pass the knowledge about them
to qrexec policy checker....

Now instantiating API servers is handled by common function. This is,
among other reasons, for c...

Xen do not support other cases at all ("PCI device assignment for HVM
guest failed due to PoD en...

register_event_handlers is called early, when libvirt connection may not
be yet established - es...

One more thing gone during changing AdminVM base class.

QubesOS/qubes-issues#2622

QubesOS/qubes-issues#2622

This will be useful for admin.vm.volume.Clone implementation.

QubesOS/qubes-issues#2256

This way also AdminVM will have (empty) properties there. It is much
cleaner than adding `if has...

It isn't used for anything, so simply ignore it for good.

https://github.com/QubesOS/qubes-core...

qdb.list return list of bytes().

1. Send the event after setting tag/feature
2. Provide old value for feature
3. Rename 'key' kwa...

* qubesos/pr/111:
vm: drop 'internal' property
qmemman: make sure to release lock
qmemman:...

* qubesos/pr/110:
storage: use direct object references, not only identifiers
vm: fix volume...

Make qubes.NotifyTools reuse logic of qubes.FeaturesRequest, then move
actual request processing...

BaseVM have no (useful) __str__ method.

It isn't used anywhere in the code right now. And when it will be
needed, it should be a "featur...

Even when handling updated meminfo or domain list something goes wrong,
make sure to release the...

One more place not converted to python 3.

Drop DeviceInfo.data - device extension should provide a subclass with
proper individual fields....

Reference objects, not their IDs - this way when object is modified, it
is visible everywhere wh...

- kernel volume shouldn't have snap_on_start, it's read-only volume
anyway
- root volume of Ap...

This will allow filtering them out in udev rules - to not parse any of
it.

QubesOS/qubes-issues...

When VM is renamed only volume.vid get updated, but not other attributes
calculated from it. Con...

With libvirt in place, this isn't enough - libvirt also keep VM
configuration in its memory and ...

dom0 isn't real VM and most properties doesn't apply to it. Lets make it
more explicit.

Specifically, check if root volume is updated after template switch.

Again, if libvirt or even Xen isn't running, we can safely assume VM
isn't too.

Re-init volume config of all 'snap_on_start' volumes at template
chanage. For this, save origina...

Move inheriting volume from template to a helper function.

No functional change.

QubesOS/qubes...

Make them call into qubesd. Create separate socket for "misc" calls - VM
accessible, but not par...