This is much less error-prone.

Simplifies stuff.

This is the standardized version of XDG_SESSION_DESKTOP.

No functional change intended in the non-error case.

This is used by systemd to set the type of the desktop session.

XDG_SESSION_TYPE is used to determine what kind of session is running,
such as Wayland or X11.

No functional change outside of unlikely error cases.

* origin/pr/192:
Fix mode of 75-pulseaudio-qubes.preset
Remove trailing space in 75-pulseaud...

* origin/pr/181:
Use set -a instead of sed
Do not hardcode "user" as the GUI user
Increase...

It shouldn't be executable.

Since pipewire units are getting disabled on pulseaudio-qubes install,
reverse the action when p...

QubesOS/qubes-issues#6358

Avoid conflict on listening socket if pulseaudio-qubes is installed.

QubesOS/qubes-issues#6358

Do the same as in RPM package, to disable/enable pipewire (that would
otherwise conflict with pu...

https://github.com/QubesOS/qubes-gui-agent-linux/pull/139#issuecomment-1627711217

https://github.com/QubesOS/qubes-issues/issues/8230

Fetch it from QubesDB instead.

instead of only "user" user.

This is more robust in case systemctl decides to change how it quotes
newlines in variable values.

The latter cannot report errors and has undefined behavior instead.

The GUI agent must not release a grant mapping until it is known that
the GUI daemon has either ...

No functional change currently intended.

No functional change intended.

This breaks compatibility with protocol versions older than 1.4.
Therefore, it must not be merge...

* origin/pr/190:
Add libpam-systemd dependency

Do not attempt to install qubes-gui-agent in dom0, as it depends on
qubes-core-vm which isn't av...

Signed-off-by: Augsch123 <[email protected]>

Add missing backslashes so desired variables are actually set for the
call.

Just not setting them do not clear those set in the common section,
clear them explicitly.

First pass on supporting pipewire. We do that only for Debian 12+.

From @marmarek's suggestion to not break something if anyone wants
to remove this package.

QubesOS/qubes-issues#8160

* qubesos/pr/185:
pulse: use pulseaudio version from pkg-config

Pulseaudio release a few pre-releases as X.99.Y and they require modules
to match this longer ve...

* origin/pr/157: (74 commits)
PipeWire agent is not less code
PipeWire agent: Add dependency...

Reported by @unman

Fixes QubesOS/qubes-issues#7537

* origin/pr/182:
Rework Archlinux packaging

The PipeWire agent is actually slightly more code than the PulseAudio
agent, but the benefits mo...

It makes no sense to _not_ have the PipeWire agent depend on PipeWire,
as without PipeWire it is...

This ensures that 'make install' works if run twice.

This allows it to be managed by Qubes.

Otherwise the two could conflict.

struct impl is shared by multiple threads simultaneously, and updates to
a bitfield cannot be ma...

Otherwise we will block the realtime thread.

Wim Taymans's line cannot be changed, but mine can.

INT_MAX/2 (0x3FFFFFFF) should be enough for everyone :). This avoids a
Xen-specific limit.

Suggested-by: Marek Marczykowski-Górecki <[email protected]>

The only time this can fail is if SPA buffers are too small. If this
happens, it should be caug...

stream->impl can be NULL in this case.

It turns out to only need 320 bytes.

This is necessary to support loading the module multiple times.

Even a dead stream needs to be shut down properly.

This causes a SIGSEGV; will probably revert.

An overrun could be due to a lost uncork command. Send a fresh uncork
command in that case.

Not having a default is unnecessarily annoying, and setting the size in
the configuration file m...

If a stream state change has been requested, immediately after vchan
connection is a good time t...

This caused infrequent reconnection failures.

xruns are a warning, not an error.

Assertions are not an error handling mechanism. If creating a vchan
fails, or if the vchan cann...

Just use "qubes-audio".

pacat-simple-vchan needs to know the current state of the streams
upon vchan connection. Otherw...

They are used to detect fatal errors.

Several keys were missing.

This does not work due to what I believe is a PipeWire limitation.

pw_properties_update_string() is not available in old PipeWire versions.
Instead, create a separ...

- use dh_installsystemduser on Debian
- use %systemd_user_post and %systemd_user_preun in RPM sp...

Required by the MIT license of PipeWire.

It is potentially racy.

Suggested-by: Marek Marczykowski-Górecki <[email protected]>

The input here is trusted, so there is no need to be paranoid about
input validation.

Whenever an event happens on the capture vchan, send any control
commands that need to be sent. ...

pw_log_error() is only for errors.

It was intended to work around a bug in pacat-simple-vchan (indefinite
blocking during vchan rea...

This is probably a no-op, but out of an abundance of caution, set
stream->closed_vchan to NULL, ...

It is necessary to stop watching the vchan during shutdown, to prevent
events from firing that w...

No change in behavior.

The new stop_watching_vchan() function is now the only code used to stop
watching for vchan even...

They are not needed.

It was a debugging leftover from when I was trying to interpret some
logs.

Suggested-by: Marek ...

Most of it is regarding threads, but not all of it.

EFAULT ("bad address") means that a bad pointer was passed to a system
call. Do not use it as a...

Suggested-by: Marek Marczykowski-Górecki <[email protected]>

The buffer sizes are adjustable via the PipeWire configuration file.