github.com/parse-community/node-apn commits | Ecosyste.ms: OpenCollective

Use the new setter.

17fd3ec0c618bbbc21f4eb61a251b97ca8ceb65d authored almost 10 years ago

The alert getter was tested.

5a267d4075e9841dd2c58bc7b762877ed070a470 authored almost 10 years ago

No need to determine the encoding in many places.

9e6e50edf8db46b257ef8e27d4342cc778c4d611 authored almost 10 years ago

Alert has two formats. It should have a getter.

ed20d081630868f07c3f22f4a31de4048b128ea1 authored almost 10 years ago

Outdated dependencies

149d8eec3c9967f0bebaa2908d19ff82c0ac7555 authored almost 10 years ago

The address shouldn't be be specified explicitly

95867b867f27532ad3a806657bd23a180b632e0e authored almost 10 years ago

The enhanced interface has been removed

The newer binary interface is always used instead.

f81768b7fe9d192e59a598a526862b54682c7c51 authored almost 10 years ago

The "legacy" protocol has been removed.

ab8c3d6d6f8f017589d33982eaca902266ac7e18 authored almost 10 years ago

Use forEach with array.

0557074c6a997527888e6f24496cdf6bd5ba8226 authored almost 10 years ago

v1.7.2

bb47e03452e673b2ab12de2402fe24782a13a816 authored almost 10 years ago

For...in... doesn't make sense for arrays.

1fac4dae27bd98c3f8e008cefe1940c3fa72b737 authored almost 10 years ago

Another for(...in... goes down.

400fd6ad51341f8bf1e29de799e94cc99845c8e8 authored almost 10 years ago

Don't use for(..in.. for arrays.

06c875030942814214cb072381e16b3509349702 authored almost 10 years ago

Fixed flakey test on 0.8

69dbc69ba230aa0b77590aab92e747ca97fe6a1e authored almost 10 years ago

Don't want to use a function before it is defined

70b72700c0a332d5038a784b98c61ca86eaebc2d authored almost 10 years ago

Stricter comparisons

f11151bb933b1a150c66a254fca6d76a698840f0 authored almost 10 years ago

"use strict";

e871d321956bad123397662382a032e93cc91121 authored almost 10 years ago

' vs. "

cc8341870833988b233d9835562331c9d12679fe authored almost 10 years ago

Lint.

ee39271ed481c54ebbb5924aa7104e53a14a35a6 authored almost 10 years ago

Old and busted legacy code.

cdf49fade55a855fc47d651385fda730269ced84 authored almost 10 years ago

BADGE ALL THE THINGS.

b52059662f52a48018f7ca9e17c3df299442935d authored almost 10 years ago

Declare functions before they're used.

40dc0ad4a2dfa2d6683f2db64cec87249fb80576 authored almost 10 years ago

Stricter comparisons

0cbb2bac4ef9c43c1a2de623fe149ddbfe6612cd authored almost 10 years ago

More. damn. quotes.

1392931a43bbc45d06494702e5da0db815232559 authored almost 10 years ago

Shouldn't use functions before they're defined.

31777260607fbc94ebab7a809eec18f307dc2cb8 authored almost 10 years ago

' vs " - The enquotening.

7b292a20c66639cf0385cb820523fa8596a9c25f authored almost 10 years ago

Better code order.

bdeb5c22f4f9cd6840dca65f7522b029140f9ad4 authored almost 10 years ago

Missing semicolon.

695518b6a58d9c0caf7d239523b89ae09b2f14c9 authored almost 10 years ago

Variable not used.

b00218207ce696712b4b19b3ab87c14affff69a3 authored almost 10 years ago

Unnecessary requires.

cc99b7c09f2ab12c6449b899343cdbfb97778456 authored almost 10 years ago

Refactor the truncate function.

bb3d65114357dcd4cc990b992f94eada7f6d8898 authored almost 10 years ago

Space things out.

95a7903e2040c8208369e0911d910ee4d819c48b authored almost 10 years ago

' vs " redux.

b50e7a391ff1c798ce62062aa735c7174a4c00e2 authored almost 10 years ago

Semicolons. There will be more, I'm sure.

a5a735931c2ef1c124786829cec7db952dae09e9 authored almost 10 years ago

Prefer dot-notation

8bdf59fff0239a128b836a1e86dcc5015ce6672f authored almost 10 years ago

Variable is already declared by parameter.

40bab67dc4d56638fb9442c93fee6d1482a85867 authored almost 10 years ago

Never use implicit `if` blocks. {} FTW.

b7685005b7b89562f8f01b2a6368f4721fadc908 authored almost 10 years ago

Don't throw from within a try{}

d415e1f89de15c632b1736af4ea50f7b11bbc039 authored almost 10 years ago

This should reduce the cyclomatic complexity.

4c4d1005f2f63464cecaaa0a9000f3ca8043c552 authored almost 10 years ago

Unnecessary require.

8321297549ff571f6e6689e3d8f7d9d0dc75ea3b authored almost 10 years ago

' vs "

e64fdd6423f34a5c1fd01921d1e3f2f356108d78 authored almost 10 years ago

Semicolons, add a few, delete a few.

e8833dd3c96afedb735be2cb12c41525037313ff authored almost 10 years ago

Functions should be named, not anonymous

Also shouldn't be assigned to a variable of the same name.

26ee8c1519b06b1cce663f32ebf8cda394b5533d authored almost 10 years ago

Another duplicate variable declaration

053d8a45267954582fe56393dbe90572da16009f authored almost 10 years ago

Duplicate declarations are bad.

7550b280f1df108bfbc979b73d40ac46af2f8fa4 authored almost 10 years ago

CI should publish to npm

3b24706d43a2e368caf40236cd705c0338cec690 authored almost 10 years ago

The YAML wasn't formatted correctly.

f9bd3d6295ac4680c60b52d308616b0a52e923dc authored almost 10 years ago

New stable node.js

a8a7d88a1fed2e1dacf656cdb937834045b9996b authored almost 10 years ago

Simpler command.

Still not working though :(

d4bbb8dc25d8346ac12b19113022ef7111465fd4 authored almost 10 years ago

echo != cat

0a713c69275733358d5499af635ff6efc16bc55c authored almost 10 years ago

No. sleep. till. coverage.

9a8ee5c9d5e49f200a7019e3be2f91f30eab2c0c authored almost 10 years ago

Last try for today.

d98a4237a5dda009c1d953b7b44a28278df8f075 authored almost 10 years ago

Coverage still isn't working

222b48ddc6b4f1781ed833f172f3372d8f78005a authored almost 10 years ago

Correct istanbul command.

f2450c4304fa37352ffacc4577999564ccd35f68 authored almost 10 years ago

Don't want to run coverage across the build matrix

34a64af62956981856e56c8de502e00e443d6d6d authored almost 10 years ago

Stupid typo.

99f8d75792ef79adb68c362c44e8e69da03cddfb authored almost 10 years ago

dependencies aren't yet compatible with chai 2.0

f0941ed81a3cb81750bb80506c1e644e46e8041f authored almost 10 years ago

Broken travis.yml

bb0c4e3b4280cdb96835189e9f50358326fa4c42 authored almost 10 years ago

Automatic coveralls upload.

65f5102e76f7493e72b845e803b095fcb4037da9 authored almost 10 years ago

Not sure we need to test specific iojs yet.

f7e3941a13520a5890adad0480ec6dfa9eadae8c authored almost 10 years ago

node 0.8's npm doesn't seem to support `^` semver

57418f2f9117e86202dca36a2a49181129fc23e5 authored almost 10 years ago

Revert "Process.nextTick is a little too specific"

Depending on process timers with fake timers in use is a worse idea.

This reverts commit 736bf6...

25b1db58ee54e3dfbcb0437649df610bfafb44cc authored almost 10 years ago

Test dependency was missing. This made Travis sad.

33cedcc5c28c685569cccd5aecf707866b4e75f8 authored almost 10 years ago

TravisCI

58773b848618ee22a895a640fa731310340bf0bc authored almost 10 years ago

Missing test

5d87daa459a84ee3aa21ebcabe6efa8a8b2d6e5c authored almost 10 years ago

Process.nextTick is a little too specific

See previous message about promises being a pain to test.

736bf6ad7f9c844dba8366cd9aa89d5698e58842 authored almost 10 years ago

The names were confusingly similar

e151416592e57e6ae0390a19ba5990fd89985a78 authored almost 10 years ago

The description said "connect connect timeout"

387fc15ac2f1fa6df948cc63f8cd0569a9d9e6fc authored almost 10 years ago

The old way was rubbish.

I'm not sure whether the tests were help or hindrance here. Promises with tests are a bit of a p...

13996aed7c1c6ebc20ef9a9e4a9424e032776b2b authored almost 10 years ago

Missing test for connection failure case.

603200dbb02dafe9c1ea6f432283ee6b1494974f authored almost 10 years ago

The test broke using fake timers.

Because the fake `createSocket` immediately calls the callback it will clear the timeout before ...

2de1ab87084bf58fa4f1293c06dd66b17dfc1ec6 authored almost 10 years ago

Fake timers are needed

It turns out that using `rewire` conflicts with sinon overriding the global timers.

The globals...

ee79dbbdfbf4bea6031165906ff251ac952dabf9 authored about 10 years ago

Missing tests for timeout option

503b5b51f4c2b79d7318b9a165d6a06233caf9f4 authored about 10 years ago

Initialize should fail in this case only

Override Connection.prototype.initialize with an instance specific method for this case.

e6f5b703d4de9d862478d4a28fad7de0efaa7720 authored about 10 years ago

We don't want duplicate errors

If deferred connection is rejected then a socketError will already be emitted. We shouldn't emit...

c19a16e64fbf47f4505d721ef6ff3ecc40f8c1b7 authored about 10 years ago

Pending tests for connect timeout behaviour.

f2921c969edea71269ace2cd60277b9f9a2b818d authored about 10 years ago

If module initialisation fails, Give up connecting

1b7c307704006aeceddf46e6fc2f57798654ea39 authored about 10 years ago

Only emit `error` when it is unrecoverable

Fixes #238.

Applications should always attach an `error` event listener. If not, an uncaught ex...

43a1c11f7bb42eaef0aa2b7b352445b8379f4d88 authored about 10 years ago

done() is important in promises.

If promises aren't returned somewhere else they should be terminated with done(). This will ensu...

c7e9aa25db7aee31a0a09e7af195fbb4aa122818 authored about 10 years ago

v1.7.1

553131479b99304c536661b5d310e938cbd6f503 authored about 10 years ago

Fixes #243

If ca = [] then tls.connect will not trust any certificates. If ca is undefined then the system ...

132084a8393c834cdcdf11e0993ff483c9289dd3 authored about 10 years ago

Fixes #224

5b6d6af06e627f6650fda006e9b4cc546ca39444 authored about 10 years ago

Update docs for `cacheLength` to show new default

The new default of `cacheLength` is now 1000 and not 100

Signed-off-by: Andrew Naylor <argon@mk...

ca1c158d60c3d0caa9f1a9a2efcfb1a74888a69d authored about 10 years ago

Prevent silently dropped connections.

Apple has a habit of silently killing connections which lie unused for several hours. Deliberate...

5c1c92c4ab4571bcebb946b8a08a4ef60d20187f authored about 10 years ago

JShint configuration

4d5bc3a174a223f8b49e9b989ad2a5c3274a04b9 authored about 10 years ago

v1.7.0

e3d71d155092d7a500797716e4f2fe48eec999c9 authored about 10 years ago

Don't break old code.

Old implementations will explicitly pass the address/gateway instead of the production flag. In ...

0a879bf225bb37b1b2fc63104b9270d29a2463e1 authored about 10 years ago

Don't explode if the production flag is missing

642204aaf7fd1db963f129538ef281e8b271bfda authored about 10 years ago

Simplified test setup/teardown

37da13c6d61a8d0be239b9f6c6c054ef5aece987 authored about 10 years ago

Without this there could be an uncaught exception.

b68956643b248b678b27a0df145937760a47bae8 authored about 10 years ago

Credential validation for feedback too.

89fd50f9033c987034354e4457bd3e02f4d42790 authored about 10 years ago

Check the validator is called correctly.

f8ce5ea2204e2d8eb4786dc30f1ae0480d96766d authored about 10 years ago

Explicitly check that PFX is passed through.

197433cf6c375bbe217575a2bda8b8af59304e7e authored about 10 years ago

Better expectation syntax

...I think so anyway.

5846665c48a09128db6d753a9f4f851b59cda713 authored about 10 years ago

Only the validator needs the production flag

Removed unnecessary passing of the production flag from the parser. Also added a missing test on...

612e343ec9399762d9efd5cfdddc297e1d7d45a8 authored about 10 years ago

Correct english in the description

295f7bdfa0c9ba34cde1ac2ff69a455dfe5a6472 authored about 10 years ago

Test should be more rigorous.

1922c50d26cf8c8040b44477a70774396a7ad906 authored about 10 years ago

Unnecessary initialization.

...it happens in `beforeEach`

5c8d3616514e24dcfbcfd2c5f6747ae60235d9d7 authored about 10 years ago

Missing test.

If validateCredentials is called with undefined it will blow up.

2a513ec91e3de46e236b35623cc0f3530906b7eb authored about 10 years ago

More descriptive assertions.

c146171ba3da4e8e24948153e9f806bf90a91b73 authored about 10 years ago