Per discussion here: https://chromiumcodereview.appspot.com/10387164/

[email protected]

R...

The previous method (only setup on first iteration of loop) didn't respect
that the actions migh...

'all' are all targets transitively referenced by all.gyp. For example:

all.gyp:
targets: [
...

r1378 broke on ninja, not because of command line too long, but because there was no inputs spec...

1. Commands were previously joined with &&, which resulted in the command line being too long
2....

defined, so that IntDir can use the definition of OutDir by topologically
sorting references to m...

Review URL: https://chromiumcodereview.appspot.com/10383117/
Patch from Marshall Greenblatt <mar...

Review URL: https://chromiumcodereview.appspot.com/10384109

git-svn-id: http://gyp.googlecode.co...

This is now fixed in the upstream gyp files and no longer necessary.
Review URL: https://chromiu...

Discovered that: 1) the long command line test wasn't testing all the link
command line (.lib an...

BUG=none
TEST=trybots

Review URL: https://chromiumcodereview.appspot.com/10383017

git-svn-id: ...

TEST=Build chrome.exe using the compiler from Windows SDK 7.1

Review URL: https://chromiumcoder...

With this, -I flags no longer get escaped. This is mostly OCD, but
a back-of-the-envelope calcul...

TBR=scottmg
Review URL: https://chromiumcodereview.appspot.com/10383073

git-svn-id: http://gyp....

Review URL: https://chromiumcodereview.appspot.com/10356060

git-svn-id: http://gyp.googlecode.c...

VS2010 uses some file tracking juju in various .tlog files to do reality-based dependency tracki...

This generate will generate an XML file that can be import into an
Eclipse CDT project. It will ...

"FavorSizeOrSpeed" should map to Os/Ot. These were backwards.

"Optimization" can also be set to...

There was some code to re-run an action, but it only worked if the
command change came from a ch...

The speed improvements were minor (maybe 200ms) and it was
reported that on a RAM disk, it was s...

Addition of test here http://codereview.chromium.org/10371002/ discovered that
VS doesn't suppor...

Some investigation here: http://chromiumcodereview.appspot.com/10337008/

[email protected]
...

[email protected]
BUG=125640

Review URL: https://chromiumcodereview.appspot.com/10371002

g...

Disable the check on Android for now. The other platforms should now be fixed.

Original review:...

Fixes currently broken ninja buildbot tests.

[email protected]

Review URL: https://chromiu...

TBR=scottmg
Review URL: https://chromiumcodereview.appspot.com/10343006

git-svn-id: http://gyp....

Review URL: https://chromiumcodereview.appspot.com/10010028

git-svn-id: http://gyp.googlecode.co...

The batch-file-with-space test doesn't work for the msvs generators.

I looked at trying to fix ...

Review URL: http://chromiumcodereview.appspot.com/10273034

git-svn-id: http://gyp.googlecode.c...

Changes:
* ninja_syntax.py: Fix a bug when passing dict variables to Writer.build()
* Explicitly...

The first argument of a command (the program) can't always be quoted on Windows. In particular, ...

The scons generator didn't remove invalid characters from rule names; remap
those. It also doesn...

Add support for VS macros $(InputPath) and $(PlatformName), and improve the locations where they...

Ninja doesn't want ( and ) in rule names.

[email protected]
BUG=chromium:125606

Review URL...

[email protected]
BUG=125606

Review URL: https://chromiumcodereview.appspot.com/10270020

g...

This is more robust to changes in the set of available platforms.
Review URL: http://codereview....

Fix expansion of $(OutDir). Also, make sure there's no redundant path contents (.., etc.) when e...

I really can't figure out why, but using copy /y nul $out for stamp doesn't cause the changes to...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/10233002

git-svn-id: ...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/10198022

git-svn-id: ...

This test is flaky because it expects the shared_intermediate action to be
re-run when target2 i...

Without this, if -Wimplicit-function-declaration is enabled, the test fails
with a warning from ...

Import lib doesn't update timestamp if exports haven't changed when incremental linking is on, w...

aka actually make /INCREMENTAL flag do something useful.

When ULDI is on, the objs making up of...

Missing input files cause MSVS 2010 to constantly think the
target is dirty and mark it for rec...

That is, only use Express/SDK if our registry detection determined that the Express version is d...

Review URL: https://chromiumcodereview.appspot.com/10127012/

git-svn-id: http://gyp.googlecode...

sources + sources! + sources/ are appleid.

This allows greater use of gyp-isms in cross compile ...

git-svn-id: http://gyp.googlecode.com/svn/trunk@1330 78cadc50-ecff-11dd-a971-7dbc132099af

Review URL: https://chromiumcodereview.appspot.com/10106003

git-svn-id: http://gyp.googlecode.co...

Allow expanding $OTHER_CFLAGS and $inherited in OTHER_CPLUSPLUSFLAGS,
since these are probably c...

Patch from Myles C. Maxfield <[email protected]>!

Review URL: https://chromiumcodereview.app...

splitlines strips newlines, and I wasn't readding them when writing to stdout.

R=thakis@chromiu...

Make the linker flag matching a more general, add tests,
and support unexported_symbols_list and...

Along with https://chromiumcodereview.appspot.com/9967020, fixes requirement
to have run vcvarsa...

On Windows, Chromium uses a reference to a DXSDK_DIR environment variable which may or may not e...

The xcode generator can't handle if 'dependencies' contains the
same target twice, as it happens...

Review URL: https://chromiumcodereview.appspot.com/10024011

git-svn-id: http://gyp.googlecode.co...

BUG=chromium:102033
Review URL: https://chromiumcodereview.appspot.com/10020015

git-svn-id: htt...

Check registry too if environment variable isn't available.

[email protected]

Review URL: ...

Emulate it in win_tool instead. Fixes red gypbot at r1317.

[email protected]

Review URL: h...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/10022004

git-svn-id: ...

Now that postbuilds run in the gyp file's directory, this is
no longer required (harmful, even)....

TBR=scottmg
Review URL: https://chromiumcodereview.appspot.com/10026002

git-svn-id: http://gyp....

A few cases that were unhandled before. OutputFile override doesn't really mix
that well with pr...

Xcode and make treat them as relative to the gyp directory,
ninja should too.

The straightforwa...

Renames other VS macro test to more general different directory.

(Along with a couple minor CLs...

(and unrelatedly, add assert to ExpandMacros)

[email protected]

Review URL: https://chromi...

Some Windows build rules use gyp magic names, and VS macros in their inputs
and outputs. Expand ...

Happens to fix that link path weren't relative-ized to .gyp file (but lib ones were) which is th...

Magically build .idl files via midl compiler if there's no other explicit
build rule specified. ...

The root cause is that there's something slightly broken in dependency checking, either in ninja...

Also fix a bug where they didn't get exporte correctly to plists
in make and ninja.

BUG=chromiu...

Review URL: https://chromiumcodereview.appspot.com/10008016

git-svn-id: http://gyp.googlecode.co...

When LD_DYLIB_INSTALL_NAME is set explicitly to $(bla:standardizepath)
in a bundle target with a...

And add assert to WriteVariableList because I seem to do that every time I use
it.

R=thakis@chr...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9965133

git-svn-id:...

Reduces memory usage during final link, but otherwise doesn't change behaviour.

R=thakis@chromi...

(already reviewed/suggested in previous CL)

[email protected]

Review URL: https://chromi...

A common noisy message that messes with one-line-ninja-overprinting style.

[email protected]...

Minor cleanup, makes include handling the same style as library handling is on mac & win.

Revie...

Having/not having this flag doesn't change behaviour in our case, because it
only applies to mul...

Redirects final binary, including support for VS macros in the filename. Note that modifying the...

Primarily:
- Convert path variables to /, but only if the action is run under cygwin
- Wrap the ...

.def files get magically translated in build rules in VS, emulate that here.
Multiple .def files...

TBR=scottmg
Review URL: https://chromiumcodereview.appspot.com/9956030

git-svn-id: http://gyp.g...

Review URL: https://chromiumcodereview.appspot.com/9959026

git-svn-id: http://gyp.googlecode.com...

Also fix a bug uncovered by this: Xcode provides a
default -install_name. (It looks like the Con...

Looks like the option wasn't needed, so remove it.
Review URL: https://chromiumcodereview.appspo...

It was pseudo-global, kind of weird, and better off gone. I don't think I'll miss him.

R=thakis...

Removing the C runtime library removes the entry point that the linker
expects, so we can test b...

Always call win_tool helper to copy (which was previously fallback). Don't use
mklink because it...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9918025

git-svn-id: h...

To build Native Client, we want to have a relatively clean way to
cross compile from within acti...

Target 'dyna' in test/mac/postbuilds/test.gyp had
source 'file.c', which defined a function f(),...

BUG=http://code.google.com/p/chromium/issues/detail?id=120214
TEST=actions-none
R=mark@chromium....

Fixes erroring out with long command lines.

Review URL: https://chromiumcodereview.appspot.com/...

- remove all unnecessary 'product_name's
- fix _ to - in filename
- normalize order of 'msvs', a...

- NXCOMPAT default behaviour was incorrect, make ninja match msvs IDE.
- Debug info pdb name was...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9864003

git-svn-id: h...