IsPathSection is 2-3% of the execution time for chromium. Hand optimize
it a bit to make it twic...

Makes no difference for me but might help others because gyp can easily
keep lots of processors ...

__OPTIMIZE__ is a gcc-specific define, so this was broken on Windows
after https://code.google.c...

The 'UseSafeExceptionHandlers' setting, if set to 'true', passes the
/safeseh option to ml.exe.
...

Currently tests use manual context management (try: ... finally: ...)
This is cleaner and more r...

This reverts r1883, which seems to be causing gyp-win32 bot failures on
test\ninja\solibs_avoid_...

When one configuration inherits from another, we should merge the
configurations before merging ...

Xcode has great development and debugging tools, but runs slowly with very
large projects. Ninj...

The android build system supports 32/64 bit multiarch builds; add
support for this in the androi...

The android backend mangles the names of targets in its output in order
to ensure they don't cla...

The rule_trigger target doesn't serve any useful purpose since all the
output files from the rul...

Implements ARCHS filtering by VALID_ARCHS and variable expansion, like
$(ARCHS_STANDARD), in Xco...

GYP doesn't produce a valid Ninja rule for 'none' target type.
These targets are used to make fa...

According to Xcode 5.1 release notes, the "Standard Architectures" build
settings now also inclu...

When building for iOS, consider any architecture set in the gyp files
as valid (to allow buildin...

1. Only write unique_name for rules on Windows, it's unused elsewhere.
Makes individual_generate...

Before this CL, if a rule matched N source files and had M inputs, the inputs
where repeated for...

This commits adds a new 'msvs_external_builder_clcompile_cmd' property, which
will be used when ...

https://code.google.com/p/gyp/wiki/GypLanguageSpecification#Rules doesn't say
that it's availabl...

[email protected]

Review URL: https://codereview.chromium.org/202203002

git-svn-id: http:...

Using win-tool to do a recursive copy is failing on such systems, because for example, if I had ...

The bug was caused by i386 and x86_64 binary using the same rsp file.
Add arch to rsp filename i...

Before this, dependencies inside a static_library weren't updated to
reference the _N targets, n...

[email protected]

Review URL: https://codereview.chromium.org/198283004

git-svn-id: htt...

To support link lines longer than 128 kiB == 131072 bytes, like it's
needed for chromium's conte...

The Visual Studio emulation does not expand the special
variables like 'VSInstallDir' into the '...

The version of clang that ships with Xcode 5.0 and higher add an extra
symbol if the command-lin...

Xcode 5.1 removed support for garbage collection, and no longer recognize
the GCC_ENABLE_OBJC_GC...

Many tests have to check the version of Xcode (as new versions introduce
incompatibilities) so i...

See https://codereview.chromium.org/177043010/#msg15 for the cmake bit, and
the following commen...

[email protected]

Review URL: https://codereview.chromium.org/195283002

git-svn-id: http:...

The property svn:executable has been set on the test_check_sdkroot.sh script
so remove the worka...

With Xcode 5.0.0, the SDKROOT environment variable is always set
when building, even if not set ...

[email protected]

Review URL: https://codereview.chromium.org/191443005

git-svn-id: http:...

This will allow targets to be generated where spaces aren't desirable in target names.

Patch b...

attribute from the 'none' targets' dependencies.

The intention behind this change is to let the ...

Addendum to r1804. The fix in that revision only works
for VS 2008; for 2010 and later we genera...

This extends validation of MSVS settings to ignore any key found that is suffixed with '_exclude...

The Android build system doesn't use CFLAGS for assembly source files,
but gyp expects this. Set...

name; but it also does this when one of the files is excluded
from the build, which I think is a ...

BUG=None
[email protected]

Review URL: https://codereview.chromium.org/170853002

git-svn-i...

XcodeVersion may end up being called many times when building large
projects, so cache the versi...

No functionality change, but more consistent with -MF $out.d, and the
generated files shrink by ...

Chromium includes some targets that should only be compiled on
specific platform and end up with...

BUG=None
[email protected]

Review URL: https://codereview.chromium.org/159303003

git-svn-id:...

When cloning the target dictionaries for "iphoneos", correctly filter
the ARCHS value to only in...

The _XcodeVersion from XcodeSettings class does not need to be a member
function as it does not ...

The methods _XcodeVersion returns a tuple with two strings (Xcode
version and Xcode build), so w...

This CL helps cross-compile work well. Linux doesn't have to have /proc/meminfo.
For example, ch...

If CC is set to 'clang-cl' in make_global_settings, use that
as the compiler instead of cl.exe ...

When using ! or / filtering mechanisms on MSVS tool dictionaries, the resulting automatically cr...

This adds support to the Eclipse gyp generator for detecting the
compiler's default include dire...

This allows lastKnownFileType to be set for files named, for instance,
Images.xcassets.

Patch b...

it's not needed anymore as we're using the GYP_USE_SEPARATE_MSPDBSRV flag on the Windows builder...

The code that utilized this file was removed in r1184.

Review URL: https://codereview.chromium....

Patch from [email protected].

[email protected]
BUG=335607

Review URL: https://cod...

Follow up to r1831, which forgot to adjust one of the call sites of _ConvertSourcesToFilterHiera...

Follow up to r1837. The previous test used print, which can get lost
when running in parallel. I...

Originally by yukawa_g <[email protected]>,
see <https://codereview.chromium.org/8229003>, excep...

This is a hack to get variables set here:
https://code.google.com/p/chromium/codesearch#chromium...

This variable causes separate instances of mspdbsrv to be used
for each invocation of the linker...

[email protected]

Review URL: https://codereview.chromium.org/131063004

git-svn-id: http...

Bots failing with

FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-mani...

This is "just more correct" (will e.g. make -t clean work a bit
better) and also allows syzygy r...

MSVS 2008 can't cope with the generator makefiles.

This is a conditional revert of r1820

BUG=3...

Currently, it's a strange mix between depth, the filename, and generator
output that happens to ...

VS2012 express and others do not include a 64 bit compiler
that generates 64 bit code. This patc...

Without this, `gcl commit` doesn't work without --no_presubmit.

Also set `svn:eol-style LF` on ...

I'm trying to land some GN changes and get this error on various platforms with various configur...

If Xcode isn't installed passing the CLT version is the next best bet.
This ports the CLT versio...

This reimplements r1819 in a way that should avoid breaking Xcode, and
should also allow setting...

This is what's happening in the ninja generator, and what's happening in the
make generator for ...

Failing tests are at
http://build.chromium.org/p/tryserver.nacl/builders/gyp-mac/builds/1478

Fa...

[email protected]
BUG=326030

Review URL: https://codereview.chromium.org/118443002

git-svn...

A number of developers have found themselves in a state where they have multiple
copies of the s...

Make link order in VS match gyp order (redux).

Previous attempt(s) failed on a sources list of:...

OS X systems running only the Command Line Tools for Xcode package,
without the full Xcode, don'...

http://code.activestate.com/recipes/576693/ specifies author and MIT
license, but it wasn't incl...

Now actually tested on 2.6. :/

[email protected]

Review URL: https://codereview.chromium.o...

Using collections.OrderedDict caused chromium roll to fail:

Broke Win Builder (dbg) runhooks:

...

No intended behavior change.

[email protected]

Review URL: https://codereview.chromium.or...

And add a test for this specific variation.

[email protected]
BUG=chromium:326030

Review U...

The 'normal' way to do manifests is to have link generate a manifest
based on gathering dependen...

Sources in a given directory matched before, this makes folder order
match the gyp order also.

...

The evaluation bug of bare environment variable has been fixed by
Xcode 5.0.0, so do not check f...

When using Mac OS X Mavericks with Xcode 5.0.2, the only SDK installed
are 10.8 and 10.9. Fix th...

With Xcode 5.0.2, gcc is now a special version of clang and it no
longer supports the -Wno-inval...

With Xcode 5.0.0 or later, the DTSDKName of Info.plist is always
set, even if SDKROOT is not def...

The order of .obj on the link command line determines the order in the
final binary in the absen...

I'd been cursing pylint on every dcommit for the last year or
so and then doing --bypass-hooks. ...

[email protected]
BUG=310938

Review URL: https://codereview.chromium.org/102593004

git-svn...

Generating projects in subfolders could produce filters with
several nested '..' folders with a ...

This CL teaches msvs_emulation.py about following settings so that ninja ganarate can handle Pro...

Currently Ninja generator always expects VCLinkerTool.GenerateManifest is true. With this CL, it...

Currently there's a single instance of mspdbsrv shared between all the linkers. This can cause s...

There's longstanding occasional errors where the compiler complains that
the pdb is locked. This...

The buildbot have an old SDK / Xcode installed that does not
support building a simulator target...

Xcode 5.0.0 only default to x86_64 when building Mac project, not
iOS projects (since default ta...

Do like ninja and stop storing file lists in the source tree by putting
everything in the "out/g...

Designed to create projects for IDEs like kdevelop, qtcreator, code::blocks, or eclipse cdt.

Ge...