No intended functionality change.

TBR=evan
Review URL: https://chromiumcodereview.appspot.com/9...

No intended behavior change.
Review URL: https://chromiumcodereview.appspot.com/9289001

git-svn...

Error message this generates looks like:

Exception: Target base/base.gyp:base_static#target has...

Worksk fine with the xcode and make generators, but used to not work with the
work-in-progress n...

Works fine in xcode and make, but originally didn't work with the
work-in-progress ninja postbui...

Transform, e.g., 'libfoo.a' to '-lfoo', so that the LIBRARY_SEARCH_PATHS are
actually searched f...

Don't quote flags when it is obvious they don't need quoting.
This covers common flags like -DND...

CHROMIUM_STRIP_FILE needs to be written before
TARGET_POSTBUILDS_$(BUILDTYPE) is written to the ...

In that case, the current directory is chrome/ instead of chrome/src/, but
self.build is still r...

jamesr used to use different GYP_DEFINES for different configs, which was broken by
making ninja...

With this, clang works out of the box with ninja.

Based on a patch from Jeremy Apthorp <jeremya...

Print a warning if anyone specifies -Gconfig=Release.

Review URL: https://chromiumcodereview.ap...

This doesn't seem to have an effect on anything.
Review URL: http://codereview.chromium.org/9114...

The code uses include.gypi; only comments use the wrong form.

Review URL: https://chromiumcoder...

http://codereview.chromium.org/9108002/

Submitted for yukawa.

Description:
Currently MSVS 2010 ...

BUG=chromium:109163
TBR=mark (got LGTM over email)
Review URL: http://codereview.chromium.org/91...

BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/9133022

git-s...

General ARCHS support (fat binaries) are still unsupported.

BUG=90185,107027
Review URL: http:/...

$(out)/output/path was transformed to ${out}/output/path,
which Absolutify() then identified as ...

Support env vars in:
* plists
* sources and destination filenames of copies
* actions

Enable al...

Due to an earlier restat change, we no longer need a Chrome-specific
hack for lastchange.
I acci...

- Store intermediate paths on this object, allowing more of the WriteFoo
functions to just ret...

First, add tests for env vars in copies, actions, and plists,
using $(VAR) (normally expanded by...

The conceptual logic at the end of WriteSpec now is:
final_output = linker_output = WriteTarge...

No functionality change.
TBR=evan
Review URL: http://codereview.chromium.org/9139081

git-svn-id...

Give xcode_emulation.GetXcodeEnv an optional additional_settings
parameter, and unconditionally ...

Review URL: http://codereview.chromium.org/9148085

git-svn-id: http://gyp.googlecode.com/svn/tru...

Since it's now in the same focused module as XcodeSettings,
consider it a friend of that class. ...

shlex.split will eat backslash (commonly found in windows paths).
Review URL: http://codereview....

After the previous refactoring, WriteTarget had two is_mac_bundle
tests in a row. This code can...

Now GetXcodeEnv() no longer reads self.output or self.output_binary.

Also use my env var test h...

There was a bunch of code in WriteTarget that only applied when
writing out something involving ...

Add a test to check that this does in fact match Xcode.

Tweak the cycle detection logic so that...

Previously, it was first set to $(builddir), or for actions to
e.g. ../../$(builddir), only to l...

This allows getting rid of the quirky keys_to_not_absolutify.
Add extensive tests to make sure t...

Review URL: http://codereview.chromium.org/9194001

git-svn-id: http://gyp.googlecode.com/svn/tru...

BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/9107026

git...

Shows why the abs_builddir is needed.
TBR=rsesek
Review URL: http://codereview.chromium.org/9166...

I intend to unify those two into an object, so this rearrangement
will make the next change simp...

Also change the make generator's behavior to match xcode. This isn't important
for anything in p...

self.output and self.output_binary used to contain escaped spaces. Instead,
let WriteMakeRule() ...

A dependency on a bundle should cause the whole bundle to be built,
not just the bundle executab...

Also support completely empty bundles.

One problem with supporting sourceless bundles was that ...

BUG=109452
TBR=kerz
Review URL: http://codereview.chromium.org/9120018

git-svn-id: http://gyp.g...

BUG=109452
Review URL: http://codereview.chromium.org/9121020

git-svn-id: http://gyp.googlecode...

This matches xcode and make, and the chrome build depends on this.
Like http://codereview.chromi...

Similar to http://codereview.chromium.org/7396012.

This creates a separate bundle binary for bu...

Simiiar to http://codereview.chromium.org/7405001 and
http://codereview.chromium.org/8538021 .

...

This is similar to http://codereview.chromium.org/7399010. Since many
bundle names contain space...

Based on a patch from Jeremy Apthorp <[email protected]>

BUG=chromium:96894
Review URL: http...

TBR=fischman,piman
Review URL: http://codereview.chromium.org/9091010

git-svn-id: http://gyp.go...

TBR=evan
Review URL: http://codereview.chromium.org/9085007

git-svn-id: http://gyp.googlecode.c...

I tried 3 approaches:

1. extra_cflags on cc command, separate pch command
( http://coderevie...

BUG=https://github.com/martine/ninja/issues/155
TEST=manually confirmed that chrome is no-longe...

https://github.com/martine/ninja/commits/master/misc/ninja_syntax.py
Change:
* Support for speci...

BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/9074008

git...

With this, base builds (it doesn't use any 'copies' that use env vars in its name).
Once real en...

Also replace SDKROOT in libraries at gyp time, also for the make/mac build.
Now SDKROOT needs to...

Based on a patch from Jeremy Apthorp <[email protected]>

BUG=chromium:96894
TBR=tony@chromiu...

Contains a fix for http://crbug.com/108428
[email protected]
Review URL: http://codereview.c...

Instead, pass in a path remapping function. Now GetLdFlags() works
when called from the ninja ge...

It looks like this was mostly disabled by accident.
Patch from Jeremy Apthorp <jeremya@chromium....

The ninja generator changes are based on a patch from Jeremy Apthorp <[email protected]>

BUG...

https://github.com/martine/ninja/commits/master/misc/ninja_syntax.py
Notable changes:
* Support ...

This matches the current behavior and will facilitate gradually landing changes
to v8 + webkit th...

BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/9006042

git...

(Except for test/mac, which currently only runs with
xcode and make, and which doesn't work with...

Build .m and .mm files for flavor mac. This doesn't
add support for xcode_settings yet, so almos...

It's already used by 2 generators and will also be used by the
ninja generator.
Review URL: http...

unless the none target is marked with 'dependencies_traverse': 1,

TEST=coming soon, want to make...

BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/8946001

gi...

Ran:
test/variables/filelist/update_golden
test/variables/filelist/update_golden

Regressed in: ...

BUG=https://bugs.webkit.org/show_bug.cgi?id=74323
TEST=relative

[email protected]
Review U...

Ensure it is defined in the makefile before it is used, since we use
":=" in the makefile which ...

All checks that were triggered were disabled in pylintrc. I put two lists, one
of warnings that ...

Make sure that these attributes are coherent for python scripts:
- The script is indeed executab...

BUG=chromium:103273
TEST=chrome builds
TBR=mark
Review URL: http://codereview.chromium.org/86880...

Review URL: http://codereview.chromium.org/8676026

git-svn-id: http://gyp.googlecode.com/svn/tru...

BUG=chromium:103273
Review URL: http://codereview.chromium.org/8664001

git-svn-id: http://gyp.g...

No behavior change.
Review URL: http://codereview.chromium.org/8636027

git-svn-id: http://gyp.g...

Review URL: http://codereview.chromium.org/8634012

git-svn-id: http://gyp.googlecode.com/svn/tru...

BUG=chromium:104934
TEST=happier jochen
Review URL: http://codereview.chromium.org/8645001

git-...

$(SDKROOT) isn't set, so it evaluates to nothing, but not
writing it is, uh, cleaner.

BUG=none
...

I checked that all tests pass at 1092. I ran
test/variables/commands/update_golden and test/vari...

Patch from Steve Wills <[email protected]>

Original code review at http://codereview.chromium....

This finds all the varaibles that depend on other variables, performs Kahn
topolgical sort, and ...

it appears that ld.bfd is not $ORIGIN-aware and needs additional
information to figure out where...

BUG=chromium:90041
TEST=Try and roll DEPS and compile remoting_host_plugin
Review URL: http://co...

BUG=90041
TEST=test/mac/gyptest-infoplist-process.py
Review URL: http://codereview.chromium.org/...

BUG=chromium:103569
TEST=this
Review URL: http://codereview.chromium.org/8507034

git-svn-id: ht...

Currently, if library A depends on library B, we always wait until B has linked
before compiling...

Change from ensonic.
Fixed style issues.
Updated golden tests.

BUG=None
TEST=None
R=ensonic@goo...

git-svn-id: http://gyp.googlecode.com/svn/trunk@1085 78cadc50-ecff-11dd-a971-7dbc132099af

Previous output: ./gyp-mac-tool flock ?= LINK $(CXX)
Now: LINK ?= ./gyp-mac-tool flock $(CXX)
Re...

export FOO=bar doesn't work with ksh, so work around it with
a more universal syntax.

P...

Patch by [email protected] via http://codereview.appspot.com/5318049/

BUG=None
TEST=unit

...

The "Symlink Libraries" postbuild step in chromium reads it.

BUG=chromium:100990
Review URL: ht...

Actual generator change, should've been part of r1079 but wasn't.

Patch by Ben Noordhuis <info@...

Patch by Ben Noordhuis <[email protected]>!

BUG=gyp:216
Review URL: http://codereview.chromium...

[email protected], [email protected]
TEST=gyptest.py test/rules
Review URL: http://coder...