Build a library in a subdirectory, and then try to reference it using
AdditionalLibraryDirectori...

Check that the "ILT" jump tables appear/don't in the disassembly when
incremental linking is on/...

I didn't find a reasonable way to test something in the output for this one (the remaining ones ...

Verify value of compiler-set preprocessor directive.

[email protected]

Review URL: https:/...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9854036

git-svn-id: h...

Check for textual representation of flag in dumpbin output.

[email protected]

Review URL: ...

Check for [non-]/existence of a buffer security cookie in the disassembly.

[email protected]...

Generate functions with the same body, package them as COMDAT, and then make sure all or only on...

Verify that an unused function does/doesn't exist in the disassembly.

[email protected]

Re...

Reference a function from each default library. Removed odbccp32 from default
list because it's ...

http://codereview.appspot.com/5905070/

git-svn-id: http://gyp.googlecode.com/svn/trunk@1268 78c...

This is another where it'd be very hard to map flags to output contents in a
non-fragile way (es...

Fixes mac/linux ninja build.

[email protected]

Review URL: https://chromiumcodereview.apps...

Recently added exception handling test was getting optimized away on 2010
(confirmed by stepping...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9838103

git-svn-id: h...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9852013

git-svn-id: h...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9834095

git-svn-id: h...

(Fixes buildbot not having dumpbin in path, currently erroring out on r1225-1257)

R=rsleevi@chr...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9837084

git-svn-id: h...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9852014

git-svn-id: h...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9837064

git-svn-id: h...

Specify /dynamicbase:no as an additional option and use 'pefile' to verify that the flag made it...

Verify that the final executable has the correct flags specified.

Yay! Actually found a sorta-b...

Use dumpbin on obj file to make sure free function appears as separate COMDAT
entry.

R=thakis@c...

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9835073

git-svn-id: h...

R=thakis

Review URL: https://chromiumcodereview.appspot.com/9836055

git-svn-id: http://gyp.goo...

R=thakis

Review URL: https://chromiumcodereview.appspot.com/9808084

git-svn-id: http://gyp.goo...

TEST=built all.sln successfully.

git-svn-id: http://gyp.googlecode.com/svn/trunk@1251 78cadc50...

(sorry for all the noise, this one has green tries now)

Review URL: https://chromiumcodereview....

- Don't run tests on OS where they're not applicable.
- Another attempt at fixing 2005

Review U...

Unbreak VS 2005 support
Don't use flock on Windows ninja (apparently ld_target is used generally...

Previously, relying on 'cl', 'link', etc. to be in the path, so generating and
building required...

Review URL: https://chromiumcodereview.appspot.com/9699041

git-svn-id: http://gyp.googlecode.com...

With the components build, but host and target create a libbase.dylib.
With the old code, both w...

Figures: the first test I add for ninja on Windows wasn't even supported on
2010 yet.

R=thakis
...

Review URL: https://chromiumcodereview.appspot.com/9443044

git-svn-id: http://gyp.googlecode.co...

BUG=TEST=none
Review URL: https://chromiumcodereview.appspot.com/9665005

git-svn-id: http://gyp...

BUG=chromium:114970
TEST=unit
Review URL: https://chromiumcodereview.appspot.com/9651018

git-sv...

For now, this will pick /usr/bin/ibtool, but once 91675 is
fixed, it'll do the right thing.

BUG...

VC10 props and configuration attributes can be specified using 'msbuild_props'
and 'msbuild_conf...

|$(xcode-select -print-path) + Platforms/MacOSX.platform/Developer|,
which evaluates to /Develop...

This matches this cmake change:
https://raw.github.com/gist/1958550/9c03b16c370d458a7410fd045cdb...

- Add ninja to Windows runs.
Review URL: https://chromiumcodereview.appspot.com/9433026

git-svn-...

Adds win_tool (as gyp-win-tool) which is used by copy step to do a recursive mirror (removing ou...

Fixes execution of this test on Windows ninja.
Review URL: https://chromiumcodereview.appspot.co...

For some reason, there was an extra empty argument at the beginning of these
cygwin rules. It lo...

Fixes test/sibling/ on Windows ninja. In lieu of http://chromiumcodereview.appspot.com/9406035/
...

Replaced the specialness of _host with _target, b/c the _host
toolchain is usually the vanilla g...

Added support of the PlatformToolset property to Gyp (MSBuild only).

git-svn-id: http://gyp.goo...

Failing test\configurations\target_platform\gyptest-target_platform.py.
Review URL: https://chro...

Added support of the PlatformToolset property to Gyp (MSBuild only).

git-svn-id: http://gyp.goo...

Review URL: https://chromiumcodereview.appspot.com/9433030

git-svn-id: http://gyp.googlecode.com...

Not using os.path.normpath per comment and https://groups.google.com/group/gyp-developer/browse_...

If a rule has no actions, insert a no-op so that the && used for cd'ing isn't
a syntax error.
Re...

There's 2 outputs for a shared library link on Windows, the .dll and a .lib to
link other target...

BUG=none
TEST=chromium build output is almost 200 lines shorter
Review URL: https://chromiumcode...

Review URL: https://chromiumcodereview.appspot.com/9429007

git-svn-id: http://gyp.googlecode.com...

Review URL: https://chromiumcodereview.appspot.com/9425055

git-svn-id: http://gyp.googlecode.com...

The test isn't currently set up to work on Windows, but the exclusion was
previously being accom...

Review URL: https://chromiumcodereview.appspot.com/9427026

git-svn-id: http://gyp.googlecode.com...

Review URL: https://chromiumcodereview.appspot.com/9395082

git-svn-id: http://gyp.googlecode.com...

Causing an unexpected extra "." argument for some command lines, which often works, but not in s...

Review URL: https://chromiumcodereview.appspot.com/9425036

git-svn-id: http://gyp.googlecode.com...

Fixes test/defines-escaping and a couple others. (Windows shell quoting: Not
The Best Design Eve...

(product_extension explicitly specified lost its leading .)
Review URL: https://chromiumcoderevi...

- Fix copy rule for windows (mklink directory if file fails)
Review URL: https://chromiumcoderevi...

This reverts commit r1209.

This didn't quite work: we also have $(CC.target) etc.

git-svn-id: ...

A bit ugly to retrieve again via CalculateVariables, but seems better than having a second copy ...

This reverts commit r1208. Chrome builds rely on thin archives.

git-svn-id: http://gyp.googlec...

Instead, .target is considered the default, unnamed configuration,
while .host remains printed a...

Rather than probing for ARFLAGS at gyp type, just always use "crs".
This will change systems tha...

libraries go at the end of the link line, which is necessary for
this test to work on my machine...

Future change should use generator variables for prefix/suffix rather than duplicated copies.

T...

Requires a fix to MakeDirs in ninja on Windows here: https://github.com/sgraham/ninja/commit/3aa...

TEST=When a link fails in the mac/ninja build, postbuilds no longer try to run.
Review URL: http...

Review URL: https://chromiumcodereview.appspot.com/9402033

git-svn-id: http://gyp.googlecode.com...

Currently relies on 'deplist' branch of ninja. Also fix some prefixes/suffixes
for Windows. Test...

git-svn-id: http://gyp.googlecode.com/svn/trunk@1201 78cadc50-ecff-11dd-a971-7dbc132099af

Only trying to get a first test passing:

gyptest.py test/hello/gyptest-all.py -f ninja

builds...

issue=9358067
bot=gyp-linux,gyp-win64,gyp-win32,gyp-mac
project=gyp
user=scottmg
patchset=5002
ro...

General ARCHS support (fat binaries) are still unsupported.

Review URL: http://codereview.chrom...

Used in breakpad. Apparently not critical, but if it's used,
it should be supported.
Review URL:...

This allows it to be run on Windows/for MSVS via -GMSVS_VERSION=[2008,
2008e, 2010, 2010e] -GMSV...

Review URL: https://chromiumcodereview.appspot.com/9373048

git-svn-id: http://gyp.googlecode.com...

Review URL: https://chromiumcodereview.appspot.com/9370035

git-svn-id: http://gyp.googlecode.com...

No behavior change.

TBR=evan
Review URL: https://chromiumcodereview.appspot.com/9374032

git-sv...

The output is only interesting to people debugging postbuild perf,
and they can just change thei...

Helps with building 'all' in Debug in chromium.
Review URL: https://chromiumcodereview.appspot.c...

This is now the responsibility of the gyp file to set.

BUG=gyp:250

Review URL: https://chromiu...

Rather than attempting to detect this at gyp time, leave it up to
the author of the gyp file to ...

Suppose you had dependent targets A -> B -> C, where C generated
a header that was used by A. T...

Add a generator flag "msvs_list_excluded_files"
to not list _excluded_files in the generated pro...

This didn't work, since even if ARCHS has only one element, dependent targets
might have been bu...

Review URL: https://chromiumcodereview.appspot.com/9298039

git-svn-id: http://gyp.googlecode.com...

This is already rejected at input time (it's not in the set of
valid target types), so these cod...

Allows disabling UseLibraryDependencyInputs on a per-project reference basis.
This allows leavi...

Looks like this just passes now.

TBR=evan
Review URL: https://chromiumcodereview.appspot.com/92...

Also improve the test that was supposed to catch problems like this to
catch this.

BUG=chromium...

Do this the same way the make build does it, but just tacking all
postbuilds on to the last comm...

This currently passes only with the xcode generator.

BUG=chromium:95529
Review URL: https://chr...