github.com/electron/gyp commits | Ecosyste.ms: OpenCollective

Remove some unused variables reported by pyflakes

BUG=none
TEST=trybots

Review URL: https://chromiumcodereview.appspot.com/10383017

git-svn-id: ...

96301a199dd148fc47449c0920f600e5f55298ab authored almost 13 years ago

Let GYP recognize the 'WDK_DIR' environment variable when generating ninja output on Windows.

TEST=Build chrome.exe using the compiler from Windows SDK 7.1

Review URL: https://chromiumcoder...

b2903afc077e85ac2401cac09da9fced58364f12 authored almost 13 years ago

ninja: Add '/', '\', and '.' to the set of shell-safe characters.

With this, -I flags no longer get escaped. This is mostly OCD, but
a back-of-the-envelope calcul...

406fbc093108b22736fbb1bd77be25673bdc56a5 authored almost 13 years ago

Remove duplicate function definitions I accidentally added in r1357.

TBR=scottmg
Review URL: https://chromiumcodereview.appspot.com/10383073

git-svn-id: http://gyp....

3a0604feac0260b1db27c4f2bcd38599e49e6625 authored almost 13 years ago

Because the files are .c and were without warnings-as-errors, the non-declared call to printf that was intended to cause an error ended up just being a warning. So, if PCH wasn't working, the test would succeed anyway. Turn on warnings-as-errors to fix this.

Review URL: https://chromiumcodereview.appspot.com/10356060

git-svn-id: http://gyp.googlecode.c...

c047e51e4adbf28ebf6eebbf85f848d2583afda2 authored almost 13 years ago

Fixup dependencies in rules for VS2010 (MSBuild).

VS2010 uses some file tracking juju in various .tlog files to do reality-based dependency tracki...

1d54fed606d6115ae3cc3bb4c55ded088aed0c95 authored almost 13 years ago

Create a gyp generator for Eclipse CDT settings

This generate will generate an XML file that can be import into an
Eclipse CDT project. It will ...

b9227b4de8268024460b3ff08a2abac964b18a8d authored almost 13 years ago

ninja windows: fix mapping of optimization flags

"FavorSizeOrSpeed" should map to Os/Ot. These were backwards.

"Optimization" can also be set to...

797e23b7c91b2db426a5738811a44299f8a6b31a authored almost 13 years ago

MSVS 2008: Fix to ensure that actions are re-run when the command changes

There was some code to re-run an action, but it only worked if the
command change came from a ch...

b5965b0c90a4c6baf306d57bd3bcefba26c7676d authored almost 13 years ago

Remove the hack to concat .d files into a single deps file.

The speed improvements were minor (maybe 200ms) and it was
reported that on a RAM disk, it was s...

3c02308fe834c7af49f1557ac3d56be58a9b1fc7 authored almost 13 years ago

windows: test that \ at end of action arg doesn't work

Addition of test here http://codereview.chromium.org/10371002/ discovered that
VS doesn't suppor...

00b4fbddf722044f4085c787067b90c3c7f7bf25 authored almost 13 years ago

ninja windows: normalize 'call x.bat' specially

Some investigation here: http://chromiumcodereview.appspot.com/10337008/

[email protected]
...

e3a169b7d32a3e55cac69d06150d3ccc054681c5 authored almost 13 years ago

ninja windows: make sure there's a trailing slash on $(VCInstallDir)

[email protected]
BUG=125640

Review URL: https://chromiumcodereview.appspot.com/10371002

g...

a908a27056e1931a1726b9c55d9f4e96aec2bffe authored almost 13 years ago

Reland "Error on multiple files with same basenames in static library targets."

Disable the check on Android for now. The other platforms should now be fixed.

Original review:...

dcc7b2131b8a8a212e8bb604a13f5559bd2a3d89 authored almost 13 years ago

ninja windows: fix program path normalization

Fixes currently broken ninja buildbot tests.

[email protected]

Review URL: https://chromiu...

0ef41e45404ced03099f4b218122eb45fa242b66 authored almost 13 years ago

Revert r1354. The world (linux, cros, android) is not ready for it yet.

TBR=scottmg
Review URL: https://chromiumcodereview.appspot.com/10343006

git-svn-id: http://gyp....

b8ef53d4a840dbcbdea307119e2fb256010e6b9f authored almost 13 years ago

Error on multiple files with same basenames in static library targets.

Review URL: https://chromiumcodereview.appspot.com/10010028

git-svn-id: http://gyp.googlecode.co...

d12e58e297cf0345fcd9ed11494516a34ae2a1d3 authored almost 13 years ago

Don't support spaces in command, simplify msvs_emulation

The batch-file-with-space test doesn't work for the msvs generators.

I looked at trying to fix ...

c428e27ca8b967c1ed4712b8a180b29e95e8e028 authored almost 13 years ago

Assume that the compiler comes from the SDK if it is detected but Visual Studio is not installed. Use the seput script from the SDK in such a case.

Review URL: http://chromiumcodereview.appspot.com/10273034

git-svn-id: http://gyp.googlecode.c...

294e0381ea601562bd44934a7cc87fe547ee85a9 authored almost 13 years ago

Merge latest ninja_syntax.py from upstream.

Changes:
* ninja_syntax.py: Fix a bug when passing dict variables to Writer.build()
* Explicitly...

97bd1d8f114f5ca2e6f5dcb543fb338d4c2c4263 authored almost 13 years ago

ninja windows: handle more cases in program quoting

The first argument of a command (the program) can't always be quoted on Windows. In particular, ...

633226f88e77df649873460d52b697f79ddf6bd2 authored almost 13 years ago

Fix sanitize-rule-names test for scons.

The scons generator didn't remove invalid characters from rule names; remap
those. It also doesn...

52da27c0230f1c528d4bd1c721fcf3d5f68a1186 authored almost 13 years ago

ninja windows: more support for VS macros

Add support for VS macros $(InputPath) and $(PlatformName), and improve the locations where they...

e01ccc49466a67307cd3b14e027b67c0b4c207ca authored almost 13 years ago

ninja windows: sanitize rule names to not emit corrupt .ninja files

Ninja doesn't want ( and ) in rule names.

[email protected]
BUG=chromium:125606

Review URL...

d6e8bf613334e053a1c0dbdd0a26732e40ef2b61 authored almost 13 years ago

ninja windows: make sure that .s files aren't passed to compiler

[email protected]
BUG=125606

Review URL: https://chromiumcodereview.appspot.com/10270020

g...

30fc7a83b548f5a4bb11a20d01fc49bc0a28e325 authored almost 13 years ago

Exclude problematic formats from tests, rather than including all other platforms

This is more robust to changes in the set of available platforms.
Review URL: http://codereview....

891e8aba7606c57610ce512d6c8c93321b79a715 authored almost 13 years ago

ninja windows: fix expansion of some VS macros

Fix expansion of $(OutDir). Also, make sure there's no redundant path contents (.., etc.) when e...

316572adf9447041df54617c9bcd7341aae83296 authored almost 13 years ago

ninja windows: don't use copy /y nul $out for STAMP

I really can't figure out why, but using copy /y nul $out for stamp doesn't cause the changes to...

1001fa059831b66b30241a45c2295b5a6774176b authored almost 13 years ago

ninja windows: don't print blank lines in RC wrapper

[email protected]

Review URL: https://chromiumcodereview.appspot.com/10233002

git-svn-id: ...

c264119ae323f4c44b71c707caca61595f648ba8 authored almost 13 years ago

ninja windows: fix for not closing quotes on command line properly

[email protected]

Review URL: https://chromiumcodereview.appspot.com/10198022

git-svn-id: ...

e40346aefa7fc85fb018bd3698b15257726e3adc authored almost 13 years ago

Fix flakiness in test/intermediate_dir

This test is flaky because it expects the shared_intermediate action to be
re-run when target2 i...

7de43b9540a23f600c1a41b22b4b1ef4dfde8926 authored almost 13 years ago

Avoid a compiler warning in test/hard_dependency

Without this, if -Wimplicit-function-declaration is enabled, the test fails
with a warning from ...

b80e7a102ee5463d5ec8c4cac956049cc02b22fc authored almost 13 years ago

ninja windows: fix not-touched import library causing spurious rebuilds

Import lib doesn't update timestamp if exports haven't changed when incremental linking is on, w...

49d923a14c903c3f2ba2515831c2020f916f30f2 authored almost 13 years ago

ninja windows: support Use Library Dependency Inputs linking

aka actually make /INCREMENTAL flag do something useful.

When ULDI is on, the objs making up of...

93942ea156ab1994076967a8a69bffbfb81f8383 authored almost 13 years ago

Make missing files a fatal error for the MSVS generator

Missing input files cause MSVS 2010 to constantly think the
target is dirty and mark it for rec...

ebf75939050163bc7cf240f00642de8adf913357 authored almost 13 years ago

Default to VS installation and fallback to SDK setenv, rather than the opposite.

That is, only use Express/SDK if our registry detection determined that the Express version is d...

ee124269a50e20529da0debb46554bd312d8b5e1 authored almost 13 years ago

Allow GYP to detect VC++ compiler when only SDK is installed.

Review URL: https://chromiumcodereview.appspot.com/10127012/

git-svn-id: http://gyp.googlecode...

e742145e8fe779b17c5cd62cd3b0f69449981f9f authored almost 13 years ago

Adding support for "latelate" variables that get expanded after

sources + sources! + sources/ are appleid.

This allows greater use of gyp-isms in cross compile ...

1aee2469b5be5281af4c0ac742667f78862dc014 authored almost 13 years ago

Let the code from the last revision actually have an effect.

git-svn-id: http://gyp.googlecode.com/svn/trunk@1330 78cadc50-ecff-11dd-a971-7dbc132099af

3d6d213c3588291b0ac88d28d4836eb0dcad1479 authored almost 13 years ago

mac make&ninja: Temporarily accept strings instead of lists for OTHER_CPLUSPLUSFLAGS.

Review URL: https://chromiumcodereview.appspot.com/10106003

git-svn-id: http://gyp.googlecode.co...

581dcf4a237f60bcae86ef7ded8f90823847ca5b authored almost 13 years ago

mac make/ninja: Add limited support for OTHER_CPLUSPLUSFLAGS.

Allow expanding $OTHER_CFLAGS and $inherited in OTHER_CPLUSPLUSFLAGS,
since these are probably c...

05db0cd87fbd78fe8599db6a23bddf5431dd6f7d authored almost 13 years ago

Support for freebsd 9

Patch from Myles C. Maxfield <[email protected]>!

Review URL: https://chromiumcodereview.app...

5ae062720e0efd996e20db04532944487f2e8153 authored almost 13 years ago

ninja windows: fix wrappers not outputting with newlines

splitlines strips newlines, and I wasn't readding them when writing to stdout.

R=thakis@chromiu...

b65e8ff6917ddaf214365f7dd2bc0c49721080cf authored almost 13 years ago

ninja and make mac: Absolutize sectcreate paths.

Make the linker flag matching a more general, add tests,
and support unexported_symbols_list and...

59906326b3431dc9daaeabbe2625611e28545aff authored almost 13 years ago

ninja windows: output set_environment.bat to export desired environment

Along with https://chromiumcodereview.appspot.com/9967020, fixes requirement
to have run vcvarsa...

52da1bb74f964fd403496019cb317ab4bf2a5297 authored almost 13 years ago

ninja windows: strip DXSDK_DIR if SDK unavailable

On Windows, Chromium uses a reference to a DXSDK_DIR environment variable which may or may not e...

34859ca02ff8c5cc6f9b47b81d65b1b9798ee64f authored almost 13 years ago

Regression test and fix for http://crbug.com/122588.

The xcode generator can't handle if 'dependencies' contains the
same target twice, as it happens...

f43429ae11eed171d835bf1ccf13d246cc8e910f authored almost 13 years ago

Minor cleanups to the xcode generator. No functionality change.

Review URL: https://chromiumcodereview.appspot.com/10024011

git-svn-id: http://gyp.googlecode.co...

e8934c9af66645f47884f59ac08eb19f40269a40 authored almost 13 years ago

mac/make: Make bundles work when --generator-output is used.

BUG=chromium:102033
Review URL: https://chromiumcodereview.appspot.com/10020015

git-svn-id: htt...

4d8ab8c5c273662a250ebae3efea2c0368558f32 authored almost 13 years ago

ninja windows: try harder to find DirectX installation

Check registry too if environment variable isn't available.

[email protected]

Review URL: ...

77e1d06ee24e258fe7ae671579101c39b67cc270 authored almost 13 years ago

ninja windows: old versions of rc.exe (on bot) don't support /nologo flag

Emulate it in win_tool instead. Fixes red gypbot at r1317.

[email protected]

Review URL: h...

2a4fa6a7436e6e1e4b7faa06777e282970552c9a authored almost 13 years ago

ninja windows: support build of .rc files

[email protected]

Review URL: https://chromiumcodereview.appspot.com/10022004

git-svn-id: ...

fe2b8fa04d030ce015798f990ec823c738e2b1d1 authored almost 13 years ago

mac make and ninja: Keep CHROMIUM_STRIP_SAVE_FILE gyp-relative.

Now that postbuilds run in the gyp file's directory, this is
no longer required (harmful, even)....

06018e293265568ac848cd5ac7b5f02867b82696 authored almost 13 years ago

Fix red bots. It's /bin/bash, not /usr/bin/bash.

TBR=scottmg
Review URL: https://chromiumcodereview.appspot.com/10026002

git-svn-id: http://gyp....

085182c9afac547f171086ec1fe88506f7843eb6 authored almost 13 years ago

ninja windows: improve support for override of OutputFile

A few cases that were unhandled before. OutputFile override doesn't really mix
that well with pr...

32793a8056e38ff832397ad4444d3cfb1a2bf953 authored almost 13 years ago

ninja and make/mac: Fix postbuild paths.

Xcode and make treat them as relative to the gyp directory,
ninja should too.

The straightforwa...

6cde8d2820d498078f4c9b5e20a50318c627da14 authored almost 13 years ago

ninja windows: add support for $(ProjectName) macro

Renames other VS macro test to more general different directory.

(Along with a couple minor CLs...

3a51ab74d34407cec5ab2b9ae69053185d5643ad authored almost 13 years ago

ninja windows: env refactor fixes

(and unrelatedly, add assert to ExpandMacros)

[email protected]

Review URL: https://chromi...

9519c5f024935fab5dffacaa952aa4b914aa32ef authored almost 13 years ago

ninja windows: support vs macro expansion in rules

Some Windows build rules use gyp magic names, and VS macros in their inputs
and outputs. Expand ...

a53c88e4daf8e662591f36759973b9acd1f05ef7 authored almost 13 years ago

ninja windows: refactor libpath extraction to be shared between link and lib

Happens to fix that link path weren't relative-ized to .gyp file (but lib ones were) which is th...

239e5e86cf313f02862a8cb446565c8a4684a17b authored almost 13 years ago

ninja windows: Support magic idl build rules

Magically build .idl files via midl compiler if there's no other explicit
build rule specified. ...

3ea22ea93a1008564b34a2ab8727fc8ebe2057bc authored almost 13 years ago

Fixes red gypbot at r1297. gyp-win32 failing on this test on some VMs but not others (yuck!).

The root cause is that there's something slightly broken in dependency checking, either in ninja...

48dfa163862cc5801ed548b7639dbb330e79a77b authored almost 13 years ago

Export LD_DYLIB_INSTALL_NAME and DYLIB_INSTALL_NAME_BASE to postbuilds.

Also fix a bug where they didn't get exporte correctly to plists
in make and ninja.

BUG=chromiu...

dea566fe51cb78913373c853b796251f50460125 authored almost 13 years ago

ninja/mac: Don't export the environment twice to postbuilds.

Review URL: https://chromiumcodereview.appspot.com/10008016

git-svn-id: http://gyp.googlecode.co...

fbd562a5f612f88b99433c29f8325ce9c7016416 authored almost 13 years ago

Regression tests for Info.plists with LD_DYLIB_INSTALL_NAME.

When LD_DYLIB_INSTALL_NAME is set explicitly to $(bla:standardizepath)
in a bundle target with a...

e2836a080c3d26acfddeca574ee9823ffa4f3c53 authored almost 13 years ago

ninja windows: fix pdb name fom r1301

And add assert to WriteVariableList because I seem to do that every time I use
it.

R=thakis@chr...

b0f214bf6a12e6f856ba153cebc2fa0099309c58 authored almost 13 years ago

revert r1300 (returncode incorrect for link-wrapper)

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9965133

git-svn-id:...

0b2858b316bf4bbc21f950a1cb98b65eb0b323ff authored almost 13 years ago

ninja windows: make pdb named per target by default, rather than per .cc file

Reduces memory usage during final link, but otherwise doesn't change behaviour.

R=thakis@chromi...

e14a0f95b7ee63461a9c55df72d0c5a82e6fe1cf authored almost 13 years ago

ninja windows: simpler link-wrapper code

(already reviewed/suggested in previous CL)

[email protected]

Review URL: https://chromi...

77a1dbdb1d7cc2dee6c20f9777e2279c53e02f1e authored almost 13 years ago

ninja windows: suppress 'Creating library...' output

A common noisy message that messes with one-line-ninja-overprinting style.

[email protected]...

0be0875c34baa4b1fda194d161a8d439193f176b authored almost 13 years ago

ninja windows: (internal) make include handling more link library handling

Minor cleanup, makes include handling the same style as library handling is on mac & win.

Revie...

c5be8f4d8c5d33e0950903ee5b8cbbbfac73e436 authored almost 13 years ago

ninja windows: filter out /MP option

Having/not having this flag doesn't change behaviour in our case, because it
only applies to mul...

d8382145056f334114aef9d1f6e653af92df996b authored almost 13 years ago

ninja windows: add support and test for linker OutputFile setting

Redirects final binary, including support for VS macros in the filename. Note that modifying the...

7671e1043dc3130b27b741476093e738938c6da9 authored almost 13 years ago

ninja windows: support running actions under cygwin shell

Primarily:
- Convert path variables to /, but only if the action is run under cygwin
- Wrap the ...

e661e7d22d88286bba8f3c994743de4f8c9e0048 authored almost 13 years ago

ninja windows: support .def files for exports (also exe for msvs)

.def files get magically translated in build rules in VS, emulate that here.
Multiple .def files...

ba0fa88fe48c4b9c998b8a56c8f2f796a5708200 authored almost 13 years ago

Add a file I forgot to add in r1291.

TBR=scottmg
Review URL: https://chromiumcodereview.appspot.com/9956030

git-svn-id: http://gyp.g...

6df85c7dbed4e13e1160b53ba13f1fbb115d229b authored almost 13 years ago

mac make and ninja: Fix LD_DYLIB_INSTALL_NAME with DYLIB_INSTALL_NAME_BASE reference.

Review URL: https://chromiumcodereview.appspot.com/9959026

git-svn-id: http://gyp.googlecode.com...

afffbb4afb88d9597be81d274e2ee14e84bf24f2 authored almost 13 years ago

mac: Tests for LD_DYLIB_INSTALL_NAME and DYLIB_INSTALL_NAME_BASE.

Also fix a bug uncovered by this: Xcode provides a
default -install_name. (It looks like the Con...

ef3aaf46e7b74d0d5213c4fc0cfad1a4dbefece5 authored almost 13 years ago

Regex options go in re.compile(). re.search() gets a search start position.

Looks like the option wasn't needed, so remove it.
Review URL: https://chromiumcodereview.appspo...

8bd2a89676dc62c4f0374767e108cb5abbf03ddb authored almost 13 years ago

ninja windows: internal cleanup, get rid of self.configname

It was pseudo-global, kind of weird, and better off gone. I don't think I'll miss him.

R=thakis...

85c870adc1255c3d93f0280dfeea895f0726889d authored almost 13 years ago

ninja windows: handle NODEFAULTLIB linker setting

Removing the C runtime library removes the entry point that the linker
expects, so we can test b...

de7c534efc9adbcfaac148f41849d108ebd36388 authored almost 13 years ago

ninja windows: always use recursive-mirror helper for COPY

Always call win_tool helper to copy (which was previously fallback). Don't use
mklink because it...

7bdd6d857a7cd027cbd9f816e10a7e76d43cdab9 authored almost 13 years ago

ninja windows: adjust 'libraries' entries that are prefixed with -l

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9918025

git-svn-id: h...

d8bd529d28ab6befcaaf285b0ce3cc42eb4d1775 authored almost 13 years ago

Making sure we can do a cross compile from inside none type targets.

To build Native Client, we want to have a relatively clean way to
cross compile from within acti...

f5805f44bba8c7e9e5d3d59123a3fcf4247eecc5 authored almost 13 years ago

Fix an ODR violation in gyptest-postbuild.py.

Target 'dyna' in test/mac/postbuilds/test.gyp had
source 'file.c', which defined a function f(),...

e5944c88a28bffb97c2b164e61f46fc4c9dca4ff authored almost 13 years ago

Add support to xcode generator for 'none' targets with source file actions.

BUG=http://code.google.com/p/chromium/issues/detail?id=120214
TEST=actions-none
R=mark@chromium....

2f50e033f2bbdde2b168177750995e54a98a7375 authored almost 13 years ago

Change build commands to use @rsp files

Fixes erroring out with long command lines.

Review URL: https://chromiumcodereview.appspot.com/...

7c97342c8eba9aa2418a6381e876a7d2bd03df12 authored almost 13 years ago

ninja windows: Various style fixes for recently added tests

- remove all unnecessary 'product_name's
- fix _ to - in filename
- normalize order of 'msvs', a...

89fcd93b01b73e1666ad96aac77e8d04f37d01d9 authored almost 13 years ago

ninja windows: Fixes for recently added tests

- NXCOMPAT default behaviour was incorrect, make ninja match msvs IDE.
- Debug info pdb name was...

4c1544f0fb7ae571011b32626c3b8cf72f9a2df1 authored almost 13 years ago

ninja windows: test for linker fixed base address flag

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9864003

git-svn-id: h...

29c55697dba4bbc0b4d9ca04cc0ea54623e9ba46 authored almost 13 years ago

ninja windows: test for linker additional library directories

Build a library in a subdirectory, and then try to reference it using
AdditionalLibraryDirectori...

db7808a22a67ccaa736ca66dd67871ea4d4db0ba authored almost 13 years ago

ninja windows: test for incremental linking flag

Check that the "ILT" jump tables appear/don't in the disassembly when
incremental linking is on/...

a77815760b3f94870063d9a04e9409287d99019a authored almost 13 years ago

ninja windows: test for debug format setting

I didn't find a reasonable way to test something in the output for this one (the remaining ones ...

1b4c13d05949334bd9d69083a51919c5811bcc25 authored almost 13 years ago

ninja windows: add test for RTC flag

Verify value of compiler-set preprocessor directive.

[email protected]

Review URL: https:/...

fa562dd448da8e17f186ba786a1ef3255850da6c authored almost 13 years ago

ninja windows: test for linker debug information flag

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9854036

git-svn-id: h...

689ff09e42b34085055258297132820631629555 authored almost 13 years ago

ninja windows: test for nxcompat linker flag

Check for textual representation of flag in dumpbin output.

[email protected]

Review URL: ...

4be724ff3253a772f0f212c117515e0d525d8abb authored almost 13 years ago

ninja windows: test for buffer security setting

Check for [non-]/existence of a buffer security cookie in the disassembly.

[email protected]...

45c609c67e3b4d3fd3c7ec8919149297cd420546 authored almost 13 years ago

ninja windows: test for opt:icf/noicf

Generate functions with the same body, package them as COMDAT, and then make sure all or only on...

cd83cb9cf7101ba364cbc2a7b31c070bf409dfa9 authored almost 13 years ago

ninja windows: test for opt:ref/noref

Verify that an unused function does/doesn't exist in the disassembly.

[email protected]

Re...

9915ca1cff1734983a5fc4afb0cfd43b0e858c88 authored almost 13 years ago

ninja windows: test that default libraries are correctly linked against

Reference a function from each default library. Removed odbccp32 from default
list because it's ...

2ff4ba441bf0f0a03f324e041567fadc121619c8 authored almost 13 years ago