Works insofar as the project files load in VS2012, the ninja environment points to the correct c...

This resulted in double call to flock on linux/make.

BUG=http://code.google.com/p/chromium/issu...

Issue was introduced by r1466.

R=bradnelson,scottmg
Review URL: https://chromiumcodereview.apps...

These get baked into the generated build file if they
are set at gyp time.

BUG=
TEST=compiler-o...

the scripts early.

There are three cases:
* Command is a batch file
* Command is an exe/com
...

This fixes a couple of problems:
- CONFIGURATION_NAME is now getting set. This seems to be a req...

muck with environment variables
Review URL: https://chromiumcodereview.appspot.com/10830232

git-...

incorrectly generated without a trailing slash on MSVS 2008.

This only manifested as an issue wh...

When shlex was getting an arg like:
r'"some\interesting\path.file" other_file'

shlex was turn...

This is mostly for goma builds.
Review URL: https://chromiumcodereview.appspot.com/10837168

git...

This new patch should fix the mac bot issue.

Took over from http://codereview.chromium.org/9649...

git-svn-id: http://gyp.googlecode.com/svn/trunk@1462 78cadc50-ecff-11dd-a971-7dbc132099af

Should fix mac bot this time

Took over from http://codereview.chromium.org/9649016/

BUG=14090...

git-svn-id: http://gyp.googlecode.com/svn/trunk@1460 78cadc50-ecff-11dd-a971-7dbc132099af

BUG=chromium:141132
[email protected]

git-svn-id: http://gyp.googlecode.com/svn/trunk@...

Fixed mac bot issue.

Took over from http://codereview.chromium.org/9649016/

BUG=140900
TEST=se...

Code review: https://chromiumcodereview.appspot.com/10836144/

BUG=chromium:141132

git-svn-id:...

git-svn-id: http://gyp.googlecode.com/svn/trunk@1456 78cadc50-ecff-11dd-a971-7dbc132099af

minor python style cleanups

Add GypError exception class for user visible errors

BUG=

Review ...

BUG=http://code.google.com/p/gyp/issues/detail?id=290

Review URL: https://chromiumcodereview.ap...

Took over from http://codereview.chromium.org/9649016/

BUG=140900
TEST=set CC/CXX to cross-com...

git-svn-id: http://gyp.googlecode.com/svn/trunk@1452 78cadc50-ecff-11dd-a971-7dbc132099af

[email protected]

git-svn-id: http://gyp.googlecode.com/svn/trunk@1451 78cadc50-ecff-11dd...

======
Pass defines to midl.exe.

Code review: https://chromiumcodereview.appspot.com/10843056/
...

TEST=Build chrome.exe using the compiler from Windows SDK 7.1

Review URL: https://chromiumcoder...

Took over from http://codereview.chromium.org/9649016/

BUG=None
TEST=set CC/CXX to cross-comp...

Part of upstreaming, adding top-level ninja flag indicating that 'depfile'
entry is a key for th...

Windows ninja binary in depot_tools currently supports both as synonyms. One
suggestion Evan had...

For XCode: Fixing problem when 2 sources have the same normalize path, but not
the ...

Don't report backtrace of skipped tests by default.

Use dict.pop() to retrieve and remove eleme...

[email protected]
BUG=gyp:289

Review URL: https://chromiumcodereview.appspot.com/10837010

...

The handling of $! variable was supposing that the path was starting with the
variable, and was ...

This adds an additional heuristic to the existing one. Now if an option begins
with either a '/'...

This matches the Xcode behavior of SDKROOT treatment. For SDKROOT values that
don’t begin with m...

Apparently (per http://build.chromium.org/f/client/gyp/) using a .def file
makes the linker thin...

Was warning when value set to 'false'. Herp derp. :(

[email protected]

Review URL: https...

Basic support of manifest files being generated. There's two steps to this,
the first is to have...

oriented correctly.

I'm not sure if this is the 'best' way to accomplish this. A better way migh...

Hermetic cygwin isn't part of the gyp checkout.
Bare actions can't be tested, without using msvs...

Patch from Benjamin Lerman <[email protected]>!
Review URL: https://chromiumcodereview.appspot.co...

When linking an executable, every directory in mac_framework_dirs must be
added as a -F option.
...

This is useful in cases where environment variables are updated by scripts and
so may contain du...

Specifically, action strings would render like:
'action': ['python', '-c', 'print \'Hello wor...

Fix symbol export and exe extension to work on Windows. Enable incremental
linking which makes t...

- Avoid trailing whitespace when list is empty
- Use new line for every entry, including first e...

Add a new backend to gyp, "android", which creates Android.mk style
makefiles. This can be used...

You can still select 2008 or 2005 by setting GYP_MSVS_VERSION.

When running tests, try 2010 fir...

This ports http://code.google.com/p/gyp/source/detail?r=1425 to mac.

Without this change, incre...

This makes it so that changing component-internal implementation details only
causes the compone...

It's used for chrome build on Android. Ant needs
to know the build type from this variable:
http...

If these variables aren't available, some tools error out (unable to create temp files, etc.)

R...

- Add support for .asm files for win32
- Add support for msvs_target_platform
- Update x64 test ...

Hash rule_name/unique_name for now to make the path shorter and get builds working again. We sho...

Isolate from the running environment, and make sure we're directly using the correct python bina...

Instead of having one wrapper that happens pre-ninja to set up the compiler
environment, extract...

Previously, local version of ninja had modified $in to be \n separated when in response files. U...

This allows to click on messages in visual studio to open file with error or warning.
By default...

The description for external rules (where msvs_external_rule != 0) had been set to the full comm...

Currently, if two multiple targets in different directories use the same name,
gyp's behaviour ...

TEST=test/same-source-file-name

git-svn-id: http://gyp.googlecode.com/svn/trunk@1414 78cadc50-...

TEST=test/same-rule-output-file-name
Review URL: http://codereview.chromium.org/10538055/
Patch ...

'EntryPointSymbol' translates to /ENTRY: in linker flags. This is needed by Chrome's mini_insta...

TEST=test/sanitize-rule-names/

Review URL: http://codereview.chromium.org/10535052/
Patch from ...

In some cases, an action is only evaluated under certain conditions.
This works in the make gen...

'ResourceOnlyDLL' translates to '/NOENTRY' in linker flags :/. Allows creating
DLLs that contain...

To match VS (and fix some .rc build steps in Chromium targets)

BUG=chromium:128729

Review URL:...

dump_dependency_json was only outputting #target targets, not #host. Add
generator_supports_mult...

No functionality or performance change.
Review URL: https://chromiumcodereview.appspot.com/10442...

This change would, e.g., catch if -Wno-invalid-offsetof were given when building
a C (or Obj-C) ...

Building libvpx on Linux requires knowledge of the static library file.
Assign the directory pat...

Multiple actions in a single none target fail to all depend correctly on
the stamps from all the...

This makes the functions a bit less indented.
No functionality change.
Review URL: https://chrom...

cd test/variables/commands ; ./update_golden ; cd -
cd test/variables/filelist ; ./update_golden...

If someone wants to debug this, they can just add a local print statement.

32s -> 29.5s for nin...

Speeds up ninja gyp time on mac from 34s to 31.8s.

BUG=chromium:82230
TEST=none
Review URL: ht...

Makes gyp with GYP_GENERATORS=ninja file generation 20% faster.

BUG=82230
TEST=none
Review URL:...

Make existing msvs-only test for PCH be msvs+ninja. Adds various flags to cflags and build rule ...

Review URL: https://chromiumcodereview.appspot.com/10451028

git-svn-id: http://gyp.googlecode.co...

Prior review:
https://chromiumcodereview.appspot.com/10399131/

Fixing more lint warnings.

BUG=...

Normally gyp files use 'includes', or 'msvs_system_include_dirs', but the msvs
generator support...

BUG=None
TEST=None
[email protected],[email protected]
Review URL: https://chromiumcoderev...

Mt should have been Manifest.
Perils of tests that recaptiulate the implementation.

BUG=http://...

Similar to:
http://code.google.com/p/gyp/source/detail?r=1388

BUG=None
TEST=None
R=thakis@chrom...

This allows static library targets to export headers like frameworks so they
can be packaged up....

Review URL: https://chromiumcodereview.appspot.com/10408026

git-svn-id: http://gyp.googlecode.co...

TBR=scottmg
Review URL: https://chromiumcodereview.appspot.com/10413004

git-svn-id: http://gyp....

TBR=evan
Review URL: https://chromiumcodereview.appspot.com/10332236

git-svn-id: http://gyp.goo...

Use this to make gyptest-objc-gc pass with both Xcode 3 and 4.
Review URL: https://chromiumcoder...

Review URL: https://chromiumcodereview.appspot.com/10409007

git-svn-id: http://gyp.googlecode.co...

This change caused a performance regression in the Windows incremental
build on the Chromium bot...

Per discussion here: https://chromiumcodereview.appspot.com/10387164/

[email protected]

R...

The previous method (only setup on first iteration of loop) didn't respect
that the actions migh...

'all' are all targets transitively referenced by all.gyp. For example:

all.gyp:
targets: [
...

r1378 broke on ninja, not because of command line too long, but because there was no inputs spec...

1. Commands were previously joined with &&, which resulted in the command line being too long
2....

defined, so that IntDir can use the definition of OutDir by topologically
sorting references to m...

Review URL: https://chromiumcodereview.appspot.com/10383117/
Patch from Marshall Greenblatt <mar...

Review URL: https://chromiumcodereview.appspot.com/10384109

git-svn-id: http://gyp.googlecode.co...

This is now fixed in the upstream gyp files and no longer necessary.
Review URL: https://chromiu...

Discovered that: 1) the long command line test wasn't testing all the link
command line (.lib an...