github.com/electron/gyp commits | Ecosyste.ms: OpenCollective

Allow variables with magic suffixes (_files, et al.) to be excludable and matchable with 'sources!/'.

R=mark
BUG=16395
TEST=projects are still generated correctly for all platforms.

Review URL: htt...

3c6be73f03a003ecf21c151daa3276405a5c0e39 authored over 15 years ago

When using msvs_cygwin_shell: 0, the first parameter might contain

forward slashes, these should be preserved.

BUG=None
TEST=None
TBR=sgk

Review URL: http://coder...

7579cbe19e443be917bc014b6ad0a5d89758e786 authored over 15 years ago

Switching 'none' targets back to Utility.

Adding a new 'dummy_executable' type which is like none but with
generates a junk exe in IntDir t...

a6b0f51899dacbe82bdcad681dca213b07c8b68c authored over 15 years ago

Switching 'none' to executable as it turns out lib does not enforce IB's

build order as hoped either.

BUG=None
TEST=None
TBR=sgk

Review URL: http://codereview.chromium...

8d9e0c0dbbdc5c4da500c6312dcfcd1231a82176 authored over 15 years ago

Adding workaround to deal with incredibuild not building things in the

right order with type 'none'.

BUG=None
TEST=None
TBR=sgk

Review URL: http://codereview.chromium...

bf29b382712b0a7ce1446d3e06d4468439564356 authored over 15 years ago

ExpandVar doesn't print the input file name on error

Make the error more informative.

Patch contributed by Florent Thoumie
BUG=45

Review URL: http:...

02fc820076c8f8e424adf39361013404ec63c9c0 authored over 15 years ago

gyp.bat hates paths with spaces

In Windows, if a path has spaces you are expected to enclose it in quotes.
gyp.bat fails to do t...

2a68998d9e36c714a0232d1468f8aa1453c23bc2 authored over 15 years ago

Paring back the overzealousness of the last change.

It was excluding inputs with triggers hooked to them.

BUG=None
TEST=None
TBR=sgk

Review URL: ht...

69a844a7e628d0b14484465bad7477cdc956c1f6 authored over 15 years ago

Apply issue 27 to help with FreeBSD support.

Note that the patch didn't apply completely.

Review URL: http://codereview.appspot.com/88144

...

eb7c9bd26b721bb5812fc4b9ef7a05cad482531c authored over 15 years ago

Excluding inputs to actions from being processed by usual msvs handling.

Additionally including rule inputs as sources automatically.
Sundry cleanup.

BUG=43
TEST=None

...

f6fe18378ca01859cbcda0ea2443d2947124fef3 authored over 15 years ago

http://code.google.com/p/gyp/issues/detail?id=16

add a generator flag for controlling the parallel building of targets.
Review URL: http://codere...

91ad8f838fbffd7d169788b5f5fe611a5ed1a872 authored over 15 years ago

Support a generator flag output_dir to control the name of the build dir; defaults to "out" still.

Allows '-G output_dir=sconsbuild' to have the output dropped where a bunch of scripts expect. (...

ffb7f2a66fb0748a0e8db6943a686f936a9bb8cd authored over 15 years ago

Add a few more files and fix v8 for cpg & dfg

Review URL: http://codereview.chromium.org/151116

git-svn-id: http://gyp.googlecode.com/svn/trun...

a54384dfdb2cacc542c1dcf30a72f548ba80d0ad authored over 15 years ago

Makefile generator: add some comments.

git-svn-id: http://gyp.googlecode.com/svn/trunk@534 78cadc50-ecff-11dd-a971-7dbc132099af

7a5f7e4bdfa995d5e2f8ffa30935486b5adf1401 authored over 15 years ago

Support the suffix option in makefile generation.

Review URL: http://codereview.chromium.org/150130

git-svn-id: http://gyp.googlecode.com/svn/trun...

66e94ca02dc0e18c0121abdae0ce2d6ae9e38a28 authored over 15 years ago

Fixing typo down in auto vs detection.

BUG=None
TEST=None
TBR=mad

Review URL: http://codereview.chromium.org/151102

git-svn-id: http:...

e8fcdc9c5ddcf71b745e3d513faaf3e73fa87386 authored over 15 years ago

Let the generator say if it wants absolute build file paths.

Review URL: http://codereview.chromium.org/150123

git-svn-id: http://gyp.googlecode.com/svn/trun...

e4690810903d6bb7613fe97666f4deb0229c8d1b authored over 15 years ago

Make a helper for splitting lists of strings (name=val) into dictionaries.

Use the helper for the defines.
Turn generator flags into name/value pairs.
Use the helper for ge...

413fae9c2f955a0e4898c51a2d9c76aa1a493b83 authored over 15 years ago

Makefile generator: install loadable_modules like executables

This is necessary for the plugin tests.

Review URL: http://codereview.chromium.org/150080

git-...

fbb339dfacf879d2466a66da2e224561d7d31af5 authored over 15 years ago

Changing msvs generator to put ()s around sln folder names.

This will allow people to build individual projects by name at the command
line (as they did pre-...

83cf5fa46591cc80fc8655a2046afab1a531cd42 authored over 15 years ago

Makefile generator: Fix paths when run from gclient runhooks

Patch from Antoine Labour.

git-svn-id: http://gyp.googlecode.com/svn/trunk@527 78cadc50-ecff-11...

ca8bf9a1c07f7c0b0bdae325e73a4314143591aa authored over 15 years ago

Makefile generator: fallback on 'cp' if 'ln' fails.

Useful when your build output is on a different file system.

http://code.google.com/p/chromium/...

82a377ad476cdc4e59ba498fd7e72322f42c4c53 authored over 15 years ago

Reverting the r523 change for parens matching <!() expansions. It

breaks the following test case:

{
'conditions': [
['OS=="linux"', {
'targets': [
...

7c98c1d4645139cd00f59628db79061a05a02774 authored over 15 years ago

Set the IgnoreImportLibrary property for VCLinkerTool definitions

of loadable_module targets, so dependent targets don't expect an
import library to be created.
Re...

471c43836bd8ed68bdcf41d3f8b7ba1904de007c authored over 15 years ago

Here's a fix for the paren matching in <!() expansions. It now will correctly match parens within a command substitution, although there is no way to escape parens, so you couldn't currently have a command substitution like <!(echo ")") or <!(echo \)), but that could be added later.

In addition to the paren matching, I also do recursive expansion of <!() expansions (but NOT oth...

d0c3a1b4b6050db148e0cb12990a64b97445cc8d authored over 15 years ago

Support cflags_c and cflags_cc in the Makefile generator.

This allows you to pass flags specific to just C or C++ compilation.
This should make the curren...

576a12d92691c3aff4ead0c5e91e9eef9521c0a2 authored over 15 years ago

Change the name of SCons target-specific intermediate directories from

${TARGET_NAME}/intermediate to _${TARGET_NAME}_intermediate, to avoid
conflicts trying to use the...

26af493e88ebd09d275c46c93342c7b796369c03 authored over 15 years ago

Move up the fetching of the home dir so we can use it for a few things.

Add a TODO for defaults.
Support GYP_GENERATORS env var for controlling what is generated (comman...

817da792b2cee3bbcc185045deae8b0fce2739cb authored over 15 years ago

Factor out the creation of the generator and its necessary supporting

data structures into a reusable gyp.Load() function.
BUG=none
TEST=none
Review URL: http://codere...

fde9c3ff08e1db97b77bc639ffb6849be5fb74d8 authored over 15 years ago

Submitting on behalf of [email protected]

BUG=None
TEST=None

I added the abililty to specify command variable substitutions as
'<!(["pyth...

a53e67d5c73850541c5979de6efc03e252443379 authored over 15 years ago

Sorting projects by name then guid so they show up in order on vs2008.

Review URL: http://codereview.chromium.org/126135

git-svn-id: http://gyp.googlecode.com/svn/tru...

0653084808e10c7bf97047ed91a3ccdeb5dc27c0 authored over 15 years ago

Gotta import glob before you can use glob.glob()...

Review URL: http://codereview.chromium.org/126097

git-svn-id: http://gyp.googlecode.com/svn/trun...

6bd1322d9c40c09837e56f411be2f688a1f79f34 authored over 15 years ago

Fix cut-and-paste error.

git-svn-id: http://gyp.googlecode.com/svn/trunk@515 78cadc50-ecff-11dd-a971-7dbc132099af

0c9d1634d1ec09cfe883c49295b2747df35c27cb authored over 15 years ago

Add support for a 'resource_include_dirs' setting that will be used in

preference to 'include_dirs' for Windows resource compilation.
Review URL: http://codereview.chro...

a0f8fc665e0a870cf477dfeb49f007a1c8f69bd9 authored over 15 years ago

Allowing components to introduce global gyp includes.

Review URL: http://codereview.chromium.org/125006

git-svn-id: http://gyp.googlecode.com/svn/tru...

2a0f4a117882f965670046a58d898a7b0616515b authored over 15 years ago

Revert the input change since it actually has to work in two modes and this doesn't handle both.

Review URL: http://codereview.chromium.org/122050

git-svn-id: http://gyp.googlecode.com/svn/trun...

13184c46b66a9fd2cc6e56fb8865cebf57321882 authored over 15 years ago

Remove the assert, it's not valid.

Review URL: http://codereview.chromium.org/123029

git-svn-id: http://gyp.googlecode.com/svn/trun...

47502e4b56bf6ff881541e815a1eea6bda039229 authored over 15 years ago

Fix a bug in the make build where actions where run with

absolute paths. Instead, cd into the directory where the
action is and run it with relative paths...

75a14aafd47250072bfabc17dd4ca75dd4d1be8b authored over 15 years ago

Xcode project generation:

Fix typo for fetching build settings from config list.
When adding a dependency, don't auto l...

56b048d3d60659511ff980fba288078f428c4ced authored over 15 years ago

Switching vs2008 generation to opt in.

Review URL: http://codereview.chromium.org/119185

git-svn-id: http://gyp.googlecode.com/svn/tru...

00d77f6af8076182f5c5d930b29fec97c47fc438 authored over 15 years ago

Adding support for using checked-in canned vcproj files in a gyp generated sln.

Review URL: http://codereview.chromium.org/119012

git-svn-id: http://gyp.googlecode.com/svn/trun...

c6f25046eac63e80cb1337204587824389abf6e9 authored over 15 years ago

Submitting change for ajwong.

See: http://codereview.chromium.org/118021

Review URL: http://codereview.chromium.org/118055

gi...

4b8a30b02c135fd83ae04c104552c98056a2ad6b authored over 15 years ago

Fixing msvs generator sln tree collapsing to handle

the case of folders that match project names.

Review URL: http://codereview.chromium.org/118027
...

ec88b0f42f3b537ea89b1fd9f2396a63729370ff authored over 15 years ago

Add a way for generators to provided keys that should also be matched for rules.

Have the xcode generator support rules on the mac bundle resources.
If a rule source comes from...

6bfd4530db863baa22944fe9564d9f12586ab472 authored over 15 years ago

fixing some comments up for style

git-svn-id: http://gyp.googlecode.com/svn/trunk@503 78cadc50-ecff-11dd-a971-7dbc132099af

565b6377c2de175e7177cc9fd3dcf957b37601d9 authored over 15 years ago

Add a generic way for generator info to get passed to input to affect processing, this allows the generator to have optional keys with data that can extend input processing.

Split the path keys (for keeping things relative) into a base set and allow the generator to exte...

a887771018238c16ecbc9ef66bbc38becce0f0fe authored over 15 years ago

Use the internal SCons Copy() Action factory to preserve symlinks when

copying trees without relying on platform-dependent features.
Review URL: http://codereview.chrom...

80f43f70ca20fcacf766fbf70450c488be09b782 authored over 15 years ago

Creating a folder tree in the sln's based loosely on the actual

project hierarchy.

Review URL: http://codereview.chromium.org/115892

git-svn-id: http://gyp.goo...

6c47da4a65c2f9e159a58fd9243ba57c406678de authored over 15 years ago

Add a function to fetch the installed version of Xcode.

We're not using this yet, but the objectVersion in files created with 3.2 is different, so we'll...

d2b869f20e7b69f5de48a911d1984d9a3c3133ea authored over 15 years ago

Allowing msvs_settings to set OutputFile (so alternate paths can be used).

Review URL: http://codereview.chromium.org/115715

git-svn-id: http://gyp.googlecode.com/svn/tru...

2a9dc0f0254fddc8fb006afb1e628030542f0d3a authored over 15 years ago

Suppressing error output for mkdir.

Suppressing bogus error return (we'll rely on the copy failing instead).

Review URL: http://code...

f546e686d73c5aac02690e3438a30ec3dd078075 authored over 15 years ago

Make copied files part of target_files, not prerequisites, so they get

installed even if the target has no other output files.
Review URL: http://codereview.chromium.or...

968c25bf11142cca1d4e832c003f6d4b2457b07e authored over 15 years ago

Producing smaller command lines and doing -j PROCS+1

Review URL: http://codereview.chromium.org/112034

git-svn-id: http://gyp.googlecode.com/svn/tru...

f7e924c2f6ae5d7cbcf50ca93421788dab991ee9 authored over 15 years ago

Do mkdir up front for makefile rules, rather than per item.

Review URL: http://codereview.chromium.org/115480

git-svn-id: http://gyp.googlecode.com/svn/tru...

e484c600d79a6efe656ba76994477707e0e38817 authored over 15 years ago

Only use one outputs in the target list, as make does the wrong thing when

there are multiple outputs.

Review URL: http://codereview.chromium.org/115476

git-svn-id: http:...

4b5703e7aeeee007211f77e0b01caf3eccd74e15 authored over 15 years ago

Determine the number of CPUs in a POSIX-friendly way on UNIX. Also support

OSX and Windows.

BUG=7942

Review URL: http://codereview.chromium.org/112015

git-svn-id: http:/...

3e61ad694be27d8ff6dae6ea8bc422ea394023d5 authored over 15 years ago

Using := instead of = in generated makefile.

Calling cygpath over and over is bad!
Dropping leftover commented out stuff.

Review URL: http://...

2c428264013f36c2bd71689a08101b60d7177c25 authored over 15 years ago

Fixing bad merge with my other change.

Review URL: http://codereview.chromium.org/113508

git-svn-id: http://gyp.googlecode.com/svn/tru...

891ff6696d1709c99b420b76a855674d33c16f9f authored almost 16 years ago

Enhanced msvs generator so that it can optionally emit makefiles for

selected rules.
Added support for 'message' in rules and actions.
Cleaned up some aspects of rule...

e296957aaca033cab95ac2f28f9aac08d816528c authored almost 16 years ago

Catch as a value error so we don't each keyboard interrupts.

Review URL: http://codereview.chromium.org/113362

git-svn-id: http://gyp.googlecode.com/svn/trun...

930fb712bd6c876da2e7806ce88385acba7d14e2 authored almost 16 years ago

Fixing bad handling of 0 with msvs_cygwin_shell.

Python needs static types.... sigh.

Review URL: http://codereview.chromium.org/115307

git-svn-i...

03f799256e0984f1ff6049b4b706d92ffc050f5f authored almost 16 years ago

Added support for 'inputs' in 'rules'.

These get translated into additional dependencies for the rule.

Review URL: http://codereview.ch...

dd4b6b1881885ab9c8d49e93a37f9ca36e1afc1e authored almost 16 years ago

Restoring old default behavior to lib/

Review URL: http://codereview.chromium.org/114022

git-svn-id: http://gyp.googlecode.com/svn/tru...

e5c88385322696ada79e838cf1df02f304cba725 authored almost 16 years ago

Make variable expansion handle int variables.

Review URL: http://codereview.chromium.org/113300

git-svn-id: http://gyp.googlecode.com/svn/trun...

d07ae6bf9612cd9b36b063724371ce10e8a058b4 authored almost 16 years ago

Fixing up the path handling when calling things thru cmd.

Review URL: http://codereview.chromium.org/115214

git-svn-id: http://gyp.googlecode.com/svn/tru...

d359b8ea969120b86dc41277d030b63eca1ea002 authored almost 16 years ago

Adding support for product_name on windows.

Review URL: http://codereview.chromium.org/99307

git-svn-id: http://gyp.googlecode.com/svn/trun...

de41f4c70d5429f41d28f7e72cdfec3b4fb74ace authored almost 16 years ago

Try to convert default values to ints instead of always making them strings, this supports variables that want integer values.

Review URL: http://codereview.chromium.org/113280

git-svn-id: http://gyp.googlecode.com/svn/trun...

18edfdaa043171e5686ec89f8e956a232e40fb8f authored almost 16 years ago

Taking out vs2005 override, as it now resides in the buildbot config.

Review URL: http://codereview.chromium.org/113228

git-svn-id: http://gyp.googlecode.com/svn/tru...

6f603e738b74bc1a34d7ea96320042507056bad9 authored almost 16 years ago

Explicitly generate vs2005 project files when run on the buildbots.

Review URL: http://codereview.chromium.org/114019

git-svn-id: http://gyp.googlecode.com/svn/tru...

94789ac7c44413249449e88cf113f66b1e333ae0 authored almost 16 years ago

Add msvs generator support for different visual studio versions.

At this point only the version number is tweaked,
which is enough to prevent visual studio from c...

d849f28a8e9e439717051caaee6a8be1d4ba4ad0 authored almost 16 years ago

Add __repr__() methods for friendlier descriptions of what

a given object actually represents, e.g.:
<PBXFileReference 'webdatasource_impl.cc' at 0x11bc850>...

38d14aa8e16fa6251a0b45469873e0ea5400f4a2 authored almost 16 years ago

Remove the call to setup_mount.bat on every command invocation.

We'll make sure this is done with a specific target for it.
Review URL: http://codereview.chromiu...

4395205d438d9da0deedfefa44ea4cacfaf9ea91 authored almost 16 years ago

If the source file for a copy begins with an absolute path

or a '$' (a variable), don't prepend $(ProjectDir).
Review URL: http://codereview.chromium.org/11...

11923abad40fb38ca217febde055c9af4dc114e2 authored almost 16 years ago

Allow product_extension in Xcode generator

Review URL: http://codereview.chromium.org/113111

git-svn-id: http://gyp.googlecode.com/svn/trun...

4d6b2679749b27ad04944251692892c17e5aa5a7 authored almost 16 years ago

Makefile generator: handle missing files in dependency lists.

Thanks to "Managing Projects with GNU make"!

Review URL: http://codereview.chromium.org/113061
...

bb0fb30d25fc36568d3e453ca2d942f6ea83977c authored almost 16 years ago

Make the local --mode= and --verbose= options (more) discoverable

by explicitly adding them to the -h help text.
Review URL: http://codereview.chromium.org/114008
...

fe86fec812143df0f08346541fe3afc8e39f4db9 authored almost 16 years ago

Removing excess space that can cause issues on some systems.

Review URL: http://codereview.chromium.org/100365

git-svn-id: http://gyp.googlecode.com/svn/tru...

2fc26bffed130e29a709fa397153db7f28419105 authored almost 16 years ago

Use hashlib/md5 in a way that avoids deprecation warnings and is

backwards-compatible.
Review URL: http://codereview.chromium.org/100339

git-svn-id: http://gyp.g...

0237d55fbc1af90bf8de8c0206030225c6e211c6 authored almost 16 years ago

Makefile generator: more cleanups, order-only deps, restore shared link.

git-svn-id: http://gyp.googlecode.com/svn/trunk@462 78cadc50-ecff-11dd-a971-7dbc132099af

8df7f009111c20f6a70644c00cf2f3ac86fb9b74 authored almost 16 years ago

Makefile generator: previous commit used wrong variable.

git-svn-id: http://gyp.googlecode.com/svn/trunk@461 78cadc50-ecff-11dd-a971-7dbc132099af

623f6665978d7f799825bdea08b36b32b7304d3b authored almost 16 years ago

Makefile generator: actions/rules need to happen before any compiles.

git-svn-id: http://gyp.googlecode.com/svn/trunk@460 78cadc50-ecff-11dd-a971-7dbc132099af

06a9a48311d204fc582c76c668959dd85463aed1 authored almost 16 years ago

Makefile generator: significant refactoring for cleanup.

git-svn-id: http://gyp.googlecode.com/svn/trunk@459 78cadc50-ecff-11dd-a971-7dbc132099af

0a445a124e9b7e1069bc405746036256bc515f17 authored almost 16 years ago

Makefile generator: output directory must be exactly two dirs deeper than src/.

git-svn-id: http://gyp.googlecode.com/svn/trunk@458 78cadc50-ecff-11dd-a971-7dbc132099af

86531b60fd9c5beb5265e7d61a2ad5bdf97c95ce authored almost 16 years ago

Makefile generator: absolutify paths used in copy rules.

git-svn-id: http://gyp.googlecode.com/svn/trunk@457 78cadc50-ecff-11dd-a971-7dbc132099af

a63ecb43e5e6e0a7da79fd80d05447b97f744b26 authored almost 16 years ago

- Use a local flag to tell if the project already has an 'All' target, and don't generate one (assume they are controlling it for a reason)

- When generating an 'All' target, only do it if there are tests that are allowed to be included ...

83891a83bee6f9ab4a471d2ef74ce5c28fc81c64 authored almost 16 years ago

Makefile generator: previous cleanup caused us to lose LDFLAGS.

git-svn-id: http://gyp.googlecode.com/svn/trunk@455 78cadc50-ecff-11dd-a971-7dbc132099af

59ac89c0a6df0e453edb8cf1c138ae6dbfd65885 authored almost 16 years ago

Makefile generator: support Release builds; include build type in output dir.

git-svn-id: http://gyp.googlecode.com/svn/trunk@454 78cadc50-ecff-11dd-a971-7dbc132099af

7d8441dfa244206546f1fc8e1c15e0b4840ccc20 authored almost 16 years ago

Makefile generator: eliminate some hacks. Remove local_CFLAGS.

git-svn-id: http://gyp.googlecode.com/svn/trunk@453 78cadc50-ecff-11dd-a971-7dbc132099af

0eac038be2935f2bae1a8898b44e3275a4eb9bdc authored almost 16 years ago

Remove duplicate --mode= configurations.

Review URL: http://codereview.chromium.org/100188

git-svn-id: http://gyp.googlecode.com/svn/trun...

7509f193028a2194993993bff48e2fc5aa627a3d authored almost 16 years ago

Hook up the internal alias that we're going to use for an action-only

target with the actual publicly visible target name. This requires
calling env.Alias() instead o...

35b9b2e62b49d6408610df9ca55d08ac36704fa5 authored almost 16 years ago

Turning on setup_mount for everything, just to be safe.

Using set CYGWIN=nontsec, as this seems to be required on some machines (buildbots).

Review URL:...

6380a4405fb1393169fae7a6dd242ddafc1fc450 authored almost 16 years ago

Always test changes before commit....

Changing the way TMPDIR is generated, since it collided with string substitution.

Review URL: ht...

764891a1830c52df3f4f28bfcfba57270b7d7536 authored almost 16 years ago

Defining TMPDIR, since dftables requires it.

Review URL: http://codereview.chromium.org/99176

git-svn-id: http://gyp.googlecode.com/svn/trun...

078566908be59853b6ec342fdc10149b53d4f946 authored almost 16 years ago

Add generated help text which provides the list of available target

names (and LOAD= module names).
Review URL: http://codereview.chromium.org/100130

git-svn-id: ht...

59187ad3bab46cd5032099022ecf9920d24acda6 authored almost 16 years ago

When there's no actual target being built, use an Alias in the

target_files array, instead of just leaving it empty. Without this, SCons
doesn't think there's ...

cc98fbc9be6acdc7b9a091d3e307aa10329976ad authored almost 16 years ago

Adding support for .def files to the windows generator.

Review URL: http://codereview.chromium.org/100050

git-svn-id: http://gyp.googlecode.com/svn/tru...

eb5469600365ec5dbf19bff275e8a3e3e974d44d authored almost 16 years ago

Makefile generator: support shared library linking.

git-svn-id: http://gyp.googlecode.com/svn/trunk@444 78cadc50-ecff-11dd-a971-7dbc132099af

f7c521353bb53562927effc6f87a42d216bf3973 authored almost 16 years ago

Makefile generator: cleaner handling of 'settings' targets.

git-svn-id: http://gyp.googlecode.com/svn/trunk@443 78cadc50-ecff-11dd-a971-7dbc132099af

7dcb31d67cc3d8ecd31d006ace825e4fc96914a9 authored almost 16 years ago

Makefile generator: add an "all" target that builds everything.

git-svn-id: http://gyp.googlecode.com/svn/trunk@442 78cadc50-ecff-11dd-a971-7dbc132099af

b89e30e775e6e9f3670e0cd83e2d65fb2a9994df authored almost 16 years ago

Makefile generator: two hacks around some Chromium-specific weirdness.

git-svn-id: http://gyp.googlecode.com/svn/trunk@441 78cadc50-ecff-11dd-a971-7dbc132099af

7fe09eea54741b72acf682c5fcc78b72448ca8ce authored almost 16 years ago