Ecosyste.ms: OpenCollective
An open API service for software projects hosted on Open Collective.
github.com/electron/gyp
https://github.com/electron/gyp
With this, clang works out of the box with ninja.
Based on a patch from Jeremy Apthorp <jeremya...
b0ce2064dc124455bd1faaefa13c0d0ba2ef39a8 authored about 13 years agoPrint a warning if anyone specifies -Gconfig=Release.
Review URL: https://chromiumcodereview.ap...
8afa492d3bebb7ae9a2db24b291add91db5ed459 authored about 13 years ago
This doesn't seem to have an effect on anything.
Review URL: http://codereview.chromium.org/9114...
The code uses include.gypi; only comments use the wrong form.
Review URL: https://chromiumcoder...
7a9d1ab1b214d7342b5a6d3ae4837fd572a8f4d0 authored about 13 years agohttp://codereview.chromium.org/9108002/
Submitted for yukawa.
Description:
Currently MSVS 2010 ...
BUG=chromium:109163
TBR=mark (got LGTM over email)
Review URL: http://codereview.chromium.org/91...
BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/9133022
git-s...
07356616e1c5d8782b6711baef1afa7c9829254b authored about 13 years agoGeneral ARCHS support (fat binaries) are still unsupported.
BUG=90185,107027
Review URL: http:/...
$(out)/output/path was transformed to ${out}/output/path,
which Absolutify() then identified as ...
Support env vars in:
* plists
* sources and destination filenames of copies
* actions
Enable al...
14821d9ce557f087f24d0016c2a5b9b7278b8560 authored about 13 years ago
Due to an earlier restat change, we no longer need a Chrome-specific
hack for lastchange.
I acci...
- Store intermediate paths on this object, allowing more of the WriteFoo
functions to just ret...
First, add tests for env vars in copies, actions, and plists,
using $(VAR) (normally expanded by...
The conceptual logic at the end of WriteSpec now is:
final_output = linker_output = WriteTarge...
No functionality change.
TBR=evan
Review URL: http://codereview.chromium.org/9139081
git-svn-id...
80aa553fb2019b0b6718e5a70507fb139ff2ad00 authored about 13 years ago
Give xcode_emulation.GetXcodeEnv an optional additional_settings
parameter, and unconditionally ...
Review URL: http://codereview.chromium.org/9148085
git-svn-id: http://gyp.googlecode.com/svn/tru...
3fc6c8d718be1df48005da2802759adbaf82b2e4 authored about 13 years ago
Since it's now in the same focused module as XcodeSettings,
consider it a friend of that class. ...
shlex.split will eat backslash (commonly found in windows paths).
Review URL: http://codereview....
After the previous refactoring, WriteTarget had two is_mac_bundle
tests in a row. This code can...
Now GetXcodeEnv() no longer reads self.output or self.output_binary.
Also use my env var test h...
ac2a8d9430ce7bfc0d3ad415d5c96dabe9b200b2 authored about 13 years ago
There was a bunch of code in WriteTarget that only applied when
writing out something involving ...
Add a test to check that this does in fact match Xcode.
Tweak the cycle detection logic so that...
06bb1b70edfe30b4959b6e34d64de671379a10ff authored about 13 years ago
Previously, it was first set to $(builddir), or for actions to
e.g. ../../$(builddir), only to l...
This allows getting rid of the quirky keys_to_not_absolutify.
Add extensive tests to make sure t...
Review URL: http://codereview.chromium.org/9194001
git-svn-id: http://gyp.googlecode.com/svn/tru...
dd2ad6caf1787c519e5651eb21086e7e76370b77 authored about 13 years ago
BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/9107026
git...
15c05f590ca43ec8f9e7e7aee8857e30f6cd4b55 authored about 13 years ago
Shows why the abs_builddir is needed.
TBR=rsesek
Review URL: http://codereview.chromium.org/9166...
I intend to unify those two into an object, so this rearrangement
will make the next change simp...
Also change the make generator's behavior to match xcode. This isn't important
for anything in p...
self.output and self.output_binary used to contain escaped spaces. Instead,
let WriteMakeRule() ...
A dependency on a bundle should cause the whole bundle to be built,
not just the bundle executab...
Also support completely empty bundles.
One problem with supporting sourceless bundles was that ...
c6df8c5ee463555eddcce754e9c9099d74a7e611 authored about 13 years ago
BUG=109452
TBR=kerz
Review URL: http://codereview.chromium.org/9120018
git-svn-id: http://gyp.g...
42d9b6828d9442eedd144ae9b1937be280b19e01 authored about 13 years ago
BUG=109452
Review URL: http://codereview.chromium.org/9121020
git-svn-id: http://gyp.googlecode...
e313a564d24c0350e949f8e441b4de0244d0421a authored about 13 years ago
This matches xcode and make, and the chrome build depends on this.
Like http://codereview.chromi...
Similar to http://codereview.chromium.org/7396012.
This creates a separate bundle binary for bu...
ae92e253c3e2670f028e64c58baa140ecbd5461d authored about 13 years ago
Simiiar to http://codereview.chromium.org/7405001 and
http://codereview.chromium.org/8538021 .
...
4143358985fabc41e9220e0ca415a1e9d858fa92 authored about 13 years ago
This is similar to http://codereview.chromium.org/7399010. Since many
bundle names contain space...
Based on a patch from Jeremy Apthorp <[email protected]>
BUG=chromium:96894
Review URL: http...
TBR=fischman,piman
Review URL: http://codereview.chromium.org/9091010
git-svn-id: http://gyp.go...
c0173712eeb856dafa9b7091bd130e225443e760 authored about 13 years ago
TBR=evan
Review URL: http://codereview.chromium.org/9085007
git-svn-id: http://gyp.googlecode.c...
a8a33e272f6ea391b59b9073878642620bab3933 authored about 13 years agoI tried 3 approaches:
1. extra_cflags on cc command, separate pch command
( http://coderevie...
BUG=https://github.com/martine/ninja/issues/155
TEST=manually confirmed that chrome is no-longe...
https://github.com/martine/ninja/commits/master/misc/ninja_syntax.py
Change:
* Support for speci...
BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/9074008
git...
a4440c03ca124d27c167bd1f6023c37cb2993e20 authored about 13 years ago
With this, base builds (it doesn't use any 'copies' that use env vars in its name).
Once real en...
Also replace SDKROOT in libraries at gyp time, also for the make/mac build.
Now SDKROOT needs to...
Based on a patch from Jeremy Apthorp <[email protected]>
BUG=chromium:96894
TBR=tony@chromiu...
Contains a fix for http://crbug.com/108428
[email protected]
Review URL: http://codereview.c...
Instead, pass in a path remapping function. Now GetLdFlags() works
when called from the ninja ge...
It looks like this was mostly disabled by accident.
Patch from Jeremy Apthorp <jeremya@chromium....
The ninja generator changes are based on a patch from Jeremy Apthorp <[email protected]>
BUG...
0839e68998d2c8e8f10ff21e648136f220fddd26 authored about 13 years ago
https://github.com/martine/ninja/commits/master/misc/ninja_syntax.py
Notable changes:
* Support ...
This matches the current behavior and will facilitate gradually landing changes
to v8 + webkit th...
BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/9006042
git...
b940d959cdac6d2ebb3fe07892d4baabc8ebe548 authored about 13 years ago
(Except for test/mac, which currently only runs with
xcode and make, and which doesn't work with...
Build .m and .mm files for flavor mac. This doesn't
add support for xcode_settings yet, so almos...
It's already used by 2 generators and will also be used by the
ninja generator.
Review URL: http...
unless the none target is marked with 'dependencies_traverse': 1,
TEST=coming soon, want to make...
4f8e92ca01139033a0f93b12b5ae44ec482463a6 authored about 13 years ago
BUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/8946001
gi...
27aaada3227da7f17b70ae773808dc149da70cc4 authored about 13 years ago
Ran:
test/variables/filelist/update_golden
test/variables/filelist/update_golden
Regressed in: ...
0db3c475db0f3470ec9e74ce80acd9e13a2a5570 authored about 13 years ago
BUG=https://bugs.webkit.org/show_bug.cgi?id=74323
TEST=relative
[email protected]
Review U...
Ensure it is defined in the makefile before it is used, since we use
":=" in the makefile which ...
All checks that were triggered were disabled in pylintrc. I put two lists, one
of warnings that ...
Make sure that these attributes are coherent for python scripts:
- The script is indeed executab...
BUG=chromium:103273
TEST=chrome builds
TBR=mark
Review URL: http://codereview.chromium.org/86880...
Review URL: http://codereview.chromium.org/8676026
git-svn-id: http://gyp.googlecode.com/svn/tru...
0fc3814647116a3c363d479ae476512b4e60571e authored about 13 years ago
BUG=chromium:103273
Review URL: http://codereview.chromium.org/8664001
git-svn-id: http://gyp.g...
fbcd968877bac98d0d6f5f61847c0232939562f4 authored about 13 years ago
No behavior change.
Review URL: http://codereview.chromium.org/8636027
git-svn-id: http://gyp.g...
926fcf0d1e8bfbe0f98aa26624a0bb4a085ed78d authored about 13 years agoReview URL: http://codereview.chromium.org/8634012
git-svn-id: http://gyp.googlecode.com/svn/tru...
3e35424d0f99be22e6de6eb3e2c4a60254ee9167 authored about 13 years ago
BUG=chromium:104934
TEST=happier jochen
Review URL: http://codereview.chromium.org/8645001
git-...
83690500c08123255c363ee1fe1d97f3b16b7578 authored about 13 years ago
$(SDKROOT) isn't set, so it evaluates to nothing, but not
writing it is, uh, cleaner.
BUG=none
...
I checked that all tests pass at 1092. I ran
test/variables/commands/update_golden and test/vari...
Patch from Steve Wills <[email protected]>
Original code review at http://codereview.chromium....
fa1ff074d693ee9b3b3cd4ca8e618ebb85ad8237 authored about 13 years ago
This finds all the varaibles that depend on other variables, performs Kahn
topolgical sort, and ...
it appears that ld.bfd is not $ORIGIN-aware and needs additional
information to figure out where...
BUG=chromium:90041
TEST=Try and roll DEPS and compile remoting_host_plugin
Review URL: http://co...
BUG=90041
TEST=test/mac/gyptest-infoplist-process.py
Review URL: http://codereview.chromium.org/...
BUG=chromium:103569
TEST=this
Review URL: http://codereview.chromium.org/8507034
git-svn-id: ht...
9a04900954d1a571238c4feacc916c2a58cf862a authored over 13 years ago
Currently, if library A depends on library B, we always wait until B has linked
before compiling...
Change from ensonic.
Fixed style issues.
Updated golden tests.
BUG=None
TEST=None
R=ensonic@goo...
git-svn-id: http://gyp.googlecode.com/svn/trunk@1085 78cadc50-ecff-11dd-a971-7dbc132099af
044ec99926ee71a0c0ab31335664f501c15e13a9 authored over 13 years ago
Previous output: ./gyp-mac-tool flock ?= LINK $(CXX)
Now: LINK ?= ./gyp-mac-tool flock $(CXX)
Re...
export FOO=bar doesn't work with ksh, so work around it with
a more universal syntax.
P...
Patch by [email protected] via http://codereview.appspot.com/5318049/
BUG=None
TEST=unit
...
121e04c64042b17dd6c12d780eddbfa0fcf0923b authored over 13 years agoThe "Symlink Libraries" postbuild step in chromium reads it.
BUG=chromium:100990
Review URL: ht...
Actual generator change, should've been part of r1079 but wasn't.
Patch by Ben Noordhuis <info@...
0c79cca8b06f1dc5883ebee880ea365761676931 authored over 13 years agoPatch by Ben Noordhuis <[email protected]>!
BUG=gyp:216
Review URL: http://codereview.chromium...
[email protected], [email protected]
TEST=gyptest.py test/rules
Review URL: http://coder...
have a similar path and not risk collision.
[email protected], [email protected]
BUG=g...
have a similar path and not risk collision.
[email protected], [email protected]
BUG=g...
git-svn-id: http://gyp.googlecode.com/svn/trunk@1075 78cadc50-ecff-11dd-a971-7dbc132099af
5714eb793a2b2f67f408602667c88d1efe19efe3 authored over 13 years ago
BUG=none
TEST=unit tests still pass
Patch from Jochen Eisinger <[email protected]>
Review URL...
TBR=mark
Review URL: http://codereview.chromium.org/8271022
git-svn-id: http://gyp.googlecode.c...
5cf3fcf76f9579db7638a4489f4a12314fcc729d authored over 13 years agoBUG=None
TEST=None
[email protected]
Review URL: http://codereview.chromium.org/8277015
git-svn...
452878af0c0f95537b56d0fb479c0113a93e2a1b authored over 13 years agoAdding a test that external makefile rules work in msvs
(and don't mess up other platforms).
BUG...
87e482822c1ddbbb9397e9aa38f0af6e9f07cd41 authored over 13 years ago
BUG=chromium:90052
Review URL: http://codereview.chromium.org/8265003
git-svn-id: http://gyp.go...
3074fb75009c2755d7050db784d6ca72719dce30 authored over 13 years agoPatch by Robert Nagy <[email protected]>
Review URL: http://codereview.chromium.org/8228003...
5c79bed72c9808566bde1e7e949cd45d5e6d6575 authored over 13 years ago
BUG=chromium:90052
Review URL: http://codereview.chromium.org/8216001
git-svn-id: http://gyp.go...
924a3d0140e88a0fe62d58c8616fd591ce320275 authored over 13 years ago