github.com/electron/gyp commits | Ecosyste.ms: OpenCollective

Correct topological sort.

http://codereview.appspot.com/5905070/

git-svn-id: http://gyp.googlecode.com/svn/trunk@1268 78c...

30e48dc705c948d4508d90f716bba61f19a6b641 authored almost 13 years ago

ninja windows: test for compiler optimization settings

This is another where it'd be very hard to map flags to output contents in a
non-fragile way (es...

50a7b44de1270611a933e1fdd63a720e4533f1df authored almost 13 years ago

Don't try to find devenv on non-Windows.

Fixes mac/linux ninja build.

[email protected]

Review URL: https://chromiumcodereview.apps...

e80d9b7ecdbc080e610a46691b3f5c130d3309de authored almost 13 years ago

Fix exception handling test on vs2010

Recently added exception handling test was getting optimized away on 2010
(confirmed by stepping...

1530e4b6d07a76a4878fa9e670fcef0afd9d87aa authored almost 13 years ago

ninja windows: test for warning as error flag

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9838103

git-svn-id: h...

d0fc904a09a85614417d3a401e0aa05e56eca303 authored almost 13 years ago

ninja windows: add test for delayload dlls

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9852013

git-svn-id: h...

9e3dccea366171f71109b73ecdf75677c806c6a0 authored almost 13 years ago

ninja windows: test for warning level

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9834095

git-svn-id: h...

b7e497b5513e15e5db18a0e49efb37876d54f241 authored almost 13 years ago

Add run_dumpbin as test function for VS-based testers

(Fixes buildbot not having dumpbin in path, currently erroring out on r1225-1257)

R=rsleevi@chr...

02c29d879475682c7835d498873c74109b69d00c authored almost 13 years ago

ninja windows: test linker subsystem flag

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9837084

git-svn-id: h...

e3f4a73ddb8139e45e6539a74b16eeb5f7abc7e5 authored almost 13 years ago

ninja windows: test for additional compiler options

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9852014

git-svn-id: h...

618de22b4eaffdb3c78dcbe3e2452d70fd17ca0d authored almost 13 years ago

ninja windows: test exception handling flags

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9837064

git-svn-id: h...

5dcc1675ef0ac17b2bad675036c12dae618858df authored almost 13 years ago

ninja windows: test for additional linker options

Specify /dynamicbase:no as an additional option and use 'pefile' to verify that the flag made it...

d58b7d13daff41c16809d09bde2d1c0555bb237f authored almost 13 years ago

ninja windows: test ASLR (aka DYNAMICBASE) flag

Verify that the final executable has the correct flags specified.

Yay! Actually found a sorta-b...

afacb0130c5e1ffe8f5354ed591494ada3e7e965 authored almost 13 years ago

ninja windows: test for function level linking

Use dumpbin on obj file to make sure free function appears as separate COMDAT
entry.

R=thakis@c...

67478b94b237ff4ba14a8edd9f31b0a771043627 authored almost 13 years ago

ninja windows: test RTTI flag

[email protected]

Review URL: https://chromiumcodereview.appspot.com/9835073

git-svn-id: h...

533bae00370b5d260fe49b3113d6f8d2a182e687 authored almost 13 years ago

ninja windows: test for runtime library settings

R=thakis

Review URL: https://chromiumcodereview.appspot.com/9836055

git-svn-id: http://gyp.goo...

77a9177a97c25a167eb9fd5be40dd980b1c6c2d3 authored almost 13 years ago

ninja windows: test for additional link dependencies

R=thakis

Review URL: https://chromiumcodereview.appspot.com/9808084

git-svn-id: http://gyp.goo...

d34fcb776c73fe11e18699eccb9c0c409379c7ac authored almost 13 years ago

MSBuild: TargetPath should match Lib.OutputFile or Link.OutputFile to avoid the MSB8012 warning.

TEST=built all.sln successfully.

git-svn-id: http://gyp.googlecode.com/svn/trunk@1251 78cadc50...

ee51458f70f17d32cf258b8d510d0d15c1e2af26 authored almost 13 years ago

Fallback behaviour was broken for forcing express version

(sorry for all the noise, this one has green tries now)

Review URL: https://chromiumcodereview....

629a6696c9456c761afee2ddd854032987e072ca authored almost 13 years ago

Unbreak Mac and vs2005

- Don't run tests on OS where they're not applicable.
- Another attempt at fixing 2005

Review U...

510f520d4d41f80f87e65076f7792baad02bd4b8 authored almost 13 years ago

Unbreak Windows build

Unbreak VS 2005 support
Don't use flock on Windows ninja (apparently ld_target is used generally...

9eb37b259954c28240fabbb6f020f44f057fe9c7 authored almost 13 years ago

Explicit paths to tools for ninja, rather than relying on environment

Previously, relying on 'cl', 'link', etc. to be in the path, so generating and
building required...

ac3e9ffbfe0bcd946b2de33747133a68a1bdda75 authored almost 13 years ago

Unbreak gyptest-toolsets.py on linux.

Review URL: https://chromiumcodereview.appspot.com/9699041

git-svn-id: http://gyp.googlecode.com...

714d6eaec919fd4e2882b245a066619c02d9be5e authored almost 13 years ago

mac make: Don't put host shared libraries into the product directory.

With the components build, but host and target create a libbase.dylib.
With the old code, both w...

299eb63862f16469aa6548d0d947f930fa756de7 authored almost 13 years ago

Fix CharacterSet map for VS 2010

Figures: the first test I add for ninja on Windows wasn't even supported on
2010 yet.

R=thakis
...

20076770ec90e5e4dab81a3d34cca8346108bf59 authored almost 13 years ago

Starting with additional includes, defines, and some basic cflags and ldflags.

Review URL: https://chromiumcodereview.appspot.com/9443044

git-svn-id: http://gyp.googlecode.co...

e9f84600b50e10b673135656e5f7351066fca90f authored almost 13 years ago

Add a test case for the CFBundleSignature happy path.

BUG=TEST=none
Review URL: https://chromiumcodereview.appspot.com/9665005

git-svn-id: http://gyp...

e3a8d23a80e1d777c9d2beb1f75d0e4f4dbd2715 authored almost 13 years ago

mac make and ninja: Don't require CFBundleSignature in Info.plist files.

BUG=chromium:114970
TEST=unit
Review URL: https://chromiumcodereview.appspot.com/9651018

git-sv...

465477502ef5545ea6e29a8d3035b3ac62cf7c78 authored almost 13 years ago

Make _CopyXIBFile() work with Xcode 4.3

For now, this will pick /usr/bin/ibtool, but once 91675 is
fixed, it'll do the right thing.

BUG...

44a264defa4e17f0260478b01947a947030bf4d0 authored almost 13 years ago

Allow specification of VC10 props and configuration attributes in gyp file.

VC10 props and configuration attributes can be specified using 'msbuild_props'
and 'msbuild_conf...

c5b7d8a31fdaaf598801fb32b84d7c355437ccf2 authored almost 13 years ago

ninja&make/mac: Continue working on xcode4.2 and below, too.

|$(xcode-select -print-path) + Platforms/MacOSX.platform/Developer|,
which evaluates to /Develop...

cf10e76e5f2057241fdc861abb1947010b62e3e9 authored almost 13 years ago

Let mac ninja and mac make work better with xcode 4.3.

This matches this cmake change:
https://raw.github.com/gist/1958550/9c03b16c370d458a7410fd045cdb...

3019d859f213c9c688c2b39d5c65f9b821bd15f9 authored almost 13 years ago

- Make gyptest.py set up the environment in case cl/link/etc. aren't in the environment.

- Add ninja to Windows runs.
Review URL: https://chromiumcodereview.appspot.com/9433026

git-svn-...

880525d606ba0b4b185351e379c25d74fbc2d326 authored almost 13 years ago

Add fallback for COPY when mklink not available (windows ninja)

Adds win_tool (as gyp-win-tool) which is used by copy step to do a recursive mirror (removing ou...

f2a88c8e4bac7567d81a8e18650bc176bcc6838f authored almost 13 years ago

Update test/restat to not expect `touch' to be in the path.

Fixes execution of this test on Windows ninja.
Review URL: https://chromiumcodereview.appspot.co...

c48f45ee8c3ea1bb06b88222d0353ea5ade8d7f7 authored almost 13 years ago

Don't allow empty string as first argument of action.

For some reason, there was an extra empty argument at the beginning of these
cygwin rules. It lo...

5fd4856a28070d901cc679e20b2a537e921b8b8c authored almost 13 years ago

Normalize path before requesting list of targets (ninja)

Fixes test/sibling/ on Windows ninja. In lieu of http://chromiumcodereview.appspot.com/9406035/
...

9c10e269b56b1435f4cacf3ae2ac650911088a8b authored almost 13 years ago

Enable cross-compilation with ninja.

Replaced the specialness of _host with _target, b/c the _host
toolchain is usually the vanilla g...

e6841837c079d34b6f69228cf0386682086188a5 authored almost 13 years ago

Recommit http://codereview.chromium.org/9390017/ for alexeypa

Added support of the PlatformToolset property to Gyp (MSBuild only).

git-svn-id: http://gyp.goo...

627a7dbacb225f0ac431a5edc0defcc9ec4b5415 authored almost 13 years ago

Revert r1228.

Failing test\configurations\target_platform\gyptest-target_platform.py.
Review URL: https://chro...

c4ae117303460f8f4d64150c322d6f5624c9aeed authored almost 13 years ago

Commit of http://codereview.chromium.org/9390017/ for alexeypa.

Added support of the PlatformToolset property to Gyp (MSBuild only).

git-svn-id: http://gyp.goo...

867ab81cd84f7f68fc759abee2fe38bcf4b20193 authored almost 13 years ago

Don't rely on `touch' being available (windows ninja)

Review URL: https://chromiumcodereview.appspot.com/9433030

git-svn-id: http://gyp.googlecode.com...

53057d5a68df2840371397405a027503de50209d authored almost 13 years ago

Manual path slash normalization in ExpandSpecial (windows ninja)

Not using os.path.normpath per comment and https://groups.google.com/group/gyp-developer/browse_...

21834784c3f6c32a2fa71b42a1fe2d1de7daf4a0 authored almost 13 years ago

Don't emit empty commands in rule even if the action is empty.

If a rule has no actions, insert a no-op so that the && used for cd'ing isn't
a syntax error.
Re...

18e3f1c2f15542eada19b974891d8f9f07d5fd83 authored almost 13 years ago

Support import libraries for Windows ninja

There's 2 outputs for a shared library link on Windows, the .dll and a .lib to
link other target...

22db577b7cf026d791e3f0af1d383c2fd23286d0 authored almost 13 years ago

mac ninja&make: Filter out useless 'This view is clipping its content' message.

BUG=none
TEST=chromium build output is almost 200 lines shorter
Review URL: https://chromiumcode...

d8c0d3501bd3b70b651cd79fcf70f15c62844ced authored almost 13 years ago

Fix indent on test code for test/assembly broken in r1220

Review URL: https://chromiumcodereview.appspot.com/9429007

git-svn-id: http://gyp.googlecode.com...

e3a750dcca3727d576833351bfc09bbd858871f6 authored almost 13 years ago

Allow override of OS variable on Windows ninja.

Review URL: https://chromiumcodereview.appspot.com/9425055

git-svn-id: http://gyp.googlecode.com...

d1f8bc3ff3d7478e63f814649c1d343c79fc2af1 authored almost 13 years ago

Exclude test/assembly on Windows

The test isn't currently set up to work on Windows, but the exclusion was
previously being accom...

4a17f17a122c774cad1672c2b0fdbd7ed6d24ca8 authored almost 13 years ago

Fix obj extension for test/ninja/chained-dependency to work on Windows ninja build.

Review URL: https://chromiumcodereview.appspot.com/9427026

git-svn-id: http://gyp.googlecode.com...

26a7c7bbab5ab3714674bc19a2e07234c10511df authored almost 13 years ago

Quote arguments properly in rules for cmd on Windows ninja.

Review URL: https://chromiumcodereview.appspot.com/9395082

git-svn-id: http://gyp.googlecode.com...

2a94eb861ca335c642a05cb1a17c25c8f8123f79 authored almost 13 years ago

Revert part of r1213 that's causing failures on Mac.

Causing an unexpected extra "." argument for some command lines, which often works, but not in s...

12bcd458c1023d0f031cf0ad7c11393b2643879f authored almost 13 years ago

make action_dependencies test win32 and c89 friendly

Review URL: https://chromiumcodereview.appspot.com/9425036

git-svn-id: http://gyp.googlecode.com...

04e5b88e2c54378b3961fbdbd60c53dcd1aac432 authored almost 13 years ago

Fix quoting shell args on Windows

Fixes test/defines-escaping and a couple others. (Windows shell quoting: Not
The Best Design Eve...

3bb8af4f7dc9e6d364d2e6d93823bf09edf89704 authored almost 13 years ago

Fix test/product broken at r1211

(product_extension explicitly specified lost its leading .)
Review URL: https://chromiumcoderevi...

c9a7a53be61c328a9201c95ad8e134a3f79709a4 authored almost 13 years ago

- Another normpath (slightly concerned about this one for other platforms? but it makes the build files a lot more consistent on Windows)

- Fix copy rule for windows (mklink directory if file fails)
Review URL: https://chromiumcoderevi...

41f4f988ac2d1baceaef1c9d79d60801746b5491 authored almost 13 years ago

Revert "make: don't use .target in paths or printouts"

This reverts commit r1209.

This didn't quite work: we also have $(CC.target) etc.

git-svn-id: ...

023d71b91d502f776f67c9fced435601070a4349 authored almost 13 years ago

Retrieve generator variables, rather than repeating.

A bit ugly to retrieve again via CalculateVariables, but seems better than having a second copy ...

8724b1fac5a20c24eef69df66e2bfbbb50426c87 authored almost 13 years ago

Revert "make: drop all system tests"

This reverts commit r1208. Chrome builds rely on thin archives.

git-svn-id: http://gyp.googlec...

5571194611c2d70d2b5a6ec380c0a094d88713f0 authored almost 13 years ago

make: don't use .target in paths or printouts

Instead, .target is considered the default, unnamed configuration,
while .host remains printed a...

f16c37ab3da428d392ba4042766477cd92a5d1d2 authored almost 13 years ago

make: drop all system tests

Rather than probing for ARFLAGS at gyp type, just always use "crs".
This will change systems tha...

858ea7252b82b8675959ec417fe7d57a32ebd5c2 authored almost 13 years ago

linux: in module test, pass -ldl as a library not ldflag

libraries go at the end of the link line, which is necessary for
this test to work on my machine...

cd57883537e450c9273694a6d78e8ba8f70dfce2 authored almost 13 years ago

Fix error in previous change here: http://chromiumcodereview.appspot.com/9401016

Future change should use generator variables for prefix/suffix rather than duplicated copies.

T...

b9b1386d56702908a21dcf7ed94429be243c36b9 authored almost 13 years ago

More slash fixes for Windows ninja, and some work on actions.

Requires a fix to MakeDirs in ninja on Windows here: https://github.com/sgraham/ninja/commit/3aa...

26967a5ce4cd4b456724e0b3795b1ea5d62845ed authored almost 13 years ago

mac: Let `mac-tool flock` exit with the exit code of the child program.

TEST=When a link fails in the mac/ninja build, postbuilds no longer try to run.
Review URL: http...

835f60a22d4a97810e4012b7fb5ef56c1316d170 authored almost 13 years ago

mac ninja&make: Support GCC_ENABLE_SSE3_EXTENSIONS and friends.

Review URL: https://chromiumcodereview.appspot.com/9402033

git-svn-id: http://gyp.googlecode.com...

b7adfd975a2b7eefed0cdf40e8b89ecf41e72e40 authored almost 13 years ago

Fix .ds for ninja on Windows

Currently relies on 'deplist' branch of ninja. Also fix some prefixes/suffixes
for Windows. Test...

dc00394d05d592abcf83a543b35cd034d6e48e7a authored almost 13 years ago

Remove mistaken commit.

git-svn-id: http://gyp.googlecode.com/svn/trunk@1201 78cadc50-ecff-11dd-a971-7dbc132099af

1d0f57578f1b2b4c58c6f5afaa0b22265ab9c095 authored almost 13 years ago

Very preliminary work for ninja on Windows.

Only trying to get a first test passing:

gyptest.py test/hello/gyptest-all.py -f ninja

builds...

2efa4fd241f7296bdb97e9b18296e97cb669915b authored almost 13 years ago

name=r1s8

issue=9358067
bot=gyp-linux,gyp-win64,gyp-win32,gyp-mac
project=gyp
user=scottmg
patchset=5002
ro...

422e37907b90fe4cafd2c6323128b1af25a1b61c authored almost 13 years ago

mac: Support ARCHS with zero or one element in the make and ninja generators.

General ARCHS support (fat binaries) are still unsupported.

Review URL: http://codereview.chrom...

31543448be478a5482732cda9e9b88cf5b3e08e1 authored almost 13 years ago

mac make&ninja: Support GCC_CHAR_IS_UNSIGNED_CHAR.

Used in breakpad. Apparently not critical, but if it's used,
it should be supported.
Review URL:...

e3389bf8ea077627bfc900f749d2002a5a397b70 authored about 13 years ago

Allow generator flags to populate the initial environment for dump_dependency_json.

This allows it to be run on Windows/for MSVS via -GMSVS_VERSION=[2008,
2008e, 2010, 2010e] -GMSV...

315c6d71c86e47204686753a91c10693b0e17d9c authored about 13 years ago

Don't double newlines in libtool stderr output.

Review URL: https://chromiumcodereview.appspot.com/9373048

git-svn-id: http://gyp.googlecode.com...

5350adef1346c2c77b8d2ba7f83cd044f30668d9 authored about 13 years ago

ninja/mac, make/mac: Strip useless libtool output.

Review URL: https://chromiumcodereview.appspot.com/9370035

git-svn-id: http://gyp.googlecode.com...

044fbe1c263aef9b29e85fefca1672d530717fa7 authored about 13 years ago

mac_tool: Alphabetize Exec functions, with their private methods below them.

No behavior change.

TBR=evan
Review URL: https://chromiumcodereview.appspot.com/9374032

git-sv...

d197d57c5cc7d3271acd24a0af4618ea3d03189a authored about 13 years ago

ninja: Don't echo POSTBUILD commands.

The output is only interesting to people debugging postbuild perf,
and they can just change thei...

786c3e3f0352600183caeb02501d0d9bbb7c1126 authored about 13 years ago

ninja: Only run one ld process at once.

Helps with building 'all' in Debug in chromium.
Review URL: https://chromiumcodereview.appspot.c...

120d42f65834ad2d0c1160c07b04292621a2e6ba authored about 13 years ago

linux: drop detection of --threads flag to the linker

This is now the responsibility of the gyp file to set.

BUG=gyp:250

Review URL: https://chromiu...

e7383d2865306c880894d41ed18e3ed216e43734 authored about 13 years ago

linux: drop LINKER_SUPPORTS_ICF flag

Rather than attempting to detect this at gyp time, leave it up to
the author of the gyp file to ...

6a2d06941eafe51ad7143cc680f21bdd9a0cba9f authored about 13 years ago

ninja: fix missing dependency for multiply-removed actions

Suppose you had dependent targets A -> B -> C, where C generated
a header that was used by A. T...

3e072ae11b949109e2dccdcca24123fc9c611630 authored about 13 years ago

Add msvs generator flag to control _excluded_files inclusion.

Add a generator flag "msvs_list_excluded_files"
to not list _excluded_files in the generated pro...

48d1e6b57f4f67771b54bfa070102d118bd97491 authored about 13 years ago

Revert r1161, "support ARCHS with one element in the make and ninja generators."

This didn't work, since even if ARCHS has only one element, dependent targets
might have been bu...

53efa0b474303eb5ac7fea0265298ed41dddfb0f authored about 13 years ago

ninja: Support --toplevel-dir.

Review URL: https://chromiumcodereview.appspot.com/9298039

git-svn-id: http://gyp.googlecode.com...

f719983890919a9eda1e5f526d1d63ed64b8a38a authored about 13 years ago

msvs: drop dummy_executable.

This is already rejected at input time (it's not in the set of
valid target types), so these cod...

76a10a2a3204e8db9c684126d5c73273fd518c8f authored about 13 years ago

Add flag msvs_2010_disable_uldi_when_referenced

Allows disabling UseLibraryDependencyInputs on a per-project reference basis.
This allows leavi...

5e9c0a10f5f6115247a1a5c4f19d2581d7ad7dad authored about 13 years ago

ninja/mac: Enable test/mac/gyptest-libraries.py

Looks like this just passes now.

TBR=evan
Review URL: https://chromiumcodereview.appspot.com/92...

811299f068ed8c40b1da72eca2fcc1ecc00304ba authored about 13 years ago

ninja/mac: Don't rebuild bundle targets with postbuilds more than once.

Also improve the test that was supposed to catch problems like this to
catch this.

BUG=chromium...

5f55530576e367f4f53df4213ee7c23ff545c57c authored about 13 years ago

ninja/mac: Support postbuilds.

Do this the same way the make build does it, but just tacking all
postbuilds on to the last comm...

ecae04c143848a2a0247af1af0180fe0a19b1a77 authored about 13 years ago

mac: Add a test that changing nibs / resources trigger dependent postbuilds.

This currently passes only with the xcode generator.

BUG=chromium:95529
Review URL: https://chr...

4b240ee841e2a615efe774042b455cb40d918334 authored about 13 years ago

Use test.touch() instead of os.utime() in a test.

No intended functionality change.

TBR=evan
Review URL: https://chromiumcodereview.appspot.com/9...

c104385daa64ee5eb12d3b6e52be9ea100ef9e87 authored about 13 years ago

make/mac: Move postbuild code around a bit, some if it into xcode_emulation.

No intended behavior change.
Review URL: https://chromiumcodereview.appspot.com/9289001

git-svn...

60e8244fa9b6f4bef0606ccc46cc5d23904a952a authored about 13 years ago

Reject gyp files that use an invalid target.

Error message this generates looks like:

Exception: Target base/base.gyp:base_static#target has...

f319f4f91e07f1787a7139864577310af4d49a77 authored about 13 years ago

Test that postbuilds on static libraries work, also for sourceless libraries.

Worksk fine with the xcode and make generators, but used to not work with the
work-in-progress n...

22709429d355b14b9b5574300b421337e62f8341 authored about 13 years ago

Add a test for having a postbuild with multiple configurations.

Works fine in xcode and make, but originally didn't work with the
work-in-progress ninja postbui...

dca5554d1d147bf997d35ca15c39e3d3ab662d40 authored about 13 years ago

xcode emulation for make: Adjust .a and .dylib entries in 'libraries'.

Transform, e.g., 'libfoo.a' to '-lfoo', so that the LIBRARY_SEARCH_PATHS are
actually searched f...

08d6b2cb13257ed4eafd7469e1018e2a3531c42c authored about 13 years ago

ninja: reduce quoting of -D flags

Don't quote flags when it is obvious they don't need quoting.
This covers common flags like -DND...

96a38dc8fe41da89fee36b76995c281dae2ba13b authored about 13 years ago

make/mac: Alternate fix for chromium:106859

CHROMIUM_STRIP_FILE needs to be written before
TARGET_POSTBUILDS_$(BUILDTYPE) is written to the ...

42cdbe04ece5da22c61b3e4adbd9083974633e47 authored about 13 years ago

ninja/mac: Fix ${BUILT_PRODUCTS_DIR} when ninja is invoked from `gclient sync`.

In that case, the current directory is chrome/ instead of chrome/src/, but
self.build is still r...

c57a88ebac3dddc5bbd496078896b8ec77b1a0f0 authored about 13 years ago

ninja: If -Gconfig is given, write just that single config. Else, write all configs.

jamesr used to use different GYP_DEFINES for different configs, which was broken by
making ninja...

0fd732e653ec75080b5e9014be0b90ee5be5704e authored about 13 years ago