[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/838023002

clang-format wanted to rewrap this way.

[email protected]
BUG=crashpad:1

Review URL: https:/...

- Wrap constants in FILE_PATH_LITERAL for L"".
- dynamic allocation, as VS otherwise complains a...

d:\src\crashpad\crashpad\util\file\string_file_writer_test.cc(367) : warning C4244: 'initializin...

Includes:
836497baf21c5fbb7876573dc1dadef4c023a87d win: Default to /SUBSYSTEM:CONSOLE

TBR=mark@...

[email protected]
TEST=util_test --gtest_filter=UUID.FromString

Review URL: https://coderevie...

[email protected]
TEST=util_test --gtest_filter=ScopedTempDir.*

Review URL: https://coderevie...

[email protected]
TEST=util_test --gtest_filter=Xattr.*

Review URL: https://codereview.chromi...

This adds an Info.plist to these two tools that use task_for_pid().
Since they’re flat unbundled...

run_with_crashpad runs a program with a Crashpad exception handler. It
allows a Crashpad excepti...

CrashpadClient is the primary interface for an application to have
Crashpad monitor it for crash...

crashpad_handler is Crashpad’s exception handler server.

Currently, it runs a loop to receive e...

This updates moved man pages to reference man_footer.ad by a proper
relative path following 39f6...

Prefer

function(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa,
bbbbbbbbbbbbb,
ccccccccc...

More clear at callsites, and relatively important not to accidentally choose the wrong one.

R=m...

'util' builds on Windows after this.

[email protected], [email protected]
BUG=crashpad:1

R...

Includes:
4d84318dbcdf46b543ab4556736cf8a9ae3ced18 win: Disable C4201, nameless struct/union war...

d:\src\crashpad\crashpad\snapshot\cpu_context.cc(96) : warning C4245: 'return' : conversion from...

This function will be useful in upcoming non-test code. Because the
first Crashpad client that w...

Also add ScopedFileHandle as cross-platform version of ScopedFD/ScopedFileHANDLE.

R=mark@chromi...

There will be no reason to leave the handler process connected to its
invoker’s stdin or stdout....

As the whence values are "helpfully" available in windows.h as well
( http://msdn.microsoft.com/...

I started (https://codereview.chromium.org/812403002/) emulating oflag values
on Windows in File...

Intended for future use to implement util/file/file_writer.

There's a similar class in base:
ht...

Includes:
43b7cd397e5f239e59700831430b703d9a4a3b4f win: Fix for logging.h ERROR, again
a83f16010...

Ref:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms686946%28v=vs.85%29.aspx

R=mark@...

Otherwise, when assigning to a smaller type, MSVC warns e.g.

d:\src\crashpad\crashpad\util\nume...

Rename fd_io to file_io, and ReadFD to ReadFile, etc.

file_io.cc is the higher level versions t...

[email protected]

Review URL: https://codereview.chromium.org/813873002

This picks up:

222feaf3d302 Update README
e38cddb83571 Lock: don’t require NativeThreadType to ...

[email protected]

Review URL: https://codereview.chromium.org/804913003

There were many call sites that wasted a few lines on
mach_port_allocate() and sticking the resu...

The comment referred to the old form of the |persistent| argument, which
was a bool.

R=rsesek@c...

Else,

d:\src\crashpad\crashpad\util\net\http_multipart_builder.cc(50) : warning C4244: 'initial...

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/807973002

This picks up:

158694255c7a win: undef ERROR, causing failing LOGs
3a981db6e6df MSVC: Disable “...

This DCHECK fails for me locally as

[----------] 3 tests from ProcessInfo
[ RUN ] ProcessI...

CXX_LIBRARY_VERSION is irrelevant, because the only C++11 library
feature of any concern is whet...

TEST=util_test NotifyServerTest.*
[email protected]

Review URL: https://codereview.chromium...

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/807463004

Just avoid the Mac-specific __attribute__ tagging for now. There will need
to be some Windows-sp...

Pick up build fix.

[email protected]

Review URL: https://codereview.chromium.org/804853004

To pull in string16 changes.

[email protected]
BUG=crashpad:1

Review URL: https://coderevi...

e.g.

FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files (x86)\Microsoft Visual Studi...

e.g.

d:\src\crashpad\crashpad\util\numeric\in_range_cast.h(35) : warning C4244: 'return' : conv...

I could also add COMPILER_CLANG to build_config.h, but that doesn't
appear in Chromium, apparent...

Unfortunately VS2013's support of C++11 is partial. It supports the
extended union definition, b...

When run from the wrong location and test data or other test programs
can’t be found, the tests ...

[email protected]

Review URL: https://codereview.chromium.org/799463003

BUG=4
[email protected]

Review URL: https://codereview.chromium.org/799073002

And another roll to get to mini_chromium to HEAD.

[email protected]
[email protected]
BUG...

[email protected]

Review URL: https://codereview.chromium.org/800983002

Needs to include roll with https://codereview.chromium.org/803593002/ included.

R=mark@chromium...

To pick up progress on compiling base on Windows.

[email protected]
BUG=crashpad:1

Review ...

mini_chromium rev broken, will fix and re-roll.

[email protected]

Review URL: https://code...

Want to roll the mini_chromium changes in little chunks as the bot
doesn't otherwise build them,...

The implementations for the exc and mach_exc subsystems were nearly
identical, and were a good t...

TEST=util_test
[email protected]

Review URL: https://codereview.chromium.org/793323003

To add definition of ssize_t. Uses #include <../include/...> to
emulate #include_next, similar t...

MachMessageServer::Run()’s distinct |nonblocking| parameter is removed.
The information it forme...

Option names like --mach-service are easier to type than --mach_service.
Command-line tools don’...

TEST=util_test CompositeMachMessageServer*
[email protected]

Review URL: https://codereview...

UniversalMachExcServer provided both an interface and an implementation,
contrary to the other c...

This exposed a bug in the ExcClientVariants test, which was expecting
the memory used for new_st...

These DCHECKs make sure that buffer sizes and message sizes are as
expected.

TEST=util_test Mac...

This method is now much more straightforward, easy to understand, and
maintainable.

There are n...

The F_SETNOSIGPIPE fcntl() command is not available on 10.6. Use
socketpair() instead of pipe(),...

In the pre-C++11 10.6 SDK, std::numeric_limits<>::max() is not marked
constexpr and cannot be us...

MachMessageWithDeadline() is a mach_msg() wrapper that deals with
deadlines instead of timeouts....

A subsequent change will add MachMessageWithDeadline(), a mach_msg()
wrapper. Conceptually, it m...

MachMessageServer was wasteful with allocations for request and reply
messages. It allocated new...

The buffer sizing logic was correct to start with. I don’t know why I
misread it. It should say ...

TEST=util_test ChildPortServer.*:ExcServerVariants.*:MachMessageUtil.*
[email protected]

Re...

Previously, test structures were initialized with InitializeForTesting()
methods. A related code...

These port dispositions were naïvely taken from excUser.c and
mach_excUser.c, but the local and ...

The existing implementation used the same logic as is found in
mach_msg_server(), but that logic...

As documented, MACH_SEND_TRAILER would allow a sender to provide its own
message trailer instead...

ChildPortHandshake is the most generic system yet to allow child
processes to provide their pare...

Previously, MachMessageServer::Run() only provided two strategies for
dealing with large message...

the child_port subsystem.

Common routines shared with the ExcServer family of classes have been
...

[email protected]

Review URL: https://codereview.chromium.org/756653004

[email protected]

Review URL: https://codereview.chromium.org/752243002

TEST=util_test ExcServerVariants.*
[email protected]

Review URL: https://codereview.chromiu...

In b6a0183ccec7, gtest and gmock were held back at older versions with
limited C++11 support, be...

[email protected]

Review URL: https://codereview.chromium.org/725303003

[email protected]

Review URL: https://codereview.chromium.org/727983002

DropPrivileges() is used in exception_port_tool, so that when it is
installed as a setuid execut...

This also transitions exception_port_tool to use TaskForPID(), so that
it can be safely used as ...

Also, move ProcessArgumentsForPID() into ProcessInfo.

This change prepares for a TaskForPID() i...

TEST=minidump_test MinidumpFileWriter.InitializeFromSnapshot*
[email protected]

Review URL:...

[email protected]

Review URL: https://codereview.chromium.org/707223002

MinidumpLocationDescriptorListWriter and MinidumpRVAListWriter are
implementation details and sh...

TEST=minidump_test MinidumpCrashpadInfoWriter.InitializeFromSnapshot
[email protected]

Revi...

Doxygen was generating some pretty bogus-looking documentation for
the Python http_transport_tes...

This produced errors such as:
minidump_misc_info_writer_test.cc:665:32: error: non-constant-expr...

TEST=MinidumpModuleCrashpadInfoWriter.*
[email protected]

Review URL: https://codereview.ch...

TEST=minidump_test MinidumpStringWriter.*List
[email protected]

Review URL: https://coderev...

This will be used as the foundation for writing a list of
MinidumpUTF8String objects. MinidumpUT...

MinidumpLocationDescriptorListWriter. This allows easier construction of
minidump structures that...

MinidumpWritableAtRVA<>() now checks that the object of the requested
type is actually in the ra...