This makes it easier for clients to start the Crashpad handler, instead
of requiring them to kno...

origin.

This adds AuditPIDFromMachMessageTrailer() to get the process ID of a
Mach message’s sen...

BUG=crashpad:14
[email protected]

Review URL: https://codereview.chromium.org/1001713002

This regressed in 359bdd86225c when a non-POD UUID data member was added
to MinidumpCrashpadInfo...

The client ID is added to a new field, MinidumpCrashpadInfo::client_id,
in each minidump file th...

disabled.

ClientInfo::set_system_crash_reporter_forwarding() can be used to
disable forwarding. ...

NSInputStream requires overriding and implementing private methods in order to
use it with NSURL...

BUG=crashpad:14
[email protected]

Review URL: https://codereview.chromium.org/997993002

Child exits were using exit(), which caused crashes on 10.10 for
Multiprocess-based tests that r...

TEST=run_with_crashpad --handler crashpad_handler \
-a --database=/tmp/crashpad_db \
...

bootstrap_look_up().

This hasn’t been required since the 10.5 SDK, which is no longer
supported....

upload attempts to no more than 1 per hour.

The rate limiting is simplistic but duplicates the e...

I don’t want to call it 1.0 yet because the Windows client isn’t done
and there’s no processor y...

These people have contributed and reviewed significant and non-trivial
code.

R=rsesek@chromium....

Rather than accepting the path to the database’s parent directory, this
now accepts the path to ...

This makes it possible to #include "client/settings.h" for the interface
even on Windows. Althou...

[email protected]

Review URL: https://codereview.chromium.org/997613002

abuses and misuses.

TEST=crashpad_client_test CrashReportDatabaseTest.*
[email protected], s...

This is only implemented for CrashReportDatabaseMac, because
CrashReportDatabaseWin does not cur...

optimization.

Newer versions of clang (in this case, trunk r231191) can see through
the pointles...

This only works 64->64, 32->32, and 64->32. We shouldn't have a
need for 32->64. It will also cu...

[email protected]

Review URL: https://codereview.chromium.org/988063003

Likewise for EXPECT_DEATH_CHECK() and EXPECT_DEATH().

In the in-Chromium build configured for of...

BUG=crashpad:12
[email protected]

Review URL: https://codereview.chromium.org/996433002

picking up:

e7847b381703 10.10 compatibility for base::mac::ScopedLaunchData
6d162c334672 comm...

When building in the Chromium tree, this swaps out Crashpad’s copies of
mini_chromium, gtest, an...

Test code that requires test data should call Paths::TestDataRoot() to
obtain the test data root...

gtest and gmock both rely heavily on exit-time destructors, and must
build with -Wno-exit-time-d...

nullptr ProcessReader::Module.

Prior to 64b87325b9de, the alignment problem meant that the Modul...

In Chromium, many targets are built, sharing a single output directory.
Collisions are likely. W...

When building in the Chromium tree, chromium_code is necessary to apply
Chromium’s build/filenam...

BUG=crashpad:12
[email protected]

Review URL: https://codereview.chromium.org/989023002

A few stragglers were missing from bc401f6aac22. I really don’t know how
that’s possible, since ...

The 10.10 SDK deprecates <launch.h>, but this file is still useful and
is used by util/mac/launc...

Includes:
- win: Default build to x64

[email protected]
BUG=crashpad:1

Review URL: https:/...

Mostly size_t <-> unsigned int warnings, but I also had a mistake in
PROCESS_BASIC_INFORMATION, ...

32-bit mode.

TEST=snapshot_test (specifically MachOImageAnnotationsReader.CrashDyld)
R=rsesek@ch...

A couple of the problems related to not having a C++11 library:

- You can’t put const elements...

This is as a precursor to ProcessReader. Some basic functionality
is included for now, with more...

The handler is now capable of uploading crash reports from the database.
At present, only one up...

ProcessSnapshotMinidump.

ModuleSnapshotMinidump is currently only capable of reading module
anno...

between classic and extension structures.

Previosly, each MinidumpModuleCrashpadInfo structure c...

Includes:
win: disable C4996 warning about deprecated functions

[email protected]
BUG=crash...

ProcessReaderWin only a stub for now.

[email protected]
BUG=crashpad:1

Review URL: https://c...

the Snapshot family.

For the time being, only ProcessSnapshotMinidump::AnnotationsSimpleMap()
is...

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/940793002

FileSeekerInterface::SeekSet().

These methods perform common error checking.

TEST=util_test Str...

implement the new interface.

The upcoming minidump reader will get minidump data from a
FileRead...

Some annotations will exist at a broader scope than per-module, which is
the only place that ann...

Original CL (review, misc support code changes) at https://codereview.chromium.org/867363003/.

...

Upload isn’t actually hooked up yet, but this establishes the upload
thread and provides all of ...

e:\b\build\slave\crashpad_win_rel\build\crashpad\util\misc\initialization_state_dcheck_test.cc(2...

As there are no extended file attributes available on all Windows file
systems (NTFS supports al...

This also splits the per-OS Semaphore methods into their own files.

TEST=util_test Semaphore.*
...

Uses solution suggested in linked bug. No test as it'd be flaky, slow,
or both.

R=mark@chromium...

This adds a new optional out-parameter to
HTTPTransport::ExecuteSynchronously() and provides Mac...

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/900323003

The PUSH/POP are less noisy for sure. SUPPRESS is a little more
subtle -- it's correctly documen...

external defined symbols.

Indirect symbols remain unsupported.

Xcode 5.1 ld64-236.3/src/ld/Link...

- unaligned due to heap allocation
- potentially uninitialized local
- truncation of uint64_t ->...

- More references to sizeof(Struct::Member)
- Complaints about not being able to generate
cons...

- Stack object instantiated for sizeof to avoid

d:\src\crashpad\crashpad\minidump\minidump_syst...

MINIDUMP_MISC_INFO and MINIDUMP_MISC_INFO_2, etc. are not
derived from each other in Windows' db...

Includes

fb514aa4270ded201e841de6c2f45c72eafb236c Add MSVS_ warning suppression macros
a89b5f1a...

test_process_snapshot.h apparently requires the full inclusion,
not a forward declaration otherw...

No constexpr on VS2013. :(

[email protected]
BUG=crashpad:1

Review URL: https://codereview.c...

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/902793003

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/897233002

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/897863004

- implicit conversion from time_t -> long
- "exception_info" is a pseudo-keyword on MSVC related...

Needed on Windows for sys/time.h.

d:\src\crashpad\crashpad\snapshot\test\test_process_snapshot....

Had to move this one out to a scoped_ptr too, otherwise when
it's instantiated in test code on t...

- time_t -> uint32_t warning
- mixing bool and BOOLEAN
- potentially unintialized variable warni...

e.g.

d:\src\crashpad\crashpad\minidump\minidump_memory_writer_test.cc(347) : error C2220: warni...

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/896133002

A (somewhat cursory) inspection leads me to believe that there's
no particular alignment require...

In some cases, it's sufficient to move the zero-length array to the end of the
structure. When t...

- dbghelp.h requires windows.h to be included before it (ick!).
Add a stub one for non_win to ...

[email protected]

Review URL: https://codereview.chromium.org/904493002

deals solely with a weak FileHandle.

CrashReportDatabase::PrepareNewCrashReport() provides its c...

A crash handler needs a way to clean up after itself it it calls
CrashReportDatabase::PrepareCra...

Includes:

99f91222f4c99b1420ca8cc76d4effc9a6204da0 Pull in ALIGNAS, define WIN32_LEAN_AND_MEAN
...

Oops, forgot to do this before landing.

[email protected]
[email protected]
BUG=crashpad:...

- Various "FD" to "Handle"
- Existing Multiprocess implementation moves to _posix.
- Stub implem...

- Dependency on compat required for sys/types.h inclusion for ssize_t.
- Test impl of stat to av...

(There's also https://codereview.chromium.org/854363006/ based on
WinInet, I'm still a little un...

[email protected]
TEST=client_test --gtest_filter=CrashReportDatabase\*

Review URL: https://c...

Includes:
45cbbb054ccef2e77d5233aa95c5f2742a23dec1 Add FilePath::FinalExtension and RemoveFinalE...

off_t exists on Windows, but Seek is implemented in terms of
SetFilePointerEx which expects a LO...

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/816223007

%zu aborts in system printf functions on Windows, so use PRIuS instead.

[email protected], rs...

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/852773004

Includes:

3ce1cc29260d5b49ac21d96454a778c02f583172 Pull in base/format_macros.h from Chromium, ...

Also fix implementation of CreateFile which aborted at runtime
when provided POSIX-style permiss...

[email protected]
TEST=util_test --gtest_filter=Xattr\*

Review URL: https://codereview.chromi...

After https://codereview.chromium.org/826003003/.

[email protected]

Review URL: https://code...

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/808493003

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/840933004

As it was left unimplemented on Windows per previous discussion.

[email protected]
BUG=crashp...

Uses the posix-y CRT functions rather than Win32 API for consistency/similarity
to the POSIX cod...