744f209 win: Enable C4800, implicit bool conversion
82060c1 mac: Make Mach port scopers better S...

Fixes two incorrect usages of ssize_t/off_t being implicitly converted
to bool. As such, I think...

Oops, forgot to test Mac, sorry.

[email protected]

Review URL: https://codereview.chromium.o...

When used in client headers, the downstream dependency on compat
is unpleasant, so avoid that.

...

[email protected]
BUG=crashpad:59

Review URL: https://codereview.chromium.org/1412243005 .

[email protected]

Review URL: https://codereview.chromium.org/1415313003 .

[email protected]
BUG=crashpad:52

Review URL: https://codereview.chromium.org/1408073005 .

Follow up to TODO in https://codereview.chromium.org/1419623003/.

[email protected]
BUG=crash...

L"" and wstring are a bit of a mess cross-platform, so just store the
type name as UTF8 instead....

[email protected]
BUG=crashpad:21, crashpad:52

Review URL: https://codereview.chromium.org/14...

BUG=crashpad:67
[email protected]

Review URL: https://codereview.chromium.org/1399623002 .

[email protected]

Review URL: https://codereview.chromium.org/1416833003 .

/bug/ redirects to the Crashpad project on Monorail. /bug/new redirects
to the “new issue” scree...

In https://codereview.chromium.org/1411523006, the Mach port scopers are
becoming better ScopedG...

Having two ~s in one block confused doc generation.

[email protected]

Review URL: https://...

These wrap the GetProcAddress(LoadLibrary(), …) idiom into macros that
are much less wordy.

T...

“fetch crashpad“ is possible since depot_tools ea1b3d5ed88b.

[email protected]

Review URL:...

This new test from 7de04b02f85d was failing on Windows 10. I started by
adding the hint, which p...

base::RandInt(0, max - 1) has a uniform distribution.
base::RandUint64() % max does not.

TEST=c...

Oops.

[email protected]
BUG=crashpad:21, crashpad:52

Review URL: https://codereview.chromium...

Follows https://codereview.chromium.org/1400413002/.

[email protected]
BUG=crashpad:21, crash...

To eventually be used to fill out MINIDUMP_HANDLE_DESCRIPTOR.

[email protected]
BUG=crashpad:...

I thought I had confirmed that this still allocated and ignored the flag
on older OSs, but I mus...

end_to_end_test.py started failing after landing
https://codereview.chromium.org/1392093003/ but...

Capture the memory for the loader lock (can be inspected by !cs), as
well as all locks that were...

When not building against the C++11 library headers, the compiler cannot
treat the lambda as lva...

c9625ad5d23c Update base/numerics/* and base/template_util.h

[email protected]

Review URL...

Makes !vprot work in windbg, e.g.

0:000> !vprot 0x970000
BaseAddress: 00970000
Allocation...

Follows https://codereview.chromium.org/1375313005.

Adds MINIDUMP_MEMORY_INFO for non-win in db...

[email protected]
BUG=crashpad:46

Review URL: https://codereview.chromium.org/1390913008 .

Getting closer... Some tests passed on the last run, but the ones that
rely on having ntdll symb...

Oops, was passing the out dir (...\crashpad\out), not the binary dir
(...\crashpad\out\Debug). D...

There's a problem running crashpad_handler, but I'm not sure what it is.
I think an exception is...

[email protected]
BUG=crashpad:20, crashpad:46, crashpad:52

Review URL: https://codereview.ch...

BUG=crashpad:67
[email protected], [email protected]

Review URL: https://codereview.chromiu...

BUG=crashpad:67

Review URL: https://codereview.chromium.org/1397173002 .

I'd like to write some `expect(1)`-style tests (possibly using
http://pexpect.readthedocs.org/en...

BUG=crashpad:67
[email protected], [email protected]

Review URL: https://codereview.chr...

BUG=crashpad:67
[email protected]

Review URL: https://codereview.chromium.org/1390353004 .

This script populates doc/generated. This directory is named in
.gitignore on the master branch,...

I’ve accidentally created Crashpad databases when running
crashpad_database_util by mistyping th...

BUG=crashpad:22
[email protected]

Review URL: https://codereview.chromium.org/1397603002 .

BUG=crashpad:22
[email protected]

Review URL: https://codereview.chromium.org/1392653002 .

Previously, any attempt to create a new crash report database would
result in this message being...

This doesn’t really provide compatibility, it just ignores the
deprecation warning for +[NSURLCo...

We already use all the shared constants for page protection and type,
so rather than making vari...

This resolves some left-behind TODOs referring to a closed bug. It looks
like this should have w...

BUG=crashpad:63
TEST=crashpad_util_test FileIO.*OpenFileFor*
[email protected]

Review URL:...

BUG=crashpad:63
TEST=crashpad_util_test FileIO.OpenFileForWrite
[email protected]

Review U...

ExceptionPorts::GetExceptionPorts() returned a
std::vector<ExceptionPorts::ExceptionHandler>, wh...

This is a weird option that causes crashpad_handler to discard the crash
handler it inherited an...

If the task’s exception handler for EXC_CRASH, EXC_RESOURCE, and
EXC_GUARD exceptions cannot be ...

launchd actually does set the EXC_RESOURCE and EXC_GUARD handlers
exactly the same way that it s...

This wraps bootstrap_check_in() in BootstrapCheckIn(), and
bootstrap_look_up() in BootstrapLookU...

Chrome’s relauncher process needs a way to sever ties with the
crashpad_handler instance running...

Sadly this code did not survive a collision with the real world. In
probing for the environment ...

Previously:

0:000> !peb
PEB at 7f374000
InheritedAddressSpace: No
ReadImageFileExecO...

[email protected]
BUG=crashpad:46

Review URL: https://codereview.chromium.org/1382963002 .

crashy_program's log looks something like this now:

0:000> .ecxr
eax=00000007 ebx=7f24e000 ecx=...

To be used for improved version of ReadMemory() that is memory-map
aware, in particular for read...

Pulls in:

133a8c61c: win: Turn on ASLR by default

[email protected]

Review URL: https://cod...

This causes a link error on msvs builds which we don't care about, but
in general if build/commo...

On Win10, VirtualQueryEx supports querying the x64 part of WOW64
processes. However, on lower OS...

928f9c45fe2d win: Allow frame pointer omission (FPO, /Oy)

BUG=crashpad:53
[email protected]...

RtlCaptureContext() is buggy and limited.

BUG=crashpad:53
[email protected]

Review URL: h...

Not yet written as MINIDUMP_MEMORY_INFO_LIST to minidump.

[email protected]
BUG=crashpad:20, ...

Windows requires the connection to the handler to do anything, so it
can't really be implemented...

Follow up to https://codereview.chromium.org/1364053002/.

[email protected]
BUG=crashpad:46

...

The Windows equivalent uses references, which are better than pointers
for these const non-null ...

This makes the basics of !peb work in windbg, however, pointed-to things
are not yet retrieved. ...

Pulls in:

win: Update iterator debug settings to match VS default, and be explicit about which ...

[email protected]
BUG=crashpad:50

Review URL: https://codereview.chromium.org/1355503005 .

[email protected]

Review URL: https://codereview.chromium.org/1356753004 .

Ninja assumes all DLLs will have an import library generated (caused
when there are any exports)...

[email protected]
BUG=crashpad:1, chromium:440500

Review URL: https://codereview.chromium.org...

Factor out some test launching code used in cross-bitness tests.

[email protected]
BUG=crashp...

Removes the bitness-specific targets in favour of pulling binaries from
the other build director...

8c31354f5e0c Fix mixed line endings warning
4f4c7cb5a63e Add TestGypXcodeNinja to run tests agai...

These were made unnecessary after changing how registration works, but I
forgot to actually dele...

This undoes 595803e1be18, a workaround that should no longer be
necessary now that base no longe...

These files were only using basictypes.h for implicit_cast, which moved
to util/misc/implicit_ca...

Pulls in "win: Don't omit frame pointers".

[email protected]
BUG=crashpad:50

Review URL: h...

A few function implementations that were missing, various switches
for functions/functionality t...

Split out of https://codereview.chromium.org/1336823002/, I'll go and
adapt various places to us...

Until the base one goes away this complains of it being ambiguous.

[email protected], scottmg...

Removes basictypes.h implicit_cast.

[email protected]

Review URL: https://codereview.chrom...

The implicit_cast in base will be no more, make sure we have a reference
to the crashpad version...

chromium's implicit_cast is going to be removed so stop using it.

BUG=529769,472900
R=mark@chro...

[email protected]
BUG=crashpad:50

Review URL: https://codereview.chromium.org/1339813002 .

OpenThread(THREAD_ALL_ACCESS, ...) fails on XP with the uplevel value of
THREAD_ALL_ACCESS, so u...

[email protected]
BUG=crashpad:50

Review URL: https://codereview.chromium.org/1343433003 .

The pipe handle was being leaked on connections (oops!). On XP this
resulted in the next test's ...

Fails on XP with ERROR_INVALID_PARAMETER (undocumented). Not overly
important that we reject emb...

PROCESS_ALL_ACCESS was changed in later SDKs and the newer value fails
when run on XP with ERROR...

It looks like I wrote the x86_64 version first and didn’t adapt
everything perfectly when transi...

After https://codereview.chromium.org/1303173011/, the thread suspend
count would be one too lar...

[email protected]
BUG=crashpad:1

Review URL: https://codereview.chromium.org/1303173011 .

Follow up after suggestion in https://codereview.chromium.org/1301853002/.

[email protected]
...

[email protected]

Review URL: https://codereview.chromium.org/1325343003 .

CrashReportExceptionHandler::CatchMachException() must always set a
valid new_state. Failing to ...