[email protected]
BUG=crashpad:89

Change-Id: Ib6a67147e538811168d68f14a457fdceab30c02e
Review...

Change-Id: I4d5ee3a8a3a39b34bee6ad616646966e986132b1
Reviewed-on: https://chromium-review.google...

Change-Id: Ide75475aa9c42edf36c3a709bfc7dfbfed68b0d3
Reviewed-on: https://chromium-review.google...

CrashpadInfo not being initialized/propagated properly on Mac.

Change-Id: I5f33a16e4e18bb1b068e...

Change-Id: I6467aafba5d20f8a199bab0e2476f98a5318f84a
Reviewed-on: https://chromium-review.google...

crashpad and mini_chromium both have top-level “build” directories.
These would conflict with to...

This augments the standalone and in-Chromium models with an external
model, in which the depende...

7c5b0c1ab44a Use Gerrit (Polygerrit) for mini_chromium code review

Change-Id: I883672b91dac5387...

Kasko needs a way to read crash keys from out of process. This API
reuses the functionality of P...

It has no effect on Gerrit hosts. The notification settings within
Gerrit need to be configured....

Change-Id: I36baf766e17cf7f86d14fd28f8e6c22008c8f6f4

The previous approach was nice for its simplicity, but unfortunately
didn't work when the compil...

[email protected]
BUG=crashpad:86, chromium:571144

Review URL: https://codereview.chromium.or...

For perceived freshness of command-line tools

[email protected]

Review URL: https://coder...

This is a temporary measure to try to account for lower than expected
upload volume from Chrome ...

This matches Chromium 01e379fac955.

[email protected]

Review URL: https://codereview.chrom...

a43fee120b10 Sync Mac scopers with upstream Chromium

This adapts to updated Mac scopers from Ch...

This was done in Chromium’s local copy of Crashpad in 562827afb599. This
change is similar to th...

Crashpad uses std::move() as of 6bebb1082933. scoped_ptr<>::Pass() will
be unavailable once mini...

This will prune the database on a daily basis, in accordance with the specified
condition.

BUG=...

../../handler/crash_report_upload_thread.cc:142:7: error: field 'database_' will be initialized ...

This was extracted from CrashReportUploadThread and will be re-used for the
database pruning thr...

Fix some warnings when compiling crashpad with VC++ 2015 Update 1.

Warning 4302 occurs if you c...

This more-natural spelling doesn’t require Crashpad developers to have
to remember anything spec...

The upcoming https://codereview.chromium.org/1513573005/ requires that
std::move() in compat be ...

[email protected]

Review URL: https://codereview.chromium.org/1511233002 .

At the default level, we might be terminated before the process we're
watching, which would mean...

BUG=chromium:567877
[email protected], [email protected]

Review URL: https://codereview.ch...

BUG=chromium:472900
[email protected]

Review URL: https://codereview.chromium.org/15081930...

MEMORY_BASIC_INFORMATION64 specifies an alignment of 16, but the
standard allocator used by cont...

Causes a warning in the gyp-msvs generator.

[email protected]

Review URL: https://codereview...

The BaseName() was added because system DLLs were being reported by
GetFileVersionInfo()/VerQuer...

Reported by [email protected].

[email protected]
BUG=chromium:427616

Review URL: http...

BUG=crashpad:78
TEST=crashpad_snapshot_test PEImageReader.VSFixedFileInfo_AllModules
R=scottmg@c...

Don't call GetFileVersionInfo(), which calls LoadLibrary() to be able to
access the module's res...

Per https://codereview.chromium.org/998653002/, we were going to call
the Windows client milesto...

[email protected], [email protected]
BUG=crashpad:80

Review URL: https://codereview.chromiu...

[email protected]

Review URL: https://codereview.chromium.org/1489063002 .

Since C++11 library support isn't available everywhere crashpad is
compiled, add our own move() ...

On Win 7 in a debug configuration, walking all locks was gathering
hundreds of thousands of lock...

This reverts commit b3464d96f5fc0d82f860651b7918626dfbd80d65.

It was temporarily landed to be a...

On Win 7 in a debug configuration, this was gathering hundreds of
thousands of locks, causing te...

See e.g. http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/4502/steps/compile/...

FILE_TYPE_CHAR handles can't be inherited via
PROC_THREAD_ATTRIBUTE_HANDLE_LIST, or CreateProces...

Modules will work without a VERSIONINFO resource. This happens in some
of Crashpad's tests.

R=s...

This log spam from end_to_end_test.py indicated that
GetFileVersionInfo() was being called three...

8b085f0d2168 Fix warnings encountered in MSVC build of gtest/gmock tests
322a4914a309 Better use...

43f04e729962 win: Compile with /bigobj

[email protected]

Review URL: https://codereview.c...

[email protected]
BUG=chromium:82385

Review URL: https://codereview.chromium.org/1463633002 .

The fields aren't accessed anyway, but clang warns that they're
completely inaccessible. Also, m...

[email protected]
BUG=crashpad:77

Review URL: https://codereview.chromium.org/1464473003 .

This unifies several things that used a 16-character random string, and
a few other users of ran...

All our Main()s are in namespace crashpad already, so this just works.

[email protected]
BUG=...

[email protected]

Review URL: https://codereview.chromium.org/1404033002 .

985372e5da14 win: Send log messages to a debugger via
OutputDebugString()
06e0fa130...

The bug and linked code review has more of the history, but we’ve been
tempted to remove the loo...

Previously, there was a window after starting the upload thread but
before the SIGTERM handler w...

This is unexpected and important enough that the restart shouldn’t
happen silently.

BUG=crashpa...

[email protected]

Review URL: https://codereview.chromium.org/1408353011 .

[email protected]

Review URL: https://codereview.chromium.org/1426533008 .

This is better because now end_to_end_test.py fails immediately with

[1180:9020:20151106,145204...

Something like this is required to implement something like
https://code.google.com/p/chromium/c...

This requires Windows NT 6.0 (Vista and Server 2008). On earlier
operating system versions, the ...

HandleToInt() and IntToHandle() use int, a signed type, for the 32-bit
integer representation of...

[email protected]
BUG=chromium:546288

Review URL: https://codereview.chromium.org/1431813003 .

I've heard/lived enough horror stories about AV, outbound-blocking
firewalls, etc. on Windows, t...

This is necessary to be able to connect to crashpad_handler from a
Chrome renderer.

R=jschuh@ch...

[email protected]

Review URL: https://codereview.chromium.org/1419533014 .

In 2eeaa3ac549a, I added a check to make sure that the expected CONOUT$
handle was found. Its om...

Review URL: https://codereview.chromium.org/1424713008 .

This consolidates all of the twisted casts and comments that discuss how
HANDLEs are really only...

Crashpad is mostly friendly with clang-format and has its own
.clang-format file. Adding buildto...

Allowing the client to create its own pipe name string caused a race
between client and server. ...

By invoking crashpad_handler with --mach-service instead of
--handshake-fd, the handler will run...

BUG=crashpad:68
[email protected]

Review URL: https://codereview.chromium.org/1413033007 .

For multiprocess architectures, this method allows the pipe used for
registration to be obtained...

In https://codereview.chromium.org/1414533006/, I'm adding a few
Mac-specific SetHandler() varia...

BUG=crashpad:69
[email protected]

Review URL: https://codereview.chromium.org/1428803006 .

The cdb on the x86 bot displays relative to exported DLL symbols, but
newer ones don't seem to, ...

This is necessary for 64 bit tools installed on a 64 bit OS, but with
the tests run from a 32 bi...

BUG=crashpad:47
[email protected]

Review URL: https://codereview.chromium.org/1414323003 .

Doxygen doesn’t generate documentation for macros unless the file that
defines it has a \file di...

I considered writing the CodeView records to the minidump, but I didn't
find a ton of docs and d...

[email protected]

Review URL: https://codereview.chromium.org/1427193002 .

Each routine in this implementation returns MIG_BAD_ID. These routines
may be overridden.

Most ...

[email protected]

Review URL: https://codereview.chromium.org/1428973002 .

Patch from Marc-A...

All other links to code.google.com and googlecode.com are fixed to point
to their proper new hom...

This re-lands 9d03d54d0ba1, which was partially un-done by an apparent
bad rebase leading up to ...

Previously, crashpad_handler made its own receive right, and transferred
a corresponding send ri...

This allows better code sharing in crashpad_handler’s main(). It doesn’t
look like much of an im...

The intended use is to flip the client-server relationship in
CrashpadClient so that the initial...

[email protected]
BUG=chromium:546288

Review URL: https://codereview.chromium.org/1415543003 .

BUG=crashpad:1
[email protected]

Review URL: https://codereview.chromium.org/1411123011 .

Roll mini_chromium deps to remove disabling of those warnings in common.gypi:
8e12d3d win: Rem...

[email protected]
BUG=chromium:546288

Review URL: https://codereview.chromium.org/1418613013 .

[email protected]
BUG=crashpad:1, chromium:546288

Review URL: https://codereview.chromium.org...

[email protected]
BUG=crashpad:1, crashpad:526488

Review URL: https://codereview.chromium.org...

Chromium base doesn't have base::c16len, c16memcpy, etc. when
WCHAR_T_IS_UTF16, so implement c16...

[email protected]

Review URL: https://codereview.chromium.org/1416493006 .

8d42e24 win: Enable C4800, implicit bool conversion
82060c1 mac: Make Mach port scopers better S...