implicit_cast<> only performs a cast in cases where an implicit
conversion would be possible. It...

TEST=minidump_test MinidumpMiscInfoWriter.InitializeFromSnapshot
[email protected]

Review U...

TEST=minidump_test MinidumpSystemInfo*
[email protected]

Review URL: https://codereview.chr...

This only came up in one location, PointerVector.

A template alias is superior to inheritance, ...

This replaces all occurrences of “typedef Y X;” with “using X = Y;”.

[email protected]

Rev...

TEST=minidump_test MinidumpExceptionWriter.InitializeFromSnapshot
[email protected]

Review ...

downstream, and tests.

TEST=minidump_test
[email protected]

Review URL: https://codereview....

and its test.

Minidump context structures now interoperate more easily with snapshot
CPUContext ...

[email protected]

Review URL: https://codereview.chromium.org/689193003

Not doing this causes gtest to issue these warnings:

[WARNING] ../../third_party/gtest/gtest/sr...

BUG=https://crbug.com/415544
[email protected]

Review URL: https://codereview.chromium.org/69...

These classes don’t really have “mutators” other than their singular
AddModule() methods, and th...

and its test.

TEST=minidump_test MinidumpMemoryWriter.AddFromSnapshot
[email protected]

Rev...

These classes don’t really have “mutators” other than their singular
AddModule() methods, and th...

This addresses a review comment from
https://codereview.chromium.org/681303003/diff/120001/util/...

BUG=https://crbug.com/415544
[email protected]

Review URL: https://codereview.chromium.org/68...

[email protected]

Review URL: https://codereview.chromium.org/689483003

MinidumpModuleListWriter.

TEST=minidump_test
[email protected]

Review URL: https://coderevi...

[email protected]

Review URL: https://codereview.chromium.org/688643002

TEST=minidump_test
[email protected]

Review URL: https://codereview.chromium.org/681313005

MinidumpModuleCrashpadInfoListWriter and everything downstream.

TEST=minidump_test
R=rsesek@chro...

All minidump objects now own their all of their children, rather than
having them maintain weak ...

BUG=415544
[email protected]

Review URL: https://codereview.chromium.org/669153006

The classes were renamed in response to
https://codereview.chromium.org/675803002/diff/1/minidum...

test.

Move SimpleAnnotations from being a property of the minidump to being a
property of the mo...

TEST=minidump_test
[email protected]

Review URL: https://codereview.chromium.org/679443002

class virtual destructor with “override”.

TEST=minidump_test MinidumpContextWriter.*:MinidumpMod...

The iov_base field appears before the iov_len field, but for some
reason, sometimes the fields w...

MinidumpWritableAtLocationDescriptor<>().

TEST=minidump_test
[email protected]

Review URL: ...

MinidumpFileWriter, and Minidump*StringWriter.

TEST=minidump_test
[email protected]

Review ...

Suggested at
https://codereview.chromium.org/654573003/diff/1/minidump/minidump_string_writer_te...

TEST=minidump_test MinidumpCrashpadInfoWriter.*
[email protected]

Review URL: https://coder...

[email protected]

Review URL: https://codereview.chromium.org/657303003

[email protected]

Review URL: https://codereview.chromium.org/662813003

[email protected]

Review URL: https://codereview.chromium.org/650223007

[email protected]

Review URL: https://codereview.chromium.org/649633004

TEST=snapshot_test MachOImageAnnotationsReader.*
[email protected]

Review URL: https://code...

TEST=snapshot_test, util_test CheckedMachAddressRange.*
[email protected]

Review URL: https...

TEST=client_test SimulateCrash.SimulateCrash
[email protected]

Review URL: https://coderevi...

nroff mandoc-format man pages can be generated by running:

a2x --format manpage \
--attribu...

TEST=minidump_test MinidumpSimpleStringDictionaryWriter.*
[email protected]

Review URL: htt...

The base class takes care of this.

TEST=util_test ScopedTaskSuspend.ScopedTaskSuspend
R=rsesek@...

This change was generated mechanically by running:

find . \
\( -name \*.cc -or -name \*...

This change was generated mechanically by running:

find . \( -name \*.cc -or -name \*.mm -or ...

[email protected]

Review URL: https://codereview.chromium.org/650993003

[email protected]

Review URL: https://codereview.chromium.org/650303002

[email protected]

Review URL: https://codereview.chromium.org/652003002

This also introduces ScopedFcntlFlags.

TEST=util_test ScopedTaskSuspend.*:ScopedFcntlFlags.*
R=...

This uses THREAD_NULL, TASK_NULL, and HOST_NULL in preference to
MACH_PORT_NULL and kMachPortNul...

amount of time spent sleeping.

Even with the slop, this wound up being flaky, specifically on vi...

ExpectProcessIsRunning() goes to a lot of trouble to deal with the flaky
{CTL_KERN, KERN_PROCARG...

This is in line with the other new minidump_*_test_util files, namely,
the “context” and “memory...

TEST=minidump_test MinidumpThreadWriter*
[email protected]

Review URL: https://codereview.c...

Inspired by
https://codereview.chromium.org/637503006/diff/20001/minidump/minidump_thread_writer...

TEST=minidump_test MinidumpExceptionWriter*
[email protected]

Review URL: https://coderevie...

testing::Test::HasFatalFailure() after calling functions that could fail
fatally.

Inspired by
ht...

These utilities are also useful to MinidumpThreadWriter’s test.

TEST=minidump_test MinidumpMemo...

TEST=minidump_test MinidumpModuleWriter*
[email protected]

Review URL: https://codereview.c...

The contents of tools are moved into the namespace
crashpad::(anonymous namespace).

https://goo...

The contents of tests are moved into the namespace
crashpad::test::(anonymous namespace).

https...

TEST=minidump_test MinidumpContextWriter.*
[email protected]

Review URL: https://codereview...

[email protected]

Review URL: https://codereview.chromium.org/628403002

InitializeCPUContextX86_64(), and their tests.

TEST=snapshot_test CPUContextMac.*
R=rsesek@chrom...

No functional change.

TEST=snapshot_test SystemSnapshotMacTest.CPUX86SupportsDAZ
R=rsesek@chrom...

In locations that observe daylight saving time, this method now probes
different times to determ...

[email protected]

Review URL: https://codereview.chromium.org/623163004

TEST=snapshot_test SystemSnapshotMac.*
[email protected]

Review URL: https://codereview.chr...

It is a thread_t, not a task_t.

[email protected]

Review URL: https://codereview.chromium....

7dda7b322881 accidentally moved the libbsm.dylib dependency from
util_test_lib to util_test. It ...

These are all of the abstract base classes used in the Snapshot series,
discussed in the thread ...

[email protected]

Review URL: https://codereview.chromium.org/620793003

(Perhaps I should have just left it in mini_chromium, but anyway.)

[email protected]
BUG=cras...

This fixes a sloppy compliation error: “Redefinition of enumerator
'kMinidumpContextX86Xstate'”....

Just guarding the usage of $SDKROOT so that ninja doesn't error out
on invalid $ escape on parsi...

This includes ClockMonotonicNanoseconds() and SleepNanoseconds().

SleepNanoseconds() is like ba...

These are fairly simple classes and it’s not valuable to test them
individually. They will be te...

[email protected]

Review URL: https://codereview.chromium.org/597263002

TEST=util_test Semaphore.*:ProcessReader.*:ExceptionPorts.*
[email protected]

Review URL: h...

[email protected]

Review URL: https://codereview.chromium.org/593183003/

TEST=util_test Int128.UInt128
[email protected]

Review URL: https://codereview.chromium.org...

This will be used in the upcoming Minidump context structures.

This also updates mini_chromium ...

[email protected]

Review URL: https://codereview.chromium.org/588073004

Update mini_chromium to 313bd83d6d9d, picking up:

313bd83d6d9d Use close$NOCANCEL on Mac, as in...

TEST=util_test Multiprocess.Multiprocess
[email protected]

Review URL: https://codereview.c...

The queue length of a new receive port appears to be 2 on Mac OS X 10.10
DP8 14A361c. The value ...

This reverts commit 63fd3ae47d2513ef4390c3d8c0dde3fa95152480.

SMJobRemove() still performs a 1-...

Don’t require a __TEXT, __text section in every module. Some system
modules on 10.6, including A...

On 10.6, the main executable does not show up at index 0, but appears
elsewhere in the list. Mod...

elements whose handler port would be MACH_PORT_NULL.

For most exception targets, *_get_exception...

finish.

It was possible for the child process to exit before the parent had a
chance to complete...

TEST=util_test
[email protected]

Review URL: https://codereview.chromium.org/577333002

For identity-carrying exceptions, the system-wide thread ID is shown.

For state-carrying except...

exception handler ports.

task_t, thread_t, and exception_handler_t are typedefs for mach_port_t....

[email protected]

Review URL: https://codereview.chromium.org/575033004

mach_exception_data_type_t is more generic and is used for any element
of a codes[] array. For i...

57eb311528f2.

[email protected]

Review URL: https://codereview.chromium.org/575243002

ExcCrashRecoverOriginalException(), and use it where sensible.

TEST=util_test ExcVariantsTest.Ex...

catch_exception_tool catches Mach exceptions. Currenlty, it simply
prints a message with some in...

There’s also some light reformatting in here. Should save a few lines.

TEST=util_test ExcServer...

TEST=util_test ServiceManagement.SubmitRemoveJob
[email protected]

Review URL: https://code...