Ecosyste.ms: OpenCollective
An open API service for software projects hosted on Open Collective.
github.com/electron/node
Node fork to make it suitable for embedding in Electron
https://github.com/electron/node
This commit attempts to fix an issue when building on windows using the
following command line o...
This change provides unified tracking of asynchronous promise lifecycles
for both domains and as...
PR-URL: https://github.com/nodejs/node/pull/13177
Reviewed-By: James M Snell <[email protected]>...
PR-URL: https://github.com/nodejs/node/pull/13172
Reviewed-By: Colin Ihrig <[email protected]>
R...
Original commit message:
[turbofan] Boost performance of Array.prototype.shift by 4x.
For s...
e51a20160923a54b796b1955fcb8e00194b4c240 authored over 7 years ago by Ali Ijaz Sheikh <[email protected]>
This commit adds coverage for several edge cases related to
util.format() format string placehol...
Currently the following compiler warning is displayed when building:
../test/cctest/test_insp...
25ade76fb01258d8a789a9cd893b284542827efd authored over 7 years ago by Daniel Bevenius <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13216
Reviewed-By: Colin Ihrig <[email protected]>
R...
* track callback invocations with common.mustCall() and
common.mustNotCall()
* remove test in ...
Add `common.refreshTmpDir()` before using the tmp directory.
fs.writeSync no longer requires an...
bbf74fb87b2f8273e1d93e949f9c840b12ce4805 authored over 7 years ago by Rich Trott <[email protected]>Document --inspect-port, and fix the reporting for when it is misused.
The option requires an a...
3954ea9f41b187915c4812ff6f360276bc94028c authored over 7 years ago by Sam Roberts <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13200
Reviewed-By: Anna Henningsen <[email protected]...
Really minor but I could not find an open PR for anything n-api where
this could be changed, so ...
Adds the ability to for write streams to have an _final method which acts
similarly to the _flus...
Covert lib/dgram.js over to using lib/internal/errors.js
for generating Errors. See
[using-inter...
test-stream2-basic runs in a few seconds. It can be moved to parallel.
PR-URL: https://github.c...
1aad4ba2841120d04661681cd7a60b7124912d42 authored over 7 years ago by Rich Trott <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13146
Reviewed-By: Refael Ackermann <[email protected]...
In test/pummel/test-stream2-basic.js, check that noop functions are
called the expected number o...
Fixed a regression that caused the callback passed to destroy()
to not be called if the stream w...
PR-URL: https://github.com/nodejs/node/pull/13145
Refs: http://eslint.org/docs/rules/no-useless-...
PR-URL: https://github.com/nodejs/node/pull/13138
Reviewed-By: Anna Henningsen <[email protected]...
* Wrap text at 80 characters.
* Use periods consistently.
PR-URL: https://github.com/nodejs/nod...
eebc2622781d62125cd37a1c5ad06f26ba0a117f authored over 7 years ago by Alexey Orlenko <[email protected]>
This commit fixes an incorrect keyboard shortcut in
`doc/STYLE_GUIDE.md`: entering em-dashes is ...
Use common.mustCall() in test-fs-makeStatsCallback to confirm that the
callback is invoked.
PR-...
7c12d12ecf7fb4f0e22bc45690e123d827a0820d authored over 7 years ago by Rich Trott <[email protected]>
When a no-op message event handler is used in a test, make it clear what
is expected by using `c...
Add tests to validate that properties marked as static
are available through the class as oppose...
Fix mismatch in title for napi_get_value_string_utf16
Fixes: https://github.com/nodejs/abi-stab...
f3ef9719b5c18775fcfdb12dd62aaeef8caeb94a authored over 7 years ago by Michael Dawson <[email protected]>
This fixes a race condition in the watchdog timer used for vm timeouts.
The condition would term...
This option has been broken for almost a year when used with any of the
vm.runIn.. family of fun...
Use `file` as name of the argument, as the CLI documentation does.
PR-URL: https://github.com/n...
a886b17bfb48147fa2007b9968e9dce706a408a2 authored over 7 years ago by Sam Roberts <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13118
Reviewed-By: Refael Ackermann <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13113
Reviewed-By: James M Snell <[email protected]>...
PR-URL: https://github.com/nodejs/node/pull/13012
Reviewed-By: Jeremiah Senkpiel <fishrock123@ro...
Fixes: https://github.com/nodejs/node/issues/12833
PR-URL: https://github.com/nodejs/node/pull/1...
I came across this template class but I don't understand why it is
there. It is not used in the ...
This reverts commit 571882c5a45872ac67e4e29513c4c8f23af9f781.
Removing the process.nextTick() c...
ba0dbaa1930db93a9e988ce1a525c8b2054a2970 authored over 7 years ago by Evan Lucas <[email protected]>
This test ensures that a http client request with the default agent
that has a socket that is im...
PR-URL: https://github.com/nodejs/node/pull/12263
Reviewed-By: Anna Henningsen <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/12936
Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/12936
Reviewed-By: Anna Henningsen <[email protected]>
AssertionError class is moved to interna/error
in reference to the TODO in assert.js. This was
s...
The method used has code duplication but is the most performant
PR-URL: https://github.com/node...
9836cf571708a82396218957cacb3ed1ed468d05 authored over 7 years ago by Daniel Pihlstrom <[email protected]>
This test currently fails if node was configured --without-ssl. This
commit adds crypto check an...
PR-URL: https://github.com/nodejs/node/pull/13122
Reviewed-By: James M Snell <[email protected]>...
PR-URL: https://github.com/nodejs/node/pull/12983
Reviewed-By: Colin Ihrig <[email protected]>
R...
PR-URL: https://github.com/nodejs/node/pull/13085
Reviewed-By: Anna Henningsen <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13085
Reviewed-By: Anna Henningsen <[email protected]...
also added regression tests
PR-URL: https://github.com/nodejs/node/pull/13111
Fixes: https://gi...
This change ensures that the WebSocket server can be stopped
(and restarted if needed) buy calli...
Fixed sequential test-net-connect-local-error by swapping port
and localPort in net.connect opti...
This commit fixes two coverity warnings for unchecked
return values.
Refs: https://github.com/n...
06f62eb384f4f823bd224165c224da08d7dec0ab authored over 7 years ago by cjihrig <[email protected]>
When a transform stream's callback is called more than once,
an error is emitted with a somewhat...
Remove common.PORT from
test-dgram-send-callback-buffer-length-empty-address to eliminate
possib...
Remove common.PORT from test-dgram-send-callback-buffer-length to
eliminate possibility that a d...
Remove common.PORT from test-dgram-send-address-types to eliminate
possibility that a dynamic po...
Replace common.PORT with available port assigned by the operating
system in test-dgram-send-call...
Replace common.PORT with available port assigned by the operating
system in test-dgram-send-call...
Adds destroy() and _destroy() methods to Readable, Writable, Duplex
and Transform. It also stand...
I can't see that the forward declaration of class Connection is needed
and wanted to raise this ...
Currently it is possible to call TLSWrap() without using new and the
following error message:
FA...
I think the code would be a little clearer if the return statement
was removed here since End() ...
I can't find any usage of Buffer in this file and think the include
can be removed.
PR-URL: htt...
7a15eefbba113cd0df99b420de1718aa7a01afa8 authored over 7 years ago by Daniel Bevenius <[email protected]>
Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-se...
Imprecision in process.hrtime() in some situations can result in a zero
duration being used as a...
Add `--set key=""` to cut down the time it takes to run
test-benchmark-http by about a third.
A...
171a43a98685d5cca6710d2d6bf4d20008de3426 authored over 7 years ago by Rich Trott <[email protected]>
This commit fixes the Node process crashing when constructors of classes
of the zlib module are ...
This fixes the async_hooks.AsyncHook constructor such that it throws an
error when provided with...
Edit to the comment in the stack trace capture, highlighting the use of
the constructorOpt argum...
Fix the bug that you start process without network at first, but it
connected lately, `dns.resol...
Port the disabled readline test to make it runnable in our usual test
suite.
PR-URL: https://gi...
595e5e3b23a2c41a4abf01b0084b64f524a58a6a authored over 7 years ago by Rich Trott <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13066
Reviewed-By: Luigi Pinca <[email protected]...
This reverts 4cb5f3daa350421e4eb4622dc818633d3a0659b3
Based on community feedback I think we sh...
8250bfd1e5188d5dada58aedf7a991e959d5eaa9 authored over 7 years ago by Myles Borins <[email protected]>
The usage of common.PORT could cause undesired port collisions when run
in parallel. The followi...
This commit contains three separate changes:
- Always return a string from ToUnicode no matter ...
06a617aa21c434b5e607370e7ee0051d506a4793 authored over 7 years ago by Rajaram Gaunker <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/12846
Fixes: https://github.com/nodejs/node/issues/1...
* Improve comments describing test.
* Remove unnecessary `common.noop`
* Remove confusing scopin...
* Add common.mustCall() for error handlers.
* Alphabetize modules
PR-URL: https://github.com/no...
658741b9d9255c5e18fafa76f3a70876153c8d59 authored over 7 years ago by Rich Trott <[email protected]>
When using an Agent for HTTPS, `TLSSocket`s are reused and need to
have the ability to `asyncRes...
Realized that we don't actually point people to the file to
include in order to access N-API fun...
Unlike most N-API functions, `napi_get_last_error_info()` should not
clear the last error code w...
PR-URL: https://github.com/nodejs/node/pull/13086
Reviewed-By: Gibson Fahnestock <gibfahn@gmail....
PR-URL: https://github.com/nodejs/node/pull/12935
Reviewed-By: Anna Henningsen <[email protected]...
Call uc_init() after u_setDataDirectory() to find out if the data
directory is actually valid.
...
46e773c5db9ebc106823594b82f4ff14a0a004f3 authored over 7 years ago by Ben Noordhuis <[email protected]>
According to the explanation in #3635#issuecomment-157714683
And as a continuation to #5422 we a...
This commit attaches a Symbol to the result of
net._normalizeArgs(). This prevents normal arrays...
Remove common.PORT from test-cluster-dgram-reuse to eliminate
possibility that a dynamic port us...
Removed an incorrect reference to the use of setEncoding(null) as the
proper way to handling bin...
As per https://github.com/nodejs/node/issues/12946
the crypto doc for publicEncrypt doesn't tell...
As per style guide avoid the use of you, your etc.
Rational as per: http://www2.ivcc.edu/rambo/t...
Changed the second parameter of assert.throws to match the errors.
PR-URL: https://github.com/n...
a593c74f811c12823053e6b7093466015992e9e6 authored over 7 years ago by Akshay Iyer <[email protected]>
Currently the function CryptoPemCallback is used for two things:
1. As a passphrase callback.
2....
Use `common.mustCall()` and `common.mustNotCall()` to check that
callbacks are invoked the expec...
Make searches for empty subsequences do exactly what
`String.prototype.indexOf()` does.
Fixes: ...
28ddac2ec285b950a17bc42d7c79c329c8573c9e authored over 7 years ago by Anna Henningsen <[email protected]>
The callback function in cares_query is synchronous and called before
closed. So dns.setServers ...