Ecosyste.ms: OpenCollective
An open API service for software projects hosted on Open Collective.
github.com/electron/node
Node fork to make it suitable for embedding in Electron
https://github.com/electron/node
PR-URL: https://github.com/nodejs/node/pull/13918
Reviewed-By: James M Snell <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13972
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmai...
PR-URL: https://github.com/nodejs/node/pull/13659
Fixes: https://github.com/nodejs/node/issues/1...
* Use common.mustNotCall() to check that callback is not invoked.
* Add space per test writing g...
PR-URL: https://github.com/nodejs/node/pull/13946
Reviewed-By: Colin Ihrig <[email protected]>
R...
I noticed this comment while working on a different task and could not
find any reason for it be...
* Use common.mustNotCall() to confirm SIGINT listeners are not being
invoked.
* Improve assert...
* order require() statements per test writing guide
* add keydir variable to make readFileSync()...
PR-URL: https://github.com/nodejs/node/pull/13952
Reviewed-By: Richard Lau <[email protected]>
R...
Document the lifetime of the structure returned
by napi_get_last_error_info
PR-URL: https://git...
ef28d85611bcb1b0d91b6525b7c16517bf21020c authored over 7 years ago by Michael Dawson <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13857
Reviewed-By: Refael Ackermann <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13857
Reviewed-By: Refael Ackermann <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13857
Reviewed-By: Refael Ackermann <[email protected]...
1) Add missing lazy assert call
2) Remove obsolete error type
3) Name undocumented error type mo...
PR-URL: https://github.com/nodejs/node/pull/13857
Reviewed-By: Refael Ackermann <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13967
Reviewed-By: Rich Trott <[email protected]>
Rev...
PR-URL: https://github.com/nodejs/node/pull/13900
Fixes: https://github.com/nodejs/node/issues/1...
The docs implied that the parameters `from` and `to` are invalid only
if neither of them is a st...
PR-URL: https://github.com/nodejs/node/pull/13869
Refs: https://github.com/nodejs/node/pull/1360...
These methods are Javascript-accessible so they get an implicit
HandleScope. The extra scope is ...
Removed some bad escape characters
PR-URL: https://github.com/nodejs/node/pull/13808
Fixes: htt...
The motivation for this commit is that we are building Node with
--shared-openssl and in our cas...
PR-URL: https://github.com/nodejs/node/pull/13281
Fixes: https://github.com/nodejs/node/issues/1...
The tools directory has newer and stricter indentation enabled, but the
legacy indentation rules...
Enable stricter indentation rules for benchmark code.
PR-URL: https://github.com/nodejs/node/pu...
496f60489d774ff32e3136b99320963ad46eed98 authored over 7 years ago by Rich Trott <[email protected]>Provide a bash script for updating ESLint in the project.
PR-URL: https://github.com/nodejs/nod...
1e5e0ce862174b95fcc04d4b9f9ea68c5944bfee authored over 7 years ago by Rich Trott <[email protected]>
Update ESLint to 4.1.0. This fixes a bug that previously prevented us
from using the new and str...
* use common.mustCall()/common.mustNotCall() as appropriate
* reorder require() statements per t...
* Use `common.mustCall()` to guarantee callback invocations
* Order modules according to test wr...
PR-URL: https://github.com/nodejs/node/pull/13930
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmai...
Make test-http(s)-set-timeout-server tests more similar and resolve the
following issues:
* `te...
2e5ce2bc2c4b1abc48c514a668bb272484a59830 authored over 7 years ago by Julien Klepatch <[email protected]>Fixes Coverity errors.
PR-URL: https://github.com/nodejs/node/pull/13878
Reviewed-By: Colin Ihr...
The previous commit removed the dependency on the code in that
directory. This commit removes t...
The library is only used in a single build-time tool where it can be
easily substituted by regul...
This commit fixes a regression related to IPC 'message'
events. When messages are not emitted in...
Currently when configuring the project using --openssl-fips a gyp
include file name config_fips....
We don't use the global Buffer throughout the lib/ to avoid circular
dependency issues in core, ...
Remove unnecessary imports from:
* test/parallel/test-buffer-nopendingdep-map.js
* test/paralle...
Remove superfluous import from:
* test/parallel/test-buffer-fakes.js
* test/parallel/test-buffe...
Remove superfluous import from:
* test/parallel/test-buffer-alloc.js
* test/parallel/test-buffe...
* test/parallel/test-fs-mkdtemp.js
* test/parallel/test-fs-read-zero-length.js
* test/parallel/t...
Removed require('buffer') from
- test/disabled/test-sendfd.js
- test/internet/test-dgram-broadc...
For if/else and loops where the bodies span more than one line, use
curly braces.
PR-URL: https...
095c0de94d818088cacf2c33ad4913768c15024a authored over 7 years ago by Rich Trott <[email protected]>* also update STYLE_GUIDE comment about Em dashes
PR-URL: https://github.com/nodejs/node/pull/1...
e3ea0fc97bf3a911463275446024b50e8bae865f authored over 7 years ago by Refael Ackermann <[email protected]>
* Use `common.mustCall()` to track callback invocations
* Remove console.log() statements unrela...
* Use common.mustCall() to confirm that _write() is called only once.
* Check that _write() is c...
Previous realization produces some false positive and false negative
results due to:
* conflict...
3b0e800f18133674ae30b4c6cd5729c12fa054ff authored over 7 years ago by Vse Mozhet Byt <[email protected]>Original commit message:
Fix GCC 7 build errors
BUG=chromium:691681
R=franzih@chro...
Fix previously-unnoticed typo in `required-modules.js`.
Refs: https://github.com/nodejs/node/pu...
25b4d875ed28939a400f1fa33007bf6e77ef977b authored over 7 years ago by Rich Trott <[email protected]>
ESLint 4.0.0 provides stricter (and more granular) indentation checking
than previous versions. ...
In preparation for applying the more strict indentation linting
available in ESLint 4.0.0, corre...
test-global-console-exists cannot use the common module as explained in
a comment but it was inc...
When _write completes with an Error, 'finish' was emitted before
'error' if the callback was asy...
This commit aims to improve the documentation examples that send
sockets over IPC channels. Spec...
PR-URL: https://github.com/nodejs/node/pull/13734
Reviewed-By: Ben Noordhuis <[email protected]...
Newer v8 versions exclude the constructor from the stack trace
so the recalculation of the trace...
Using a object instead of an Error is sufficient as the Error
itself won't be used but only the ...
The error message might be misleading if an object property
was the issue and not the argument i...
This seems to have been removed inadvertently by
330c8d743e33a83f85389ea8a64e3d3854ea0048 in PR ...
PR-URL: https://github.com/nodejs/node/pull/13820
Reviewed-By: James M Snell <[email protected]>...
V8 will crash if escape is called twice on the same
scope.
Add checks to avoid crashing if napi...
3e18c49657bcb0f2504def3d7d6d900f0c25e357 authored over 7 years ago by Michael Dawson <[email protected]>Fixes `this.push(undefined)`.
Fixes: https://github.com/nodejs/node/issues/13753
PR-URL: https:...
Mention that the staging branch should be rebased on top of the release
branch after merging a r...
Error value was not checked. Turns out, uv_ip6_addr was actually called
on malformed IP (square ...
PR-URL: https://github.com/nodejs/node/pull/13559
Fixes: https://github.com/nodejs/node/issues/1...
It's on by default now and the flag will be removed in the near future.
Fixes: https://github.c...
1c314f5facb98e4790ff60f0104f5d18bc3eb53e authored over 7 years ago by Ben Noordhuis <[email protected]>* Remove needless RegExp flag
In fixed case, `/g` flag is needless in the boolean context.
*...
76340e3f1007998c7cb9d69fa1a42d42663ca6c2 authored over 7 years ago by Vse Mozhet Byt <[email protected]>allow `dns.setServers` parameter to contain port
e.g.
```
dns.setServers([ '103.238.225.181:66...
PR-URL: https://github.com/nodejs/node/pull/13702
Reviewed-By: Refael Ackermann <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13702
Reviewed-By: Refael Ackermann <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13702
Reviewed-By: Refael Ackermann <[email protected]...
Changed the parameter name in set(Multicast)TTL from "arg" to "ttl"
both within code and error m...
process.hrtime() incorrectly passed the function name to
errors.TypeError instead of the name of...
PR-URL: https://github.com/nodejs/node/pull/13291
Refs: https://github.com/nodejs/node/issues/11...
Watching directories has limited support on AIX. This is documented.
Watch a file in test/async-...
Original commit message:
[string] Re-enable result caching for String.p.split
Runtime:...
7cdcca7623aba835ef23a15d4bf76cd2dcfc2130 authored over 7 years ago by Michaël Zasso <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13631
Reviewed-By: Ben Noordhuis <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13726
Reviewed-By: Anna Henningsen <[email protected]...
Add support for `Buffer.from(new String('...'))` and
`Buffer.from({[Symbol.toPrimitive]() { retu...
This commit removes the small node-tap lookalike from several
of the streams2 tests. It's only u...
This commit adds coverage for util.callbackify() type checking.
PR-URL: https://github.com/node...
471e88feb47e8a711e395cf6167d723adf3d1b7a authored over 7 years ago by cjihrig <[email protected]>
* use `common.mustNotCall()` to confirm callback is not called
* reorder modules to conform with...
Adds documentation and samples for the `connection` and
`socket` properties available on the `ht...
PR-URL: https://github.com/nodejs/node/pull/13741
Reviewed-By: Colin Ihrig <[email protected]>
R...
Use non-capturing grouping or remove capturing completely when:
* capturing is useless per se, ...
878990498a246488dfe5393ddc89b2b15f395a4d authored over 7 years ago by Vse Mozhet Byt <[email protected]>Use non-capturing grouping or remove capturing completely when:
* capturing is useless per se, ...
b9457717cab131a0f6e58b12f4b65a7aae4ecc30 authored over 7 years ago by Vse Mozhet Byt <[email protected]>
Make test-http(s)-set-timeout-server tests more similar and resolve the
following issues:
* `te...
bed3579dbecfba0a619674c1a3d1918f1950de1b authored over 7 years ago by jklepatch <[email protected]>
doc/api/async_hooks.md
+ L198: Missing code-language flag
+ L239: Missing code-language flag...
PR-URL: https://github.com/nodejs/node/pull/13714
Reviewed-By: Refael Ackermann <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13712
Reviewed-By: Rich Trott <[email protected]>
Rev...
PR-URL: https://github.com/nodejs/node/pull/13710
Reviewed-By: Colin Ihrig <[email protected]>
R...
* Do not repeat RegExp creation in cycle.
* Use sufficient string instead of RegExp in split().
...
* format test per project guide
* use listener that emits clear message
* use common.mustNotCall...
We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for ...
Currently when node is configured --without-intl the tests in this
commit fail. This commit adds...
Commit d7e4ae1eb01c618404452f9b351efc4710b1c127
("test: add common.hasIntl") added common.hasInt...
* /m is needless if ^ and $ are not used
* /g is needless in split()
* /g is needless in test() ...
Update ESLint and configuration to version 4.0.0.
PR-URL: https://github.com/nodejs/node/pull/1...
3ad90a4ac8aefad4c5d73fc0607649bf2e2f9cfa authored over 7 years ago by Rich Trott <[email protected]>
Make the "can we lint?" check in Makefile and vcbuild.bat depend on
bin/eslint.js rather than li...
PR-URL: https://github.com/nodejs/node/pull/13719
Reviewed-By: Anna Henningsen <[email protected]...