Ecosyste.ms: OpenCollective
An open API service for software projects hosted on Open Collective.
github.com/electron/node
Node fork to make it suitable for embedding in Electron
https://github.com/electron/node
This reverts commit 44483b6898128b05c09635e03e4d7ceaf3efb14c.
PR-URL: https://github.com/nodejs...
d69ecc6f51855574b8f0af1004e6d0ffd9b20c7a authored over 7 years ago by Refael Ackermann <[email protected]>
If the first parameter of `request.end` `data` is specified, it should
be equivalent to calling ...
Explain the behavior of `fs.open()` under win32 that file path contains
some characters and add ...
PR-URL: https://github.com/nodejs/node/pull/14089
Reviewed-By: Benjamin Gruenbaum <benjamingr@gm...
PR-URL: https://github.com/nodejs/node/pull/14099
Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13885
Reviewed-By: Colin Ihrig <[email protected]>
Instead of generating string concatenation, generate a template literal.
This is mostly useful a...
In anticipation of stricter linting for indentation, remove instances of
extra indentation that ...
This can be useful for tracing map creation.
PR-URL: https://github.com/nodejs/node/pull/14018
...
46d7cb88c7f8b416e667c52de80e6766115b3781 introduced an error in a
comment in `.eslintrc.yaml`. T...
In anticipation of stricter linting for indentation issues, modify
ternary operators in lib that...
Currently the following warning is issued when buildning:
Building addon
/work/nodejs/node/test...
If the buffer or array is too large to completion, make a dummy smallest
substitute object for i...
In preparation for stricter indentation linting, remove the
align-multiline-assignment custom ru...
Using asyncId as the default triggerAsyncId is wrong. The triggerAsyncId
can actually never be t...
Timers and nextTick have special emitBefore and emitAfter functions for
historic reasons. These ...
Its important for post-mortem diagnostics and should be more prominently
documented.
PR-URL: ht...
388e552579aff6b5152c67adeda182d2d40e8dfc authored over 7 years ago by Sam Roberts <[email protected]>
Refs: https://github.com/nodejs/node/issues/13925
PR-URL: https://github.com/nodejs/node/pull/14...
V8 caches and does not subsequently release `ObjectTemplate` instances.
Thus, we need to store t...
Currently this test fail when configured --without-inspector or
--without-ssl as it is expected ...
* Fix AsyncHooksGetTriggerAsyncId such it corresponds to
async_hooks.triggerAsyncId and not asyn...
PR-URL: https://github.com/nodejs/node/pull/13916
Refs: https://github.com/nodejs/node/pull/1364...
We had some, but not complete coverage indirectly through
other tests. Add test to validate it ...
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to
enable for post-mortem debugg...
PR-URL: https://github.com/nodejs/node/pull/14061
Reviewed-By: Benjamin Gruenbaum <benjamingr@gm...
Documentation, error message, and code now use the same argument name.
PR-URL: https://github.c...
8520e6f2804fad64fb50b91c80553715d3c83bd4 authored over 7 years ago by Eduardo Leggiero <[email protected]>
Not an actual bug, as far as I can tell, the compiler is simply not
smart enough to figure out t...
Fixes the following deprecation warning:
../src/node_api.cc:2020:30: warning: 'bool
v8:...
In the case where triggerAsyncId is null it should default to the
current executionAsyncId. This...
If the .listen() hasn't been called on the server, there is no handle
object. In this case use n...
PR-URL: https://github.com/nodejs/node/pull/13755
Reviewed-By: Trevor Norris <trev.norris@gmail....
Currently most of the event tests only test a single event type,
which might let those benchmark...
Replace multiple mutually exclusive `if` statements with if-else
statements.
PR-URL: https://gi...
6e86a70da2f54bd68cc5a8038a5d6940d6a4fce9 authored over 7 years ago by kuroljov <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13997
Refs: https://github.com/whatwg/url/pull/328
R...
* Remove pinning of eslint-plugin-markdown
An issue affecting Node.js source has been fixed i...
15599cbc977af3bc2a94365adc6687ca5e2bde04 authored over 7 years ago by Vse Mozhet Byt <[email protected]>Also fix repl and url libs for the rule.
PR-URL: https://github.com/nodejs/node/pull/14032
Refs...
PR-URL: https://github.com/nodejs/node/pull/14036
Reviewed-By: Ben Noordhuis <[email protected]...
Add clarification to the documentation on util.format()
and console.log() regarding how excessiv...
Remove common.mustCall() in test that might connect to a server already
running on the local hos...
In preparation for more robust indentation linting, fix an off-by-one
indentation in lib/http_se...
If the filesystem does not support UCS2, do not run the test.
PR-URL: https://github.com/nodejs...
4dd7d09723aa29ae164cf37031ed08dc6b532c0e authored over 7 years ago by Rich Trott <[email protected]>* Make common.skip() exit.
Also add common.printSkipMessage() for partial skips.
* Don't mak...
2d2986ae72f2f5c63d95a94f05fa996d9f0609f1 authored over 7 years ago by Vse Mozhet Byt <[email protected]>
* Do not require if test is skipped.
* Do not re-require without need.
* Sort requiring by modul...
The sequential/test-regress-GH-4027 test is flaky with an increased
system load, failing when th...
For simplicity and clarity (if not brevity), add CTC and CTC Emeriti to
Collaborators list in RE...
PR-URL: https://github.com/nodejs/node/pull/13839
Fixes: https://github.com/nodejs/node/issues/1...
This change removes `common.noop` from the Node.js internal testing
common module.
Over the las...
380929ec0c4c4004b522bed5e3800ebce2b68bfd authored over 7 years ago by Rich Trott <[email protected]>
* Make changes to `test-https-set-timeout-server` to resolve
inconsistencies with its http cou...
PR-URL: https://github.com/nodejs/node/pull/14009
Refs: https://github.com/nodejs/node/issues/11...
PR-URL: https://github.com/nodejs/node/pull/14011
Reviewed-By: Refael Ackermann <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/14011
Reviewed-By: Refael Ackermann <[email protected]...
doc/api/cluster.md
L337: Use the definition link
doc/api/deprecations.md
L106: Fix the defi...
* use common.mustNotCall() to confirm callback is not invoked
* whitespace change per test-writi...
1. Rename private functions
2. Use destructuring
3. Remove obsolete comments
PR-URL: https://gi...
0455fff880b9a4d25ee24150aedafa51808926ee authored over 7 years ago by Ruben Bridgewater <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13862
Reviewed-By: Refael Ackermann <[email protected]...
* Use common.mustCall() to confirm callback is invoked.
* Change spacing of require statements t...
PR-URL: https://github.com/nodejs/node/pull/13732
Reviewed-By: Colin Ihrig <[email protected]>
R...
PR-URL: https://github.com/nodejs/node/pull/13732
Reviewed-By: Colin Ihrig <[email protected]>
R...
PR-URL: https://github.com/nodejs/node/pull/13732
Reviewed-By: Colin Ihrig <[email protected]>
R...
PR-URL: https://github.com/nodejs/node/pull/13732
Reviewed-By: Colin Ihrig <[email protected]>
R...
PR-URL: https://github.com/nodejs/node/pull/13732
Reviewed-By: Colin Ihrig <[email protected]>
R...
PR-URL: https://github.com/nodejs/node/pull/13732
Reviewed-By: Colin Ihrig <[email protected]>
R...
PR-URL: https://github.com/nodejs/node/pull/13732
Reviewed-By: Colin Ihrig <[email protected]>
R...
Original commit message:
d8: Make in process stack dumping optional
Adds a flag (--dis...
31349e224576f1846a900958c9fecf566d07a04c authored over 7 years ago by ochang <[email protected]>
Since V8 5.9 V8 installs a default signal handler for some signals
when creating a default platf...
PR-URL: https://github.com/nodejs/node/pull/13716
Reviewed-By: Refael Ackermann <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/14035
Refs: https://github.com/nodejs/node/issues/14...
PR-URL: https://github.com/nodejs/node/pull/13767
Refs: https://github.com/nodejs/node/issues/11...
PR-URL: https://github.com/nodejs/node/pull/13852
Refs: https://github.com/nodejs/node/issues/12...
PR-URL: https://github.com/nodejs/node/pull/13811
Reviewed-By: Jackson Tian <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13982
Refs: https://github.com/nodejs/node/pull/1289...
* Reorder require() statements per test-writing guide
* Use common.mustNotCall() to check that c...
* re-order require() and crypto check per test writing guide
* use common.mustNotCall() to confi...
The at-exit addons test uses asserts like the other addons tests,
but at-exit is the only one th...
PR-URL: https://github.com/nodejs/node/pull/13963
Reviewed-By: Refael Ackermann <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13974
Reviewed-By: Luigi Pinca <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/13381
Reviewed-By: Andreas Madsen <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13381
Reviewed-By: Andreas Madsen <[email protected]>
It is possible that `recvmsg()` may return an error on ancillary data
reception when receiving a...
Fixes: https://github.com/nodejs/node/issues/13924
PR-URL: https://github.com/nodejs/node/pull/1...
Refs: https://github.com/nodejs/node/issues/13924
PR-URL: https://github.com/nodejs/node/pull/13...
* rename :exit to :distexit
PR-URL: https://github.com/nodejs/node/pull/13969
Refs: https://git...
Refs: https://github.com/nodejs/node/issues/13925
PR-URL: https://github.com/nodejs/node/pull/13...
When building in machines with multiple versions of Visual Studio
installed, node-gyp should res...
vcbuild.bat should detect what version of Visual Studio to use, it
should simply work without an...
PR-URL: https://github.com/nodejs/node/pull/13733
Reviewed-By: Luigi Pinca <[email protected]...
A chunk validity checks verifie if a chunk is a UInt8Array.
We should defer it as it might be ve...
PR-URL: https://github.com/nodejs/node/pull/13962
Fixes: https://github.com/nodejs/node/issues/1...
This commit verifies that Node's internal errors are recognized
by V8's IsNativeError(), which i...
When 53b8c51e7c4fca593eeeddbec0bdcfd77466cc80 was cherry-picked into
`master`, `NODE_VERSION_IS_...
Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simpl...
* Add exit listener to child process to check return code. Previously,
child process faiilure ...
Use stricter ESLint indent checking for sample code in docs.
PR-URL: https://github.com/nodejs/...
7477f9ba9c40ac36b17e005ff61f8fa3794f6d3e authored over 7 years ago by Rich Trott <[email protected]>
In preparation for stricter ESLint indentation checking, fix a few
issues in sample code.
PR-UR...
8969c1b76209e83f3fc3cb00a41421f7996e399b authored over 7 years ago by Rich Trott <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13989
Reviewed-By: Refael Ackermann <[email protected]>
Using objectMode with stream_wrap has not worked properly
before and would end in an error.
Ther...
This fixes a broken test on Windows caused by EOL conversion.
PR-URL: https://github.com/nodejs...
a1ecdcfb154ec79db4da595ca85ce75f9f759c6a authored over 7 years ago by Tobias Nießen <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/13940
Reviewed-By: Colin Ihrig <[email protected]>
R...
Notable changes
* **Stream**
Two regressions with the `stream` module have been fixed:
* Th...
- Categorize all nonspacing marks (Mn) and enclosing marks (Me) as
0-width
- Categorize all sp...