Ecosyste.ms: OpenCollective
An open API service for software projects hosted on Open Collective.
github.com/electron/node
Node fork to make it suitable for embedding in Electron
https://github.com/electron/node
Fix a typographical error in deprecation text. Convert run-on sentence
to two sentences (one in ...
Make deprecation text slightly more concise and direct.
PR-URL: https://github.com/nodejs/node/...
74c74db35eaa2dd2f5c22880ae007f19ad6e48bd authored over 6 years ago by Rich Trott <[email protected]>LC_ALL=C.UTF-8 MANROFFSEQ='' MANWIDTH=80 man --warnings -E UTF-8 -l -Tutf8 -Z ./doc/node.1 > /de...
79e1260cd8422b3de31abab05bb8261bc8d779e5 authored over 6 years ago by Jérémy Lal <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/20502
Refs: https://github.com/nodejs/node/issues/20...
In http.ClientRequest's doc, add maxHeadersCount as a public property.
And in the description of...
Refs: https://github.com/nodejs/node/issues/8913
PR-URL: https://github.com/nodejs/node/pull/20...
b5931e1d456e804d5de91016bd037f1e1fd6f427 authored over 6 years ago by Denis Fäcke <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/20408
Reviewed-By: Michaël Zasso <targos@protonmail....
Do less variable allocations and reassignments inside spliceOne
since it's relied on by some per...
PR-URL: https://github.com/nodejs/node/pull/20455
Fixes: https://github.com/nodejs/node/issues/1...
PR-URL: https://github.com/nodejs/node/pull/20373/
Reviewed-By: Colin Ihrig <[email protected]>
...
This was originally introduced in 3446ff417ba1e, in order to fix
a hard crash. However, since th...
PR-URL: https://github.com/nodejs/node/pull/20460
Fixes: https://github.com/nodejs/node/issues/1...
- Instead of storing a pointer whose type refers to the specific
subclass of `BaseObject`, jus...
Also, fix some other nits in passing
(formatting, punctuation, typos, redundancy, obsoleteness)....
Partial doc cleanup as per
https://github.com/nodejs/node/issues/20421
PR-URL: https://github.c...
b2d6eb74d45482daddad3ffb2690519300945d68 authored over 6 years ago by Michael Dawson <[email protected]>In pull-requests.md:
* Refer to the Collaborator Guide as Collaborator Guide and not
Collabor...
PR-URL: https://github.com/nodejs/node/pull/20408
Reviewed-By: Michaël Zasso <targos@protonmail....
The documentation used `file` for the first argument to `appendFile()`
functions. However, the c...
PR-URL: https://github.com/nodejs/node/pull/20400
Fixes: https://github.com/nodejs/node/issues/2...
Instead of always checking whether we've already warned about a
possible EventEmitter memory lea...
PR-URL: https://github.com/nodejs/node/pull/20469
Reviewed-By: Tobias Nießen <[email protected]>
...
Use the potentially more efficient fs.copyFileSync() instead of reading
the whole file in and wr...
PR-URL: https://github.com/nodejs/node/pull/20343
Reviewed-By: Rich Trott <[email protected]>
Rev...
PR-URL: https://github.com/nodejs/node/pull/20397
Refs: https://github.com/nodejs/node/issues/89...
Refs: https://github.com/nodejs/node/commit/368517c0dc2576e1f8f315e53d0cfebb22acf9e2
PR-URL: ht...
b0ed31cf9c9175a023985aa599b6e089b2ea53b6 authored over 6 years ago by xsbchen <[email protected]>
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in ...
A recent change made these benchmarks fail by always finishing
with 0 iterations. Restore a coun...
Tell the contributor to generally not squash commits during the pull
request review process.
PR...
7a769ebba870fdfb18b6e04aab504d612133fc82 authored over 6 years ago by Rich Trott <[email protected]>
Although I agree with the guideline people should generally not squash
commits in a pull request...
There is a paragraph about why the promise-based API uses `FileHandle`
rather than a numeric `fd...
There is a paragraph explaining that `fs.write()` cannot write a
substring of the provided strin...
There is no need to get this property twice in this rather hot spot:
if there is no such key, th...
We cannot manage with `{any}` because `message` cannot be
of `Symbol` or `undefined` types.
PR-...
54e93315ed9d6dd8934a7be04e99d5a2e4be20a5 authored over 6 years ago by Vse Mozhet Byt <[email protected]>Document that only enumerable, string-keyed properties are returned.
Fixes: https://github.com/...
d7557e111e5d94443aa88d8e2a35a896bea5dc03 authored over 6 years ago by Gabriel Schulhof <[email protected]>Original commit message:
Fix Object.entries/.values with non-enumerable properties
Ite...
da8bc6ab50431dd9b16cd820e1fcf93f22e4d83c authored over 6 years ago by Michaël Zasso <[email protected]>
Ensure that napi_throw() is able to throw a primitive value, and
document that it is able to thr...
This commit removes unnecesary requires of http and internal/util in
http2/core.js
PR-URL: http...
42bbaa338db3cb4a01e4ff83a88ad52251d7adb9 authored over 6 years ago by Daniel Bevenius <[email protected]>
This commit removes v8 qualified identifiers that have using directives
to be consistent with th...
PR-URL: https://github.com/nodejs/node/pull/20420
Reviewed-By: Anatoli Papirovski <apapirovski@m...
Some other formatting nits were fixed
and some superfluous descriptions were simplified in passi...
PR-URL: https://github.com/nodejs/node/pull/20411
Reviewed-By: Trivikram Kamat <trivikr.dev@gmai...
Shorten the text about the `highWaterMark` value for the stream returned
by `fs.createReadStream...
Since the table of contents is built dynamically when
building the documentation, the additional...
Add parameters for the callback for the Http2Session:localSettings event
and Http2Session:remote...
Remove unnecessary "has been known to" tentativeness from
COLLABORATOR_GUIDE.md. "has been known...
This change replaces some constants with better alternatives which were
unavailable in OpenSSL 1...
This removes the former default values and the spread arguments
usage. That was unnecessary and ...
Mention that a copy is made of the native string by the
napi_create_string_* APIs.
Fixes: https...
7ac491b8ac127e2c7aff82b436637f015c722b14 authored over 6 years ago by Gabriel Schulhof <[email protected]>
Describe what JavaScript values of type `napi_external` look like in
JavaScript.
Fixes: https:/...
1908668826ff3dc38f826afd31665b2e6b483543 authored over 6 years ago by Gabriel Schulhof <[email protected]>
Since v10.0.0, the `URL` class is available on the global object, so
using a `require` statement...
PR-URL: https://github.com/nodejs/node/pull/18191
Reviewed-By: Rich Trott <[email protected]>
Rev...
Originally wrote this for some work that is going to take a while
longer before it’s ready to be...
PR-URL: https://github.com/nodejs/node/pull/20295
Reviewed-By: Richard Lau <[email protected]>
R...
This commit addresses a TODO added by Ruben Bridgewater in commit
c6b6c92185316e13738e6fa931fdd5...
The headers should be handled as all others as well and just indicate
all arguments.
PR-URL: ht...
5542a98aa44df622d176b1a942553e1299ca43d9 authored over 6 years ago by Ruben Bridgewater <[email protected]>
This improves the error example output by reflecting the current
state. It also makes sure the e...
Remove "(I prefer the former)" from onboarding-extras. Without any
explanation as to why one mig...
This is just some code cleanup.
PR-URL: https://github.com/nodejs/node/pull/20294
Reviewed-By: ...
Work around https://github.com/nodejs/build/issues/1254, which
effectively breaks stress test CI...
Improve parameters for the callback for the Http2Session:connect event
inline with the pattern i...
Adjust indentations and fix a typo.
PR-URL: https://github.com/nodejs/node/pull/20315
Reviewed-...
Fix an issue when an error was emitted by the stream before
`iterator.next()` is called.
PR-URL...
05b7b8d50659491bd9f151828dfdb4e66f7f4fb9 authored over 6 years ago by Julien Fontanet <[email protected]>
`./configure --xcode` ostensibly let you built with the Xcode IDE but
it has never been tested r...
This removes outdated TODOs and adds a test for invalid input in
`fs.copyFile` and solves a TODO...
If `common.expectsError` is used as a callback, it will now also
verify that there is only one a...
logit -> log it
PR-URL: https://github.com/nodejs/node/pull/20349
Reviewed-By: Rich Trott <rtro...
In case there was no ack, the callback would have returned
more than the error as return value. ...
`console.table()` is implemented in Node.js core and no longer requires
the inspector for use.
...
cc09d7ec5b280a7374e2eb3809fc6fb999dbab77 authored over 6 years ago by Rich Trott <[email protected]>
If lines gets skipped, they are marked with three dots. This makes
sure they are better visualiz...
PR-URL: https://github.com/nodejs/node/pull/20310
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
After passing an HTTP socket, release its associated resources.
PR-URL: https://github.com/node...
ec2037da128139d87ea05c97682614f3af40dd8f authored over 6 years ago by Santiago Gimeno <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/20398
Reviewed-By: Gireesh Punathil <[email protected]...
Codify types, variable names, and code fragments
checking patterns I've managed to think of.
So...
9cf3ae5bc3770d85b1a89e4f6bcae0c3c5e814b9 authored over 6 years ago by Vse Mozhet Byt <[email protected]>
When a request with a long payload is received, http2 does
not allow a response that does not pr...
`EVP_PKEY_EC` only covers ANSI X9.62 curves not IETF ones(curve25519
and curve448). This fixes t...
This commit updates the isFd function to call isUint32 instead of
doing the same thing.
PR-URL:...
e45e5b809d88b2b117b110e135f689c91386a23b authored over 6 years ago by Daniel Bevenius <[email protected]>
This commit updates the Duplex constructor adding an if statement
checking if options is undefin...
PR-URL: https://github.com/nodejs/node/pull/20356
Reviewed-By: James M Snell <[email protected]>...
When isInsideNodeModules gets called while already processing
another stack trace, V8 will not c...
If the properties are not specified in `console.table()`, then we should
make a best effort to d...
PR-URL: https://github.com/nodejs/node/pull/20309
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
This is been removed because of this:
the source is not provided
it adds 105ko of useless files
...
PR-URL: https://github.com/nodejs/node/pull/20307
Reviewed-By: Anna Henningsen <[email protected]...
Use gyp’s own copying mechanism instead.
It’s not really clear which UNIX utils exactly are nee...
2ce4b7cb8c6b72389f45a3f5b738eb286b860610 authored over 6 years ago by Anna Henningsen <[email protected]>
Use a shared function, for..in instead of Object.keys, do less work in
`setHeader` and instead d...
This change enables concurrent inspector sessions, through WebSocket
interface as well as JS int...
When a test times out, the contents of stdout and stderr can often be
highly valuable in debuggi...
Improve documentation regarding the callback parameters for the
frameError event for instances o...
Fixes: https://github.com/nodejs/node/issues/20082
PR-URL: https://github.com/nodejs/node/pull/2...
PR-URL: https://github.com/nodejs/node/pull/20254
Reviewed-By: Rich Trott <[email protected]>
Rev...
PR-URL: https://github.com/nodejs/node/pull/20219
Reviewed-By: James M Snell <[email protected]>...
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.
PR-U...
81de53383624e2c3a4c08ef894881998ddb4f16e authored over 6 years ago by Ulan Degenbaev <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/20293
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmai...
PR-URL: https://github.com/nodejs/node/pull/20223
Reviewed-By: Colin Ihrig <[email protected]>
R...
PR-URL: https://github.com/nodejs/node/pull/20094
Reviewed-By: James M Snell <[email protected]>...
Currently when building the following warning is emitted:
../test_symbol.c:4:19:
warning: unuse...
This is unused inside Node core, so nothing good can
come from keeping it around.
PR-URL: https...
44fdd36b96a55938d11112965be1bbaaec597695 authored over 6 years ago by Anna Henningsen <[email protected]>Remove a superfluos persistent from test_constructor_name.c.
PR-URL: https://github.com/nodejs/...
b5c1c146f5c5ba39435cf9488488803dd401607a authored over 6 years ago by Gabriel Schulhof <[email protected]>
The libuv 1.20.2 update in Node 10 aligned the Windows behavior
of os.uptime() with that of othe...
PR-URL: https://github.com/nodejs/node/pull/20291
Refs: https://github.com/nodejs/node/pull/1715...