Ecosyste.ms: OpenCollective
An open API service for software projects hosted on Open Collective.
github.com/electron/node
Node fork to make it suitable for embedding in Electron
https://github.com/electron/node
PR-URL: https://github.com/nodejs/node/pull/18591
Reviewed-By: Weijia Wang <[email protected]>
R...
PR-URL: https://github.com/nodejs/node/pull/18609
Reviewed-By: James M Snell <[email protected]>...
Right now it is possible to get an AssertionError from input that has
the customInspect function...
In rare cirumstances it is possible to get a identical error diff.
In such a case the advances d...
This reverts commit de848ac1e0483327a2ce8716c3f8567eaeacb660.
The commit broke multiline repl.
...
PR-URL: https://github.com/nodejs/node/pull/13876
Reviewed-By: Matteo Collina <matteo.collina@gm...
Currently the call can lead to a TypeError with the message:
`Cannot read property 'value' of un...
Refs: https://github.com/nodejs/node/pull/18513
PR-URL: https://github.com/nodejs/node/pull/186...
ba944b16972c4b248e946d4bacb2141e5ef7eba9 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
Rename the `parentId` property on the PromiseWrap object to a
`isChainedPromise` property. The f...
If the package.json file does not have a "main" entry, return undefined
rather than an empty str...
PR-URL: https://github.com/nodejs/node/pull/18704
Reviewed-By: Tiancheng "Timothy" Gu <timothygu...
PR-URL: https://github.com/nodejs/node/pull/18700
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
PR-URL: https://github.com/nodejs/node/pull/18697
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
moves exposed internalBindings to a single location with short
guidelines on how to expose them ...
Don't disconnect the child until all exceptions are thrown.
Fixes: https://github.com/nodejs/no...
01d049165c7d3ef9d102c85f0218044cb45f4787 authored almost 7 years ago by Santiago Gimeno <[email protected]>Previously, the err passed to the callback of fs.open() was not checked.
PR-URL: https://github...
540cbf84afddfbdd2e88ecbb92c28b7dcc582498 authored almost 7 years ago by Evan Lucas <[email protected]>Ref: https://github.com/nodejs/node/issues/18643
PR-URL: https://github.com/nodejs/node/pull/18...
4a1a4bfc7edf4ce209b5ed29ce7ff440e1457ed1 authored almost 7 years ago by Yang Guo <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/18665
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
Missing the length argument in napi_create_function.
PR-URL: https://github.com/nodejs/node/pul...
2bead4ba9e1f92f1cf07fdaaa32197fff7600172 authored almost 7 years ago by Aonghus O Nia <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/18685
Reviewed-By: James M Snell <[email protected]>...
PR-URL: https://github.com/nodejs/node/pull/18644
Reviewed-By: Ben Noordhuis <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/18637
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
Replace var for let or const.
PR-URL: https://github.com/nodejs/node/pull/18649
Reviewed-By: Ru...
Previously, fs.readdirSync calls the function returned by
env->push_values_to_array_function() i...
The specific issues raised by Coverity are:
** CID 182716: Control flow issues (DEADCODE)
/sr...
PR-URL: https://github.com/nodejs/node/pull/18581
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
Previously, we performed casts that are considered undefined behavior.
Instead, just define `ssi...
Implement string decoder in C++. The perks are a decent speed boost
(for decoding, whereas creat...
Tests relying on synchronous timing have been migrated to use events.
PR-URL: https://github.co...
de848ac1e0483327a2ce8716c3f8567eaeacb660 authored almost 7 years ago by Bradley Farias <[email protected]>
Adds the remaining options from tls.createSecureContext() to the
string generated by Agent#getNa...
In ICU 61.x, icu4c will no longer put its declarations in the global namespace.
Everything will ...
This adds puctiations to the comments, uses a capital letters for
the first character, removes a...
PR-URL: https://github.com/nodejs/node/pull/18683
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmai...
The code coverage in `root/internal/vm/Module.js` lacked test coverage
for the url options param...
The emit{Before,After} APIs in AsyncResource are problematic.
* emit{Before,After} are named to...
523a1550a3d07ecc3d13e071cb0f1c732bae3bad authored almost 7 years ago by Ali Ijaz Sheikh <[email protected]>
Instead of using kOnTimeout index to track a special list
processing function, just pass in a fu...
Add optional Http2ServerRequest and Http2ServerResponse options
to createServer and createSecure...
Currently doc building doesn't support ES-style default params in
function definitions which cau...
PR-URL: https://github.com/nodejs/node/pull/18679
Fixes: https://github.com/nodejs/node/issues/1...
PR-URL: https://github.com/nodejs/node/pull/18670
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
The current stack trace thrown in case `assert.throws(fn, object)`
is used did not filter the st...
Users of MakeCallback that adds the domain property to carry context,
should start using the asy...
PR-URL: https://github.com/nodejs/node/pull/18617
Reviewed-By: Anna Henningsen <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/18617
Reviewed-By: Anna Henningsen <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/18651
Refs: https://github.com/nodejs/node/pull/8281...
PR-URL: https://github.com/nodejs/node/pull/18651
Refs: https://github.com/nodejs/node/pull/1222...
For tests that use anonymous namespaces, some tagged the close
of the namespace with 'namespace'...
Due to extensive reliance on timings and the fs module, this test
is currently inherently flaky....
Unused since 34b535f4caba366789d949211e4369b1e1d01152.
PR-URL: https://github.com/nodejs/node/p...
ef78a1e584593438b1447033c1738a5f1efe638a authored almost 7 years ago by Anna Henningsen <[email protected]>Remove the various **Note:** prefixes throughout the docs.
PR-URL: https://github.com/nodejs/no...
d3569b623ccd593c9ef62fcaf0aba2711dc7fbfa authored almost 7 years ago by James M Snell <[email protected]>
The current output uses JSON.stringify to escape the config values.
This switches to util.inspec...
The original test case hides the underlying cause by using
`PassThrough`. This change adds a tes...
When async hooks integration for Timers was introduced, it was
not included in the code for unre...
Remove unnecessary condition from timeout & interval clearing.
PR-URL: https://github.com/nodej...
8204b0f9c6dbbdba1ca4120698a7f87ca1c9d91c authored almost 7 years ago by Anatoli Papirovski <[email protected]>
It's possible for user-code to flip an existing timeout to
be an interval during its execution, ...
A recent commit removed the usage of the second argument of
tryOnTimeout but left the definition...
The ctx.error is supposed to be handled in fs.readlinkSync,
but was handled in fs.symlinkSync by...
The method to implement is `_write` not `_transform`.
PR-URL: https://github.com/nodejs/node/pu...
e9b5b4fae3592f4d4992e0e4195fec8d65f57bf4 authored almost 7 years ago by Luigi Pinca <[email protected]>
Fix a regression introduced by
https://github.com/nodejs/node/pull/18515 that broke
the dicer mo...
- Throw getPathFromURL() and nullCheck() errors synchronously instead
of deferring them to the...
This helps to show the cause of errors in the CI.
PR-URL: https://github.com/nodejs/node/pull/1...
b50571602afdbed72d3cb9e412c0e4ef5d1bae80 authored almost 7 years ago by Joyee Cheung <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/18270
Fixes: https://github.com/nodejs/node/issues/8...
developer.mozilla.org/en/... -> developer.mozilla.org/en-US/...
PR-URL: https://github.com/node...
259f62a8e8d4eac2f067b205abc9264b946d6738 authored almost 7 years ago by Vse Mozhet Byt <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/18630
Reviewed-By: Jon Moss <[email protected]>
Rev...
This test was added over six years ago, and the behavior
seems to have changed since then. When ...
Instead of separately calling into C++ from JS to retrieve
the Timer.now() value, pass it in as ...
PR-URL: https://github.com/nodejs/node/pull/18562
Reviewed-By: Ben Noordhuis <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/18578
Refs: https://github.com/v8/v8/compare/6.4.388...
The readline module wants a truthy time while using Timer.now() doesn't
necessarily guarantee th...
PR-URL: https://github.com/nodejs/node/pull/18498
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
Assuming less knowledge on the part of the reader, making it easier
to get start using Node.js.
...
PR-URL: https://github.com/nodejs/node/pull/18596
Reviewed-By: Michaël Zasso <targos@protonmail....
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not nece...
google.com added another TXT record which broke this test.
This removes the check on the content...
PR-URL: https://github.com/nodejs/node/pull/16648
Refs: https://github.com/nodejs/node/issues/16...
This commit moves error creation helpers scattered around
under lib/ into lib/internal/errors.js...
We cannot make uvException a proper class due to compatibility
reasons for now, so there is no n...
PR-URL: https://github.com/nodejs/node/pull/18546
Reviewed-By: James M Snell <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/18601
Refs: https://github.com/nodejs/node/pull/1840...
PR-URL: https://github.com/nodejs/node/pull/18516
Reviewed-By: Anatoli Papirovski <apapirovski@m...
The complicated `awaitDrain` machinery can be made a bit
slimmer, and more correct, by just rese...
PR-URL: https://github.com/nodejs/node/pull/18605
Reviewed-By: Anna Henningsen <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/18602
Reviewed-By: Anatoli Papirovski <apapirovski@m...
This seems to be slipped in https://github.com/nodejs/node/pull/18297
PR-URL: https://github.co...
ac829f0135b02e0c130e2433e028235c2bed2059 authored almost 7 years ago by Vse Mozhet Byt <[email protected]>
This adds the Http1IncomingMessage and Http1ServerReponse options
to http2.createServer().
PR-U...
f6e1466352e00e40da4f4c3e8b14d40752890374 authored almost 7 years ago by Peter Marton <[email protected]>
This adds the optional options argument to `http.createServer()`.
It contains two options: the `...
Overlooked when landing the respective PRs.
PR-URL: https://github.com/nodejs/node/pull/18564
R...
Mention the new modules team.
PR-URL: https://github.com/nodejs/node/pull/18545
Reviewed-By: Ti...
PR-URL: https://github.com/nodejs/node/pull/18526
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
Callbacks should always return `null` instead of `undefined` if no
error occurred.
PR-URL: http...
6a29630c30186d7a0c71203fe7b15a39ea080c1d authored almost 7 years ago by BufoViridis <[email protected]>
Added a test to ensure input validation for FD and mode for fs.fchmod.
Removed check for values ...
The generatedMessage was wrong in case simple assert was used and
a message was auto generated. ...
Prevent reading a Node.js module. That could theoretically lead to
false errors being thrown oth...
PR-URL: https://github.com/nodejs/node/pull/18590
Reviewed-By: Jon Moss <[email protected]>
Rev...
Fixes: https://github.com/nodejs/node/issues/18466
PR-URL: https://github.com/nodejs/node/pull/...
0548034272d2f91e00fc2f600e3dcbba868e28bc authored almost 7 years ago by Camilo Gonzalez <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/18515
Reviewed-By: Matteo Collina <matteo.collina@gm...
PR-URL: https://github.com/nodejs/node/pull/18475
Reviewed-By: Jeremiah Senkpiel <fishrock123@ro...
Replace `v8::Isolate::GetCpuProfiler()` with `v8::CpuProfiler::New()`
and cache the instance; cr...
PR-URL: https://github.com/nodejs/node/pull/18523
Reviewed-By: Jon Moss <[email protected]>
Rev...
PR-URL: https://github.com/nodejs/node/pull/18558
Reviewed-By: Ben Noordhuis <[email protected]>