Ecosyste.ms: OpenCollective

An open API service for software projects hosted on Open Collective.

github.com/electron/node

Node fork to make it suitable for embedding in Electron
https://github.com/electron/node

build: fix coverage after gcovr update

PR-URL: https://github.com/nodejs/node/pull/18958
Fixes: https://github.com/nodejs/node/issues/1...

3f78d3fcf8029a0a169baa314afa89d47377790d authored almost 7 years ago by killagu <[email protected]>
src: fix error message in async_hooks constructor

There are two minor issues in the AsyncHook constructor, if the object
passed in has an after an...

f2defcac4dd10f018215e3db530bed1314ce2225 authored almost 7 years ago by Daniel Bevenius <[email protected]>
doc: make the background section concise and improve its formality

PR-URL: https://github.com/nodejs/node/pull/18928
Reviewed-By: Claudio Rodriguez <[email protected]...

a27e6d7321e129055c08842690533fa5aecfd923 authored almost 7 years ago by Wilson <[email protected]>
fs: throw copyFileSync errors in JS

PR-URL: https://github.com/nodejs/node/pull/18871
Refs: https://github.com/nodejs/node/issues/18...

4eb45b884d9bd1f13979047750ad680275f4a348 authored almost 7 years ago by Joyee Cheung <[email protected]>
fs: throw fs.mkdtempSync errors in JS land

PR-URL: https://github.com/nodejs/node/pull/18871
Refs: https://github.com/nodejs/node/issues/18...

d2dc2a50113492840e77e4f5d3df6ff75fa986a4 authored almost 7 years ago by Joyee Cheung <[email protected]>
fs: throw fs.utimesSync errors in JS land

PR-URL: https://github.com/nodejs/node/pull/18871
Refs: https://github.com/nodejs/node/issues/18...

82523d3b6eb7905fc59f12a0d38026af996152fa authored almost 7 years ago by Joyee Cheung <[email protected]>
fs: throw fs.chownSync errors in JS land

PR-URL: https://github.com/nodejs/node/pull/18871
Refs: https://github.com/nodejs/node/issues/18...

8fb5a6cd81a893dc4929a290206ac0b10c068487 authored almost 7 years ago by Joyee Cheung <[email protected]>
fs: throw fs.chmodSync errors in JS land

PR-URL: https://github.com/nodejs/node/pull/18871
Refs: https://github.com/nodejs/node/issues/18...

437c75649335a0b412670b82d3dfc37be7b01d0b authored almost 7 years ago by Joyee Cheung <[email protected]>
fs: use SyncCall in OpenFileHandle

PR-URL: https://github.com/nodejs/node/pull/18871
Refs: https://github.com/nodejs/node/issues/18...

e8ec898a7d8169bed73378b5cd4e677adbec16c8 authored almost 7 years ago by Joyee Cheung <[email protected]>
fs: throw openSync errors in JS

PR-URL: https://github.com/nodejs/node/pull/18871
Refs: https://github.com/nodejs/node/issues/18...

fea5dda1d1ee4ebc2883fc9b4019c254176cc2c6 authored almost 7 years ago by Joyee Cheung <[email protected]>
fs: throw readdirSync errors in JS

PR-URL: https://github.com/nodejs/node/pull/18871
Refs: https://github.com/nodejs/node/issues/18...

d2c4f5082f371bbbfc01972d177799dc42e255a9 authored almost 7 years ago by Joyee Cheung <[email protected]>
fs: throw realpathSync.native errors in JS

PR-URL: https://github.com/nodejs/node/pull/18871
Refs: https://github.com/nodejs/node/issues/18...

72d150ea6f72098a2a99e4a25658f3b5c767d03b authored almost 7 years ago by Joyee Cheung <[email protected]>
fs: throw mkdirSync errors in JS

PR-URL: https://github.com/nodejs/node/pull/18871
Refs: https://github.com/nodejs/node/issues/18...

77b42e34de519d211f7b68330781af67be76fd35 authored almost 7 years ago by Joyee Cheung <[email protected]>
fs: throw rmdirSync errors in JS

PR-URL: https://github.com/nodejs/node/pull/18871
Refs: https://github.com/nodejs/node/issues/18...

46164ba2126095d4a788062003e3096699565efe authored almost 7 years ago by Joyee Cheung <[email protected]>
http: do not replace .read() in IncomingMessage

Remove the req._consumed property, as its use is completely
superseded and not needed anymore. T...

29be1e5f8426b8f58a390847aa94c1f9a6d103f4 authored almost 7 years ago by Matteo Collina <[email protected]>
build: fix lint-md-build dependency

PR-URL: https://github.com/nodejs/node/pull/18981
Fixes: https://github.com/nodejs/node/issues/1...

0bff955b6d9e1d3f5b1c0b1b71e68f7c0da33de7 authored almost 7 years ago by Joyee Cheung <[email protected]>
fs: fix functions executed in wrong context

The callback should run in the global scope and not in the FSReqWrap
context.

PR-URL: https://g...

c3eb3efa315382d1073d6a126f4d888cf3e121ec authored almost 7 years ago by Ruben Bridgewater <[email protected]>
Revert "fs: Revert throw on invalid callbacks"

This reverts commit 8250bfd1e5188d5dada58aedf7a991e959d5eaa9.

PR-URL: https://github.com/nodejs...

e9f2cecf1a14285574f9b6104dd690ef92495d74 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
perf_hooks: make PerformanceObserver an AsyncResource

PR-URL: https://github.com/nodejs/node/pull/18789
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google....

009e41826f47c595ca994f673023f9380198be36 authored almost 7 years ago by James M Snell <[email protected]>
perf_hooks: emit trace events for marks, measures, and timerify

Adds the `node.perf.usertiming` trace events category for recording
usertiming marks and measure...

9e509b622bbdc14b7153d006f57043f268017138 authored almost 7 years ago by James M Snell <[email protected]>
perf_hooks: eliminate deprecation warning

PR-URL: https://github.com/nodejs/node/pull/18789
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google....

aca8e764da444a9a5eb67812db2317c1c32215d9 authored almost 7 years ago by James M Snell <[email protected]>
doc: remove redundant `the`

PR-URL: https://github.com/nodejs/node/pull/19008
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmai...

e6b823d84ac2382bc2d863a8c9de437590ea20d5 authored almost 7 years ago by Leko <[email protected]>
http2: fix condition where data is lost

PR-URL: https://github.com/nodejs/node/pull/18895
Reviewed-By: Anna Henningsen <[email protected]...

dbe645f11460a8985f5f6e07f9ed829bee43e101 authored almost 7 years ago by Matteo Collina <[email protected]>
doc: fix/add link to Android info

We have two notes in API docs about Android support:
the first has no links, the second links to...

fcebb16478b6bb1c997958806f65df7f0e2230ac authored almost 7 years ago by Vse Mozhet Byt <[email protected]>
doc: remove `Returns: {undefined}`

Removed * Returns: {undefined} in doc/ to prevent confusing users

PR-URL: https://github.com/no...

646e67e1dca9df6ca8e81dcbfa683d2623110c85 authored almost 7 years ago by Sho Miyamoto <[email protected]>
doc: mention git-node in the collaborator guide

PR-URL: https://github.com/nodejs/node/pull/18960
Fixes: https://github.com/nodejs/node/issues/1...

1bb92ce04fdf516742f6462d5b26dabc558183a6 authored almost 7 years ago by Joyee Cheung <[email protected]>
doc: update 2fa information in onboarding.md

Because it is no longer possible to add someone to the nodejs GitHub
organization if they do not...

1460b31bd3a9699bed9b715f0e8c1edb4fd0aa44 authored almost 7 years ago by Rich Trott <[email protected]>
doc: add process.debugPort to doc/api/process.md

Fixes: https://github.com/nodejs/node/issues/18639

PR-URL: https://github.com/nodejs/node/pull/...

65ca369c070cefcaf6300a234de6448f3015e8e8 authored almost 7 years ago by flickz <[email protected]>
doc: `readable.push(undefined)` in non-object mode

`readable.push()` supports `undefined` in non-object mode, but it was
not previously documented....

8b518edf114446eedc3f0f828e78d9eae6f74af2 authored almost 7 years ago by 陈刚 <[email protected]>
src: remove node namespace qualifiers

This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.

PR-URL: ...

cae41827610667d987a557ed828f89574fad9cf2 authored almost 7 years ago by Daniel Bevenius <[email protected]>
util: use blue on non-windows systems for number/bigint

PR-URL: https://github.com/nodejs/node/pull/18925
Reviewed-By: Luigi Pinca <[email protected]...

1708af369ba4cdfbc9f3eadd657508498b8489a3 authored almost 7 years ago by Gus Caplan <[email protected]>
zlib: improve zlib errors

- Use assert to check mode in the Zlib constructor since it should
only be passed by us.
- Int...

da886d9a4cd923bd5fc33eff7df22ff7d855a00b authored almost 7 years ago by Joyee Cheung <[email protected]>
tools: ignore VS compiler output in deps/v8

PR-URL: https://github.com/nodejs/node/pull/18952
Reviewed-By: Ben Noordhuis <[email protected]...

15e41a9951c425913c43073ba5f6af04c0867715 authored almost 7 years ago by Michaël Zasso <[email protected]>
tls: use after free in tls_wrap

The root cause is that `req_wrap` is created in `StreamBase::Write`
and passed to `TLSWrap::DoWr...

743f8904cca16d87c8ac856488bf021849a43383 authored almost 7 years ago by Kyle Farnung <[email protected]>
doc: add new documentation lint rule

Add 80 characters limit to docs.
Change docs to fit 80 characters per row.

PR-URL: https://gith...

a29089d7c866955616c0e363843017e9b9b2a736 authored almost 7 years ago by estrada9166 <[email protected]>
deps: upgrade libuv to 1.19.2

PR-URL: https://github.com/nodejs/node/pull/18918
Reviewed-By: Ben Noordhuis <[email protected]...

3a191229418dcc0e21956847993b1702c88a923b authored almost 7 years ago by cjihrig <[email protected]>
url: reduce deplicated codes in `autoEscapeStr`

PR-URL: https://github.com/nodejs/node/pull/18613
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...

3cef3e61d647d3dd2107087d876a3a02e0c3961e authored almost 7 years ago by Weijia Wang <[email protected]>
2018-02-22, Version 9.6.1 (Current)

Notable changes:

* events:
- `events.usingDomains` being set to false by default was removed ...

8476815f01bb4e60693f1fc8a06f384c903396da authored almost 7 years ago by Myles Borins <[email protected]>
events: preset `usingDomains` to false

The line setting this was removed in a previous commit. This
potentially breaks code in the wild...

6657b153abba09a16e4a628f3a46fc2cdf176b7d authored almost 7 years ago by Myles Borins <[email protected]>
doc: remove extraneous "for example" text

No need to announce obvious example code as being example code. Remove
unneeded "for example" te...

9cb96ac82808254e3322119eb1e6b2a7b847741e authored almost 7 years ago by Rich Trott <[email protected]>
doc: update description of 'clientError' event

Default behavior is to send a '400 Bad Request' response if the socket
is writable.

PR-URL: htt...

54cb3c5759919745c25554daffc613dbee230d37 authored almost 7 years ago by Luigi Pinca <[email protected]>
doc: fix link in onboarding.md

Remove link to the outdated members team

PR-URL: https://github.com/nodejs/node/pull/18878
Revi...

0329643b0fc891e1c5ada1a2033d7a051418812a authored almost 7 years ago by Justin Lee <[email protected]>
test: fix test-http-connect

Fixes: https://github.com/nodejs/node/issues/18940
PR-URL: https://github.com/nodejs/node/pull/1...

fecc64d6dc905ce1fcc9c8635c653e4a69a2bfc0 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
test: really test the ttywrap bits of getasyncid

Follow-up from https://github.com/nodejs/node/pull/18800

Code that tries to exercise tty fds mu...

0a262803882adcdcd8dad8a80153e434206290fa authored almost 7 years ago by Jeremiah Senkpiel <[email protected]>
2018-02-22, Version 9.6.0 (Current)

Notable changes:

* async_hooks:
- deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh)
h...

945eb1bb693216400bc222c56d607f182e2e2939 authored almost 7 years ago by Myles Borins <[email protected]>
http: remove default 'drain' listener on upgrade

Ensure that the default `'drain'` listener is removed before the
`'connect'` or `'upgrade'` even...

2b7f920e26171f05fac437d867a30209f57c6bad authored almost 7 years ago by Luigi Pinca <[email protected]>
src: fix abort when taking a heap snapshot

Remove an erroneous CHECK that asserted the persistent object's internal
field pointer still poi...

ffab6cd5057bce6dbbcbe06b0eaa0f905aa43115 authored almost 7 years ago by Ben Noordhuis <[email protected]>
module: replace "magic" numbers by constants

- add new constants
- replace numbers by constants

PR-URL: https://github.com/nodejs/node/pull/...

070a82e82c917492bf306e546cef55ffb3ca8359 authored almost 7 years ago by Sergey Golovin <[email protected]>
deps: cherry-pick 46c4979e86 from upstream v8

Original commit message:

Use wider types for max_old_space_size and co.

Make --max_old...

13cb056e4cfce7419148eb089205735fb12bcd9f authored almost 7 years ago by Ben Noordhuis <[email protected]>
repl: fix tab-complete warning

When create a nest repl, will register `Runtime.executionContextCreated`
listener to the inspect...

26231548ad1dff971cdeaab3085b372a75ad1efb authored almost 7 years ago by killagu <[email protected]>
http: remove default 'error' listener on upgrade

Remove the default `'error'` listener when the socket is freed. This
is consistent with the clie...

51be03cd577fe8b5a73dd9558bd6a2727f9c3c0b authored almost 7 years ago by Luigi Pinca <[email protected]>
doc: enable eslint prefer-template rule

PR-URL: https://github.com/nodejs/node/pull/18831
Reviewed-By: Luigi Pinca <[email protected]...

d6fc7e3af4f8888b0d80d73287314b14d3c7f86e authored almost 7 years ago by Ruben Bridgewater <[email protected]>
tools: update eslint rule

The former notation was deprecated. This updates it as recommended.

PR-URL: https://github.com/...

3a2e912b2d75730a7733200c953b59b98793ae81 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
tools: enable eslint one-var rule

PR-URL: https://github.com/nodejs/node/pull/18831
Reviewed-By: Luigi Pinca <[email protected]...

8be96579aeee39e3942bde7f1bb56b21bd9a99e9 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
tools: enable eslint no-whitespace-before-property rule

PR-URL: https://github.com/nodejs/node/pull/18831
Reviewed-By: Luigi Pinca <[email protected]...

cbc6f39b718513282cfd841dcc90a9df3f547de9 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
tools: enable eslint strict key-spacing

PR-URL: https://github.com/nodejs/node/pull/18831
Reviewed-By: Luigi Pinca <[email protected]...

684c1bb42d916fed12945ba1678934e8983082dd authored almost 7 years ago by Ruben Bridgewater <[email protected]>
tools: enable eslint no-undef-init rule

This also fixes the three entries that did not pass.

PR-URL: https://github.com/nodejs/node/pul...

ff5b56ea9d70d24140bf4bc53b8692ef1513f43a authored almost 7 years ago by Ruben Bridgewater <[email protected]>
test: http2 compat response.write() error checks

PR-URL: https://github.com/nodejs/node/pull/18859
Reviewed-By: James M Snell <[email protected]>

a926c1a18f42ac8b9631838fb03980cbbded1bdf authored almost 7 years ago by Trivikram <[email protected]>
test: http2 stream.respond() error checks

PR-URL: https://github.com/nodejs/node/pull/18861
Reviewed-By: James M Snell <[email protected]>

5782c51dfb729a1331e223e14ee3c9a5d0a19113 authored almost 7 years ago by Trivikram <[email protected]>
http: allow _httpMessage to be GC'ed

Set `socket._httpMessage` to `null` before emitting the `'connect'` or
`'upgrade'` event.

PR-UR...

e5369e054bae809b73254f7ea93df02d7ac4eb8d authored almost 7 years ago by Luigi Pinca <[email protected]>
test: introduce common.runWithInvalidFD()

This provides a more reliable way to get a fd that can be used
to tirgger EBADF.

PR-URL: https:...

acf2fd39f7461b36d895582e7b7d7a8b3be03eff authored almost 7 years ago by Joyee Cheung <[email protected]>
test: use runWithInvalidFD() in tests expecting EBADF

PR-URL: https://github.com/nodejs/node/pull/18864
Fixes: https://github.com/nodejs/node/issues/1...

5055c29e82c4634e6845702fba97cc2438923d44 authored almost 7 years ago by Joyee Cheung <[email protected]>
tools: add falsely removed eslint rules

This adds the eslint rules back in that were falsely removed while
landing https://github.com/no...

13637d23f7a2667c2f9abfe2c1a44d6941e10681 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
errors: simplify sysError

PR-URL: https://github.com/nodejs/node/pull/18857
Reviewed-By: Anna Henningsen <[email protected]...

95bae858094450bd01f858ddd358ae0f83865157 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
errors: add comments about falsy error types

Some error types are not properly set. This adds comments which
ones are probably falty and to w...

eb3edefb70f80de23be6c06bf10904048fd369fd authored almost 7 years ago by Ruben Bridgewater <[email protected]>
console: port errors to new system

This ports the errors to the new error system.

PR-URL: https://github.com/nodejs/node/pull/1885...

7c8beb5b5f35875811d6e44e9a03907c03a39bb5 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
errors: update all internal errors

This updates all internal errors to the new error type. While doing
so it removes unused errors....

6e1c25c45672b70f4b6c6c8af56d9c0762bfae04 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
errors: implement new error handling

This implements a function based system. Instead of passing in the
error code as first argument,...

8272c225b12eb08f60d41791c68f3f1a28caec20 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
build, win: vcbuild improvements

Removes extra erroor messages when Python is not installed. Removes
"vswhere not found" message ...

887a2ba92eec98ddf1e0953e742419236eff75d7 authored almost 7 years ago by Bartosz Sosnowski <[email protected]>
fs: use fs.access in fs.exists

Uses fs.access to implement fs.exists functionality. Fixes a issue,
when a file exists but user ...

d3955d15ff5c68acf91f35177d290ff068068a05 authored almost 7 years ago by Bartosz Sosnowski <[email protected]>
fs: support as and as+ flags in stringToFlags()

PR-URL: https://github.com/nodejs/node/pull/18801
Reviewed-By: Joyee Cheung <[email protected]...

b1e52fe2ea99a52ace6399e9f629c965f66a2643 authored almost 7 years ago by Sarat Addepalli <[email protected]>
tools: fix custom eslint rule errors

This fixes a few rules by making sure the input is actually ready
to be checked. Otherwise those...

7107c9201de10e9808e7e12a53829bf899ce19da authored almost 7 years ago by Ruben Bridgewater <[email protected]>
test: http2 client setNextStreamID errors

PR-URL: https://github.com/nodejs/node/pull/18848
Reviewed-By: Luigi Pinca <[email protected]...

20dae8540b4a6306d53ebd8fca88a9940c8e9c00 authored almost 7 years ago by Trivikram <[email protected]>
vm: consolidate validation

PR-URL: https://github.com/nodejs/node/pull/18816
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...

3cb3618973bcf7817b55eb4fd96cc5fe7284cbd9 authored almost 7 years ago by Timothy O. Peters <[email protected]>
src: replace var for (let|const) in utilities module

Update Utilities module to replace var for let or const

PR-URL: https://github.com/nodejs/node/...

ca79fc5373f2fde4a3a3cfd86c34c3848df37a1a authored almost 7 years ago by jvelezpo <[email protected]>
crypto: add docs & tests for cert.pubkey & cert.fingerprint256

Include example on how to pin certificate and/or public key

PR-URL: https://github.com/nodejs/n...

6aab9e1eed68b10e027b87795285b34eafdcf229 authored almost 7 years ago by Hannes Magnusson <[email protected]>
crypto: provide full cert details to checkServerIdentity

PR-URL: https://github.com/nodejs/node/pull/17690
Reviewed-By: James M Snell <[email protected]>...

853f0bdf1908f754a0e7a7486339e79578c2c68b authored almost 7 years ago by Hannes Magnusson <[email protected]>
crypto: add cert.pubkey containing the raw pubkey of certificate

PR-URL: https://github.com/nodejs/node/pull/17690
Reviewed-By: James M Snell <[email protected]>...

5a6beb774128a890830d3dc7b742929dc539418e authored almost 7 years ago by Hannes Magnusson <[email protected]>
crypto: add cert.fingerprint256 as SHA256 fingerprint

PR-URL: https://github.com/nodejs/node/pull/17690
Reviewed-By: James M Snell <[email protected]>...

7876aeb0fe01acf007401cfedf12709f834c927b authored almost 7 years ago by Hannes Magnusson <[email protected]>
net: inline and simplify onSocketEnd

PR-URL: https://github.com/nodejs/node/pull/18607
Reviewed-By: Luigi Pinca <[email protected]...

281d00eebdc53e4a018cf4876f04eaf75538afd2 authored almost 7 years ago by Anna Henningsen <[email protected]>
cluster: fix inspector port assignment

Make sure that inspector ports in cluster are inside the valid range:
`[1024, 65535]`.
Fixes fla...

45982de4184e66bb53577b9c07383189f3d83dde authored almost 7 years ago by Santiago Gimeno <[email protected]>
src: remove unused using declarations async_wrap

PR-URL: https://github.com/nodejs/node/pull/18893
Reviewed-By: Michaël Zasso <targos@protonmail....

2990429b16f32c216d357a5cbf3f81d43aa8abaf authored almost 7 years ago by Daniel Bevenius <[email protected]>
doc: remove CII badge in README

PR-URL: https://github.com/nodejs/node/pull/18908
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-...

b5444301f5207187c4e8f104868f66980e7fe430 authored almost 7 years ago by Roman Reiss <[email protected]>
test: fix deprecation warning in binding.cc

Currently, the make-callback-domain-warning addon generates the
following warning:
../binding.cc...

53a5d87becb664c183d63a5c028641bc248f0771 authored almost 7 years ago by Daniel Bevenius <[email protected]>
src: fix deprecation warning in node_perf.cc

Currently the following deprecation warning is produced when compiling
node_perf.cc:

./src/node...

2d76379e30ea1f31593f282ab7fb5368eddd2367 authored almost 7 years ago by Daniel Bevenius <[email protected]>
doc: lowercase primitives in test/common/README.md

PR-URL: https://github.com/nodejs/node/pull/18875
Reviewed-By: Benjamin Gruenbaum <benjamingr@gm...

48e90ed87e3116333f0b964a2eed352ca915a660 authored almost 7 years ago by Vse Mozhet Byt <[email protected]>
test: check symbols in shared lib

When building the node with `--shared` option, we need
to verify the symbols in shared lib inste...

ab7c627e5327d621a734a32680cbfc99453f8b20 authored almost 7 years ago by Yihong Wang <[email protected]>
test: http2 errors on req.close()

PR-URL: https://github.com/nodejs/node/pull/18854
Reviewed-By: James M Snell <[email protected]>...

15e02ceb1e7522c27f586bad878cdddc613fcada authored almost 7 years ago by Trivikram <[email protected]>
net: use `_final` instead of `on('finish')`

Shutting down the connection is what `_final` is there for.

PR-URL: https://github.com/nodejs/n...

03ddd13d8a72190aa22194eb535e9cb683f4f815 authored almost 7 years ago by Anna Henningsen <[email protected]>
src: remove unnecessary Reset() calls

The previous commit made persistent handles auto-reset on destruction.
This commit removes the R...

d4024815b7d55005c3ec25c74cf647f7eba1d5cc authored almost 7 years ago by Ben Noordhuis <[email protected]>
src: don't touch js object in Http2Session dtor

Don't try to update the internal field pointer of the JS object in the
destructor.

The garbage ...

6bdc18c592b9d66fd652a9bdaa53f87486d0a634 authored almost 7 years ago by Ben Noordhuis <[email protected]>
src: prevent persistent handle resource leaks

Replace v8::Persistent with node::Persistent, a specialization that
resets the persistent handle...

992703f2b50f6b3483e9b930737d177b9e01256d authored almost 7 years ago by Ben Noordhuis <[email protected]>
doc: fix minor grammar/typographical issues in onboarding.md

PR-URL: https://github.com/nodejs/node/pull/18847
Reviewed-By: Richard Lau <[email protected]>
R...

e53275d819fb21d4bb15a27a714f134551233cf9 authored almost 7 years ago by Rich Trott <[email protected]>
doc: update onboarding.md for faster exercise completion

Note that the CI run for the exercise can be minimal.

PR-URL: https://github.com/nodejs/node/pu...

1b83a9df054a0d5bac28fef96bd0598d86dae6d8 authored almost 7 years ago by Rich Trott <[email protected]>
doc: fix nits in tools/doc/README.md

* Sync format schemes with the current doc state.
* Lowercase primitive types.
* Fix typos and u...

d28edf97fa5cb863b5497cc3964c103f782d8b62 authored almost 7 years ago by Vse Mozhet Byt <[email protected]>
lint: move eslint to new plugin system

PR-URL: https://github.com/nodejs/node/pull/18566
Reviewed-By: Joyee Cheung <[email protected]...

6934792eb34c75c16ac810951d0abadfe96238a9 authored almost 7 years ago by Gus Caplan <[email protected]>
test: actually test tty `getColorDepth()`

TTY tests should almost never be placed in `/parallel/`. Skipping TTY
tests there due to missing...

7514eb3cff9f333882db0a3173247df06c0257e5 authored almost 7 years ago by Jeremiah Senkpiel <[email protected]>
test: move getTTYfd() to common helpers

This utility is fairly generic and likely useful for more than one test.

PR-URL: https://github...

92bf2492cd6b78b1ab26765660d912ee34bb90c6 authored almost 7 years ago by Jeremiah Senkpiel <[email protected]>
test: http2 client settings invalid callback

PR-URL: https://github.com/nodejs/node/pull/18850
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...

0089860757753f305a45a4c6d19db54e162c36c2 authored almost 7 years ago by Trivikram <[email protected]>
test: http2 client ping errors

PR-URL: https://github.com/nodejs/node/pull/18849
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...

1e57a8d1171558774c849e7a8e5d8b91b003ffab authored almost 7 years ago by Trivikram <[email protected]>