Ecosyste.ms: OpenCollective
An open API service for software projects hosted on Open Collective.
github.com/electron/node
Node fork to make it suitable for embedding in Electron
https://github.com/electron/node
A few bug fixes result in more stringent linting rules.
PR-URL: https://github.com/nodejs/node/...
0863a0e528ba9ee01f960dce7ffebe8fff3a774c authored almost 7 years ago by Rich Trott <[email protected]>
ESLint 4.19.1 fixes some bugs in rules. These changes prepare us for the
upgrade.
PR-URL: https...
5e00a013eb219716d952cb8eb29a134c00f5db54 authored almost 7 years ago by Rich Trott <[email protected]>
- using a length of 6 for `"hello"` includes a terminating null yielding
`"hello\u0000"`
- len...
The buffer module was introduced in v0.1.90. Updated `introduced_in`
value in `buffer.md` to ref...
PR-URL: https://github.com/nodejs/node/pull/19547
Reviewed-By: Richard Lau <[email protected]>
R...
PR-URL: https://github.com/nodejs/node/pull/19555
Reviewed-By: Colin Ihrig <[email protected]>
R...
ECDH.convertKey is used to convert public keys between different
formats.
PR-URL: https://githu...
f2e02883e7ef6ff58331e980f91bc31d8076a5c8 authored almost 7 years ago by Wei-Wei Wu <[email protected]>
Fixes a regression introduced in [1].
The posix version of normalize should not treat backslash ...
PR-URL: https://github.com/nodejs/node/pull/19401
Reviewed-By: Anna Henningsen <[email protected]...
... in addition to the event names they currently use.
Currently, various internal streams have...
1c8149417a5dec9b2af056f306822b8a22a09706 authored almost 7 years ago by Sameer Srivastava <[email protected]>First steps towards #19060
PR-URL: https://github.com/nodejs/node/pull/19389
Reviewed-By: James...
PR-URL: https://github.com/nodejs/node/pull/19076
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
PR-URL: https://github.com/nodejs/node/pull/19076
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
Add an explanation of the risk of exceeding platform pipe
capacity with uncaptured output in chi...
Correctly check for the presence of the inspector module before adding
it to the builtin libs li...
PR-URL: https://github.com/nodejs/node/pull/19490
Fixes: https://github.com/nodejs/node/issues/1...
Promisify sections of `child_process.exec()`
and `child_process.execFile()` changed to make clea...
Introduced in https://github.com/nodejs/node/pull/19438
PR-URL: https://github.com/nodejs/node/...
d1720bddf4de0df8e6c79a38218da61f8a40a080 authored almost 7 years ago by Vse Mozhet Byt <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/19438
Reviewed-By: James M Snell <[email protected]>...
Streams were recently updated to emit their own close event. The
Http2Stream was an exception be...
PR-URL: https://github.com/nodejs/node/pull/19451
Reviewed-By: Matteo Collina <matteo.collina@gm...
PR-URL: https://github.com/nodejs/node/pull/19481
Reviewed-By: James M Snell <[email protected]>...
PR-URL: https://github.com/nodejs/node/pull/19268
Refs: https://github.com/nodejs/node/issues/18...
Assign a code to a user-facing error.
Turn other internal-only errors to checks.
PR-URL: https:...
4e1f0907dae9916215985a9f81bf3dec1eeaeaef authored almost 7 years ago by Michaël Zasso <[email protected]>Fixes: https://github.com/nodejs/node/issues/19412
PR-URL: https://github.com/nodejs/node/pull/...
258bcb9bffb1824d65a76eb30fcd0adda0f753a0 authored almost 7 years ago by josephleon <[email protected]>
Put the "who to cc" information in the COLLABORATOR_GUIDE. The
onboarding-extras doc is a bit of...
PR-URL: https://github.com/nodejs/node/pull/19458
Reviewed-By: Colin Ihrig <[email protected]>
R...
Remove bulleted list formatting. Only check email/name for new
contributors. Change `full name` ...
PR-URL: https://github.com/nodejs/node/pull/19458
Reviewed-By: Colin Ihrig <[email protected]>
R...
This re-writes the test in C by dropping std::vector<napi_value> in
favour of a C99 variable len...
When using cluster and --inspect as cli argument it is correctly
handled and each worker will us...
This adds a rule that forbids the use of native Error constructors in
the `lib` directory. This ...
After this commit, all errors thrown from JS code in lib have an error
code.
PR-URL: https://gi...
ab8bf26994677a5f0823b3810668f6cfa18374d9 authored almost 7 years ago by Michaël Zasso <[email protected]>Also consistently import the `common` module where possible.
PR-URL: https://github.com/nodejs/...
fddcd6253b237ca68430f44c7614bf52d57c4f97 authored almost 7 years ago by Michaël Zasso <[email protected]>
Currently the writable side of the socket is closed as soon as `UV_EOF`
is read regardless of th...
Wait for the sockets to be connected before closing them and remove
unneeded `setTimeout()`.
PR...
74553465e6c450a3777c27f9cd3bd209a3726eda authored almost 7 years ago by Luigi Pinca <[email protected]>s/9\.7\.1/9\.8\.0
PR-URL: https://github.com/nodejs/node/pull/19515
Reviewed-By: Ruben Bridgewa...
Notable changes:
* assert:
- From now on all error messages produced by `assert` in strict mo...
createCipher and createDecipher are cryptographically weak, can cause
severe security issues whe...
PR-URL: https://github.com/nodejs/node/pull/19473
Reviewed-By: Tobias Nießen <[email protected]>
...
PR-URL: https://github.com/nodejs/node/pull/19432
Refs: https://github.com/v8/v8/compare/6.5.254...
Place `writable.destroy()`, `readable.destroy()`,
and `readable.read()` in the proper ABC order....
This also updates some parts of the onboarding. It is mainly about
how to handle pull requests, ...
PR-URL: https://github.com/nodejs/node/pull/19476
Reviewed-By: Trivikram Kamat <trivikr.dev@gmai...
The first parameter to the callback is `err`. Fix that. Expand example
to demonstrate an actual ...
Add function to trigger and uncaught exception.
Useful if an async callback throws an exception ...
The test uses both `assert()` and `assert.ok()`. Use just `assert.ok()`.
Remove a comment that ...
1203b1372592a5067888987080f30b6b9047d150 authored almost 7 years ago by Rich Trott <[email protected]>
trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/n...
PR-URL: https://github.com/nodejs/node/pull/19475
Reviewed-By: Colin Ihrig <[email protected]>
R...
This commit introduces a copyHooks function that can be used by
storeActiveHooks and restoreActi...
Commit 870229e66529309dfea932c52d718ddc2d734966 ("src: Add ABORT
macro") replaced the abort call...
PR-URL: https://github.com/nodejs/node/pull/19450
Reviewed-By: Anna Henningsen <[email protected]>
This commit adds proper error handling to net.connect() when
a custom lookup() function returns ...
The test is unreliable on some Windows platforms in its current form.
Make it more robust by usi...
Place the test_make_callback async_hooks-related test into its own file.
PR-URL: https://github...
f24d0ec2016cda551d3da828109296e75386bbc3 authored almost 7 years ago by Gabriel Schulhof <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/19331
Reviewed-By: Ruben Bridgewater <ruben@bridgewa...
- Check if the watcher is active in JS land before
invoking the binding, act as a noop if the ...
- Remove ERR_FS_WATCHER_ALREADY_STARTED and
ERR_FS_WATCHER_NOT_STARTED because those two situa...
In the async case, if the buffer was copied instead of being moved
then the buf will not get del...
PR-URL: https://github.com/nodejs/node/pull/19380
Refs: https://github.com/v8/v8/compare/6.5.254...
PR-URL: https://github.com/nodejs/node/pull/19429
Reviewed-By: Anna Henningsen <[email protected]...
Rename the tests appropriately alongside mentioning the subsystem.
Also, make a few basic change...
PR-URL: https://github.com/nodejs/node/pull/19400
Reviewed-By: Anna Henningsen <[email protected]...
Use of a MaybeStackBuffer was just silly. Fix a long standing todo
Reduce code duplication a bit...
Most of the inlines were leftovers from a much older design
iteration and are largely pointless ...
PR-URL: https://github.com/nodejs/node/pull/19353
Reviewed-By: Anna Henningsen <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/19390
Reviewed-By: James M Snell <[email protected]>...
This commit removes the builtin async_wrap module from
lib/async_hooks.js.
The motivation for t...
8c46fa69036757e2b86d9bea308b66d502420c5e authored almost 7 years ago by Daniel Bevenius <[email protected]>
Currently, there is an AsyncWrap constructor that is only used by
PromiseWrap. This constructor ...
This reverts commit 1708af369ba4cdfbc9f3eadd657508498b8489a3.
Numbers are much more difficult t...
1329844a0808705091891175a6bee58358380af6 authored almost 7 years ago by Ruben Bridgewater <[email protected]>
82bdf8fba2d3f fixed an issue by silently modifying the `start`
option for the case when only `en...
Before:
> Object(7n)
BigInt {}
After:
> Object(7n)
[BigInt: 7n]
PR-URL: https://github.com/n...
893432ad928e25854950c0b5c581dfb3081ed4bb authored almost 7 years ago by Michaël Zasso <[email protected]>
Add checks for a pending exception in napi_make_callback
after the callback has been invoked. I...
Emit the perf_hooks node timing milestones as trace events.
PR-URL: https://github.com/nodejs/n...
96cb4fb795808aa2774e842974aeb411c5d3dd94 authored almost 7 years ago by James M Snell <[email protected]>
The test is unreliable on some Windows platforms in its current form.
Make it more robust by usi...
PR-URL: https://github.com/nodejs/node/pull/19385
Reviewed-By: Gireesh Punathil <[email protected]...
PR-URL: https://github.com/nodejs/node/pull/19342
Reviewed-By: Michaël Zasso <targos@protonmail....
PR-URL: https://github.com/nodejs/node/pull/19340
Reviewed-By: James M Snell <[email protected]>
Currently PromiseHook extracts the PromiseWrap from a Local<Promise> in
two places. This commit ...
Move period incorrectly placed outside of parentheses to inside the
parentheses. The parenthetic...
Added some simple tests to verify that the int64 API is correctly
handling numbers greater than ...
PR-URL: https://github.com/nodejs/node/pull/19292
Reviewed-By: James M Snell <[email protected]>...
Access permission on the target child is currently thrown
as an exception. Bring this under the ...
CleanupHandles() has not been called in our own code base anymore
after the v8 debug agent has b...
- Make the HandleCleanup a struct, and make the queue a
std::list, iterate over it in CleanupH...
Refs: https://github.com/v8/v8/wiki/Untrusted-code-mitigations
PR-URL: https://github.com/nodej...
c6ae8a28109fc19ea30a5d785b2215345564c0bb authored almost 7 years ago by Michaël Zasso <[email protected]>Add a GYP flag similar to the one defined in BUILD.gn.
PR-URL: https://github.com/nodejs/node/p...
cac4da05ad91f12c1af97895b3a08e3190f6a97f authored almost 7 years ago by Michaël Zasso <[email protected]>
The previous commit deleted lib/module.js so that git
recognize the file move `lib/module.js` ->...
Create `lib/internal/modules` and restructure the module loaders
to make the purpose of those fi...
Create `lib/internal/bootstrap/` and put bootstrappers there:
Before:
```
lib/internal
├── ......
Otherwise the debug log output might be mixed up with
the expected errors and the assertion matc...
Requiring `respondWithFile()` to only work with regular files
is an artificial restriction on No...
This allows V8 to avoid preparing a execution context
for the constructor, to give a (kinda) sma...
`requests = 1000000` took about 10 minutes per run for me
and doesn’t seem to add much value on ...
The `StreamBase` interface changed, so that `OnStreamRead()`
and `OnStreamAlloc()` are not guara...
This resolves the issue of using synchronous I/O for
`respondWithFile()` and `respondWithFD()`, ...
Provide a way to create pipes between native `StreamBase` instances
that acts more directly than...
Add `AsyncScope` for cases where the async_hooks `before` and
`after` callbacks should be called...
This enables accessing files using a more standard pattern.
Once some more refactoring has been...
c412150582de524beacd180646ec5f18c518a922 authored almost 7 years ago by Anna Henningsen <[email protected]>
Put `HandleScope`s and `Context::Scope`s where they are used,
and don’t create one for native st...