Since a method exists (or not) on a class, and an object responds (or not) to a
message, Mockery...

Makes ObjectMethods#method_exists? more similar to ClassMethods#method_exists?

Makes AnyInstance#method_exists? more similar to ObjectMethods#method_exists?

Boolean expressions are declarative while conditional returns are imperative

respond_to? was called only in the if include_public_methods conditional, and
this is the only...

Since a method exists (or not) on a class, and an object responds (or not) to a
message, Mockery...

Makes AnyInstance#method_exists? more similar to ClassMethod#method_visibility

Boolean expressions are declarative, while conditional returns are imperative.
This makes method...

Make the chainability to #mock and #stub clearer

Simplify {AnyInstance,Class,Instance,Module}Methods Hierarchy

Parameterizing (& generalizing) the methods allows us to reduce the implicit
dependency/contract...

This reduces duplication in InstanceMethod & AnyInstanceMethod (assignment to
ivar), and shrinks...

Since original_method_owner returns stubbee anyway. This makes it similar in
InstanceMethod and ...

Since there're only two subclasses of StubbedMethod, I didn't see a reason to
privilege methods ...

ClassMethod is/was being used solely as a superclass of InstanceMethod and
AnyInstanceMethod, an...

ObjectMethods#stubba_method is identical, and is already included in Object.
Since a Class is an...

ObjectMethods provides everything that ModuleMethods did, and is already
included in Object. Sin...

Since the two aren't different from each other or from ModuleMethod

Since the two aren't any different from each other or from ClassMethod

Reduce duplication in AnyInstanceMethod class

The following methods are overridden in AnyInstanceMethod:

* mock_owner
* original_method_body
...

Now there's only a single implementation and it's only a few lines long,
it makes more sense to ...

The implementation is now identical to that in ClassMethod and so we can
safely remove this and ...

It's simplier to obtain the mock underlying the stubbed method from the
instance of ClassMethod ...

The implementations of AnyInstanceMethod#mock & #reset_mocha are now identical
to those of Class...

Reduce duplication by extracting ClassMethod#mock_owner and
AnyInstanceMethod#mock_owner.

Co-au...

Co-authored-by: James Mead <[email protected]>

Using define_method is safer than class_eval and it has the side effect
of making it easier to s...

This is now identical to ClassMethod#restore_original_method and so in
AnyInstanceMethod we can ...

This means that ClassMethod#restore_original_method and
AnyInstanceMethod#restore_original_metho...

Co-authored-by: James Mead <[email protected]>

This fixes a bug in AnyInstanceMethod where it would fail to restore the
visibility of a stubbed...

This also has the benefit of making
AnyInstanceMethod#restore_original_method more similar to
Cl...

This also has the benefit of making ClassMethod#restore_original_method
more similar to AnyInsta...

Accept symbol as mock/stub name

There's no need to run rubocop in so many of the CI matrix builds.
Running rubocop on Truffle Ru...

Release: https://www.jruby.org/2019/08/12/jruby-9-2-8-0.html

Note that there was a problem with...

This is because minitest > v5.11.3 uses look-behind assertions in regular
expressions which are ...

PR: #365

The singleton_class method has been available since Ruby v1.9.2 and so
it seems better to avoid ...

It's vaguely conceivable that tests in the wild are stubbing this method
and so it seems safer t...

As per 9c78af7529d34d8cf5bd4a26999124a8d684b2ed.

As per 5aac8b9e4dc8335e30de426ca103678fddcd90dc.

These changes should've been made in this commit [1].

[1]: https://github.com/freerange/mocha/c...

These changes should've been made in this commit [1].

[1]: https://github.com/freerange/mocha/c...

I've made this a minor version bump, because there's a chance the
refactoring in #358 may have l...

As per this commit [1].

[1]: 3352e9c5acc11d56198b5cf4b489156ff7ad5c34

This problem was introduced in this commit [1].

[1]: 330e3f5798a428f0c100b4d7d4cec2b1545b17ea

In this commit [1], I added a before_install entry to the Travis CI
configuration to install the...

PR: #358

Co-authored-by: Chris Roos <[email protected]>

Note the use of `original_method_in_scope` in
`ClassMethod#restore_original_method`. I can't use...

And the overridden implementation in
`AnyInstanceMethod#restore_original_method`. By reusing
`#o...

To try to better describe its purpose.

Now that the implementation is the same as its parent's in
`ClassMethod#method_visibility`.

Now that the implementation is the same as its parent's (`ClassMethod`).

The `xxx_method_defined?` methods accept either a symbol or string so
we don't need to manually ...

This makes the implementation of `AnyInstanceMethod#method_visibility`
the same as `ClassMethod#...

And the equivalent method in
`AnyInstanceMethod#default_stub_method_owner`.

I think this name m...

In the hope that it makes the code easier to understand. I found it confusing
that we were using...

And the equivalent method in `AnyInstanceMethod#method_visibility`.

The instances of `ClassMeth...

Now that the implementation is the same as its parent's (`ClassMethod`).

The old name was slightly confusing because we're actually interested in
whether the original me...

Having temporarily removed the `rescue` statement, I can see that we're
trying to catch `NameErr...

And the equivalent method in `AnyInstanceMethod#original_method`.

The instances of `ClassMethod...

To explain why we're interested in Ruby version 2 and above. I think
this makes the code easier ...

Given that it's identical to the same method in its parent
(`ClassMethod`).

And override the implementation in `AnyInstanceMethod#prepend_module`.

I want to make the imple...

And override the implementation in `AnyInstanceMethod#original_method`.

I want to make the impl...

And override the implementation in
`AnyInstanceMethod#original_method_defined_on_stubbee?`.

I w...

We use `class_eval` in both `ClassMethod#define_new_method` and
`AnyInstanceMethod#define_new_me...

Now that it's identical to the same method in its parent
(`ClassMethod`).

I think the new name better describes its purpose.

Now that it's identical to the same method in its parent
(`ClassMethod`).

And override the implementation in
`AnyInstanceMethod#default_definition_target`.

I want to mak...

As well as method parameters named `method`.

To make it clearer that it's a string/symbol and n...

Now that it's identical to the same method in its parent
(`ClassMethod`).

And override the implementation in
`AnyInstanceMethod#stub_method_definition`.

I want to make t...

I think the new name better describes its purpose.

Now that the implementation is the same as its parent's.

And override the implementation in
`AnyInstanceMethod#remove_original_method_from_stubbee`.

I w...

Expand explanation of thread-safety concerns

Travis CI started switching the default OS to Linux Xenial 16.04 on 23
Apr 2019 [1]. It looks as...

Run tests in TruffleRuby in Travis CI