PR: #420

Closes #414.

Co-authored-by: Nitish Rathi <[email protected]>

This allows us to remove the slightly ugly default argument for
Expectation#invoke.

In preparation for passing Invocation instance to Expectation#invoke.

In preparation for extracting an `invoke` helper method.

This makes the relationship with Expectation#times clearer.

The names of these tests imply that the intention is that the method
name should match (i.e. sho...

RUBY_PLATFORM doesn't necessarily end with $, as it may include a minor
version number (e.g. x86...

Fix test failures on Mac OSX Catalina

This might be overly conservative, because I know the tests worked
without this exclusion on Mac...

By explicitly disabling 4 violations.

By explicitly disabling the cop for 4 violations.

By explicitly disabling 2 violations.

By explicitly disabling cop for one violation.

Explicitly disable cop for the one violation. This should avoid any
other long modules appearing.

I'm happy not having class/module level documentation comments.

I generated this using the following command:

$ rubocop --auto-gen-config

JRuby v9.2.9.0 was released at the end of Oct 2019 [1].

[1]: https://www.jruby.org/2019/10/30/j...

These are the latest point releases of Ruby.

PR: #412

Closes #405.

PR: #411

Closes #408 and #409.

Co-authored-by: Nitish Rathi <[email protected]>

To reduce duplication.

And remove the now redundant UnexpectedInvocation class.

Note that eventually the plan is to remove the UnexpectedInvocation
class entirely and so that's...

This is in preparation for passing Invocation to Expectation#invoke.

This is a small step towards pushing more logic into the Invocation
class.

This is a step towards encapsulating the arguments entirely within the
Invocation class.

So move the instantiation of ParametersMatcher into that method.

This is in preparation for passing Invocation to ExpectationList
methods.

This also simplifies ...

Also handles Expectaction#throws scenario.

PR: #410

Second bunch of commits from #394.

Co-aut...

This helps us avoid rescuing an exception raised by code elsewhere in
the Mocha code. Also, enab...

expected hadn't quite sounded right because it also included allowed.

Using more expressive & concise conditionals & booleans.

The target is to encapsulate it inside Cardinality in a tell-don't-ask
style.

The target is to encapsulate it inside Cardinality in a tell-don't-ask
style.

Cardinality and invocations go hand-in-hand. So, the target is to move
invocations to Cardinality.

Cardinality and invocations go hand-in-hand. So, the target is to move
invocations to Cardinality.

First bunch of commits from #394.

Co-authored-by: Nitish Rathi <[email protected]>

Extract the assert_invocations method. Checking that invocations follow
'satisfied expectations:...

Less state to maintain. Array#size is O(1), so should be fine
performance-wise.

The tests were helpful for test-driving, but not all are needed due to
overlap.

Previously the expected arguments were being displayed here (using
Expectation#method_signature)...

This will allow the yields to be captured and remembered by the invocation

Since an expectation can have multiple matching invocations, and an invocation
can yield multipl...

Distinguish different ObjectMethods modules

Previously this Mocha::ObjectMethods module was re-opening the module
defined in `lib/mocha/obje...

Previously this Mocha::ObjectMethods module was re-opening the module
defined in `lib/mocha/obje...

Do not include method definer into all objects

Instead we pass the object into the three MethodDefiner methods.

Since this module is not used within the library itself, there's no need
to include it within th...

This should help avoid confusion with the Mocha::ObjectMethods module
defined within the library...

By forcing people to require the explicit integrations for Test::Unit or
Minitest, we will be ab...

These were not namespaced and it turns out they aren't actually tested
in the build.

This is a deprecation warning for the moment, but it would be good to
fail fast by raising an ex...

It's useful for the Mocha documentation to point out the different types of Test
Double and that...

Introduce stubba_class method as part of the contract between Mockery and the
object being stubbed.

PR: #382 by @nitishr

Adding a new test triggers Metrics/ClassLength: Class has too many lines. So,
inlining the expec...

This is more reasonable and realistic than yielding only if a block is given.
A stub that's set ...

PR: #370 by @nitishr

Closes #270
Closes #362

Since original_method_owner is a class, it can already provide method_visibility
(through ClassM...

on_stubbing_method_unnecessarily differs only in how the method_signature and
backtrace are comp...

It was originally extracted to please rubocop, as it complained about cyclomatic
complexity bein...