This reverts CL 447335.

Reason for revert: broke test on solaris-amd64-oraclerel, which does ha...

go/build attempts to parse comments at the beginning of non-Go files
looking for //go:build or /...

Benchmarking suggests about a 14-17% reduction in user build time,
about 3.5-7.8% reduction for ...

Fixes #56542

Change-Id: I294856f8fb4d49393310ec92ab40fb7d841b6570
GitHub-Last-Rev: a4563400af81...

The stack pointer must lie within system stack limits
when Control Flow Guard (CFG) is enabled o...

In following with Roland's TODO, switch TestDisableSHA1ForCertOnly to ParseRevocationList(...) o...

This adds a -d debug flag "fmahash" for hashcode search for
floating point architecture-dependen...

On some platforms, building PIE needs external linking, which
cannot run if cgo is not available...

Currently in PGO we use a percentage threshold to determine if a
callsite is hot. This CL uses a...

Adding PCALIGN to addMulVVW assembler implementation
provides the following improvement on power...

`TestScripts/svn` test suite fails if the host does not have a TZ
database installed.

This CL u...

Currently, FromDir identifies a VCS checkout directory just by checking
whether it contains a sp...

This is an oversight from https://go-review.googlesource.com/c/go/+/419875,
where script command...

Remove the useless issueSpill and continue directly.

Change-Id: I085e566be6f7200235e1bfe1f56a8e...

Per discussion with Roland Shoemaker, this updates
x509.CreateRevocationList to mirror the behav...

Change-Id: Ida7e756f01a2c115ac58bf10aa13b2f8fd57b6a1
GitHub-Last-Rev: 4694d397bd3ad488fd05ed2cc6...

Two edge cases that were mentioned in the docs are actually impossible:

* For NIST curves, EC...

In https://build.golang.org/log/d2eb315305bf3d513c490e7f85d56e9a016aacd2,
we observe a failure i...

The -C flag is like tar -C or make -C: it changes to the named directory
early in command startu...

Currently, with PGO, the inliner uses node weights to decide if a
function is inlineable (with a...

CC-BY-3.0 was shiny and new back in 2009, but CC-BY-4.0 is
generally preferred now. Update our C...

We don't have a formatter for these files, so check here that
they are in the right form to allo...

We were mishandling {{range $i = .}}, treating it as though it were
{{range $i := .}}. That happ...

net.IP states that a 16-byte slice can still be an IPv4 address.
But after netip.Addr is introdu...

Change-Id: I30783aa6a13ad8348fa24b27672d542a868f96de
GitHub-Last-Rev: c4584ad9dab9736275c2f2554a...

For #56041

Change-Id: I6c98458b5c0d3b3636a53ee04fc97221f3fd8bbc
Reviewed-on: https://go-review....

Randomized feature enable/disable might be something we use to
help users debug any problems wit...

Montgomery multiplication can be used for Exp mod even m
by splitting it into two steps - Exp mo...

Setting up for improving even modulus.

name time/op
ExpMont/Odd-16 2...

There does not seem to be any point to this sync.Once.
I noticed because I was surveying uses of...

Fuzz tests are meant to be run just like ordinary tests,
so copy the same loop cpu and count loo...

It adds support for no-reload option, as specified in resolv.conf(5):
no-reload (since glibc 2....

Fixes AIX build.

Change-Id: Icbb33896017bbcc488a8baff20e10eb0e14ea4b9
Reviewed-on: https://go-r...

The global ListOfHotCallSites set is used to communicate between
CanInline and InlineCalls the s...

This should reduce spurious VCS failures on slow builders, like the
one observed in
https://buil...

ErrWaitDelay is not expected to occur in this test, but if it does
it indicates a failure mode v...

I noticed some test failures in the build dashboard after CL 445597
that made me realize the gra...

We reused p so we were deleting the same directory twice instead of two
different directories. F...

Otherwise given a file like defs_nacl_amd64p32.go.~1~ we will add
"nacl" and "amd64p32" to AllTa...

The go1 benchmark suite does a lot of work at package init time, which
makes it take quite a whi...

The result of the call to fmt.Errorf was unused. It was clearly
intending to print the message, ...

If TestArenaCollision cannot reserve the address range it expects to
reserve, it currently fails...

Check for and reject environment variables containing NULs.

The conventions for passing environ...

Track the running tests and when they started,
so that we can report the running tests on a test...

Use a slightly different line number pragma when emitting instrumented
code, so as to ensure tha...

Change the 'PrepareForCoverageBuild' helper function to provide more
sensible defaults in the ca...

This patch fixes a typo/bug introduced in CL 441858 where when pattern
matching a coverage count...

When coverage testing a local package (defined by a relative import
path such as "./foo/bar") th...

Change the macOS implementation to use libc calls.
Using libc calls directly is what we do for a...

(Suggested by Austin in CL 445596.)

Change-Id: Ic774d551e8085d15435ef2b3c78d0169a365ce41
Review...

Also removes no-longer-needed "Any" field from compiler's DebugFlags.
Test/use case for this is ...

This an end-to-end test that sets GOROOT to a symlink
to the distribution, approximating copyin...

We kind of have this mechanism already, just normalizing it and
using it in a bunch of places. P...

Make them a separate type, so the normal sparse maps don't
need the extra storage.

Change-Id: I...

The recently added rule only works before decomposing slices.
Add a rule that works after decomp...

Since pgo is a new package, it is reasonably straightforward to
encapsulate its state into a non...

The test added in CL 446115 was failing on Plan 9, on which the error
returned by a failed open ...

Parts of package pgo fetch the line number of a node by parsing the
number out of the string ret...

For most tests, the test's deadline itself is more appropriate than an
arbitrary timeout layered...

This adds a testenv.CommandContext function, with timeout behavior
based on the existing logic i...

Make linkgetlineFromPos and getFileIndexAndLine methods on Link, and
give the former a more desc...

The most important change here is to log output from the child, making
it easier to diagnose pro...

The test sleeps for 1 millisecond to give the cancellation a moment
to take effect. This is flak...

Wasm can't handle the recusion for XML nested to depth 10,000.
Cut it off at 5,000 instead. This...

This one slipped through a previous cleanup
and showed up in an allocation profile.

Change-Id: ...

Change-Id: Ie3b4bfe483d7ef43da29ea1dd73d423dac36cf39
Reviewed-on: https://go-review.googlesource...

This may fix the android-.*-emu builders, which are currently broken.

For #47257.

Change-Id: I...

The js/wasm builder started failing as of CL 432535 due to needing
'go build' to import standard...

The index function was not handling certain corner cases where there
were two more bytes to be e...

Address folding is disabled in CL42172, the commit message of which
said that "In shared library...

Set the value of the variable tailCall to true and prevent
allocating or clobber the linker regi...

ref. CL 356169

Change-Id: I813750d3fe191afe50d4029024ba97800211f688
Reviewed-on: https://go-rev...

Test whether gccgo/GoLLVM supports cgo.Incomplete. If it doesn't, use a
local definition rather ...

This change improves the performance of Binomial by implementing an
algorithm that produces smal...

Packages in GOROOT that don't use cgo will not be installed in
GOROOT/pkg, and will instead be c...

Fixes #56479

Change-Id: I1d97eb3ea97304e429e178ad05cb9f861b2bce84
Reviewed-on: https://go-revie...

Otherwise we wind up mixing GOOS paths with slash separated paths.

Change-Id: I63dd733cbdb0668e...

Fixes the compiler to emit DIEs for zero sized variables.

Fixes #54615

Change-Id: I1e0c86a97f1...

When writing the set of commands excuted for go build -x, $WORK is
substituted for the work dire...

For #55022

Change-Id: I51f1ba166d5a66dcaf4b280756be4a6bf9545c5e
Reviewed-on: https://go-review.g...

This CL optimizes the sequence of instructions ADRP+ADD+LD/ST to the
sequence of ADRP+LD/ST(offs...

Before this change, the .a files for the intermediate go toolchains
were produced in the same lo...

Fixes a performance regression due to CL 418554.

Fixes #56440

Change-Id: I6ff152e9b83084756363...

In the previous, we will only use the slicing by 8 look up table when
the data size is greater t...

The existing implementation uses loops to implement bulk memory
operations such as memcpy and me...

For #20661.

Change-Id: I1e638cb619e643eadc210d71f92bd1af7bafc912
Reviewed-on: https://go-review...

The instruction format of MOVBU is the same with MOVB, this CL deletes
MOVBU from optab for simp...

The size of gnuVersym should be multiples of 2. If not, the input is
invalid. No Library and Ver...

(Fixing the most important part of this bug.)

Updates #56426

Change-Id: If657ae47a5fe7dacc31d2...

Test2json is parsing the output stream from the test, which includes
package testing's own frami...

When using "MOVD $const, Rx", any 32b constant can be generated in
register quickly. Avoid trans...

i.e.
from "function %!s(*Node=0xc0003b48c0) cannot have ABI wrappers", to "function xxFunctionNa...

flag.Example() has this comment:

... one must execute, typically at the start of main (not ...

This allows programs that want SHA1 support to call os.Setenv at startup
instead of insisting th...

As of CL 443058, rand.Seed is not necessary to call,
nor is it a particular good idea.

For #548...

Fixes #56425.

Change-Id: Ieae3fdb5326d4b6f6ec1cdcd579051559e34b35b
Reviewed-on: https://go-revi...

The Cancel and WaitDelay fields recently added to exec.Cmd are
intended to support exactly the s...

Change-Id: Iceed0f55038c87f261b60309e025132142946364
Reviewed-on: https://go-review.googlesource...

Change-Id: Ia7e1e3679e03d125feb9708cb05bbd32c4954edb
GitHub-Last-Rev: a62b72ea3edcf2b4f9f378cd03...

Change-Id: I73ace9f5b9481f3b88be0c5f6b9c5076d2f82c7f
Reviewed-on: https://go-review.googlesource...