Ecosyste.ms: OpenCollective

An open API service for software projects hosted on Open Collective.

github.com/hack-pad/go

The Go programming language
https://github.com/hack-pad/go

cmd/compile/internal/types2: deduplicate signatures with the context

This CL is a mostly clean port of CL 362801 from go/types to types2.
It deviates from go/types i...

a17a21c190c3e3ea8e88af3e89ccb3c2f101c35b authored about 3 years ago
cmd/compile/internal/types2: add a test for argument error unwrapping

This CL is a clean port of CL 351338 from go/types to types2.

Change-Id: I7fd0e5a447bf51cb359e7...

fceca2c0f1ff21e1b2b0bf9960b776bb08e58d86 authored about 3 years ago
cmd/compile/internal/types2: tweaks to ArgumentError to be more idiomatic

This CL is a clean port of CL 351335 from go/types to types2.

Updates #47916

Change-Id: Idc377...

f384c707ac3dd946e3c895d0f4e154744048ef36 authored about 3 years ago
cmd/compile: emit definition of 'any' when compiling runtime

Include the predefined type 'any' in the list of other important
predefined types that are emitt...

3d7cb23e3d5e7880d582f1b0300064bd1138f3ee authored about 3 years ago
runtime: remove defer test log spam

This appears to be leftover debugging
from CL 356011.

Change-Id: Ieeda0b7e297e0cb943827b2864413...

a2b8231b91e8c4c9e95875b8063bf364f5b0db97 authored about 3 years ago
runtime: check GOAMD64 compatibility after setting up TLS

We need TLS set up to be able to print an error without crashing.

Fixes #49586
Update #45453

C...

01b6cf09fc9f272d9db3d30b4c93982f4911d120 authored about 3 years ago
sort: improve sort documentation

Fixes #48527

Change-Id: Ib5df0819cbcd5c2e4f03bda841871d237af96b19
Reviewed-on: https://go-revie...

5e59d6ebd110a7c19770c7d996930ff379ba5726 authored about 3 years ago
os/exec: avoid NewFile on unknown FDs

exec_test.go's init function uses os.NewFile(fd) + f.Stat as a portable
mechanism to determine i...

f6591839727e09cc5cb11d08b333fd2386e8aa1b authored about 3 years ago
debug/pe,debug/macho: add support for DWARF5 sections

Adds the same logic used in debug/elf to load DWARF5 sections.

Fixes #49590

Change-Id: Iee05b9...

6c36c332fefdd433cfe6e6468a2542fc310e9f8a authored about 3 years ago
cmd: pull in golang.org/x/mod@3a5865c

This change updates the cmd module's requirement on x/mod and vendors in
the changes.

This pull...

40effca7a13d11f3549a24a5d4b02e87c12fc6bb authored about 3 years ago
runtime: get tracking time only when needed

casgstatus currently calls nanotime on every casgstatus when tracking,
even though the time is o...

29ec902efc0ae53c4435097efdb738667466756c authored about 3 years ago
go/types, types2: improve error messages referencing any

Because any is an a alias, it is naively formatted as interface{} in
error messages. This is a s...

79d0013f53d4199b9f84d813221b71adf7eb1e4d authored about 3 years ago
cmd/compile: prevent irgen crashing for empty local declaration stmt

Updates #47631
Fixes #49611

Change-Id: Ib4a4466038e0d4a9aa9380d7909f29f7d15c6c69
Reviewed-on: h...

7f4a946fa26f2ffdc14c354f2f1cc193ab5d0e90 authored about 3 years ago
go/types: remove asTypeParam and simplify some code

This is a port of CL 363438 from types2 to go/types.

Change-Id: I87c76d31b398b9ce406f96b0030ee4...

7c50ef6c8c4c827db45a3327cb950913cf9d489b authored about 3 years ago
go/types: remove structuralString in favor of inlined code

This is a clean port of CL 363154 from types2 to go/types.

Change-Id: I26c18767041db096390e84ba...

f041c7e3028545ba39c60d6e20ab9b74c01bbf33 authored about 3 years ago
go/types: slightly relax notion of structural type

This is a port of CL 363075 from types2 to go/types, adjusted for the
different error reporting ...

289c930750fccac6aca578c675694b612532fd24 authored about 3 years ago
go/types: refer to structural rather than single underlying type in errors

This is a port of CL 362997 from types2 to go/types. Some error
positions were adjusted in tests...

46e98d489fda3bc1e36af92ee625b2fce3c1f88e authored about 3 years ago
go/types: move some functions into different files (cleanup)

This is a clean port of CL 362995 from types2 to go/types.

Change-Id: Iefc37b28178795ea944e0bc0...

50dac3b410b9bc47dabc3f3c2afd21f7aecfb118 authored about 3 years ago
go/types: rename structure to structuralType

This is a clean port of CL 362994 from types2 to go/types.

Change-Id: I51b38c35ec3306274ef03555...

67c15568156eb0c5607edc51a2b5d69876ba236d authored about 3 years ago
go/types: use type variables consistently in Checker.conversion

This is a clean port of CL 362895 from types2 to go/types.

Change-Id: Icd0631127c51aec80ce9450d...

bddb79f0faa11958ff473109398be684c088a6a9 authored about 3 years ago
all: update vendored golang.org/x/tools

Update the vendored x/tools to pick up the fix for #49597, using the
following commands:

go g...

9efb6493f498f8fdcc5d34d4df4d5e9c620f861b authored about 3 years ago
cmd/go: don't try to print build info of non-Go binaries

On a non-nil err, buildinfo.ReadFile will always return a nil
*Buildinfo. In scanFile, we need t...

6e481c0b36ca484a9fe4a1de25b6def06a26b988 authored about 3 years ago
cmd/compile/internal/types2: re-use type hashing logic in Context.typeHash

This CL is clean port of CL 362800 from go/types to types2.

Change-Id: I66443b5a82b3a9c2f608a0f...

6b3f4d388fe5602172f45361f438edf54699b953 authored about 3 years ago
cmd/compile/internal/types2: refactor the Context type map to accept arbitrary types

This CL is a clean port of CL 362799 from go/types to types2.

Change-Id: Id670aa4b1ca0b568a79bb...

313cae3861841e9c64bebe2c1aed8126cf6cc117 authored about 3 years ago
cmd/compile/internal/types2: use Identical to verify type identity in the Context map

This is a clean port of CL 362798 from go/types to types2,
with an additional comment adjustment...

a52e4b9c7e8f5aae678596e0c198e67b3b2b1087 authored about 3 years ago
doc: mention generics in release notes

Also mention local types restriction.

We probably want to say more at some point, this is just ...

febbef593e8d77500d0e330db91a7be1a71d05e9 authored about 3 years ago
sync: in TryLock try to acquire mutex even if state is not 0

For #45435

Change-Id: I728accd9a53c1826243f52aa04dc2a0a1dfdaadf
Reviewed-on: https://go-review....

fdd67930a0f2fec891e4be9c2b62996eb8b06ce5 authored about 3 years ago
doc/go1.18: add AppendRune doc

For #47694

Change-Id: I39594c273aeb038702457587ee1c46e4b3920bb6
Reviewed-on: https://go-review....

865689571d52fee0b4c910d54bd4ba1484ff2344 authored about 3 years ago
debug/dwarf: better error message when reading absent debug_line_str

When a DW_FORM_line_strp is used without a debug_line_str section a
good error message (about th...

9e13a8876fb531861cbb8e865e57431de9818c16 authored about 3 years ago
cmd/compile/internal/types2: add test for imported constraints pre-1.18

But exclude the test when running unified build for now
(the unified builder's importers are not...

d15610128e63e299e39af02ea0e6be1afd38b1ff authored about 3 years ago
cmd/compile/internal/types2: use "implements" rather than "satisfies" in error messages

Type constraint satisfaction is interface implementation.

Adjusted a few error messages.

Chang...

95e85e31089523447aadb7670715c4d3383cc4ee authored about 3 years ago
cmd/compile/internal/types2: remove unneccesary tests in implements and lookup

Because the underlying type of a type parameter is an interface,
the questions whether *P for a ...

c8d7c5fe0511569f19d4ebed29f11d96f50b3e07 authored about 3 years ago
cmd/compile/internal/types2: implement Checker.implements

Checker.implements implements the complete interface
"implements" predicate. Use it instead of C...

e08aae2ee443ba8bb16b8ce9c5d3d8d4d3cfa82b authored about 3 years ago
cmd/compile/internal/types2: better position for invalid slice indices error

Report the error at the first place (which is to say, latest index)
causing the error.

Change-I...

fda92615040c831bdcd812fd20ddb0da9dcef70b authored about 3 years ago
cmd/compile/internal/types2: better position for "3-index slice of string" error

As a result, slightly narrow position tolerance for tests.

Change-Id: I543dc2b7b9a7940b0684067d...

42fa03a88ca7767c1869e55b3144a9828d29b7b5 authored about 3 years ago
cmd/compile/internal/types2: move match function to end of file (cleanup)

Change-Id: Ia09f7b1af0e84858fb73ab7e2592c5c3e983dc0e
Reviewed-on: https://go-review.googlesource...

0a54a6826ebd19e5947af57993399652c62801de authored about 3 years ago
cmd/compile/internal/types2: allow slicing for operands with []byte|string type sets

Fixes #49566.

Change-Id: I80ff4ca661f82b0981d51e0997d5988a9b82f508
Reviewed-on: https://go-revi...

cfcd71790f0ca8c2ec1ae5989cd60ad1e83ee40c authored about 3 years ago
cmd/compile/internal/types2: optimize common case in structuralType

Most of the time we don't have a type parameter. Avoid using a
closure in that case.

While at i...

0a39e4a89d26d8375bb5877f736dcc0047894060 authored about 3 years ago
go/types, types2: copy implicit bit in interface substitution

Change-Id: Idb02449ef1b06d5f47eeb4a4413e56e2cd5d0d96
Reviewed-on: https://go-review.googlesource...

184ca3cf99864b4112997891b079d106751be25c authored about 3 years ago
cmd/compile: error when using internal type declarations in generic functions

We hope to support this feature one day, but it doesn't work currently.
Issue a nice error messa...

560dc9712d4bc900b5ab32b518ba4de2a9bc588c authored about 3 years ago
cmd/compile/internal/types2: add a check for nil reason in assignableTo

A recent change to error message formatting was missing a nil check.

Fixes #49592

Change-Id: I...

92655582d0d3b739a1fc88c73cc49a24eb57f845 authored about 3 years ago
go/types: return an error message from Checker.genericType

The bare error message "%s is not a generic type" is probably never
sufficient, so change the si...

b6342a02ad901e015e1c4eb9f862824029efb7b7 authored about 3 years ago
go/types: assign error codes to new errors for Go 1.18

During development, we used placeholder _Todo error codes for new
errors related to generics. Ad...

0e654100382f345ea555cfc1e1dd50853316b368 authored about 3 years ago
cmd/compile: fix position info for implicit nodes due to generics

The main fix is that we should call ir.SetPos() at the beginning of
(*subster).node.edit functio...

1dc9af5cdc6dabe4841afb4edf9dbf5124946ea0 authored about 3 years ago
runtime: fix released bytes accumulation in bg scavenger

Currently "released" is not accumulated bytes released. If the last
attempt to scavenge ends up ...

f986191325e9c8be606b5f4db69a33692728274b authored about 3 years ago
cmd/compile, runtime: mark R1 as clobbered for write barrier call

If the call to gcWriteBarrier is via PLT, the PLT stub will
clobber R1. Mark R1 clobbered.

For ...

ce4a2755956a42aa3211c121139a52c9a97a9aa0 authored about 3 years ago
cmd/compile: ensure we replace package placeholder in type names

We want package names exposed by reflect to be things like
main.F[main.foo], not main.F["".foo]....

5337e53dfa3f5fde73b8f505ec3a91c628e8f648 authored about 3 years ago
doc: document GOAMD64 environment variable

Update #47694

Change-Id: I9c90bd251616cd4d10434bd3b6e6c30c5c819e24
Reviewed-on: https://go-revi...

dfa62c79de4f6f6ee2eb8cde340c21afc739c38d authored about 3 years ago
cmd/compile/internal/types2: simplify under() and fix a crash

The simplified version of under exposed a bug (by crashing):
When a pointer base is used before ...

c2397905e027cdbab3a28d02813adcb82368422c authored about 3 years ago
cmd/go: remove remaining uses of TODOWorkspaces

Most of them are fixed, but some of them have been rewritten to refer
to specific issues.

For #...

c54605266b746dd4d81e3753b55910e5c8dde5f0 authored about 3 years ago
go/types: return an error from Instantiate on incorrect len(targs)

Instantiate already returns an error when validation fails. Panicking on
an incorrect number of ...

c78a267bd4ccdd8699a9dbe9bad3597bf3de47e9 authored about 3 years ago
go/types: add a test for Context deduplication of hash collisions

Add a test that exercises the fall-back logic in Context to handle hash
collisions by de-duplica...

e658c42ba460b91d5b6934829ddffa802d4ca524 authored about 3 years ago
test: fix longtest failures on fixedbugs/issue48471.go

This test is failing with -G=0, so specify -G=3.

Change-Id: I4c74707d0a43f8191cb0b156204604458b...

2fd720b78086eaa57559e38f6ad4fe51c09c3a17 authored about 3 years ago
go/types: rename types.context to types.environment

Now that we have a Context type the context (unexported) type is
particularly confusing. Rename ...

c893a85f21d0e5448c687254e50cc6936b36548e authored about 3 years ago
go/types: don't set a Config.Context if none is provided

Users can re-use a type checking context by passing it via types.Config.
There is no need for us...

530e320b2a9ed08f2bba39507b877fd66352d7ca authored about 3 years ago
go/types: when type hashing, canonicalize interfaces

The interface type string preserves certain non-semantic attributes of
the type, such as embedde...

958f405371d942d988aef325b2103fa64028af45 authored about 3 years ago
go/types: when type hashing, use placeholders for type parameters

Type parameter names don't matter for the purposes of generic type
identity, so mask them with n...

c97d6817a3a47ce7ec30f1eebae48def30b64ad8 authored about 3 years ago
go/types: deduplicate signatures with the context

Extend the type checking context to allow de-duplicating *Signature
instances, in addition to *N...

bfbe5ac9ce58fb59aa38ef69dee4933f20aac039 authored about 3 years ago
cmd/compile/internal/types2: remove tparamIsIface flag and corresponding dead code

Added/clarified some comments.

Change-Id: Ib08d3343ff08c23cc8880a27a0148d1ff077a80f
Reviewed-on...

787708a6ff66092678cd4312358e90a5085eac89 authored about 3 years ago
cmd/compile/internal/types2: remove asNamed

In the few remaining places where we use asNamed, if the argument
is indeed a *Named, we either ...

bc0b98eeffa64f155e7f2a2dc6b883a97c4d0580 authored about 3 years ago
cmd/compile/internal/types2: remove a review comment in implicitTypeAndValue

Reviewed the code and simplified slightly. No semantic changes.

Change-Id: Ib785b912fbee9774632...

56e55a388986ed9c770a21e9c58df38e021b577b authored about 3 years ago
cmd/compile/internal/types2: set tparamsIsIface to true

This CL enables the mode in which the underlying type of
type parameters is the underlying type ...

c09d854f0961a997ac41a740a6e8d1892b7e6ee0 authored about 3 years ago
cmd/compile/internal/types2: underlying type of a type parameter is its constraint interface

Until now, the type checker operated with the definition that the
underlying type of a type para...

39bc666430b3340c3de0e815cfc1fbfc7b2f7e99 authored about 3 years ago
net/http: do not send Transfer-Encoding: identity in responses

Server handlers may set a "Transfer-Encoding: identity" header on
responses to disable chunking,...

b69b2f63d65609b400b4a40ae01e4a48638f050f authored about 3 years ago
cmd/go: add go work use command

For #45713, #48257

Change-Id: I7e9248f22fe7ab33b151e07cc296d64c194154e2
Reviewed-on: https://go...

fdee1b297438a64c553ecc7468a7647f5a070404 authored about 3 years ago
cmd/compile/internal/types2: make sure we are safe for nil in underIs

Reviewed all uses of underIs (global function and method) and made
sure we are ok with a nil inc...

3a4b95073a9fd7bca6e9fd80016275ef04bc1987 authored about 3 years ago
cmd/compile: add missing method info for method with correct name except for case

When being used by the compiler, augment the types2 missing method
message with extra info, if a...

429d1e01557f95bba29837f2190441696484fd41 authored about 3 years ago
cmd/compile: match Go 1.17 compiler error messages more closely

When being used by the compiler, fix up types2 error messages to be more
like Go 1.17 compiler e...

c8d6ee12d5eb1c64f2aff8a4d511f677a64e3aed authored about 3 years ago
cmd/go: use workspace modules' go.sum files to check sums

By default, use workspace modules' go.sum files to check sums. Any
missing sums will still be wr...

1cd600301ea2a0b13d5e158282200114dc9de3fd authored about 3 years ago
cmd/compile/internal/types2: better error for type assertion/switch on type parameter value

Change-Id: I98751d0b2d8aefcf537b6d5200d0b52ffacf1105
Reviewed-on: https://go-review.googlesource...

f9dcda3fd83e83fb29cc6b0f710faa49ba98a54b authored about 3 years ago
cmd/compile/internal/types2: remove asTypeParam and simplify some code

Because we do not permit a stand-alone type parameter on the RHS of
a type declaration, the unde...

9150c16bced33ca591a55fe4fb64817dd659b285 authored about 3 years ago
runtime: start ARM atomic kernel helper traceback in caller

Like the VDSO, we cannot directly traceback from the Linux kernel ARM
atomic/barrier helpers. Ho...

363459479014bde19e83d9fb6781310f63fb0b45 authored about 3 years ago
net/http: do not cancel request context on response body read

When sending a Request with a non-context deadline, we create a
context with a timeout. This con...

76fbd6167364fb98e3ebe946cfc16b5b84d4240e authored about 3 years ago
runtime/pprof: mark TestCPUProfileMultithreadMagnitude as flaky

The Linux kernel starting in 5.9 and fixed in 5.16 has a bug that can
break CPU timer signal del...

95196512b6163dbeff2e7ce5cea65072305905f2 authored about 3 years ago
runtime: drop cgoTraceback call assumptions from CgoPprof tests

the CgoPprof tests currently assume that calls to their cgoTraceback
functions are primarily for...

ecd2e140ec54feca9afbda7726345e09cd380eea authored about 3 years ago
cmd/compile: fix missing transformEarlyCall for OXDOT in subster.node

Like OFUNCINST, in case of OXDOT call expression, the arguments need
to be transformed earlier, ...

b1b6d928bd4fb368f8ada0a554fc85405e7a3688 authored about 3 years ago
internal/fuzz: set timeout for each exec of fuzz target

This change sets a timeout of 10 seconds on each
execution of the fuzz target, both during fuzzi...

5d24203c394e6b64c42a9f69b990d94cb6c8aad4 authored about 3 years ago
cmd/compile/internal/types2: unexport Context.TypeHash

Context.TypeHash is not being used outside of the type checker, so
unexport it.

The TypeHash me...

8b66b3d49f931715c52b4ed71bc1dc935132c30f authored about 3 years ago
go/types: re-use type hashing logic in Context.typeHash

The special handling for *Named types is not necessary. The hash of an
instance is simply the ha...

ede97290edd6ca9291d44f8eba503fbd8b162ed4 authored about 3 years ago
go/types: refactor the Context type map to accept arbitrary types

In preparation for storing *Signature types in Context, refactor the
type map to not depend on t...

2dbf37045c24c8ab6f93083adc8be9ccdb3e3603 authored about 3 years ago
go/types: use Identical to verify type identity in the Context map

We don't have guarantees that our type hash is perfect, and in fact
fuzzing found cases where id...

0c6a6cd4d8c19ca8892085a38477e5ff56b7cc2b authored about 3 years ago
test/recover4.go: use mprotect to create a hole instead of munmap

Currently the recover4 test, which recovers from a panic created from a
fault, generates a fault...

95d06576702c54139796f3e24e2eec4b135b1a09 authored about 3 years ago
reflect: keep pointer in aggregate-typed args live in Call

When register ABI is used, reflect.Value.Call prepares the call
arguments in a memory representa...

23adc139bf1c0c099dd075da076f5a1f3ac700d4 authored about 3 years ago
cmd/link: don't unmap output file at error exit

When the link exits on error it currently calls Out.Close, which
will munmap the output buffer a...

e9f0381a807d1797e0b5969a29f4a3666a73c9e3 authored about 3 years ago
net: use Done rather than comparing with context.Background

Fixes #49023

Change-Id: I3de70f8a25f4ba8a0fb8bb96581371e33fde2f7a
GitHub-Last-Rev: b7ec9405adc7...

7bed3c7975780cad3c0adcf548d8b2d324a09265 authored about 3 years ago
math/bits: add examples for Add, Sub, Mul and Div

Change-Id: I2f3619aa827e18f356871511c20cf2c712f496b3
Reviewed-on: https://go-review.googlesource...

c3c4a2bf6589f8c1e046149356fb5456b34a0df1 authored about 3 years ago
all: update terminology for fuzzing

This change doesn't modify any functionality.
It also doesn't update all of the comments and
var...

9d89a5eb64f25ce0e7cc6086d44b6f327cbb302c authored about 3 years ago
go/types, types2: document nil scope for imported and instantiated Func objects

Also, don't set the scope anymore when instantiating (substituting)
a signature.

Per discussion...

ccd41cc05e3ee2f0d0ded1d7faf9c1f43ce1037b authored about 3 years ago
cmd/compile: ensure stenciled function bodies are nonempty

Our compiler gets confused between functions that were declared
with no body, and those which ha...

10d3b1355184320f6d9623cb35e848e5af7c29ed authored about 3 years ago
go/build: skip rune literals when looking for go:embed

Fixes #49514

Change-Id: Id687eead731ba49974f11d2e5b489f11eff7d07b
Reviewed-on: https://go-revie...

c622d1d3f68369ec5f8ce9694fa27e7acb025004 authored about 3 years ago
runtime: fix typo

Change filepath reference from cmd/internal/ld/symtab.go to
cmd/link/internal/ld/symtab.go.

Cha...

eb68e3367bf8d55bb98eb002cef35455f5be3c5f authored about 3 years ago
runtime: adjust TestPhysicalMemoryUtilization to handle large page sizes

Currently TestPhysicalMemoryUtilization can fail on systems with large
physical page sizes like ...

46b2fc05a2681a9dd3b606176e738d786b0c2176 authored about 3 years ago
runtime/debug: make TestFreeOSMemory more robust

FreeOSMemory relies on the function FreeOSMemory increasing HeapReleased
as opposed to the backg...

3e94140465984ff6c8d658051d022e8eacf057c3 authored about 3 years ago
database/sql: prevent closes slices from assigning to free conn

In function connectionCleanerRunLocked append to closing slice affects db.freeConns and vise ver...

48f1cde942959e2fc3c56973a2986c24d554c82c authored about 3 years ago
spec: fix a broken link

Thanks for jtagcat@ for finding this.

Change-Id: If7324808edbae19ec8bf503b04e0426f3fb3b47a
Revi...

d60a4e69f16f5bc958094af206ac7e47f6bc8b04 authored about 3 years ago
obj/riscv: fix link to risc-v dwarf register numbers

The repository name and structure in the RISC-V GitHub org has been
modified, rendering the exis...

f1935c52703e4482c5047b4b35276e965896df7c authored about 3 years ago
io: add error check to TeeReader Example

Change-Id: I0b94bdced47483c6412e9979ce2d103fbfc52afb
Reviewed-on: https://go-review.googlesource...

8ce1a953fb125ab390e816540d7f6c304ee7e52b authored about 3 years ago
runtime: fix C compilation error in TestCgoTracebackGoroutineProfile

Use C89 declaration. Also fix indentation.

Change-Id: Ib974eb32ac95610d0b0eca00ca3b139b388c73bd...

84277bfd07dad771b9978149bdaed8aa16ed8982 authored about 3 years ago
cmd/compile: fix missing ddd when building call for function instantiation closure

When building a call expression for function instantiation closure, if
it's a variadic function,...

73a4bbb0df36d85d1ab8cb12d220d1d56e4049ec authored about 3 years ago
doc/go1.18: document http.Transport.Dial* being used in js/wasm

This PR adds a note into the Go 1.18 changelog for CL 330852.

Updates #46923.

Change-Id: I9915...

666fc173c02ff3004ac9ef867aa4eec7e243dde3 authored about 3 years ago