Method signatures can introduce a significant number of edges into the
type graph. One can imagi...

We have disallowed having a typeparam on the right-hand-side of a type
declaration. So, we disab...

Added a new absdiff2.go test case, which works fully without using a
typeparam on the right-hand...

While checking comparability of type parameters, we recurse through
_TypeSet.IsComparable, but d...

By processing non-alias type declarations before alias type declaration,
and those before everyt...

The type checker doesn't have a general mechanism to "use" the type
of a type alias whose type d...

Change-Id: I48804eba94ec455c4764d52af148f4210faf7d94
Reviewed-on: https://go-review.googlesource...

In validType, when we see an instantiated type, proceed as with
non-generic types but provide an...

This is necessary for cycle detection over imported types whose
underlying types are set by impo...

Because validType doesn't modify global state anymore, there's
no need to ignore imported types....

Now that we have a separate top-level entry point for validType
we can use the more narrow type ...

With this change validType doesn't modify global state anymore.
It also eliminates the need for ...

The validType check is independent of the work of declaring objects.
Move it into a separate fil...

Change-Id: I40cfc87731d3a29670a3e183948898ea0cb2402d
Reviewed-on: https://go-review.googlesource...

Change-Id: Idc4d561c7037f33aa9c844b411c38c6cb5bbfbcd
Reviewed-on: https://go-review.googlesource...

TestFutexsleep was originally created in CL 7876043 as a
regression test for buggy division logi...

Given we have support for field access to type params with a single
structural type, we need to ...

Add some useful comments, mainly relates to types.Type. (No non-comment
changes.)

Change-Id: I3...

Very, very rarely TestVectoredHandlerDontCrashOnLibrary fails because
the C subprocess exits wit...

This reverts CL 380057.

Reason for revert: appears to have broken x/tools tests on macOS.

Chan...

Mostly from CL 367954.

Change-Id: Id003b0f785a286a1a649e4d6e8c87d0418a36545
Reviewed-on: https:...

This fixes checks for crossing module boundaries when the root of
the module is a symlink. We're...

The closure in parallelLabelHog should be labeled in a addition to
parallelLabelHog itself. Gene...

This reverts CL 376414.

For #47694.
For #50481.

Change-Id: Ie73961046e52e6e5d3262ef0aeaa24bec7...

In a method declaration "func (f *Foo[_, _]) String() string { ... }",
the two blank typeparams ...

Use an enviroment variable rather than a build tag to control starting
a busy loop thread when t...

And disallow replaces of any main modules in the go.work file itself.

Change-Id: Ifa9ba9eaed047...

Fixes #50705.

Change-Id: I85857f836cbe58447625df6cd56756d3a69880ff
Reviewed-on: https://go-revi...

Now that we instantiate methods on instantiated types, there is no need
to use unification to ma...

This is a map from identifiers to type parameters, use *TypeParam
as map value instead of Type.
...

Change-Id: I23264972329aa3414067cd0e0986b69bb39bbeb5
GitHub-Last-Rev: d1d668a3cbe852d9a06f03369e...

Fixes #49687

Change-Id: Ife7f64f4c98449eaff7327e09bc1fb67acee72c9
Reviewed-on: https://go-revie...

Most CONVIFACEs are created in the transform phase (or old typechecker,
in -G=0 mode). But if th...

Slightly better for cases such as string(1 << s).
Leaves type-checker tests alone for now becaus...

It was removed in CL 378576.

For #50501

Change-Id: I26b8f0e99a40fa5c616aa4849a6ab15dd0d072f8
R...

TestCPUProfileMultithreadMagnitude compares pprof results vs OS rusage
to verify that pprof is c...

Document and enforce API expectation. Add a test so we don't
inadvertently change the function b...

This makes TestLabelSystemstack much more strict, enabling it to detect
any misplacement of labe...

GC background mark worker goroutines are created when the first GC is
triggered (or next GC afte...

Instead, allow the test to run up until nearly the test's deadline,
whatever that may be, and th...

For an extension operation like MOWWreg, if the operand is already
extended, we optimize the sec...

This test occasionally takes very slightly longer than the 3 second
timeout on slow builders (es...

This test was missed in CL 358539, presumably because the 'longtest'
builders lack a 'gpg' execu...

Fixes #45114.

Change-Id: I969e5f1037254fc0ffbba2fc07a81a3987e6b05f
Reviewed-on: https://go-revi...

For #45114.
Fixes #45117.

Change-Id: I71d6650ae2c4c06952fce19959120f15f13c08a2
Reviewed-on: htt...

Fixes #49541.

Change-Id: I27a52d0722a7408758682e7ddcd608c0a6c4881b
Reviewed-on: https://go-revi...

Also, simplify one expression (missed comment on previous review).

Change-Id: Ic2d212442c2738e0...

Currently the code handles the case of returning values from
a function with no result parameter...

Updates #47738
Fixes #49598

Change-Id: I708dcb880a701699116227a9eaca994cf460fef9
Reviewed-on: h...

Consider the following program:

package p

func f() {
x := 1
v := 2
switch v.(type) {
...

This extends the skip added in CL 375635 to the "_Headers" variant of
the test, since we have ob...

In the compiler, we need to distinguish field and method access on a
type param. For field acces...

Fixes #50501
(in a sense, by removing a flag that looks like it should do something
it does not)...

We use uname -m to decide the GOHOSTARCH default,
and on my ARM64 Mac laptop, uname -m prints x8...

The VMOVQ instruction stores a 128-bit number into a V register, for
example:
VMOVQ $0x11223...

Currently, there are two regexps in the race detector output tests
that assume subtests will com...

Change-Id: Ifbfea6bdbff172d4fbcbf231d6be180c83776e4d
Reviewed-on: https://go-review.googlesource...

Fails TestRepeatBootstrap.

This reverts CL 371474.

For #50146.

Change-Id: Ie4adda4e0229e15347...

Fails TestAllDependencies.

This reverts CL 371475.

For #50146.

Change-Id: I1feccd772d92d80e57...

As a follow-up to https://golang.org/cl/371474, add the OS version to
the metadata printed for e...

Knowing whether test failures are correlated with specific CPU models on
has proven useful on se...

SHT_NOBITS sections do not occupy space in the file and their offset is
"conceptual", reading th...

Also adjust other skips to actually call t.Skip, so that the test
correctly shows as skipped ins...

The netpoll code was written long ago, when the
only multiprocessors that Go ran on were x86.
It...

When we export a shape instantiation, because a particular
fully-instantiated type is needed by ...

Let T be a type parameter, and say we instantiate it with S, a type
that isn't pointer-like (e.g...

This is in relation to #49681

Change-Id: I32ad8b506cf8fb0a94b15c3cc8b1eaf5af728c59
Reviewed-on:...

In order to make sure we export the dictionaries/shape methods for all
fully-instantiated types ...

Using type aliases, it's possible to create structs with embedded
fields that have no correspond...

Also eliminate some arbitrary deadlines and sleeps.

Fixes #49958

Change-Id: I999b39a896e430e3b...

It's too confusing to users to run go install in module mode, so run
it in workspace mode instea...

go work sync resets the state in the modload package before each
iteration where it updates the ...

Adds simple fuzz targets to archive/tar, archive/zip, compress/gzip,
encoding/json, image/jpeg, ...

Fixes #50589

Change-Id: Ic260a6edd9af5c9c6dd8b40f0830f88644c907f1
Reviewed-on: https://go-revie...

Add "freebsd" to GOOS for which sys.FuzzSupported() returns true
and add freebsd to the build ta...

- support printing of expression and type lists in sprintf
- simplified some code in go/types/ex...

This is a stop gap solution to avoid panics due to stack overflow
during type unification. While...

If we have more than 2 arguments, we may have arguments with named and
unnamed types. If that is...

Type parameter lists are stored using ast.FieldLists. Update the
documentation to reflect that t...

This reverts CL 352109.

Reason for revert: causing OOM failures on several builders, and may ca...

Until now, CTI (constraint type inference) was run before
FTI (function type inference). This le...

Introduce a (local) notion of a set of representative types,
which serves as a representation/ap...

Adds simple fuzz targets to archive/tar, archive/zip, compress/gzip,
encoding/json, image/jpeg, ...

With this change, we shall now see:

*myS does not implement S (wrong type for DoSomething m...

The names given to methods of types created during type substitution
were possible incorrect whe...

The loading of the base type in typ0() may cause s.Def to be defined for
the instantiated type, ...

Issue #50552 is due to a problem with my recent improvement in the
interaction between generics ...

We now may have a scope associated with a type declaration, so need to
update our API documentat...

Change hidePanic (now renamed handlePanic) to print out the "internal
compiler error" message fo...

Explain the conditions under which they are called on stacks that
cannot grow.

Change-Id: I08ee...

For some reason, aix sometimes executes the bogus function body. This
should never happen as it ...

Skip the test on targets which don't support the race detector. This
fixes the linux-386-longtes...

I made the default be that, where there are differences between types2
and -G=0 error messages, ...

Follow-up on comment in CL 376914.

Also:
- add missing check != nil test in assignableTo
- use ...

Fixes #50516.

Also call DefPredeclaredTestFuncs in TestFixedbugs so it can be
run independently...

- detect *interface case and report specific error
- replaced switch with sequence of if's for m...

Only snapshot/reset coverage counters when we are actually fuzzing.
This prevents a race when ru...

Fixes #50523

Change-Id: Idab1b44d106250e9301d90ee6571f0ea51242dd9
Reviewed-on: https://go-revie...

This reverts CL 372914.

Reason for revert: missing synchronization

Change-Id: I7ebb6de082cebb7...

Added a test to make sure that the private methods of a local generic
type are properly exported...