Previous value used in the float32 roundtrip used float32(math.NaN())-1
which caused the quiet/s...

The test case is already working with unified IR, so add it to make
sure we don't regress while ...

This CL changes unified IR to include itabs in its serialized
dictionary format.

Change-Id: I33...

None of the current generic type switch test cases exercise type
switches where the instantiated...

This CL switches unified IR to using ir.DynamicType for derived
types. This has an immediate eff...

A few of the tests were printing garbage to stderr,
since FlagSet's default Output is os.Stderr:...

Before #46477, the Go generics proposal allowed `type T = U` where `U`
was an uninstantiated gen...

We shouldn't need to read in function bodies for new functions found
during inlining, but someth...

Change-Id: I7dfae0fc91c2d70873ec7ec920be7c0a4888153a
Reviewed-on: https://go-review.googlesource...

Fixes #51419

Change-Id: I0a32f41a6e6e01481ad58c7dddb57ec7085d77af
Reviewed-on: https://go-revie...

Change-Id: I7389da0c3a63fea3be5c820f2ce0d0168a95ab4c
Reviewed-on: https://go-review.googlesource...

Use dup3(oldfd, newfd, O_CLOEXEC) to atomically duplicate the file
descriptor and mark is as clo...

Fixes #51196.

Change-Id: I0ee4d8234f11e4f3b71b81546518647e07fafd7d
GitHub-Last-Rev: 8fd1a77adff...

Improve the test coverage of encoding/xml package by adding
the test cases for the execution pat...

Fixes #51258

Change-Id: I3c8b785ac912d66e1a6e2179625e6903032b8330
Reviewed-on: https://go-revie...

In a recent change CL 388654 a function was updated so it
no longer needed stack space, but the ...

For #51153

Change-Id: I4374c63498b62ba7a08f146eebd034cbd50623f6
Reviewed-on: https://go-review....

It's more trouble than it's worth. New code should be using x/sys/unix
anyhow.

Fixes #40564
Fix...

An extra "go build" was happening, for the sake of -tags=testgo,
which would insert some extra b...

This should be a bit faster and slicker than the very old ANSI X9.31,
which relied on the system...

The X9.31 expander is now only used for plan9. Perhaps once upon a time
there was a use for abst...

Import the following commits (and minor comment fixes):

* 17a0e59 - field: fix heap escape ...

Code essentially mirrors AMD64 implementation.

Change-Id: Ie97627a3041d1858fb1a30d2fc500302ab40...

For #45713

Change-Id: Ia2901cbfc5deb52503e74fcf9dff26a56ec582c3
Reviewed-on: https://go-review....

Otherwise, the behavior of 'go work use -r' (without arguments)
may be surprising.

Change-Id: I...

Fixes #51448

Change-Id: I86719b55037c377eb82154e169d8a9bbae20b77c
Reviewed-on: https://go-revie...

On Linux, the minimum required kernel version for Go 1.18 was be changed
to 2.6.32, see #45964. ...

The finalizer is called using reflectcall. When register ABI is
used, the finalizer's argument i...

Both endians perform syscalls similarly. Only CR0S0 and R3 hold
the resultant status of a syscal...

CL 386017 added new API for encoding/binary package.
This file was accidentally not updated in t...

Also correct scope position for such variables.
Adjusted some comments.

Fixes #51437.

Change-I...

The preferred form of nop is ori 0,0,0. What was being generated was
or 0,0,0.

Fix a quirk in t...

Workaround the minor endian differences, and avoid needing to
stack a frame as extra VSRs can be...

The test to enter the 32b copy loop always fails, and execution
falls back to a single 8B/iterat...

The existing codegen strategy in sort.go relied on parsing the sort.go source
with go/ast and a ...

This adds an asm implementation of aes-cbc for ppc64le to
improve performance. This is ported fr...

For #51390

Change-Id: I805e66809b2aafb48f7040dee72910dd7d6c1396
Reviewed-on: https://go-review....

Fixes #51442
Updates #50051

Change-Id: I1bfbc08c907077467fd50febbec6299a9b73af41
Reviewed-on: h...

Async preemption needs to save and restore almost all of the registers,
currently this is done b...

Advertise to DNS resolvers that we are willing and able to accept up
to 1232 bytes in a DNS pack...

This CL is a bit overkill, but it is pretty safe for 1.18. We'll
want to revisit for 1.19 so we ...

This template is based on CL 342070 and previous ones like it.
Continue to eagerly include often...

The Go 1 compatibility guarantee permits us to break code if there is
a specification error or a...

Introduced in CL 347917.

Change-Id: I99b34341f787e779bd45b967110e70a035fa6558
Reviewed-on: http...

This adds big endian support for the assembly implementation of
sha512. There was a recent reque...

AppendByteOrder specifies new methods for LittleEndian and BigEndian
for appending an unsigned i...

Modify Value.Bytes to be callable addressable byte arrays.
While related, the behavior of Value....

For #29666

Change-Id: Ibae3d75bb2c19571c8d473cb47d6c4b3a880bba8
Reviewed-on: https://go-review....

accept is no longer used on Linux since CL 346849 changed Accept to use
accept4 only.

For #4596...

The latter returns a uintptr, while the former returns a unsafe.Pointer.
A uintptr is unsafe if ...

For cases where RFC 1952 requires a field, the code returns the error
io.ErrUnexpectedEOF except...

cmd/compile uses "noalg.struct {...}" as type name when hash and eq algorithm generation of this...

Correct the slice expression in the description of Index functions.

Change-Id: I97a1b670c4c7e60...

The benchmarks added in this change revealed that ValidString
runs ~17% faster than Valid([]byte...

If name is empty or a keyword, we can skip the loop entirely.
Otherwise, we do the same amount o...

Fixes #50940.

Change-Id: Ie2a0c4505ca9d7e448017d9d00a020a6b3996be3
GitHub-Last-Rev: afd8c6b5598...

Confirm that the current implementation of core type unification
looks correct and update the re...

When doing constraint type inference, we must consider whether the
constraint's core type is pre...

Currently we only include static entries in the hint for sizing
the map when allocating a map fo...

Especially once this code gets copied into x/tools, we need a way to
evolve the file format, so ...

We use AutogeneratedPos for most compiler-generated functions. But
for method value wrappers we ...

This test case is failing on the noopt builder, because it disables
inlining. Evidently the expl...

ir.PkgName was only used by the old -G=0 frontend for representing
identifiers that refer to a p...

The typechecking code for dealing with dot imports and redeclaration
errors can be removed, as t...

This code was only needed for supporting -G=0 mode, which is now gone.

Change-Id: I504887ab179e...

Post 1.18, we're committed to types2 as cmd/compile's type checker.

Change-Id: I30d2dd2b2ba6283...

The next CL will remove the -G flag, effectively hard-coding it to its
current default (-G=3).

...

No need to eagerly read the object dictionary or setup the object
reader outside of the lazy res...

This keeps cmd/compile/internal/importer similar to how
go/internal/gcimporter will work after u...

Just a cleanup to make sure that generic SSA is properly typed.

Change-Id: Ie75fa972ae4e5fdaca5...

For certain values of GOMAXPROCS, the current code is less random than
it looks. For example wit...

Fixes #50823

Change-Id: I1c12e875b840eecadefb0d9e044ff2a268ccfbaa
Reviewed-on: https://go-revie...

Some of the SSA pseudo-variables like the memory variable don't
have a package. Print those grac...

Change-Id: Ibdaa0750f7bc47b513c047fdf4b7145ebba9e870
Reviewed-on: https://go-review.googlesource...

This logic is needed for the go/types unified IR importer, so extract
it into a separate interna...

Change-Id: I5894ac4697212267380b7a03876927bbf3e1de2b
Reviewed-on: https://go-review.googlesource...

Unified IR quirks mode existed to help bootstrap unified IR by forcing
it to produce bit-for-bit...

This is the start of the Go 1.19 development cycle, so update the
Version value accordingly. It ...

The work and work_edit script tests ran go work init, which put the
current Go version into the ...

Change-Id: I95ea33c0aad7d427da99c0ea7d0869f10ed5dd71
Reviewed-on: https://go-review.googlesource...

Change-Id: I93ff3d33a5db130dd57a9545456f2961fc3f668b
GitHub-Last-Rev: f95fafc04937a99f82cb992aab...

Converting an untyped constant to a type parameter results
in a non-constant value; but the cons...

We convert type args to shape types inside instantiations. If an
instantiation constructs a comp...

Change-Id: I2debcf926ef116c632c7366646d37de8686b7c9e
Reviewed-on: https://go-review.googlesource...

Currently, syscall.syscall-like functions are defined as
cgo_unsafe_args, which makes them ABI0,...

In getInstantiation, we were not computing tparams correctly for the
case where the receiver of ...

Normally types of constants are emitted when the type is defined (an
ODCLTYPE). However, the typ...

This update was created using the updatecontrib command:

go install golang.org/x/build/cmd/upd...

The existing test for 51219 didn't actually trigger the types2 issue - I
hadn't been able to min...

The problem in 51355 is that escape analysis decided that the
dictionary variable was captured b...

In case of a selector expression x.sel where x is a built-in
we didn't report an error because t...

In the dev.typeparams branch, the documentation for Type.Underlying was
updated with commentary ...

64-bit atomic functions on ARM have the following structure:
- check if the address is 64-bit al...

Delay validation of receiver type as it may cause premature expansion
of types the receiver type...

Fixes #51242
Updates #45551

Change-Id: Iba6e6acd9a94d24e26fcdd125f1022430723ada7
Reviewed-on: h...

For #45964

Change-Id: Ic66502c50ca328e944c91e710dca6c8dbc168e4f
Reviewed-on: https://go-review....

For #51183.
For #47694.

Change-Id: If47ae074c3cd9f73b2e7f6408749d9a7d56bd8d2
Reviewed-on: https...

Check receiver type parameter count when type checking the method
signature and report a suitabl...

TypeParam.is also provides ~ (tilde) information which is needed
to fix #51229. Delete all code ...

Previous versions of the 'go' command would reject a pseudo-version
passed to 'go get' if that p...