Sudo Project commits | Ecosyste.ms: OpenCollective

Add support for negated sudoRunAsUser and sudoRunAsGroup entries.

github.com/sudo-project/sudo - 1fe582a0e3315e562f05830c33a02223c777a1bb authored almost 6 years ago by Todd C. Miller <[email protected]>

Document that the target user's groups may be specified via the -g option.

github.com/sudo-project/sudo - fb015fac1ba317cfd3bf26ef5da3bed0190ef492 authored almost 6 years ago by Todd C. Miller <[email protected]>

Include getpwent() version of sudo_getgrouplist2_v1() from getgrouplist.c

github.com/sudo-project/sudo - 03c56db408a597f5fdd0c90a23befb437b5c54c5 authored almost 6 years ago by Todd C. Miller <[email protected]>

Use a testsudoers group file with known contents instead of the system one.

github.com/sudo-project/sudo - 0398996b3922f81807ddd4570127213de84f26c8 authored almost 6 years ago by Todd C. Miller <[email protected]>

Allow the group set by "sudo -g" to be any of the target user's groups.

Previously, this was only allowed if the group matched the target
user's primary group ID (from t...

github.com/sudo-project/sudo - 391ed95f501483e0308431fd32beada2a7086632 authored almost 6 years ago by Todd C. Miller <[email protected]>

Skip sudo_getgrouplist2() check on systems with getgrouplist_2().

sudo_getgrouplist2() is just a wrapper on such systems and this
avoids a test failure on macOS wh...

github.com/sudo-project/sudo - ffe2041a027cce4720f9b659a636ea99c245b0b0 authored almost 6 years ago by Todd C. Miller <[email protected]>

Add missing exported symbol sudo_term_eof

github.com/sudo-project/sudo - e22410ba645da7bb0697f2f9b23aa648743eff43 authored almost 6 years ago by Todd C. Miller <[email protected]>

Add missing #ifdef LDAP_OPT_X_TLS_REQUIRE_CERT

Fixes problems building on older LDAP sdks.

github.com/sudo-project/sudo - 0597969301d2dacb67450bd3183f79285cf83eb0 authored almost 6 years ago by Todd C. Miller <[email protected]>

add getgrouplist_test.c

github.com/sudo-project/sudo - 5eb0fbd0763f9ed8233e822e16dc507505abdda2 authored almost 6 years ago by Todd C. Miller <[email protected]>

Check the user's primary gid from the passwd file too.

github.com/sudo-project/sudo - a3cb22b4674b000a2833d29da730933824b1539e authored almost 6 years ago by Todd C. Miller <[email protected]>

ignore prologue

github.com/sudo-project/sudo - 06035f193e77d8b1751a9c087321a2bcbea6c6be authored almost 6 years ago by Todd C. Miller <[email protected]>

Convert PVS-Studio comment to ANSI C.

github.com/sudo-project/sudo - 6c3d20cb415d45f17294d1b0352589bdde7b2885 authored almost 6 years ago by Todd C. Miller <[email protected]>

Fix some mangled text in the license block.

github.com/sudo-project/sudo - 019279a4b8ee7c5eafd289215130557eeb7bdedf authored almost 6 years ago by Todd C. Miller <[email protected]>

Add regress test for sudo_getgrouplist2().

This test assumes all the groups in root's group list can
be resolved by group ID.

github.com/sudo-project/sudo - 404524c4ef9d027163032cc5c834e7fafd5389a8 authored almost 6 years ago by Todd C. Miller <[email protected]>

More changes in 1.8.26

github.com/sudo-project/sudo - 50b581ec3d3643084d6e1974d6d4e4a4197c3a25 authored almost 6 years ago by Todd C. Miller <[email protected]>

Add padding option to cvtsudoers.

Bug #856

github.com/sudo-project/sudo - 1b035b54268539393f7438b22c56cf9e43563739 authored almost 6 years ago by Todd C. Miller <[email protected]>

Remove an errant grset++ in the AIX version of sudo_getgrouplist2().

Bug #857

github.com/sudo-project/sudo - 78d35de935e5df74b4dfc190c2e337ab05e8c00e authored almost 6 years ago by Todd C. Miller <[email protected]>

Pass --sourcetree-root to pvs-studio and don't check sudo_noexec.c.

Since we don't auto-generate dependencies for sudo_noexec.c we
can't easily check it from outside...

github.com/sudo-project/sudo - cb588f2337bf4207776fbaba323f706f377ad77b authored almost 6 years ago by Todd C. Miller <[email protected]>

Asturian translation for sudo from translationproject.org

github.com/sudo-project/sudo - 56cff772eb7622c19fc8201be83eaa8fa630f6fe authored almost 6 years ago by Todd C. Miller <[email protected]>

Add support for CLOCK_MONOTONIC_RAW and CLOCK_UPTIME_RAW, present

on macOS.

github.com/sudo-project/sudo - 3710d5ba07d397c936072621833bab749429d3a5 authored almost 6 years ago by Todd C. Miller <[email protected]>

Add --enable-pvs-studio configure option to create PVS-Studio.cfg.

github.com/sudo-project/sudo - 4c82e18ac12ee70bf94201781bffd0167bc728f1 authored almost 6 years ago by Todd C. Miller <[email protected]>

Add comments in .c files so PVS-Studio will check them.

github.com/sudo-project/sudo - 64e5d34c570439bf6518400ebb9a2af291b90b7d authored almost 6 years ago by Todd C. Miller <[email protected]>

Add pvs-studio target and associated production rules.

github.com/sudo-project/sudo - c5df091123c3645c45ca297958f831c27cefbfff authored almost 6 years ago by Todd C. Miller <[email protected]>

Simplify range checks.

No need to check for ERANGE in the cases where we also check
that the value is <= INT_MAX. Found...

github.com/sudo-project/sudo - 45652e6d7115fe5b087966c2ae3bf356220fd706 authored almost 6 years ago by Todd C. Miller <[email protected]>

Avoid some PVS-Studio false positives.

github.com/sudo-project/sudo - 8c94175ba157525fcbd1aff8495a7e0484b75826 authored about 6 years ago by Todd C. Miller <[email protected]>

Remove some calls to sudo_fatalx(); just propagate the error return.

github.com/sudo-project/sudo - e9dec0f8d2cb162ba9b2b5d8168a9e5e5c6770f0 authored about 6 years ago by Todd C. Miller <[email protected]>

No need to check if fd_dst is -1 in sudoedit mode.

Failure to open the destination sudoedit file is fatal so there's
no need to check that fd_dst !=...

github.com/sudo-project/sudo - 6a85992b3441d128fa01f17170a011ffe2b018d4 authored about 6 years ago by Todd C. Miller <[email protected]>

In timestamp_open() no need to free cookie on error, it is NULL.

Found by PVS-Studio.

github.com/sudo-project/sudo - 6786d53d4585b3b2cbe78b39bef54e133f352f1d authored about 6 years ago by Todd C. Miller <[email protected]>

Fix a memory leak on malloc() error in sudo_ldap_role_to_priv().

Coverity CID 188804

github.com/sudo-project/sudo - deccfe68f1da247b8efea513d7af843d83bb94de authored about 6 years ago by Todd C. Miller <[email protected]>

Move the allocation of role to be immediately before in_role is set.

This makes it clear that when in_role == true, role is non-NULL.
Also remove two dead stores.

github.com/sudo-project/sudo - 84ef500061851f4508f45be432ce2bcd80a13475 authored about 6 years ago by Todd C. Miller <[email protected]>

Fix trimming of non-escaped trailing space in ldif_parse_attribute().

Found by PVS-Studio.

github.com/sudo-project/sudo - 2ff8f8601b8f348ee932aa6b65756d0723dfa9cb authored about 6 years ago by Todd C. Miller <[email protected]>

Simplify the logic surrounding sudoers_args in command_args_match().

We only need to check that sudoers_args is non-NULL once.
Found by PVS-Studio.

github.com/sudo-project/sudo - c2d93b8c97fcf396dddd3b1c4577fc06bd0f9793 authored about 6 years ago by Todd C. Miller <[email protected]>

If sudo_ldap_get_values_len() fails goto cleanup instead of oom.

This is not strictly necessary as there's not anything to cleanup
in this case but it is more con...

github.com/sudo-project/sudo - 54784a234ca63e91698e3bc4aac6d7177c663e92 authored about 6 years ago by Todd C. Miller <[email protected]>

Fix handling of timeout values in sudoers.

When passing the timeout back to the front end, ignore the
user-specified timeout if it is not se...

github.com/sudo-project/sudo - 63afa569f77494715cb7f7d0b1d1cc790c057386 authored about 6 years ago by Todd C. Miller <[email protected]>

Fix cut & pastos in cvtsudoers_make_gritem()

github.com/sudo-project/sudo - 675fc34c3de628ffcb53476121fcf290795c67bd authored about 6 years ago by Todd C. Miller <[email protected]>

Fix expected test output now that command_timeout is parsed correctly

in LDIF.

github.com/sudo-project/sudo - 60f0d65e22ba93988229453eb013728e47e5f84e authored about 6 years ago by Todd C. Miller <[email protected]>

tv_nsec can never be negative after timespecsub.

Found by PVS Studio

github.com/sudo-project/sudo - 939585e90634fb9b57e479a5fa85f40d4120e125 authored about 6 years ago by Todd C. Miller <[email protected]>

Avoid potentially undefined behavior.

Found by PVS Studio.

github.com/sudo-project/sudo - 25a58ba1caf8c7adf16e2eaaf4f9072f6a1963a1 authored about 6 years ago by Todd C. Miller <[email protected]>

sudo_ldap_parse_option() never returns '=' as the operator.

When parsing command_timeout, role, type, privs and limitprivs,
check that val is non-NULL instea...

github.com/sudo-project/sudo - e1a402f1d65f4f107a40237bc19384e43b334546 authored about 6 years ago by Todd C. Miller <[email protected]>

Fix up #line entries that reference lex.sudoers.c.

github.com/sudo-project/sudo - a9fd783f204fcdf631df42bc20d8b3ea9a6f19e1 authored about 6 years ago by Todd C. Miller <[email protected]>

Fix workaround for broken sudo 1.8.7 timing files.

github.com/sudo-project/sudo - 387672583ee302afcb69a3661906cd90c62824f5 authored about 6 years ago by Todd C. Miller <[email protected]>

Fix memory leak when reusing the runas list. We need to free the

member list itself as well as its contents.

github.com/sudo-project/sudo - fa7e6f3f042448c806b8d7c433aa51e3b550916f authored about 6 years ago by Todd C. Miller <[email protected]>

Some DIAGNOSTICS updates:

Update error message for when the user's uid does not exist in passwd.
Remove "This error indicat...

github.com/sudo-project/sudo - 75d9c6f1654bc823d029db439e5e9f6f985b0375 authored about 6 years ago by Todd C. Miller <[email protected]>

If the user's passwd entry cannot be resolved via the uid, use the

same error message as visudo.

github.com/sudo-project/sudo - fbf396e3367f63e86b1ee0f2e6bb7900be4bafaf authored about 6 years ago by Todd C. Miller <[email protected]>

Add a DIAGNOSTICS section with an explanation of the more non-trivial

error messages.

github.com/sudo-project/sudo - ae7198a2476f1ea841097cabecfdff3946485a3a authored about 6 years ago by Todd C. Miller <[email protected]>

Replace sudo_fatal(NULL) with an "unable to allocate memory" message

that includes the function name.

github.com/sudo-project/sudo - b89cf34b53a15e34d5e3ef2cdf545252ccd65dc2 authored about 6 years ago by Todd C. Miller <[email protected]>

Make EOF handling while reading the password prompt more like getpass(3).

We now return the password as long as at least one character has
been read. Previously, EOF at t...

github.com/sudo-project/sudo - 9e269e0acdc979ffcbf059e525923ce9366c4a69 authored about 6 years ago by Todd C. Miller <[email protected]>

regen

github.com/sudo-project/sudo - 7b395aad890d3ecc644428577a051e4dfc716063 authored about 6 years ago by Todd C. Miller <[email protected]>

Print a warning for password read issues.

Issues include: timeout at the password prompt, read error while
reading the password, and EOF re...

github.com/sudo-project/sudo - ab2cba0f5d8b286e8e52c06076efd32434f538ae authored about 6 years ago by Todd C. Miller <[email protected]>

Handle EOF on password input when pwfedback is enabled.

github.com/sudo-project/sudo - 2b562522105725f804fc167026265ab424aea7d2 authored about 6 years ago by Todd C. Miller <[email protected]>

Fix remaining instances of "e.g." without a trailing ','.

github.com/sudo-project/sudo - 013e0025c9a27107a80015632e4555e1dd1148ec authored about 6 years ago by Todd C. Miller <[email protected]>

Use mdoc macros for BSD systems.

All manuals now pass "make lint"

github.com/sudo-project/sudo - 675802b71c0473e02acff5eb3659596c4d8305cb authored about 6 years ago by Todd C. Miller <[email protected]>

Use -Wstyle with -Tlint since sudo is not part of the base system.

This avoids "referenced manual not found" and "operating system
explicitly specified" warnings.

github.com/sudo-project/sudo - 244be233015990972fe1b9f7693717ebaab11c8e authored about 6 years ago by Todd C. Miller <[email protected]>

Document log_suspend() and fix the description of the change_winsize() return value.

github.com/sudo-project/sudo - 5433eb546a2d235d389430d1e7b9863868b07af3 authored about 6 years ago by Todd C. Miller <[email protected]>

Fix problems found by igor. Bug #854

github.com/sudo-project/sudo - dd6a6e4013a5ac2c0710573b0ab5bbe5953e8f5b authored about 6 years ago by Todd C. Miller <[email protected]>

Sort DOCS and DEVDOCS and remove extra sudoers entry (it was listed twice).

github.com/sudo-project/sudo - a814da673f8327698495703805a9ae8d90076697 authored about 6 years ago by Todd C. Miller <[email protected]>

Add igor target to run igor(1) on the manuals.

github.com/sudo-project/sudo - ec2cc68c0b2fa8b89c71279ee61a65d5f92f0267 authored about 6 years ago by Todd C. Miller <[email protected]>

Add new -S option to sleep while the command was suspended.

The default behavior is now to not consider the time the command
was suspended as part of the nor...

github.com/sudo-project/sudo - a71eb86a713055d1753bb3feb9c7d168a0e5346f authored about 6 years ago by Todd C. Miller <[email protected]>

Add a suspend event type to the I/O log to log suspend/resume of

the command so we can skip that delay during replay.

github.com/sudo-project/sudo - cf07dc0757e58a40d56d95fa05694275fb045cb0 authored about 6 years ago by Todd C. Miller <[email protected]>

Initialize the pty rows/cols based on the values we stored in user_details.

This fixes a minor issue where we would send an extra window size
change event the first time the...

github.com/sudo-project/sudo - e2570307e68e157a823a8c06004cecdcabe6442a authored about 6 years ago by Todd C. Miller <[email protected]>

Add support for OpenLDAP's TLS_REQCERT setting in ldap.conf.

github.com/sudo-project/sudo - c0e8bde10497b5525de453e9d2d272825c23ca90 authored about 6 years ago by Todd C. Miller <[email protected]>

Move definition of TIME_T_MAX to sudo_util.h

github.com/sudo-project/sudo - 212169387933a9106d44663d7068561747aa7d22 authored about 6 years ago by Todd C. Miller <[email protected]>

Changes in 1.8.26 (so far).

github.com/sudo-project/sudo - 4c4f44621fab07e2623b8dc0c518d2b8fbc45eb8 authored about 6 years ago by Todd C. Miller <[email protected]>

Treat LOGIN, LOGNAME and USER specially. If one is preserved

or deleted we want to preserve or delete all of them.

github.com/sudo-project/sudo - d537daf787bde97d8dec585efae1551f40e88efe authored about 6 years ago by Todd C. Miller <[email protected]>

Remove special handling of the USERNAME environment variable. It

used to be set on old versions of Fedora but that hasn't been the
case for some time. It's worth...

github.com/sudo-project/sudo - 5f61f2c0f44abf6c9a5e1732101d3c80f1cd1c4a authored about 6 years ago by Todd C. Miller <[email protected]>

sudo 1.8.26

github.com/sudo-project/sudo - ce9a7dd25a0cb050a99f23fbb04ccca84c2d5abd authored about 6 years ago by Todd C. Miller <[email protected]>

Remove unused system_maxgroups argument from fill_group_list().

github.com/sudo-project/sudo - 9abcd616074bcd6a332ab371d19ff4323c24c5b7 authored about 6 years ago by Todd C. Miller <[email protected]>

Pass getgrouplist() NGROUPS_MAX+1, not NGROUPS_MAX so we have room

for the primary gid.

github.com/sudo-project/sudo - d8870177c2f516a48c832e9ef90c4d90cba0a63d authored about 6 years ago by Todd C. Miller <[email protected]>

In print_member_json_int() eliminate the need_newline variable

and just move the non-alias expansion printing bits into the
else clause, including the newline a...

github.com/sudo-project/sudo - 72ce2c807b686d7816859e894b41b9c8bb5b5804 authored about 6 years ago by Todd C. Miller <[email protected]>

Add regress test for bug #853

github.com/sudo-project/sudo - 8bf279b11e5ed0304ae3542bc3ec049b43dda37a authored about 6 years ago by Todd C. Miller <[email protected]>

When expanding an alias in print_member_json_int() avoid printing

an extra comma at the end of the entry. Bug #853.

github.com/sudo-project/sudo - 8aad36508271c751d1f34c8b595d13879f513856 authored about 6 years ago by Todd C. Miller <[email protected]>

Add Kan Sasaki

github.com/sudo-project/sudo - 8e1e4643317199309184987392b96e084655be0b authored about 6 years ago by Todd C. Miller <[email protected]>

sudo 1.8.25p1

github.com/sudo-project/sudo - 365a1ecd46c2fbf73fae71e16fb0d118abc1ec4c authored about 6 years ago by Todd C. Miller <[email protected]>

Fix a crash in the event system's poll() backend introduced with

support for nanosecond timers. Only affects systems without ppoll().
Bug #851

github.com/sudo-project/sudo - c639c965cf8dfb6c6bafc4cd78084660371ef27e authored about 6 years ago by Todd C. Miller <[email protected]>

regen

github.com/sudo-project/sudo - 1a9b932ffde18440354b518d763b58a9ca0b9df0 authored about 6 years ago by Todd C. Miller <[email protected]>

Allow for some clock drift due to ntpd, etc.

github.com/sudo-project/sudo - 27e549a3ef0ee01ba88ab89408bde817bd64a0ea authored about 6 years ago by Todd C. Miller <[email protected]>

If sudo_lock_file() fails for a reason other than the file already

being locked, give the user a chance to edit anyway.

github.com/sudo-project/sudo - 470a7830dcb20a23f915aa11474eabb8939b594a authored about 6 years ago by Todd C. Miller <[email protected]>

Quick sort is not a stable sort; use distinct sudoOrder values so

the output is predictable.

github.com/sudo-project/sudo - 0715b55474e4a4a8aa62d5a84d76cd366b2198e7 authored about 6 years ago by Todd C. Miller <[email protected]>

Fix warnings on OpenIndiana (Illumos)

github.com/sudo-project/sudo - a924b4610b8ee9794ab79c2c6967528af9342a84 authored about 6 years ago by Todd C. Miller <[email protected]>

Correct ldap_to_sudoers() return value.

github.com/sudo-project/sudo - 765d99e1f9100ba713a47d8d4c10d5caca72e1e6 authored about 6 years ago by Todd C. Miller <[email protected]>

Bug #849

github.com/sudo-project/sudo - 6e4f8c8cd2694ff656e62e2a72abb7b4d4241bf5 authored about 6 years ago by Todd C. Miller <[email protected]>

The sssd backend used to take the first match, assuming that entries

were sorted in descending order by sudoOrder. That allowed it to
avoid iterating over the entire...

github.com/sudo-project/sudo - ae04b40c052f1dc07ef7305dd87a5432aeb7bb1d authored about 6 years ago by Todd C. Miller <[email protected]>

Add some more ldif -> sudoers tests to verify sudoOrder.

github.com/sudo-project/sudo - 2221fbe2f10a316670e85ecd4575469ddb524ba2 authored about 6 years ago by Todd C. Miller <[email protected]>

For conversion to a sudoers parse tree, ldap_entry_compare() now

needs to sort in ascending order, not descending. Bug #849

github.com/sudo-project/sudo - ea38e9d90995e2901e4824d8d2e52e1ff358b047 authored about 6 years ago by Todd C. Miller <[email protected]>

No need to set input_file for stdin in parse_ldif(); noted by clang analyzer.

github.com/sudo-project/sudo - 58445393a75875a55ac2c46572c202e31c6253dd authored about 6 years ago by Todd C. Miller <[email protected]>

Use TIME_T_MAX when parsing the I/O log file timestamp and disallow

negative times.

github.com/sudo-project/sudo - e0b413eb1708a67d28453017f14672c2ef3252b5 authored about 6 years ago by Todd C. Miller <[email protected]>

When parsing an I/O log timing line, store the result in a timespec,

not a double. The speed factor (for scaling the delay) in sudoreplay
is still a double but we on...

github.com/sudo-project/sudo - e318f27fba94304567bdcca884ac48bb76a359ed authored about 6 years ago by Todd C. Miller <[email protected]>

Fix memory leak in test.

github.com/sudo-project/sudo - f1f632665c4be4468955b0cef58abc594329aeb5 authored about 6 years ago by Todd C. Miller <[email protected]>

regen

github.com/sudo-project/sudo - f9b3223edb2a9b0fe7a560cd68e1d38306fa8e8f authored about 6 years ago by Todd C. Miller <[email protected]>

Update conversion of DID_* to KEPT_* to match the new values of

DID_* and KEPT_*.

github.com/sudo-project/sudo - 2ff78702633e63c10eb003b938687fa3ff42f65f authored about 6 years ago by Todd C. Miller <[email protected]>

Set the LOGIN environment variable on AIX like we do LOGNAME.

github.com/sudo-project/sudo - 8acc29dc01e2aaad6824ff6b542314ac7cddf802 authored about 6 years ago by Todd C. Miller <[email protected]>

Add a test for the 4-argument au_close() function found in Solaris

11 instead of assuming it is present if __sun is defined. Fixes a
compilation error on OpenIndia...

github.com/sudo-project/sudo - fdd72961220c5cc8cd646998fca248da370838cc authored about 6 years ago by Todd C. Miller <[email protected]>

Add Miguel Sanders and Scott Cheloha

github.com/sudo-project/sudo - a22296788c3f34dbc33b06ebd818ea049d7dd394 authored about 6 years ago by Todd C. Miller <[email protected]>

testsudoers changes

github.com/sudo-project/sudo - 5bac1e0ddc29be95c7a15848db5f0b803b9d686e authored about 6 years ago by Todd C. Miller <[email protected]>

Add ldif support to testsudoers

github.com/sudo-project/sudo - 901b2666fc2958852acf3a4868ad3c27ffb69601 authored about 6 years ago by Todd C. Miller <[email protected]>

Move ldif -> sudoers conversion code into parse_ldif.c

github.com/sudo-project/sudo - 4782b22a479cee2338fe5c3b0747ce714e775e44 authored about 6 years ago by Todd C. Miller <[email protected]>

Move string list functions to their own file.

github.com/sudo-project/sudo - 52d54997eeb1d3de91946e923a823c537b8d2f2a authored about 6 years ago by Todd C. Miller <[email protected]>

sync

github.com/sudo-project/sudo - 5fea22e5140a973a19a98caab57c3642744a4a13 authored about 6 years ago by Todd C. Miller <[email protected]>

Backward ABI compatibility for even functions that use a timeval.

github.com/sudo-project/sudo - 63f7aa8fcfb170509dd0bc33922b4cd4aba8194d authored about 6 years ago by Todd C. Miller <[email protected]>

Use a monotonic timer for the event subsystem.

github.com/sudo-project/sudo - 6b76f9dbd310a4ebc8cea5c28127d82b0cacfe92 authored about 6 years ago by Todd C. Miller <[email protected]>