if-me.org commits | Ecosyste.ms: OpenCollective

Merge pull request #237 from kkelleey/destroy_notifications

Adding after_destroy callback to destroy notifications

github.com/ifmeorg/ifme - b4194ed79b26467c7091be87eafbfb3f4c61be19 authored over 8 years ago

Merge pull request #239 from kkelleey/fix_page_title

Fixing page title in layout

github.com/ifmeorg/ifme - 28d544d7236901ecc927776ef967cc5e7b07bd22 authored over 8 years ago

adding space and readding @page_tooltip

github.com/ifmeorg/ifme - 409defe50f3a03ebcaf91e99dc55ed03901451cc authored over 8 years ago

Removing spec for allies_controller @page_title

github.com/ifmeorg/ifme - 16d3ebbbda743a8dd6a1833d24956c3559dd3088 authored over 8 years ago

Getting rid of @page_title in favor of title helper

I can't figure out why falling back to @page_title isn't working... so
to fix the bug I added th...

github.com/ifmeorg/ifme - c300627d155b5713856ce4c272ff68f950e43aac authored over 8 years ago

Making group_show test for group.name

github.com/ifmeorg/ifme - 2b808e5fc325e32adf0b8bad32c4bd515a55c397 authored over 8 years ago

Fixing page title in layout

github.com/ifmeorg/ifme - 3d2e374d30852e66b5dd745ff3fe8f056f0c33b3 authored over 8 years ago

Refactoring groups#create

github.com/ifmeorg/ifme - 90738fa79ab77e25a6be5c6605b7d1d0bdddade5 authored over 8 years ago

Merge pull request #236 from kkelleey/use_authenticate_user_filter

Using built-in :authenticate_user! before_action

github.com/ifmeorg/ifme - 82a033607cb614c13cac3846ffc6abfad1bb2eda authored over 8 years ago

Merge pull request #238 from nchambe2/master

Refactoring MomentsSpec.js - Issue #180

github.com/ifmeorg/ifme - aa3b80754b96ead7c447e075d43574d45612130d authored over 8 years ago

Merge pull request #235 from kkelleey/refactor_page_title

Adding title helper

github.com/ifmeorg/ifme - 8f4b03cb32057c5dc14cb38fea18c9f259450bb3 authored over 8 years ago

#180 | Refactor function names for increased readability

github.com/ifmeorg/ifme - 865898d7f6b6ea8960fec01d51683fd6734dd2b4 authored over 8 years ago

#180 | Rename moments.spec.js file to MomentsSpec.js

github.com/ifmeorg/ifme - f7460c01cc19e6bfbbd54736475695ff5624b6c0 authored over 8 years ago

Refactor test names to be more descriptive && create test for label change when NO_ALLIES is selected

github.com/ifmeorg/ifme - 1d3ec1c500648a4a25d4d84baf47b0a56e263f10 authored over 8 years ago

#180 | Create test to check for unselecting all allies when set to NO_ALLIES

github.com/ifmeorg/ifme - 303f57fff923e03206c425c6473e3ac61f984c42 authored over 8 years ago

#180 | Create test to check if #viewers_label text is set to NO_ALLIES when ALL_ALLIES input box is checked

github.com/ifmeorg/ifme - 7f4665d42097724138cc678cbf2cd8f3e5ce0fa7 authored over 8 years ago

#180 | Create test to ensure #viewers input tag is not selected when clicked

github.com/ifmeorg/ifme - 99a847c12d54544f51765ad57cd407b38a003e71 authored over 8 years ago

#180 | Create test to check if allAlliesAreSelected when label text is set to ALL_ALLIES

github.com/ifmeorg/ifme - 2270bc0e9eb47d408f8c4f39061909581dcb4df2 authored over 8 years ago

#180 | Create labelTextIsAllAllies test

github.com/ifmeorg/ifme - 11609ea8e22f5ba6929626cd05d4ac64d71586f5 authored over 8 years ago

#180 | Create test to check to default value of #viewers_label

github.com/ifmeorg/ifme - 07cc523005ef05ae1899a232e0ef8e4dc3ee6429 authored over 8 years ago

#180 | Add two test to check correct value of NO_ALLIES and ALL_ALLIES

github.com/ifmeorg/ifme - b22a6698f8c7108be96c1bd4e5abde2ec7d5524c authored over 8 years ago

#180 | Create test for newOrEdit to be called when onReadyMomemts is executed

github.com/ifmeorg/ifme - 1d5427078465b76694e1799c60a6a718d28c9998 authored over 8 years ago

Remove test no functions called test

github.com/ifmeorg/ifme - a16827c0498c107d0449d93f5a2b5f98da83c1e9 authored over 8 years ago

Remove unused teardown function

github.com/ifmeorg/ifme - 2dcbe8e2e6b618e52c9f60349a12e42c61b78062 authored over 8 years ago

#180 | Remove onReadyStrategies from the setup

github.com/ifmeorg/ifme - 51378fbe5ecc8d03b2110ed9c8bfe970c5d57e70 authored over 8 years ago

#180 | Refactor beforeEach fixture readability

github.com/ifmeorg/ifme - df952e92c6e4facf40232d2ae28cfc0cd601ac5c authored over 8 years ago

Adding after_destroy callback to destroy notifications

Ideally we could have a dependent: :delete_all association on group, but
I couldn't quite figure...

github.com/ifmeorg/ifme - 2e43a29db8bc849cf491b01c180f23de3921c05e authored over 8 years ago

Merge pull request #230 from nchambe2/master

Refactoring HeaderSpec tests - issue #180

github.com/ifmeorg/ifme - 487d524b82536f8e245eb88bf4d8927606848c21 authored over 8 years ago

Fixing user_visits_group feature spec

github.com/ifmeorg/ifme - f4ad2e1cfc40e4ba1f928a6b95fcd29984937db3 authored over 8 years ago

Adding latest version of schema (#233)

github.com/ifmeorg/ifme - 1e01499d24b0c484e68e24e8914bc03ba31cffb5 authored over 8 years ago

Extracting GroupNotifier service object (#234)

This change removes duplicated code in the join, update and create
methods of the groups_contro...

github.com/ifmeorg/ifme - a4bd34957156ca5824a8d4cb73526d3e1d93cf8e authored over 8 years ago

Adding title helper

Before this commit, @page_title being set in the controller so that the
value was accessible in ...

github.com/ifmeorg/ifme - 7732b72269ab46a5aac483cbdd48cfb3a7ba9905 authored over 8 years ago

Using built-in :authenticate_user! before_action

The user_signed_in method duplicated the functionality of
the authenticate_user! helper provided...

github.com/ifmeorg/ifme - 4b46b6821e78ae82f8babc005b0b44a18a8ef2c3 authored over 8 years ago

Merge pull request #232 from kkelleey/refactor_groups_update

Refactoring groups#update

github.com/ifmeorg/ifme - dc8a03af11268c39b7e85f2f274e26f6c073dc05 authored over 8 years ago

Refactoring groups#update

Moving update_leader to helper method. ABC of update method is now ~16

github.com/ifmeorg/ifme - a32153c8b407a745b60fa604056e9d2de2c69c4c authored over 8 years ago

#180 | Add one test to momentsSpec && refactor duplication in moments.js

github.com/ifmeorg/ifme - 7a22b5a845fa0629080407a68be9a7a1d013606d authored over 8 years ago

#180 | Remove comment from expandButton function

github.com/ifmeorg/ifme - 83c192143698b0100f351c29a5806c2efd59de60 authored over 8 years ago

#180 | Remove unused function && add spacing between tests

github.com/ifmeorg/ifme - 41628aee5e3fb43794eb0da0d5d11edc7b964418 authored over 8 years ago

#180 | Remove afterAll function since dom is reset before each test is run

github.com/ifmeorg/ifme - 33d1e307416e77e40adbc8c6c03f02c712a25f7e authored over 8 years ago

#180 | Refactor fixture setup to increase readability

github.com/ifmeorg/ifme - 75e116157e258209bad824cd23112d33418503fb authored over 8 years ago

Merge pull request #229 from kkelleey/refactor_groups_update

Refactoring groups#update

github.com/ifmeorg/ifme - 8e505f90933828c9ab12e8c4558a59dd1dbc6d9a authored over 8 years ago

Refactoring groups#update

github.com/ifmeorg/ifme - 286f9cb01a9434422adb8f4d191c70f69e78b73a authored over 8 years ago

#180 | Refactor name of tests to follow this convention: has <expected behavior>when<situation that behavior depends on>

github.com/ifmeorg/ifme - 9edb9ce0a7a61ab5704f1bc9607bc59a08db2566 authored over 8 years ago

#180 | Remove comments from spec

github.com/ifmeorg/ifme - 316b8a340d43d41ff970fdd6416ff513863209b5 authored over 8 years ago

#180 | Refactor headerMouseLeave test

github.com/ifmeorg/ifme - 0696f3e786e2c4f233b8a179bd8c98b9cbca973c authored over 8 years ago

#180 | Refactor expand_moment_button mouseover tests

github.com/ifmeorg/ifme - a60b7025b2f7f1f7b8027879beee6905b3df4e84 authored over 8 years ago

#180 | Remove expand_me visibility test && add expandButton click even test

github.com/ifmeorg/ifme - 6f61de27bd59fe70698c5ca273e06e23e00bc8e5 authored over 8 years ago

#180 | Refactor expandButton function to use === vs. ==

github.com/ifmeorg/ifme - 96d5f4874f798d890f0b6cf4602dfe31990453d3 authored over 8 years ago

#180 | Refactor toggle small_nav visibility into three smaller tests

github.com/ifmeorg/ifme - e9d67e9adf15a02b2244eaa6752f8d54497d2cab authored over 8 years ago

#180 | Add expandMomentMouseover describe block

github.com/ifmeorg/ifme - ed490cff0179976b7be8899c2f662ecb50a379ec authored over 8 years ago

#180 | Add describe section for expandButton function

github.com/ifmeorg/ifme - 12231beba9282d472d9fb44e9ff26e36f81c407d authored over 8 years ago

#180 | Rename setHeight test && remove second test

github.com/ifmeorg/ifme - 6defab2fe51a3b282e8a7ad25dd4990fa03de6bc authored over 8 years ago

#180 | Refactor hideExpandMoment into several smaller tests && remove truthy/falsey assertions

github.com/ifmeorg/ifme - e71a6b38c84ebc2dc3e8163cb0796d84bc81fde8 authored over 8 years ago

#180 | Refactor showExpandMoment into several tests && remove truthy/falsey assertions

github.com/ifmeorg/ifme - d7d31e7701f9e8e51325aca46889d5cdd39f03f7 authored over 8 years ago

#180 | Refactor showExpandMe into several tests && remove truthy/falsey assertions

github.com/ifmeorg/ifme - 7ebb7ca5d3b9eeb27eff4336a39e6d0f4efd4052 authored over 8 years ago

#180 | Refactor hideExpandMe tests into several smaller tests

github.com/ifmeorg/ifme - 9c27d84888110308abd2398df17771cb65cd78c1 authored over 8 years ago

#180 | Create three seperate tests for the showSmallTopNav function & remove truthy/falsey assertions

github.com/ifmeorg/ifme - f0527bee1acd4642142a259cbe29037706ae1803 authored over 8 years ago

#180 | Create three seperate tests for the hideSmallTopNav function & remove truthy/falsey assertions

github.com/ifmeorg/ifme - c7f0cc2f2ad471210d1136f9979d30966bf223db authored over 8 years ago

Merge pull request #228 from nchambe2/master

Refactoring jasmine tests

github.com/ifmeorg/ifme - 781fba14a51b009555da580e4de066c51c093cb3 authored over 8 years ago

Merge pull request #225 from johnfrenchxyz/accessibility-fixes

Fixes accessibility issue of having multiple h1 tags in the footer

github.com/ifmeorg/ifme - a475138a7ace1938d20a58c4553bc1efebe266cc authored over 8 years ago

#180 | Delete example header.spec.js file

github.com/ifmeorg/ifme - aab85806dfbfb95061f3e066e9a998d39add24ad authored over 8 years ago

#180 | Refactor variable names in MeetingsSpec.js to increase readability

github.com/ifmeorg/ifme - 699cecc548eb3c69ea5c97f8b7a64a236e7e7f89 authored over 8 years ago

#180 | Refactor variable names in moments.spec.js to increase readability

github.com/ifmeorg/ifme - 2296de1214cfb25b11ee679e3d3d407fa210935c authored over 8 years ago

#180 | Change expect assertations to reflect new variable names

github.com/ifmeorg/ifme - d46d19d448cec7e9c360b6436be1ff380592ed1b authored over 8 years ago

#180 | Refactor variable names in HeaderSpec.js to increase readbility

github.com/ifmeorg/ifme - d9da90fb6e5132e69a572caa89d045cb3f816ff6 authored over 8 years ago

#180 | Refactor variable names to increase clarity & move mock creation into the setup

github.com/ifmeorg/ifme - 11d6e07b30c411f89587fdb1d5e26756512f6c48 authored over 8 years ago

Merge pull request #223 from kkelleey/refactor_join_group

Clean up groups#join, part 1

github.com/ifmeorg/ifme - 2d651cee9b74778c1fbf072772d861b8bdf8cfbb authored over 8 years ago

Merge pull request #226 from jmsardina/chore/add-specs-for-allies_controller

Chore/add specs for allies controller

github.com/ifmeorg/ifme - a4d0ca77537e1aa90b7a633a0c35dc9bab26cc8f authored over 8 years ago

Add controller specs for AlliesController

This commit:
- [x] introduces test coverage for the three actions in the
AlliesController (`:i...

github.com/ifmeorg/ifme - 369d6508fa3424e3a45e220ded4f344626aebd65 authored over 8 years ago

Include `require 'spec_helper'` in `.rspec`

By 'requiring' `spec_helper` in `.rspec`, we will be able to
write RSpec examples without adding...

github.com/ifmeorg/ifme - b3e2e23430d081df12579d6cc6e7138040e8a347 authored over 8 years ago

Merge pull request #222 from sienatime/siena/cursor-pointer

[Issue #221] add cursor: pointer on elements that are clickable

github.com/ifmeorg/ifme - 0a08af6b0d28af8ca5eae6d05d4c6c0f335cf44b authored over 8 years ago

Fixes accessibility issue of having multiple h1 tags in the footer

github.com/ifmeorg/ifme - 10b70311bc0c65bb213418fb7e39400b44de91eb authored over 8 years ago

Clean up groups#join, part 1

github.com/ifmeorg/ifme - 725998c283726daa89f566b95ad5212074c6f41c authored over 8 years ago

User can activate email reminders for medications (#215)

* Test environment needs action_mailer.default_url_options to run email specs

* Fix missing e...

github.com/ifmeorg/ifme - c0122b010d522e60ab03c9594b9c5206b402ec25 authored over 8 years ago

[Issue #221] add cursor: pointer on elements that are clickable

github.com/ifmeorg/ifme - 31303865b8d8633f1fc85e66563317177827d18f authored over 8 years ago

Merge pull request #218 from KaraAJC/setup

adding ruby version

github.com/ifmeorg/ifme - 54a74f5a5c54179abf5c5a6652f1d7d99593ade9 authored over 8 years ago

adding ruby version

github.com/ifmeorg/ifme - ffc7d3c04abeb3e3c25d088547982eb38dc8b48a authored over 8 years ago

Merge pull request #217 from sienatime/siena/update-readme

added instructions for rbenv and added a line about copying database.…

github.com/ifmeorg/ifme - df5cddd2863fc8750f7c2258a058bf8fd6cfc386 authored over 8 years ago

added instructions for rbenv and added a line about copying database.example.yml

github.com/ifmeorg/ifme - d7990496c3473423daa0b20bab3f05825b866c9d authored over 8 years ago

Merge pull request #216 from kkelleey/refactor_groups_leave

More refactoring of groups#leave

github.com/ifmeorg/ifme - 0557f7ee38ffb49438645022f4f65aa06270bc91 authored over 8 years ago

More refactoring of groups#leave

The ABC of the #leave method is still too high -- 29.5, but this is an
improvement

github.com/ifmeorg/ifme - 538dd7ae5f9f7d8aa7c21ef96879f90b91de3b32 authored over 8 years ago

Merge pull request #212 from maestromusica/master

Added tests for header.js

github.com/ifmeorg/ifme - 1d920600cd79b62c8a9f5e57e0d4611920c8f170 authored over 8 years ago

Meeting info view was expecting number, but was getting an association (#214)

This was intermittently failing on CI, but represents a real issue

github.com/ifmeorg/ifme - 0c2773e3c20bc651ed081e7275d4316523752d88 authored over 8 years ago

Merge pull request #213 from stellacotton/stella/medication-spec

Stella/medication spec

github.com/ifmeorg/ifme - 174ac07f0a3f73c79fd696015dc4a0e00260f33f authored over 8 years ago

conflict fix

github.com/ifmeorg/ifme - 54864d8eb8b17eed77018164772cd841bb6d210b authored over 8 years ago

Merge pull request #206 from kkelleey/refactor_leave_group_feature

More refactoring of groups#leave

github.com/ifmeorg/ifme - 30afe936bb7e434923a80570b64b74860b1eab55 authored over 8 years ago

Feature spec for adding a new medication

github.com/ifmeorg/ifme - 7f1a184e8e5cee072401761ed3a4749492276ff4 authored over 8 years ago

Create association between user and medications

github.com/ifmeorg/ifme - 2aa92bf881dfd900354bb8867f9e91d0b454e7fd authored over 8 years ago

Adding controller spec for when user is leader

github.com/ifmeorg/ifme - 8949c462ad999b505463923860593bce5612a458 authored over 8 years ago

Adding group variable

github.com/ifmeorg/ifme - 28b8f2885a3e58ae118cec676221f47d72e401ad authored over 8 years ago

Merge pull request #209 from kkelleey/show_validation_errors

Adding validation messages in groups/form

github.com/ifmeorg/ifme - 369cc14eac3a48cee8de8651742b499e449905b7 authored over 8 years ago

Merge pull request #208 from kkelleey/refactor_groups_destroy

Refactoring groups#destroy

github.com/ifmeorg/ifme - c30d0a3a1303da66114c08981b6befb58c6b32c0 authored over 8 years ago

Merge pull request #210 from piecedigital/piecedigital

Piecedigital adding JavaScript unit tests

github.com/ifmeorg/ifme - 58fe254af39a6e07d0b252c02afb4edb7425fd44 authored over 8 years ago

improvements after code review

github.com/ifmeorg/ifme - 569f0c11575a862f1de1832fba71e27381ffccc3 authored over 8 years ago

Merge branch 'master' of https://github.com/julianguyen/ifme

github.com/ifmeorg/ifme - 4544ace5156682ed4e3d81756299fd6ccaa6929c authored over 8 years ago

test code changed

github.com/ifmeorg/ifme - a47b25085fc0de9568a4308c93c5d8e3c4f40317 authored over 8 years ago

bug fix

github.com/ifmeorg/ifme - 4cdc1637055481ec4cb984662e6058f03a15d37b authored over 8 years ago

Final tests added

github.com/ifmeorg/ifme - 805c40da0007abde4971cf8bcfecf3bf098c82a1 authored over 8 years ago

refactored #header mouseleave event handler and added it's test

github.com/ifmeorg/ifme - ac1579e80c06308f8a807287331b936525d5fc52 authored over 8 years ago

fixed failing test

github.com/ifmeorg/ifme - b751c512f3f0c59a432d78a6d5b0511453d6b0c7 authored over 8 years ago